- 27 Oct, 2020 40 commits
-
-
Katie Dillon authored
This cl modifies MainThreadTaskQueue so that it owns a TaskQueue instead of extending the base/sequence_manager/TaskQueue. This is the first step in a TaskQueue ownership refactor described in this doc[1]. For now, MainThreadTaskQueue remains reference counted but this will change in follow-up CLs and these queues will be uniquely owned instead. [1] https://docs.google.com/document/d/1E--SK7wIuxwd6aGNiPc0uEU8jm1tvAvD1UrHyipn9sQ/edit?usp=sharing Change-Id: I124103bde681fe1f55c87b701691b53116f626a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453591 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#821307}
-
Guillaume Jenkins authored
Adds some comments clarifying why BrowserStatePolicyConnector isn't a keyed service. Comments are added in the impl class, the mock class, and the parent object (both the mock and the real application context). Change-Id: I3a48a3ac903a3b37c916275ae18b78e77edf691f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499961Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#821306}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I41de2be173661d2df663b01bbdbf3bb4ff58fc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499326 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821305}
-
Owen Min authored
Add kExtensionRequest trigger for ReportScheduler which generates and uploads extension request partially report. It's still a subset of full report. It means if there is a full report queued at the same time, only full report will be generated. If it's queued with version report, they will be uploaded separately. In case of persistent error, all Report should be stop. Bug: 1137964 Change-Id: Ia34837e1f982ad38926a307be59196f8a56aca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500721 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This is a reland of f6a05301 Marked: virtual/layout-ng-grid/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-*.html as failing. Original change's description: > [GridNG] Implement alignment within grid-areas. > > This patch implements alignment within a grid-item's grid-area. > When creating the GridItemData we read of the containers, and > grid-item's style, or determine its alignment axis-edge, and if it > should be stretched, saving this information on the GridItemData. > > When placing the grid-item it will use this to adjust the offset. > > This doesn't implement baseline alignment which requires a secondary > pass to correctly determine the baseline for the column/row. > > The other TODO relates to the constraint-space API, and how grid will > need a slightly new concept in order to do block-axis stretching > easily. By default non-replaced grid-items will stretch to the available > space. A new bit on the space can indicate that we should stretch to > the available space (if possible), this is similar to the shrink-to-fit > bit we have today. > > This adds a self-start/self-end test as after implementing this now new > tests passed immediately, and I don't believe we had good test > coverage for inflow content with these keywords. > > Bug: 1045599 > Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#821043} Bug: 1045599 Change-Id: I3252d9c72ac57bb38c873004ce3a2436a0b5ed83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502832Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#821303}
-
Alison Maher authored
Pass the state of PreferredContrast from NativeTheme to the renderer. This is used to evaluate the prefers-contrast media query. Spec: https://drafts.csswg.org/mediaqueries-5/#prefers-contrast Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/I0e2_nAwW7E Bug: 1107431 Change-Id: Ie7cb22be00683f3a8f4af5e36a2e71cd0b4cd8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412972Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821302}
-
Adam Ettenberger authored
Removing DumpAccessibilityTreeTest.AccessibilityAddClickListener which was producing a false-positive. Add CrossPlatformAccessibilityBrowserTest.AccessibilityAddClickListener to test that adding a mouse button listener causes an element that would otherwise be ignored to be exposed. When a Node adds or removes an event listener, notify the AXObjectCache so it can invalidate the associated AXObject when necessary. AX-Relnotes:Fix invalidation issue preventing elements with a mouse button listener from being exposed to ATs under certain conditions. Bug: 1135774 Change-Id: I3b6e725695403f6f2bad7a26c461b306b4dec531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485626Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Dave Tapuska authored
DragMsgStart_TargetDragEnter becomes DragTargetDragEnter on the widget mojo interface. DragHostMsg_UpdateDragCursor goes away as it was just the response to TargetDragEnter. These are the last of the drag messages using legacy IPC. Bug: 1039255 Change-Id: Ia030a3dd651bdfe9ac6be2dc8d0fa0a54c77c1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448052Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821300}
-
Renjie Tang authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007794 Change-Id: I6ce90efd8b8e29514c58e866316e84e487c324d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500442Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821299}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010270700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/eO09jUkryhPMkMcGrgpF5XKLX9JWZB6RvOYUgr9sMb8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/135674536,b/156323271,b/170910307 Tbr: help-app@grotations.appspotmail.com Change-Id: Ibe3c2cd9e540a872aaa9397f72301bdd04086532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821298}
-
Alex Newcomer authored
After the menu closes, rendered content can be delivered using a null |deliver_image_model_callback_|, so check for it before calling. Bug: 1134418 Change-Id: Ic97f3871a201a1c289835df74b891edf9d616460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491141Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#821297}
-
Harvey Yang authored
As Linux and ChromeOS shares the same algorithms for the fusion sensors, this commit extracts IsFusionSensorType and CreateFusionSensor into a base class PlatformSensorProviderLinuxBase. BUG=chromium:1116940 TEST=unit tests Change-Id: I074b2be07a3ccb2a7ad220cb7fafcbb11faa67ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500391Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821296}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ibeba130c3ad900eb279fd5b6e7e2ab0ba63f545b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501061 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#821295}
-
Rushan Suleymanov authored
This file is used by only one unit test for SyncScheduleImpl. All its functions are moved to the appropriate unit test file. It's not worth holding the dedicated file for only one test. Bug: 948661 Change-Id: Ia3975ddfa4ff472bf43b0df4d5ed26a77b50195a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502475Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#821294}
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that inherited properties that apply to text can be set on ::marker and should affect the marker text. And in https://github.com/w3c/csswg-drafts/issues/5303 it resolved that 'line-height' applies to text (as it already does in Chromium). Therefore, this patch allows 'line-height' in ::marker. Note it was already possibly to set it to the list item and the ::marker would inherit it. Just letting authors set it directly to the ::marker. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-line-height.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html marker-line-height.html fails in legacy because ::markers with 'content: normal' are not implemented with actual text. Change-Id: If63095d046150a2b5f76c40fce93fce1c0e7741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438413 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821293}
-
Stefan Zager authored
BUG=1142877 TBR=poromov@chromium.org NOTRY=TRUE Change-Id: Ib657fd85f7bbe1daf8fd7368c856dda60db018b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502783Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#821292}
-
Joshua Peraza authored
5368dc638901 handle potentially throwing functions in no_cfi_icall cdb1e7f52bdc fix flake in LogOutputStreamTest 640b13f3cb80 linux: Don't load section headers of test module Change-Id: I4e7f5d3983e499a20988fd1a3f6ca184ec4d1cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500319 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821291}
-
Andrew Grieve authored
Java targets should never depend in non-java targets unless they are generating inputs for them. Change-Id: I537d96183976476abec3a5fb3de87d122620a409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499418 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821290}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests. Change-Id: I244899c638df91c27f34ee3e5888077d61248c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497903 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#821289}
-
Matt Menke authored
The last browser tests using the built-in SpawnedTestServer have finally been migrated the EmbeddedTestServer, so nothing is using it. This also helps reduce visibility of the SpawnedTestServer, so makes accidental use of it harder. This CL also fixes a bunch of IWYU issues that the removal unearthed. Bug: 492672 Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Applications build for the macOS "catalyst" environment do not support the extensions or widgets that ships with Chrome on iOS. Fix the build when the variables used to enabled them are set to false. Add assertion to ensure that the BUILD.gn defining the extensions and widgets are not included when the variables are set to false, in order to prevent from accidental inclusion. Add a gn variable to control whether screen_time is enabled or not. It will allow disabling it when environment is macOS "catalyst". Bug: 1138425 Change-Id: If2cf9734c0595098cb2f60247702f73cf5da7d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498593 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821287}
-
Peng Huang authored
The crash is because fd ownership is passed to vulkan, however the fd is still hold in base::ScopedFD. It confuses android fdsan, and then fdsan reports an ownership problem and crashes. Bug: 1140950 Change-Id: I0cc22992cedb22a649c61e84020317261255e04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503008Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821286}
-
Elly Fong-Jones authored
This will make using AnyWidgetWaiter a lot more convenient for tests that cover code which does not subclass View for the widget delegate's contents view (which is current best practice). Bug: 1075649 Change-Id: Ie1c8d2917f525176d1b17bcbeddd7b6f93b19644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492891 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821285}
-
Antonio Sartori authored
According to the specification, executing a javascript: URL in a document does not commit a new document. Indeed, following https://html.spec.whatwg.org/multipage/browsing-the-web.html#javascript-protocol executing a javascript: URL request gives a response whose status is 204, and processing a response with status 204 does not commit a new document: https://html.spec.whatwg.org/multipage/browsing-the-web.html#process-a-navigate-response In particular, executing a javascript: URL does not change the document's URL. So if we create a new (empty) iframe and execute right away some javascript: URL in it, the URL of the iframe document will be "about:blank". On the other side, a document with URL "about:blank" will usually not send any Referer header, since the algorithm for determining the outgoing referrer goes through the stripping section https://w3c.github.io/webappsec-referrer-policy/#strip-url which returns `no-referrer` for a local scheme. As a consequence, we should always expect the Referer header of an outgoing fetch request from an `<iframe src="javascript:...">` without custom referrer to be empty. This CL adjusts the referrer policy inheritance WP test to that. Still, we want to test that the referrer policy is inherited correctly for javascript: URLs. For doing that, we add a custom referrer to the outgoing fetch request, and we check that the content of the received Referer header corresponds to the custom referrer modulo the inherited referrer policy. Change-Id: Ib3fe0808d3f8a1790e3f565cf2b1648fd2ea6c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464930 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#821284}
-
Rune Lillesveen authored
The css-pseudo specification lists which properties applies to which pseudo elements. For ::marker and ::first-letter we were already using the CascadeFilter. This CL uses the filter for highlight pseudo elements like ::selection and ::target-text, which share the same set of properties which apply. This means we stop retrieving resources for CSS properties which don't apply to these pseudo elements. Additionally, block all resource fetching for the ::target-text element since resource fetching can be used by an external stylesheet in combination with a text fragment url to detect text content on a page. Bug: 1136817 Change-Id: I8b19db8535882e6b20f6319cd2a9f5219e7c9538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489657 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821283}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I797c98ff77d57ab47dfb95eecfe6d70000f3409d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500561 Auto-Submit: Caroline Rising <corising@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#821282}
-
Chris Hamilton authored
This adds OnGraphCreated test seams to the browser harness, as well as a utility function for running a lambda synchronously in the graph (a common operation in tests). Change-Id: I4c10dbba34bc8c1d81722ac3780491079a8cadf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493687Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#821281}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6d17cf58. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I166d60117fcd1e0292503f434a2594759419ba5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502848Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821280}
-
Russell Davis authored
Bug: 1142027 Change-Id: Ie2fb4d4631f3d8507b404d6641f89170e35d98e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496290 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821279}
-
Stefan Zager authored
This reverts commit c756c75c. Reason for revert: Suspected cause of crbug.com/1142873 Original change's description: > [iOS] Fix tab strip views when using FullscreenProvider > > When the FullscreenProvider is used, the layout of the browser views is > slightly different. Instead of having the web content views start from > the bottom of the toolbar, the web content extends all the way to the > top of the BrowserContainerViewController, behind the tab strip. > > This means that the prior approach of making all the top background > views clear does not work when using FullscreenProvider. Instead, this > CL uses the following approach: set these background views to have > the same background color as the tab grid. As soon as the panning > gesture starts, make them clear so the tab grid shows through and the > animations appear correctly. At the same time, move the web content > views down so they don't obstruct the animations either. > > Bug: 1094335 > Change-Id: Ieea7d268e781da5e1ccd4c2c0ad3c0925407d133 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489898 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Cr-Commit-Position: refs/heads/master@{#821200} TBR=marq@chromium.org,rkgibson@google.com,mouraroberto@google.com Change-Id: I2b026d35000d34b29de9235ed2752273f6f7dd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502574Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I0275f2ee7515dd907c13f3fdfb0e9ca2da23e3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497391 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: Ibd93c72f8a5eb46a9d346d6ef381bcb3a8cbb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497389 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Wei Li authored
Change Button, ImageButton, LabelButton, and ColorTrackingVectorImageButton to always focusable on non-Mac platform and accessible only for Mac. This will remove the need to override these buttons' focus behavior for normal use cases. This CL explicitly set some button's focus behavior when they don't want to platform default focus behavior. This CL also removes the DCHECKs added earlier to show the changed behavior. Bug: 1001103 Change-Id: I97ebea9c477e6155e40b09007254a51be9ee5125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499166Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
Kyle Milka authored
Move a few of the editor screenshot files into c/b/share/. This eliminates the DEPS on those files. Bug: 1022172 Change-Id: Ibe12b1d4aadae983d74e348ea5279af4230610eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481928Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821274}
-
David Roger authored
This reverts commit f89b2b5b. Reason for revert: test is timing out on windows. See https://crbug.com/1142869 Original change's description: > Enable ChromeSitePerProcessTest.LaunchExternalProtocolFromSubframe on windows. > > Enabling test to see if it is still flaky on Windows. > > Bug: 980446 > Change-Id: I6f1b0dce68cce9bd359ebe315ee8782b26888c66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498957 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Auto-Submit: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821188} TBR=acolwell@chromium.org,wjmaclean@chromium.org Change-Id: Ie7f5c8d58bc12698c2f22b17a327b2f6f39bcffe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 980446, 1142869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502691Reviewed-by:
-
Tanmoy Mollik authored
In https://crrev.com/c/2498946 the following test was disabled because it was flaky on emulator: - GoogleServicesSettingsTest#showSignOutDialogBeforeSigningUserOut They are re-enabled on other builders. This issue seems to be problem with espresso being used in emulators similar to this bug: https://crrev.com/c/1108459 Bug: 1142481 Change-Id: I28fff49d24244af7935729e895fc2f78659ef716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499541Reviewed-by:
-
Victor Costan authored
This will avoid including this file in a large CL that turns QuotaClient into a mojo interface. Bug: 1016065 Change-Id: If029b5362fcc77b7acf8e55206b7143900ff6369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501062 Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821271}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=jwd@chromium.org Bug: 1142671 Change-Id: I9501b09c902d0741f7bbd92d1ada0ff06bfa5136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500609 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821270}
-
Stephen McGruer authored
Despite efforts to address it, this test continues to be flaky on Mac, so squash the flaky-failures. Bug: 1137228 Change-Id: I48e4745d4f21977b59cfeba99e73d39126932ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502312 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#821269}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ffe4940bba5cf5f6789dc5979669c54afd11337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821268}
-
