- 06 Jan, 2021 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I49da68522ed2dee1ce23aa81c39ee13d24e9859f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840605}
-
Zach Kirschenbaum authored
This reverts commit 0ec4e032. Reason for revert: so in the reland, we can remove NOTREACHED Original change's description: > Revert "[fuchsia] handle RetrySystemUpdate reboot reason" > > This reverts commit 394a78b4. > > Reason for revert: this breaks something > > Original change's description: > > [fuchsia] handle RetrySystemUpdate reboot reason > > > > In this change, we add support for RetrySystemUpdate. Also, we stop > > mapping `RebootSource::OTA` to `StateControlRebootReason::SystemUpdate` > > because reboots for system updates should only be called from > > fuchsia.git -- the code we remove isn't being run anyway. > > > > BUG=fuchsia:64591 > > TEST=cast_reboot_unittests > > > > Change-Id: Ic15f86d31d3985d2fa5a2a3957c5ca61066cd476 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600053 > > Reviewed-by: Sergey Volk <servolk@chromium.org> > > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > > Cr-Commit-Position: refs/heads/master@{#838871} > > TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: fuchsia:64591 > Change-Id: I9a2dd0fe105b1750c733925a8320a2f4e71cded2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611448 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > Cr-Commit-Position: refs/heads/master@{#840361} TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com Bug: fuchsia:64591 Change-Id: I4d6fffa0df883dbb6dae6add7f8e81aedcd0a95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611526 Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#840604}
-
Morten Stenshorne authored
This reverts commit 20ec4591. Reason for revert: StartupTracingTest failures. https://ci.chromium.org/p/chromium/builders/ci/win-asan/16653 Original change's description: > Reland "[tracing] Align --trace-startup and --enable-tracing." > > This is a reland of 0823dbae > > Original change's description: > > [tracing] Align --trace-startup and --enable-tracing. > > > > Use StartupTracingController both for --trace-startup (primary use case: > > browser startup perf profiling) and --enable-tracing (primary use case: > > browser test tracing). > > > > Due to historical reasons both flags are kept, but now their behaviour > > is mostly the same. If both are present, --trace-startup takes > > precedence. > > > > Differences: > > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > > continues until the browser is closed. (--trace-startup-duration overrides > > both). > > - `trace-startup-file` always treats the path as absolute, while if > > `enable-tracing-output` ends with /, it uses the provided value as the > > directory and generates the base name based on the current runtime > > metadata. > > > > R=skyostil@chromium.org,eseckler@chromium.org > > BUG=1157954 > > > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839992} > > TBR=skyostil@chromium.org,eseckler@chromium.org,nasko@chromium.org > > Bug: 1157954 > Change-Id: Ic16992026beebddea39c8a6b247b4301512057e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609139 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840015} TBR=nasko@chromium.org,skyostil@chromium.org,altimin@chromium.org,eseckler@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1157954 Change-Id: Icfe2c800d65223f4b603370e1a7f50c2ee01283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611268Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840603}
-
Sebastien Lalancette authored
Bug: 1110944 Change-Id: I83d2e15de5ef086c86a55c064159e7b75c69e251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611049Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#840602}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/password_manager/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I5d3439b94ef7214debf58439c46078b70dbfc305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611245Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840601}
-
Ulan Degenbaev authored
Change-Id: Ic9c6c58d324f93cfab923b45200eec9131732fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612995Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840600}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/74f1b6be4a91..c6345ca36de9 2021-01-06 emacs.nolkaf@hilbrich.tk * meson.build: Fix 'png' build option (#59458). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ieb07820ab0fea8a203a59bc8cfd5b207b83faadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612804Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840599}
-
Alex Ilin authored
Keep the picker disabled on startup until: - multiple profiles were used in the last 28 days, or - the picker has been shown once A new prefs::kBrowserProfilePickerShown pref is added to track whether the picker has been shown before. Bug: 1063856 Change-Id: Ia35a3b2212b3811ed592d81fa516bc1ffc07accc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598848 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#840598}
-
Peng Huang authored
* Fix tiling problem in OutputPresenterX11 * Do not handle IdleNotify event, since we will always wait on the x11 fence before reusing the buffer. Bug: 1153156 Change-Id: I308e9f7346c8fea5ba5939e4c3fe17b733e7e535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596104Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840597}
-
Robbie Gibson authored
When the thumb strip is in peeked state (horizontal tab thumbnails), switching tabs should not close the thumb strip. Bug: 1155211 Change-Id: I8b6e7312af391538dbea155a10433e8ade9d01fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600983 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840596}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609912549-c91a8fa5efe894cd1dbcbf24f242fd8e4fea7dac.profdata to chrome-linux-master-1609934346-e8075e70051f1cf5498240cc23c791e5411fb4de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I613b247379325e578df949111ba1e50e6797eb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611880Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609912549-27b0371d28f026dcf49b02c005becd8eabbb3dbd.profdata to chrome-mac-master-1609934346-5c74c9288bb90a2547279b7951f6e0eb771b0f27.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic166f33b3cd934c7f9556b6066553a0e633fbf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611879Reviewed-by:
-
Ben Mason authored
This reverts commit 2a3f2a4e. Reason for revert: Suspected build failure: crbug.com/1163418 Original change's description: > Not link ANGLE statically on Android for stable and beta channels > > Bug: 1161513 > Change-Id: Ia0a82f44b878dbcb7589a2aec9ec597ff517660b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600390 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840191} TBR=penghuang@chromium.org,zmo@chromium.org,kbr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If804b48a0b27fe6873fcdeafa3ca7530027348a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610922Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#840593}
-
Stephen Nusko authored
This reverts commit 30d16f41. Reason for revert: crbug/1163513 android perf build is broken due to missing module six. Original change's description: > Roll Catapult from de6e3a9d85af to 6c876045de14 (1 revision) > > https://chromium.googlesource.com/catapult.git/+log/de6e3a9d85af..6c876045de14 > > 2021-01-05 jbudorick@chromium.org devil: make devil_env_test pass under py3. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC matthewdeluca@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1007101 > Tbr: matthewdeluca@google.com > Change-Id: I2e0359bddda1f8287cfd881439299926ad0fc2e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611890 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#840364} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,matthewdeluca@chromium.org Change-Id: I85025d04a0f56ef302e06b658a2da6c66a9ff61c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007101 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612520Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#840592}
-
Alexander Surkov authored
Allow scripts to be used from accessibility dumptree tests Bug: 1136957 Change-Id: I3d2a1e0fcd1a69266455062b462124fb7b7b3245 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597000 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840591}
-
Ewann authored
This CL deletes SettingsMultilineDetailCell and replaces its occurrences with SettingsImageDetailTextCell. Bug: 1153313 Change-Id: I11f8940b7899adc1df43c41e809be731df21f400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612945 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609912549-501f8e0b1fb8f960dee14203abdc5f5559a20bab.profdata to chrome-win32-master-1609923503-082d3636d9b7f0ebc97af69fa1fe05452441e219.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie47b0928cde1afc88cdea48bbfed0c9c0b7d3a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612822Reviewed-by:
-
Nohemi Fernandez authored
Fixes a bug where the unified consent screen is not dismissed when interrupted by a Siri search on the Recent Tabs page. - Performs complete view controller cleanup on interrupt. - Dismisses UnifiedConsentViewController when explicitly required. - Does not explicitly release SigninCoordinator in scene controller, this is already handled in the completion callback. Bug: 1115997 Change-Id: Ib4663fe1136a394020020abc76969761c5e0f170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600835Reviewed-by:
-
Benoit Lize authored
Some PartitionAlloc crashes are likely due to freelist corruption. PartitionAlloc has two types of freelists: in the central allocator, and in the thread cache. The central allocator one already has a DCHECK() to verify that subsequent entries belong the same superpage, which doesn't hold for the thread cache freelists. This CL: - Makes these crash lead to a NOINLINE function - Add an interity check to all freelists. This is not meant to be a security mitigation, but to prevent against accidental issues. Bug: 998048 Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840587}
-
Benoit Lize authored
The issues seen on Windows (see crbug.com/1155905) also happen on Android, so disable it everywhere. Keep it for DCHECK() builds to investigate the root cause, which hasn't been identified. Bug: 1155905, 998048 Change-Id: I4d8bf3c6af3e745b5956a0a12413899c2e1c4056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612966Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#840586}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..4dde23fea599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I541760809ef52741b735aab5266004a578c33c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613005Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cfc9da2f6195..8a3bba16ba86 2021-01-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-06 jacktfranklin@chromium.org Fix sub menu context menu interaction tests on Mac 2021-01-06 dnlbellfield@gmail.com Fix text overlap in Settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I468701655768383d8040f67cbfe99d2022dc6ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611614Reviewed-by:
-
Stephen McGruer authored
This rolls up to SHA d3ce095fcc6b5a85e6056fdebbf939caf2e2719f This also cherry-picks 0dd83ea7, as the upstream version has still not landed. Bug: None Change-Id: I36c86cd06acb2a37e6a0521bc437cac2044db25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611924 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#840583}
-
Monica Basta authored
This CL does the following: 1. Specify height for product logo which avoid a shift down on page first render. 2. Specify max width for the title and subtitle. 3. Add margins to the profile card menu. This is necessary for the box shadow on item focus to be fully visible. Bug: 1063856 Change-Id: I0546a719df76b1aba6b717e5965a97211564150e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611089Reviewed-by:
-
arthursonzogni authored
Due to a bug, CSP embedded enforcement was ignoring the whole CSP directive when it contained one using the sandbox directive. This patch trivially fix it. This is intented to be merged into M89 This patch also adds many tests for the documents: 1. initial empty document 2. about-blank 3. about-srcdoc 4. data-url 5. blob-url 6. same-origin 7. cross-origin (1)(2)(3) are failing, because of https://crbug.com/1163174 Bug: 1163108,1163174 Change-Id: I888ab01009ae914809680451beee37c69b12734f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611264Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840581}
-
Patrick Brosset authored
We are removing the cssGridFeatures experiment in DevTools (the feature still exists, it is no longer an experiment). 2 web tests need to be modified to ensure relevant grid-related cases are taken into account. These cases were previously removed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2418315 Bug: 1162894 Change-Id: Ic0cfad3581590326feccd58d54e3d74eeea0dcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608663Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840580}
-
Morten Stenshorne authored
TBR=tmartino@chromium.org Bug: 1162484 Change-Id: Iae3fdd0f8242f9148ea14ebd8c483da456b144e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612967Reviewed-by:
-
Morten Stenshorne authored
This reverts commit d672f7b5. Reason for revert: SubresourceRedirectLoginRobotsBrowserTest.TestCancelBeforeImageLoad is flaky. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/96887 Original change's description: > ImageCompression: Disable on logged-in pages > > This CL adds a mojo to disable image compression on likely loggged-in > pages. > > Bug: 1160424 > Change-Id: I42dda576947aa04e51d3cb3a5fac712945ac9651 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598858 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840523} TBR=kinuko@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I150cc38bc4c2fb7113e6bdcb68c9dad0f6a2fffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1160424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613025Reviewed-by:
-
Findit authored
This reverts commit a5dab881. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840553 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E1ZGFiODgxMTZjZGZhMjE4Y2ZjMDBjYWZlMWQ5NWQ2MmNlZDA3ZDYM Sample Failed Build: https://ci.chromium.org/b/8858856492607464112 Sample Failed Step: components_unittests Original change's description: > Ensure child_path for SetProjectId() is a relative path > > Context : http://b/175833465#comment26 > > parent_path.Append(child_path) fails if child_path is an absolute > path when DCHECK is enabled > > https://source.chromium.org/chromium/chromium/src/+/master:base/files/file_path.cc;l=494;drc=4aa966b22d5d01458c8e8f80a812c7533f62a0b6 > > BUG=b:171847983 > TEST=unittest > > Change-Id: Ib7e173d349c29ac22be7c8e11467891de0e3ef3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599685 > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Commit-Queue: Satoshi Niwa <niwa@chromium.org> > Auto-Submit: Satoshi Niwa <niwa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840553} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=b:171847983 Change-Id: I58efae991c0fd90c101acb5aa7d1f5af619234cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613007 Cr-Commit-Position: refs/heads/master@{#840577}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..4dde23fea599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie585c1320e3e4b2fc465cb1bf461910b7ea21bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612820Reviewed-by:
-
Alex Ilin authored
This CL removes the restriction that disables the profile picker if the force signin enterprise policy is enabled. Force signin dialogs will be hosted by the profile picker if the corresponding feature is enabled. Bug: 1156096 Change-Id: I19ec58afc7a451fbd868eae5e3d8d13899e78719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595412Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609901004-14816faec8726b486a5318be3232c28c52f1f131.profdata to chrome-win64-master-1609923503-9b9894a01ac9daf80ce951069eff07585fba216a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iff940bb436c2ed59f8f25d8236d2e61caa305265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612817Reviewed-by:
-
Nico Weber authored
- Make python script do checks directly instead of shelling out to a bash script - Check all symbols against actual framework.order file instead of just checking the symbol at the highest address - Check all global symbols, not just __TEXT __text - Attempt to make error messages friendlier - Add symbols for coverage builds to framework.order (...e.g. on mac-rel) - Run verify-order in asan builds too. Bug: 1159620 Change-Id: I4620f211b596f9a025e65b9a86e7c98489eb5b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600900 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840573}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/9e5430536b59..c33d1680c7e9 $ git log 9e5430536..c33d1680c --date=short --no-merges --format='%ad %ae %s' 2020-12-30 junyer Make RequiredPrefixForAccel() "see through" capturing groups. 2020-12-29 junyer Correct the WINVER check for SRWLOCK. 2020-11-25 junyer Remove a double space from mksyntaxgo for Go folks. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I9bc576045e901a8f5fb04140867ff961097c9073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610994 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840572}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..4dde23fea599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieba05819c433a6bcc61674f05a170a2d2bff1160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611875Reviewed-by:
-
Gauthier Ambard authored
Launch bug: crbug.com/1137329 Bug: none Change-Id: I2c1c51a92b636c7c3685f84c1ca4e5fb4e3905dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549706 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840570}
-
Robbie Gibson authored
Fixed: 1138289 Change-Id: I2b5f6e671ac479f8b211927937cfa6961a2b5635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600745Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840569}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I107ed1ce5a0525812a1b06a17eb9471422acdc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612818Reviewed-by:
-
Morten Stenshorne authored
TBR=sammiequon@chromium.org Bug: 1163489 Change-Id: Id7522dc2da9562b970249b4ab976ccccd31a3ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613044Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4f0faa88e31722a4dcbf75e336d3b459bc7c7cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612814Reviewed-by:
-
