- 21 Jul, 2018 29 commits
-
-
Shakti Sahu authored
We need to show separate empty views for downloads and prefetch tabs. Also on prefetch tab, the message will be different if prefetch is disabled. Added EmptyViewCoordinator which will supply the empty view to the DecoratedListItemModel. The exact UI for views will be added later. Bug: 850607 Change-Id: If7c40d1964a7b13f92e272d632493f5c23749f57 Reviewed-on: https://chromium-review.googlesource.com/1144458 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#577071}
-
Findit authored
This reverts commit e3971799. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577038 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzOTcxNzk5YzA3YTRjZDM3ZGFmN2ZiOTg1NzhjYjIxMzc1NTY2NDgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10900 Sample Failed Step: cc_unittests Original change's description: > cc, gpu: Make serialization code bitness agnostic. > > With this change we use the same serialization regardless of whether > we are targeting a 32-bit or a 64-bit machine. > > Bug: 865796 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b > Reviewed-on: https://chromium-review.googlesource.com/1139106 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577038} Change-Id: I07ba570dd9d72eb02a929e50a2c3811c877543e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865796 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1146080 Cr-Commit-Position: refs/heads/master@{#577070}
-
dpapad authored
Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7fee3df853ccc565bd1c9ba664d1226eeab74886 Reviewed-on: https://chromium-review.googlesource.com/1145589Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577069}
-
Zhuohao Lee authored
Currently, the requested_power_state_ will be set by the DisplayServiceProvider::SetDisplayPower which is triggered by powerd via dbus event on ChromeOS. In normal case, it is working because powerd will call the SetPower method via dbus to initialize requested_power_state_. However, in factory mode, the powerd won't do that and that will cause factory ui can't be switched back from VT2. To avoid this problem, this patch is proposed to initialize this variable. Bug: b:78436034 Change-Id: I7c2287cb6ff47e7b8d29cdaed3ee77bcafd144c3 Reviewed-on: https://chromium-review.googlesource.com/1084419 Commit-Queue: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577068}
-
Ian Kilpatrick authored
This removes a NGConstraintSpace allocation inside: NGBlockLayoutAlgorithm::CalculateMarings This doesn't have a perf impact, but will make it easier to potentially move margins onto layout results. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I83d6d1f61e2f9bd8f94eed395e759bd01d6cbe78 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1145460Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577067}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0b0043392bfd..cc22d4d2fb02 git log 0b0043392bfd..cc22d4d2fb02 --date=short --no-merges --format='%ad %ae %s' 2018-07-21 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d754eb5620ed..ba365939b90c (1 commits) 2018-07-20 egdaniel@google.com Blacklist failing SkRemoteGlyph tests on Vulkan NexusPlayer. 2018-07-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-20 brianosman@google.com Vertex color xform bench 2018-07-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-20 egdaniel@google.com Re-add assert for mip maps. 2018-07-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-20 timliang@google.com added byte type support to SkSLC MSL generator 2018-07-20 csmartdalton@google.com ccpr: Blacklist Sandy Bridge 2018-07-20 ruiqimao@google.com added options to enable caching and draw bounds in NIMA slide 2018-07-20 herb@google.com Convert remote glyph cache to use glyp runs 2018-07-20 brianosman@google.com Move fragCoord workaround declaration 2018-07-20 egdaniel@google.com Reland "Don't require mips in GrTextureProducer if texture is 1x1." 2018-07-20 caryclark@skia.org remove unimplemented headers 2018-07-20 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0d8993c667c5..be5fe7797f1e (1 commits) 2018-07-20 csmartdalton@google.com Account for square caps in SkStrokeRec::getInflationRadius 2018-07-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0be37b444996..d754eb5620ed (1 commits) 2018-07-20 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8fb6f6a129f5..0d8993c667c5 (1 commits) 2018-07-20 csmartdalton@google.com GL: Accept "_float" extensions for "_half_float" formats 2018-07-20 ziadb@google.com SkAR Java: better finger painting. Cleaner UI 2018-07-20 benjaminwagner@google.com Remove an internal bot. 2018-07-20 borenet@google.com [infra] Only run 8888 and gl configs for Lottie 2018-07-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 da92a476b50a..0be37b444996 (2 commits) 2018-07-19 bungeman@google.com Undef the right macro in SkDWriteNTDDI_VERSION.h 2018-07-19 egdaniel@google.com Revert "Don't require mips in GrTextureProducer if texture is 1x1." 2018-07-19 bsalomon@google.com Exclude gltestpersistentcache from TSAN bot. 2018-07-19 brianosman@google.com More color space improvements to DM 2018-07-19 egdaniel@google.com Don't require mips in GrTextureProducer if texture is 1x1. 2018-07-19 brianosman@google.com Stop using rsp files for compiling on Windows 2018-07-19 ethannicholas@google.com Reland "Revert "added GrSkSLFP and converted DitherEffect to use it"" 2018-07-19 herb@google.com Convert PDF device to use glyph runs lists 2018-07-19 fmalita@chromium.org [skottie] Update DM src name to "lottie" 2018-07-19 timliang@google.com implemented onWritePixels and related tests for metal gpu backend 2018-07-19 ethannicholas@google.com Revert "Revert "added GrSkSLFP and converted DitherEffect to use it"" 2018-07-19 reed@google.com rename to Merge patheffect 2018-07-19 borenet@google.com [infra] Add infra support for Lottie 2018-07-19 rmistry@google.com Disable bookmaker CLs automatic CQ+2 for now 2018-07-19 herb@google.com Use SkGlyphRunListIterator in gpu 2018-07-19 bungeman@google.com Ignore NTDDI_VERSION with DirectWrite. 2018-07-19 reed@google.com share helper for flagging when added to raster cache 2018-07-19 caryclark@google.com fix bookmaker bot latest 2018-07-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 6a5d98c4b528..da92a476b50a (1 commits) 2018-07-19 caryclark@skia.org remove unused serialization in textblob 2018-07-19 timliang@google.com created stub for metal gpu command buffer 2018-07-19 fmalita@chromium.org De-virtualize SkBitmapController 2018-07-19 hcm@google.com Update Skia milestone to 70 2018-07-19 rmistry@google.com Debug nightly bookmaker bot Created with: gclient setdep -r src/third_party/skia@cc22d4d2fb02 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/111525079,chromium:862921,chromium:862921,chromium:862921 TBR=bungeman@chromium.org Change-Id: I0503065166103060945c430b8f6b0b9869fcaf31 Reviewed-on: https://chromium-review.googlesource.com/1145960Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577066}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I747fdd13113750aa5cf8b4d6701bd22cc168a1e8 Reviewed-on: https://chromium-review.googlesource.com/1146040Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577065}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3bfa61aedfb..a6a325ad24c5 git log c3bfa61aedfb..a6a325ad24c5 --date=short --no-merges --format='%ad %ae %s' 2018-07-21 lepton@chromium.org Android PFQ: save sdk_cheets* artifacts for pi. 2018-07-21 xixuan@chromium.org cbuildbot: Remove the abort_limit setting. 2018-07-21 saklein@chromium.org Replaced most site_config.params usages with new direct access. 2018-07-21 saklein@chromium.org Moved all site_param values into config_lib defaults. Created with: gclient setdep -r src/third_party/chromite@a6a325ad24c5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2c994a10b67920c6b85e4b33b9d4ec396d7e68f2 Reviewed-on: https://chromium-review.googlesource.com/1146000Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577064}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a5c263c..21dbf06 Bug: 830901, 851870, 851873, 859400, 866089 Tbr: zmo@chromium.org Tbr: kainino@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: Icef8ddc970ccb6653e95920c28b4d003d1b27100 Reviewed-on: https://chromium-review.googlesource.com/1144306 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577063}
-
Lei Zhang authored
Send the document loaded message from the PDF JS code on failure. Read the result code in the callback in Print Preview. In the case of failure, handle it appropriately by transitioning from the loading state to the failure state. BUG=865787 Change-Id: I331fb76814affeebb0232fa064ac9a48c66c424e Reviewed-on: https://chromium-review.googlesource.com/1144480Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577062}
-
Mike Wasserman authored
Remove problematic OzonePlatform::Shutdown method. (per-process gpu init was torn down with per-fixture aura::Env dtor) Remove redundant run_all_service_tests GPU init of OzonePatform (done as needed via WindowServiceTestSetup / GLSurfaceTestSupport) Remove obsolete WindowTreeClientWmOzoneTest aura_unittests fixture. Add some gl_factory_ozone.cc failure logging. Bug: 855191 Test: No regressions, no problems running services_unittests, etc. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If798b639e626738e3ba6d4c4a550cf3cc02c70ab Reviewed-on: https://chromium-review.googlesource.com/1144186 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577061}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fda907f4ac7e..b907757c0db1 git log fda907f4ac7e..b907757c0db1 --date=short --no-merges --format='%ad %ae %s' 2018-07-20 thestig@chromium.org Roll buildtools/ 893eb86b0..4ae75c1f8 (10 commits) Created with: gclient setdep -r src/third_party/pdfium@b907757c0db1 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I893e5594613ca7ad987455001b724005ae4b70ca Reviewed-on: https://chromium-review.googlesource.com/1145414Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577060}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9cf0f36d349f..74ff6430d6c4 Created with: gclient setdep -r src-internal@74ff6430d6c4 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I50e1bb1e77e8f0800c1c510c863785173f3fa19c Reviewed-on: https://chromium-review.googlesource.com/1145411Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577059}
-
Mike Wasserman authored
Implement NonClientFrameController::DeleteDelegate to delete itself. Regressed via the base class change WidgetDelegateView -> WidgetDelegate: http://crrev.com/c/1123654/9/ash/wm/non_client_frame_controller.h#44 See the relevant WidgetDelegateView::DeleteDelegate impl here: https://cs.chromium.org/chromium/src/ui/views/widget/widget_delegate.cc?l=200 TBR=jamescook@chromium.org Bug: 866180 Test: No ash_unittests or other leaks detected by lsan, etc. bots. Change-Id: Id8e827653d1e31a2d2abbeef9ea5e7c90e375810 Reviewed-on: https://chromium-review.googlesource.com/1145948Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577058}
-
David Bertoni authored
The toolbar icon is a visible indicator to the user that an extension is installed. Thus, a bad actor can attempt to hide the icon to disguise its presence. In addition, the icon allows the user an easy way to uninstall it. Bug: 805600 Change-Id: I178901d03b8ce6b13b70932114bbf9747890ae9d Reviewed-on: https://chromium-review.googlesource.com/1144253 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577057}
-
Wenzhao Zang authored
1) This code path is only used by old wallpaper picker. 2) |highResolutionURL| was added to new wallpaper picker images only, but the code paths shared by new and old pickers may access this field. For consistency, add this field to the old images as well (an alternative is to check the flag, but it's less clean.) Bug: 866196 Change-Id: Ia948f49090029441408f4fcb6498403ea09147a9 Reviewed-on: https://chromium-review.googlesource.com/1145879Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577056}
-
Reid Kleckner authored
This warning has a few false positives in ffmpeg. TBR=thakis@chromium.org BUG=866202 Change-Id: I08634bdeabe6e30225d37941b078c540c21a74bc Reviewed-on: https://chromium-review.googlesource.com/1145887Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577055}
-
Alexander Alekseev authored
This Cl fixes issue with <oobe-back-button> and <oobe-next-button> when text styling was not applied to <slot> default values. Bug: 865907 Change-Id: I035e0c9144527a84c6865f6fae3d86d34272c169 Reviewed-on: https://chromium-review.googlesource.com/1145870 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577054}
-
rajendrant authored
There is some crash observed in UpdateContentLengths after the Bind->BindOnce change. This CL reverts it to use BindRepeating. Bug: 865373 Change-Id: Ie9fbbd3617287523f8eca49f2e25c8afff79fa62 Reviewed-on: https://chromium-review.googlesource.com/1144217 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577053}
-
xlou authored
Added two new functions to expose pdfium functionality to the to-be-created N-up conversion mojo service. ConvertPdfPagesToNupPdf will take multiple PDF pages and import them into a N-up PDF. ConvertPdfDocumentToNupPdf will take an entire PDF document and convert it to a N-up PDF document. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: I11edc90ee717fcb295a35e3784f4ed4e72ae8117 Reviewed-on: https://chromium-review.googlesource.com/1134484 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577052}
-
Matt Menke authored
This was a tool to use the DNS stub resolver from the command line. The tool has been broken for at least 10 months, since it didn't set up a task scheduler, but used code that required one. Since no one noticed for so long, I assume we can just remove it, and have less code to maintain. Bug: 865745 Change-Id: Ia3c9e7ec5a038acaf1d1318a8aeab79192c526ae Reviewed-on: https://chromium-review.googlesource.com/1145714Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577051}
-
Ted Meyer authored
There is a race condition between AudioRenderer::Reinitialize and audio_clock_ to null. Sometimes webmediaplayerimpl can request a timestamp from the pipeline->renderer->audio_renderer which could race with an ongoing track switch doing a reinitialize. AudioRenderer: :CurrentMediaTime where reinitialize was setting Bug: 863764 Change-Id: I6d6a32be37c42bde37d1d02353e3f43a58ab4e66 Reviewed-on: https://chromium-review.googlesource.com/1142899Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577050}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org, aleventhal@chromium.org, suproteem@chromium.org Bug: 856741 Change-Id: Ic7d7b5cd157ee579064e9427e8e0fa33571b770e Reviewed-on: https://chromium-review.googlesource.com/1137259Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577049}
-
Saman Sami authored
Use video capture for screencasting. Also ship top controls height and shown ratio. Bug: 865430 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6cc7b945fb2937a6552c33ca8b5be10b566a48e1 Reviewed-on: https://chromium-review.googlesource.com/1145231Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#577048}
-
Lei Zhang authored
It should be storing PDF data and not MSKP. Adjust tests to pass. BUG=865793 Change-Id: Ib28e9c0a1579dd05d9d500bd7473103828c30079 Reviewed-on: https://chromium-review.googlesource.com/1144781Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577047}
-
Sunny Sachanandani authored
Unlike PostTask from IO thread to compositor thread in Chrome IPC, mojo polls for messages on the compositor thread which means it can dequeue a large number of begin frame messages after the compositor thread has been busy for some time. All but the last begin frame cancels the previous begin frame, and is essentially a nop, but it still ticks animations. When a page has a large number of animations each begin frame can take a long time and push out other tasks such as tile manager callbacks stalling the pipeline. Throttling the begin frames in viz doesn't fully solve the problem because we have to allow at least two begin frames in flight for pipelining, and so the client can still process two begin frames back to back. Throttling in AsyncLTFS causes issues with LTFS lifetime and ordering with respect to other messages. Saving incoming begin frame in scheduler and posting a task works and ensures that only one begin frame is outstanding at any time. R=danakj BUG=782002 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I247a87ad7475d33f878a215ce87056d20482f88c Reviewed-on: https://chromium-review.googlesource.com/1130082 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#577046}
-
Lei Zhang authored
When printing PDFs, the data type should be set to PDF. Normally this is not an issue because the renderer will just send back PDF data anyway. However, on PDF rendering failure, it defaults to the doc type to figure out what to generate for the dummy data. BUG=865793 Change-Id: I807688d07baa299af4319569a98ab2e07319cf39 Reviewed-on: https://chromium-review.googlesource.com/1144783Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577045}
-
Daniel Bratell authored
Several files in gpu/command_buffer/service use local SHADER macros. If they are compiled together in a jumbo build those macros will collide and prevent the compilation. This patch undefs the macros after use. An alternative is to give them unique names. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9de4011e1d609e5658a9d6cbe1775a3146364fa1 Reviewed-on: https://chromium-review.googlesource.com/1143265Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#577044}
-
Jonathan Metzman authored
Add fuzzable_proto_library to wrap proto_libraries used in production and by LPM. This is a reland of 2f46bdba Original change's description: > [LPM] Improve process for using the plugin for LITE_RUNTIME. > > > > Bug: 860750,861746 > Change-Id: I43d4c51f686895fc8aafb8bdae368815aee4ace2 > Reviewed-on: https://chromium-review.googlesource.com/1128249 > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577035} Bug: 860750, 861746 Change-Id: I03bae3970b7fd333268a35aa738029ff7549705a Reviewed-on: https://chromium-review.googlesource.com/1145205Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577043}
-
- 20 Jul, 2018 11 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60b9b6fb9147..7e3c67f2c332 git log 60b9b6fb9147..7e3c67f2c332 --date=short --no-merges --format='%ad %ae %s' 2018-07-20 ehmaldonado@chromium.org presubmit_support: Fix parallel execution of presubmit tests. Created with: gclient setdep -r src/third_party/depot_tools@7e3c67f2c332 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:819774 TBR=agable@chromium.org Change-Id: Idefb9827c26bf03d9a0705392db13f99b3daf9aa Reviewed-on: https://chromium-review.googlesource.com/1145800Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577042}
-
Scott Chen authored
Bug: 855205 Change-Id: I96f9face7f052db192a8eb22077d5b1dd12da7ab Reviewed-on: https://chromium-review.googlesource.com/1144413 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577041}
-
Katie D authored
This manages getting and processing user preferences, and is a pure refactor with no functional changes. Change-Id: I6cd82e188420424d37f5122bf571565e7dcdf5ac Reviewed-on: https://chromium-review.googlesource.com/1143884 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577040}
-
Jonathan Metzman authored
This reverts commit 2f46bdba. Reason for revert: Commit message incorrect. Original change's description: > [LPM] Improve process for using the plugin for LITE_RUNTIME. > > Change protobuf_library to compile everything for the full protobuf runtime > when use_libfuzzer=true is passed to GN. > > > Bug: 860750,861746 > Change-Id: I43d4c51f686895fc8aafb8bdae368815aee4ace2 > Reviewed-on: https://chromium-review.googlesource.com/1128249 > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577035} TBR=thakis@chromium.org,mbarbella@chromium.org,metzman@chromium.org Change-Id: I5bbe8ff3da58383b2b47ebc650906eb90f622cdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860750, 861746 Reviewed-on: https://chromium-review.googlesource.com/1145204Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577039}
-
Peter Collingbourne authored
With this change we use the same serialization regardless of whether we are targeting a 32-bit or a 64-bit machine. Bug: 865796 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b Reviewed-on: https://chromium-review.googlesource.com/1139106Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577038}
-
Vladimir Levin authored
R=pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03184eb50cd70b737c31244aa0e4b2681c0892ee Reviewed-on: https://chromium-review.googlesource.com/1145789 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577037}
-
Clark DuVall authored
Previously, if a request was made before any web request listeners or rules were added, the URLLoaderFactory would not be proxied through the browser process to run the WebRequest code. Now, if it is detected that WebRequest listeners/rules are added, we reset the bindings so they will be recreated and proxied through the browser process. Observers were added for a few classes so WebRequestAPI can listen to rule changes. Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371. Bug: 857577 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7805be86512545b496e30b9693374981fdc2633e Reviewed-on: https://chromium-review.googlesource.com/1139048 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577036}
-
Jonathan Metzman authored
Change protobuf_library to compile everything for the full protobuf runtime when use_libfuzzer=true is passed to GN. Bug: 860750,861746 Change-Id: I43d4c51f686895fc8aafb8bdae368815aee4ace2 Reviewed-on: https://chromium-review.googlesource.com/1128249Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577035}
-
Xu Xing authored
gpu::Scheduler executes task in the main thread. No need to call base::ThreadTaskRunnerHandle::Get. BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4ef0ba6c6a7ebeffdb721eaaec7b6d0a82e6cfde Reviewed-on: https://chromium-review.googlesource.com/1144790Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#577034}
-
Moe Ahmadi authored
Prior to this change form data were being discarded after a dynamic form submission. This was because the dynamically changed form was being added to the cache with its user entered/autofilled values. At the time of submission, form data were being discarded as they were thought to be the initial values of the fields at page load. This CL changes AutofillHandler::OnFormsSeen (which is called on dynamic form changes) to attempt to find a previously cached version of the form first. Prior to addition to the cache, form values are overridden by the cached values. This prevents those values from getting confused with the initial form values at the time of submission. Bug: 863954 Change-Id: Iba4771ee87b9777e66a6b10b6b369379dc123a46 Reviewed-on: https://chromium-review.googlesource.com/1137021 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577033}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8bf0d6f701acacab271a44dd23f80ff6ac303de0 Reviewed-on: https://chromium-review.googlesource.com/1145043Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577032}
-