- 23 Jul, 2019 40 commits
-
-
Kristyn Hamasaki authored
Ctrl+Shift+R locks bubbles from closing and allows bubbles and their elements to be inspected. Change-Id: Iba876a5dcc78324be4750823f6f53a307559bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703459 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#680118}
-
Nicolás Peña Moreno authored
This CL replaces responseEnd with loadTime in ElementTiming. Before, responseEnd would be used and would be problematic for memory cached images and for inline images (data scheme). We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This is the same time as when LargestContentfulPaint computes loadTime. As they are both under runtime flags and the hooks are not unified, for simplicity we compute the timestamp again. This will not be too expensive for ElementTiming, as the timestamp is gated on the existence of the elementtiming attribute. To store the loadTime, we change images_notified_ to be a HashMap which now stores the timestamp corresponding to loadTime and whether the image has painted (after being loaded). Bug: 982046, 879270 Change-Id: I69da42c9250cc36c567df5da285ef1a9a357b554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710840 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680117}
-
Asanka Herath authored
This change uses the plumbing introduced in prior CLs to perform detailed logging of GSSAPI library invocations. R=eroman@chromium.org Bug: 884313 Change-Id: Id010fda54f32691a092edd97385470502d18d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698942 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680116}
-
Meilin Wang authored
Delete kAssistantKeyRemapping feature flag and chrome flag since this feature has been launched. Bug: none. Test: local compile and manually test. Change-Id: Ieb8781dbb60c4ec7049c666ce05f0ce100695ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715095Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680115}
-
Jonah Ryan-Davis authored
Recent ANGLE patches have gotten two tests to pass on all platforms: conformance/glsl/misc/shaders-with-invariance.html conformance2/rendering/blitframebuffer-size-overflow.html Bug: 830046 Bug: 980675 Change-Id: I94dbd1d5567a0524aa0e0ecc23268e390cd99816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710200Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#680114}
-
Josh Nohle authored
Adds fake implementations of CryptAuthGroupPrivateKeySharer and CryptAuthGroupPrivateKeySharerImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I27a281f7f9985021c6820400e0788f7df7ed16e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713292 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680113}
-
Takuto Ikuta authored
Main purpose of this roll is to confirm that GN built on Xenial by os upgrade in https://gn.googlesource.com/gn.git/+/431bbf510dec8e10f607f7fff3f80a1ae84a737f works on Trusty builder. https://gn.googlesource.com/gn.git/+log/972ed755..152c5144 152c5144 Update and add metadata documentation 579b5b39 Move 'rust_example' to the toplevel 'examples' folder 61be3f2e Fix desc to handle single-value outputs correctly bf27729d [rust] Update RustTargetGenerator to not duplicate work 4c0c60eb Move examples to toplevel, document better. c4a88ac9 Allow crate type to be set on all Rust targets 23d22bca [docs] : fix typo 'then' => 'they' and re-generate 'reference.md' 3b5fa962 [docs] : add Markdown format for '--time' 9edc6c08 [docs] : clean up cross_compiles.md d3304fbb [docs] : fix typo sone => some fe0c6bbb Write depfile for non-C-like tools f898ccf7 Fix linking deps propagation 445ac323 [docs] GN can tell empty lists from non empty lists 3ddcc49a Fix build with GCC on FreeBSD Bug: 981741 Change-Id: I062d6b21d3955cd0a2773321b4f68056972f8950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714681Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680112}
-
Cammie Smith Barnes authored
We add DCHECKs to CreateNetworkFactory(...) for PlzDedicatedWorker to ensure that the render frame host exists, in order to help de-flake the following webkit_layout_test: virtual/omt-worker-fetch/external/wpt/fetch/api/request/destination/ fetch-destination-worker.https.html We also change the erroring out and early return in DidStartScriptLoad(...) before the call to CreateNetworkFactory(...) to the condition when |ancestor_render_frame_host| is null, rather than merely when |worker_process_host| is null. Bug: 910713 Change-Id: I471e6393392423fce736a0ef16442222629ca613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699379 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#680111}
-
Xiyuan Xia authored
LoginDisplayHostWebUI does not need to wait for wallpaper initial animation since it has no visual change (It goes from white boot splash screen to white oobe wallpaper with brightness+gray filter). Make LoginDisplayHostWebUI always create a hidden webui and show it when webui signals ready or has network errors. Bug: 985515 Change-Id: I210ac98890e908ac4381371cba686b6283297824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710000Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680110}
-
Takuto Ikuta authored
This is for faster compile step time by dropping debug symbols. Higher symbol level seems to cause slow link time. e.g. https://chromium-build-stats.appspot.com/ninja_log/2019/07/23/win-chromium-compile-dbg-ng-37-nyxn/ninja_log.win-chromium-compile-dbg-ng-37-nyxn.chrome-bot.20190723-064013.9724.gz/trace_sort_by_end.html from https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/347566 Bug: 794423 Change-Id: I393d5aae685fba158e7c4be7d7f25ab79b46dd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714371Reviewed-by:
-
Tina Wang authored
Fix nits to make code clearer. Bug: 980277 Change-Id: I08c6f04fba7e78482f01fbd5ed5f6a0b1eb09a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706556Reviewed-by:
-
Nick Diego Yamane authored
XEventDispatcher implementation *can* optionally be associated to a PlatformEventDispatcher, however in most cases it is not the case and 3 methods must be overridden with a empty/stub implementation. This CL changes XEventDispatcher, adding default empty implementation for PlatformEvent-related functions, making it easier and more intuitive implementing it. Bug: 789065 Change-Id: Icdb501133817038a536b108f8a0d8556ff3389f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710242 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#680107}
-
behdad authored
The name used for SubmitCompositorFrameToPresentCompositorFrame was not compatible with the code and has been changed to SubmitCompositorFrameToPresentationCompositorFrame Original CL added this histogram: https://chromium-review.googlesource.com/c/chromium/src/+/1672201 Bug: chromium:963778 Change-Id: Iaaace499606d7f896b0b9b5e38e13948655985a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715545Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680106}
-
Kyle Milka authored
These are in doodle.js and unused in local_ntp.js Bug: None Change-Id: I967f1f27a1ab7bc136c561d320282613d5b72f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715717Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680105}
-
Gayane Petrosyan authored
Sample screenshots: https://screenshot.googleplex.com/H1mkRMhHjAT.png https://screenshot.googleplex.com/eQpbkh9vQaO.png https://screenshot.googleplex.com/3sfoZP8NaSa.png Change-Id: I78cea0e8a387dcd3bc7aa1fe0396672e79fe7463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714219Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#680104}
-
Josh Nohle authored
Adds fake implementations of CryptAuthMetadataSyncer and CryptAuthMetadataSyncerImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I4824dd609edce07767e921f8a4667d03aa9448d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712605 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
Bug: 984954 Change-Id: Ie521ed07709ea266ea7b1c16552c14650e826467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715607Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#680102}
-
kylechar authored
This CL adds support to use SkiaRenderer with InProcessContextFactory. The existing constructor will use SkiaRenderer based on the feature list, so it will depend on the command line and default feature state. Also add a new constructor that lets tests pick between GLRenderer and SkiaRenderer so parameterized tests can be implemented. Bug: 956144 Change-Id: I5424237ccd8eecf9d7b20d59bd4627b27ed37749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715106Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680101}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/249e60896429..282f4dfee653 git log 249e60896429..282f4dfee653 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 dproy@chromium.org Update tsproxy to latest version Created with: gclient setdep -r src/third_party/catapult@282f4dfee653 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:985343 Change-Id: Id51507467b4568de0eb98b33ffc1c8cbaa00bb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680100}
-
Brandon Wylie authored
The suggested removal process as documented in the bug is to: (1) Remove any instrumentation code. (2) Mark the histograms as obsolete in histograms.xml Bug: 975891,975790 Change-Id: If21eb5799c788bf49de3e3f91ba1279ad14f19a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700329Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680099}
-
Min Qin authored
These UMA are no longer used. BUG=969993 Change-Id: Ib2d54586958289240aace62ba12d3b6a6b70ae57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704735 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#680098}
-
Mario Sanchez Prada authored
Convert the implementation and clients in the browser and renderer processes for the blink.mojom.NonPersistentNotificationListener and blink.mojom.NotificationService mojo interfaces, and adapt unit tests. Bug: 955171, 978694 Change-Id: I03aa11addfcc84fa3c16680f31f58cdca69a29db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712573 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#680097}
-
Nicolás Peña Moreno authored
This CL replaces responseEnd with loadTime. Before, responseEnd would be used and would be problematic for memory cached images. We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This time has the advantage of being independent of the memory cache and being after the image has been appended to the DOM, as shown by a test. To implement loadTime, we use a new HashMap. This HashMap populates the timestamps that will be used in ImageRecords. We cannot use the existing data structures because this happens before we know whether the image will be added to the set of visible or invisible images, etc. Bug: 982046, 965505 Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710682 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
For NG types this isn't needed anymore. The NG types now use: CalculateSizeBasedLayoutCacheStatusWithGeometry Which determines the size of a fragment ahead of time, and applies the same optimization. The only thing that we now miss, is things which are sized shrink-to-fit which use legacy layout. We couldn't apply this optimization to shrink-to-fit tables, as they may have %-based inline-sized children which affect their (final) inline size. Bug: 984642 Change-Id: I0d0b584f31947bb674f4e7e5d88d7af6cf5d9d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662535 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#680095}
-
Asanka Herath authored
This mildly reduces the number of platform specific code in files that are supposed to be cross platform. R=eroman@chromium.org Bug: 927182 Change-Id: I854f452ac95a9dbeca326821d7efd9c2ea4c61b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693565 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ecadc16190a..59b2d77a1e39 Created with: gclient setdep -r src-internal@59b2d77a1e39 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I7d0b3f34716d0f37fc0d7cff44e24f5f95847c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c80b0e954187..84bcd0c3ae08 git log c80b0e954187..84bcd0c3ae08 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mtklein@google.com skvmtool upgrades 2019-07-23 brianosman@google.com Always include surface origin in keys for program/pipeline state Created with: gclient setdep -r src/third_party/skia@84bcd0c3ae08 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I16bf6c9981d7e55296bb53a29fcb44ffee59cde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715092Reviewed-by:
-
Martin Kreichgauer authored
Tests should use the device's Config and State to influence the authenticatorGetInfo response it replies with, rather than injecting one directly. This change removes the method and changes the single test that depended on it. Also make the |allow_invalid_utf8_in_credential_entities| option in VirtualCtap2Device::Config default to `false`. It was `true` inadvertently. Change-Id: I1f0536b1b52a4d3a561afe57242639be5325a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709845 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#680091}
-
Brian Sheedy authored
Fixes the Telemetry minidump tests failing on Linux by switching from GetMostRecentMinidumpPath() to GetRcentMinidumpPathWithTimeout(), i.e. blocking until a minidump is actually available instead of assuming one has been written to disk by the time we check for it. This will also hopefully fix similar issues on other platforms, but for now, Linux is the only platform that is being re-enabled. Bug: 634156 Change-Id: I1a4bb9e8710b322e9a30c8b2040d6617bf1fc531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713749 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#680090}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I38901bded441724e46735cdda6eccc867d0c35e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715091Reviewed-by:
-
Andrew Xu authored
Learnt from other engineers that map::count at some time gives unexpected results. So replace map::count with map::find in ChromeAppListModelUpdater::FindItem. In addition, it is suspected that ActivateChromeItem may affect |current_model_updater_| in a surprising way. So move ActivateChromeItem to the end of function. Meanwhile, add more checks to help the bug investigation. Bug: 969810 Change-Id: Ic5c7b21efb4746d9761742482d9a697ebe322c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714214Reviewed-by:
-
Josh Nohle authored
Handles the BatchGetFeatureStatuses portion of the CryptAuth v2 DeviceSync protocol. Returns the feature statuses for each input device ID as a map from multidevice::SoftwareFeature to multidevice::SoftwareFeatureState. The implementation handles timeouts internally, so GetFeatureStatuses() is always guaranteed to return. Verified 100% code coverage aside from different flavors of network request errors. Bug: 951969 Change-Id: I829cb1e036c4be4c837e81a9def361be8efb071f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703278 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Vikas Soni authored
Enable 6 pixel video tests on Mac Pro FYI Release (AMD) bot since the test was fixed in CL - https://chromium-review.googlesource.com/c/chromium/src/+/1699401. Bug: 925744,911413 Change-Id: I62bf4f3beb4337d2eb84692c96ac30c3952322a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710881 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680086}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I65dd09fac56f15df03f4128cff6d51186ac3b96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715746Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680085}
-
Clark DuVall authored
TBR=kinuko@chromium.org Bug: 824840 Change-Id: I6de8c5f6089de7a031b5642fe9d440ea7ddea083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715426Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680084}
-
Aaron Tagliaboschi authored
Bug: 856777, 849483, 868407 Change-Id: I694eeab0d4041b4e521b9d2c47ded5a8d7df6ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643748Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#680083}
-
Peter Boström authored
This doesn't exist when kExtensionsToolbarMenu is on, so add a CHECK to make sure it isn't used or gives reasonable stack traces if it does hit. Bug: chromium:984654, chromium:985834 Change-Id: Ia1fde8b28dc39414cc378bda425a3d2775f0b359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715245 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#680082}
-
Aran Gilman authored
According to the W3, both alert [1] and alertdialog [2] should fire an alert accessibility event when an element with either role appears. The existing code covers alerts, since those are also implicitly live regions. However, alertdialogs are not live regions, so no alert event was fired for them. This change just moves the event generator's check for an element having an alert role before the check for live region status. [1] https://www.w3.org/TR/wai-aria-1.1/#alert [2] https://www.w3.org/TR/wai-aria-1.1/#alertdialog Bug: 983225 Change-Id: I6ecfa3ef0909e37c59bb6a94886dd3b6f3737744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698724 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680081}
-
Robert Ogden authored
Next CL will see this code moved to a new dir under //chrome/browser Bug: 986359 Change-Id: Id6d0a43b684db7aa3bcd751c6d3b7e58702ec208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715105Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#680080}
-
Max Moroz authored
Bug: 539572 Change-Id: I721b224671ead0b1f6852269667f525c7abb08ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715107 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680079}
-
