- 30 Sep, 2020 40 commits
-
-
Lukasz Anforowicz authored
This CL introduces ExternalFileURLLoaderFactory::Create static method that allows creating a ExternalFileURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<ExternalFileURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing ExternalFileURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I4bd235cf9132668d80657aece34de6fe7b60f78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357620Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#812139}
-
Aaron Tagliaboschi authored
This reverts commit 09255d96. Reason for revert: WPT bots on GitHub caught a possibly (probably) flaky test https://github.com/web-platform-tests/wpt/pull/25845/checks?check_run_id=1187933269 Original change's description: > [client-hints] Test client hint availability in service workers > > Change-Id: Icbb9de8fa340ac216a05a1093a1840c7903ba53c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432187 > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812131} TBR=yoavweiss@chromium.org,aarontag@chromium.org Change-Id: I017b04cf0ba8b47e5fa271254f69816956397aed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441268Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#812138}
-
bttk authored
The sw600dp layout location_bar_icon differed from the unqualified variant only with the value of end padding until they diverged in http://crrev.com/c/1653842 Now the alternative layout is merged back into the default variant. All overrides are now in values-sw600dp/dimens.xml Values location_bar_icon_* and location_bar_start_icon_* were identical, so now the latter values are removed. Bug: 1130414 Change-Id: I087861fbab00768009ed881bc3753a83a8458f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427211Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812137}
-
Dylan Cutler authored
This API is suspected of leaking information that could be used to identify users. We instrument this API to report digests of the value to UKM for analysis on the available entropy in this API for identifying users across different origins. Bug: 973801 Change-Id: Ia13b4b9fb7553a5e0b2ef3572c138d295c61c564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439796Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#812136}
-
Anders Hartvoll Ruud authored
This CL modifies the extraction code for complex selectors such that it can be called recursively from ExtractInvalidationSetFeaturesFrom- SelectorList. This is a step on the way towards correct invalidation behavior for :is/:where. Bug: 568705 Change-Id: I3ad09e09586032d409cea91b7ae457b832b49c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435087 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812135}
-
Michael Chang authored
For macOS, when the updater self updates, it uses the .install.sh script, and this CL should fix a bug in running the script properly. Change-Id: Ib745fbb3e998fc864ab61a8f9aba99f432c6e757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441007Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812134}
-
Oriol Brufau authored
Just replacing a line number in stack traces: resources/testharness.js:1977:25 becomes resources/testharness.js:2001:25 Change-Id: I35c7565a8cdf4d3831b059092aa5b73ddb81d73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440518Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#812133}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. This cl does not address entropy leaked by voiceschanged events. Given those events only occur when the list of voices changes due to a voice being added or becoming unavailable, it is unlikely that they would be useful to fingerprinting scripts. Bug: 973801 Change-Id: Iaa2a43f942f2eb59cece362a571da3fe308e4831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435738Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#812132}
-
Aaron Tagliaboschi authored
Change-Id: Icbb9de8fa340ac216a05a1093a1840c7903ba53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432187Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#812131}
-
Joshua Pawlicki authored
Because chrome/common/mac/launchd does not wait for process exit, and because the launchctl process itself may exit prior to setting up the new service, we must wait at certain points during updater setup to ensure that services are installed prior to their use. This CL replaces the naive 3 second wait with a 500ms polling loop that has a 3 second timeout. Bug: 1122120 Change-Id: I1c67bba21f223ec0691b55b9fe72eb28a03e98e9 Fixed: 1122120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429309 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812130}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601445309-ef3a210184e0709141a76a88c5c5e3ff88eb52a6.profdata to chrome-mac-master-1601451302-74bafe020c79028d442bb7dcedaaf977604dc6fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I335f24988fcc658f218788cd3291f15d17071128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812129}
-
Aaron Krajeski authored
This functionresets everything (transformation stack, clip, styles, font, etc). If there are pending transforms in the stack they get discarded as well. In the interest of getting the API ready for demoing I'm rushing through these a bit. TODO: Add WPT tests (crbug.com/1131449) Bug: 1131137 Change-Id: If98217fe4de804352d279aa46ab128e3bf6ae53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425067Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812128}
-
Mike Jackson authored
This reverts commit 3ce00758. Reason for revert: Keeping single enum Original change's description: > dpwas: deprecate existing display_overrides field in proto > > Feedback provided in a different CL (2375597: dpwas: Add > window-controls-overlay as a new display mode | > https://chromium-review.googlesource.com/c/chromium/src/+/2375597) > and in https://github.com/w3c/manifest/pull/932 is that we need a > way to say new display modes are allowed in display_override but > not display. > > The plan is to introduce a new enum EnhancedDisplayMode, and > display_override should be: > sequence<DisplayModeType or EnhancedDisplayModeType>. > > To support that, this CL deprecates the existing display_override field, > and renames it. Renaming here should be fine, as long as we don't use > JSON serialization. Once the new field has landed, we will remove > this field, and mark it reserved so that future users don't reuse > the field. > > Explainer: https://github.com/WICG/display-override/blob/master/explainer.md > Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing > I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion > Manifest w3c PR: https://github.com/w3c/manifest/pull/932 > > Bug: 1092667 > Change-Id: Ifbc0160a88263d4994d138f99921371ceea2bcb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436417 > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811932} TBR=dmurph@chromium.org,loyso@chromium.org,mjackson@microsoft.com Change-Id: Ie953a019c6c9d0dc7e90ea2fcf639325460e8e11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441147Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#812127}
-
Jacob Kopczynski authored
Bug: chromium:1127088 Change-Id: I7fa53861b756c648fedc1bf6d3d8b79bf8c25556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437821 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#812126}
-
Joon Ahn authored
Skeleton component for cpu chart https://screenshot.googleplex.com/C7PPFcPZ95FZXJ8 Bug: 1125150 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: Ic2ae0209fb71f894df8a4b3a4e61547975ff0f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438882 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812125}
-
arthursonzogni authored
In NavigationRequest::BeginNavigation(), records whether the navigation's initiator can be found using its ID or not. We suspect not finding it is a very rare event. This histogram will help us figure out what kind of solution should be used to support PolicyContainer for this edge case. Bug:1129416 Change-Id: I501bf0150935679667d5bd2a4cc351a70b6653ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416450Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812124}
-
Michael Chang authored
App unregister logic had a gap in which apps were being unregistered despite being on the machine. Also, changed the method name to make it more accurate to what was happening Bug: 1056450 Change-Id: I6325c303c9a7693a13bcd44c8583b7ca4020c1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439798 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#812123}
-
John Budorick authored
Bug: 1097306 Change-Id: I5ddd98b323bf7bc24015c5e561a559bcab7d9aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439797Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812122}
-
Michael Checo authored
- Add reset method to fake provider - Move method resolvers and observables to class methods Tests are in a follow up CL Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ib36194af7511da82991a012325f6a12018d12239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437027 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812121}
-
Emircan Uysaler authored
This CL adds the groundwork for video overlays on fuchsia: - Adds feature flags for an alternative path for displaying video as overlays through an ImagePipe on fuchsia. - Makes use of these flags for the initial step of associating video BufferCollections with an ImagePipe before their allocation. There is one-to-map mapping between BufferCollections and ImagePipe. ImagePipe is owned by SysmemBufferCollection instance. Bug: 1127984 Change-Id: Iaa8fa7961b7f1601d7af6a19eaf23f0f73eb7aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415381Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812120}
-
Arthur Sonzogni authored
This reverts commit e511a14a. Reason for revert: tree closed, compile failure. Speculative revert https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/13708 Fail to compile: ld.lld: error: undefined symbol: blink::FuchsiaAudioDeviceFactory::FuchsiaAudioDeviceFactory() Original change's description: > Onion soup FuchsiaAudioDeviceFactory > > This CL executes phases 5 on the design document [1]. > > [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ > > It also adds triggers the generation of blink bindings by > //media//fuchsia/mojom. > > BUG=787252 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: Ic2a1ffaea1f9647d9c2c18d298fc23c58d5cc5bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436749 > Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812057} TBR=haraken@chromium.org,sergeyu@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: Ie4a55ff77e9442a9bf0404bf58eb3951c69f9c3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440525Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812119}
-
Xianzhu Wang authored
Save it from http://jsbin.com/UVIgUTa/38/quiet into a file page/sets/key_silk_cases/physical_simulation.html, and modify it 1. Changed "-webkit-backface-visibility: hidden" to "will-change: transform" which is modern way to hint future transform changes 2. Removed some deprecated webkit prefixes Bug: 1125926 Change-Id: I50392ec4509e5b025f9bd5ad4cda2859176b1d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404374Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#812118}
-
Xianzhu Wang authored
It was accidentally added in crrev.com/807033. Change-Id: Ic482e15cfeab4e13600aa76459fcb8ce078a74ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439019Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812117}
-
Scott Violet authored
This tries to use WEB_URL first. This way 'https' urls are matched. This also special cases http://localhost: as WEB_URL doesn't handle ports. Lastly, this makes loadUrl disable intent processing. To do otherwise means you can't navigate to sites such as http://youtube.com/. BUG=none TEST=none Change-Id: I96af6c37f35fa8fae4d1bbf64fc974c3b071fbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438340Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812116}
-
Dave Tapuska authored
Add interfaces that WidgetBase can service the DIPsToBlinkSpace conversions and not via RenderWidget. BUG=1097816 Change-Id: I962bc5962cd8ff3760fb30124d742c98d4165dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430103 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812115}
-
Clemens Arbesser authored
This adds a new UKM metric that counts the number of times a lite script was shown to the user, versus the number of times it was running in total. The corresponding launch bug is http://crbug.com/1110887, but this UKM is for M-87 and after, not for M-86. The UKM is described in the design doc linked in buganizer as an addendum to the metrics section: https://docs.google.com/document/d/1GhRniGPIaBzRf8M6TZJHkvpiJSZco9W0P0_2euo_WcI/edit?ts=5f6b48e0#bookmark=id.y101pq7zbaya Bug: b/169052568 Bug: 1110887 Change-Id: I3ccf0e66b4ba209f968bb454ad4a05c2b2afda31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426591 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#812114}
-
Lei Zhang authored
Put all the bools into a struct. Change-Id: I046688c20c1cc13192fa54b2f629531df839d7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430655 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812113}
-
Owen Min authored
The unlisted tag is designed for policies that are not controlled by admin directly but set by the device management server directly. Because of that, the tag can only be used by cloud_only policies. The unlisted policies will be hidden from all documentation and template generators. On the Chromium side, this is achieved by the cloud_only tag. Bug: 1117637 Change-Id: I8e6e2bdb681a3e68897ec9e41f285805dc2e37d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436697Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812112}
-
Tomasz Wiszkowski authored
This event will allow the parent component to take an action when the user focuses the TileView using keyboard. Bug: 1106109 Change-Id: If34debc647637f0834db2bd34804c8e37a74320b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437708Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#812111}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f9788a96. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic77dbcbf33c50d91d378ebe467860d0c810dd1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440236Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812110}
-
Fredrik Söderqvist authored
This should bring us closer to how other elements are handled. The filter bounds are now applied when needed (if needed). The primary change is removing SVGLayoutSupport::AdjustVisualRectWithResources calls in the various layout paths. This restores the tighter visual rects that was previously computed. Since the visual rects propagated during layout no longer includes clipping and masking, outlines are no longer clipped for containers. Since we now no longer need to do any reading of other LayoutObject's bounds during layout, it should be possible to clean up quite a bit of hairy code in future CLs. Bug: 109224, 1028061, 1131068, 1131105 Change-Id: I502d72a5bfb3aa9149306b6c4143c69781709792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050382Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#812109}
-
Matt Menke authored
This is a core net/ performance metric, and is needed to help investigate any significant change time URLRequests take to complete. Bug: 1088996 Change-Id: Ide5f2c0f3f592ce67ad1563fcacbea64fc8b5f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424256Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#812108}
-
Ian Kilpatrick authored
The creates a new struct "RecalcLayoutOverflowResult" as the result of RecalcLayoutOverflow. There are two booleans: - layout_overflow_changed indicating if the layout-overflow changed in such a way that the parent should recalculate *it's* layout-overflow. - rebuild_fragment_tree if the fragment for the parent should be regenerated (but not necessarily recalculate the layout-overflow). There should be no behaviour change. Bug: 1066616 Change-Id: Ib7bd754b710703c8f8257a43f1add405e855bd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429970 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#812107}
-
manukh authored
OmniboxEditModel::OnPopupDataChanged params include: - |text| representing either the temporary or suffix autocompletion texts. - |is_temporary_text| to distinguish the 2 cases. - |prefix_autocompletion| The overloaded use of |text| is confusing, especially now that autocompletion consists of more than 1 string field (prefix_autocompletion and we expect to add split_autocompletion in the future). This CL replaces |text| with |temporary_text| and |inline_autocompletion|. Bug: 1062446 Change-Id: I5aa4535db1f9d4a85dced041f920d2f90afe0bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427025 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812106}
-
Ramin Halavati authored
For better measurement of Incognito usage, "Profile.Incognito.MainFrameNavigationsPerSession" metric is added to record the activity length of Incognito sessions. This metric will be added for iOS in a different CL. Bug: 966747 Change-Id: I4d163f0ec603916949972d9dc290e4247a1125e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421821 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#812105}
-
Dan Harrington authored
* ntp_snippets code in src/chrome is obsolete, since src/chrome is not used in iOS. Much of the removal was from there. * Changed code to assume that the InterestFeedContentSuggestions feature is enabled (and therefore zine is not). Bug: 1069183, 678590 Change-Id: I3b31f85a26d8ac8ff3807eee392c1994a91d0f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414997 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812104}
-
Jeroen Dhollander authored
This means the prototype now works, and the bloom response can be seen in the Assistant UI (as a very unreadable JSON string). I changed the |BloomInteractionObserver| into a |BloomUiDelegate|, as that seemed a better approach to keep the Bloom code independent of ash. Bug: b/165356952 Test: Manually deployed Change-Id: I4e1fd1acd0644c97b3e5e91131d4e593353b1e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390944 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812103}
-
Chris Hamilton authored
This defines types and utility functions that will be used by the V8ContextTracker implementation. BUG=1085129 Change-Id: I6dec02d26191a60aa3545133bbe826998693a538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427849 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#812102}
-
Andrey Zaytsev authored
Bug: 1132805 Change-Id: I24b988384eb45c315e0d59cd330e27dafb938483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435226 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812101}
-
Aga Wronska authored
This policy allows adding Family Link accounts additionally to accounts listed in DeviceUserAllowlist policy and is dedicated for school use. New policy does not change how other existing device sign-in policies work. Bug: 1126155 Change-Id: I87625f370bafd0a66f1a9c0549a222f8c11e61db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438870Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#812100}
-