GitLab

If an empty login_screen_input_methods policy is sent from the client,
treat it as if the policy was not present. Don't restrict input methods
in this case.

BUG=750572
TEST=browser_tests --gtest_filter=LoginScreenPolicyTest.*

Change-Id: I83109bb5c7648ac6a7f81da414879745bf905abb
Reviewed-on: https://chromium-review.googlesource.com/589436Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491380}

https://skia.googlesource.com/skia.git/+log/82d97bdbfc0a..50f7a1e4abea

$ git log 82d97bdbf..50f7a1e4a --date=short --no-merges --format='%ad %ae %s'
2017-08-02 fmalita Add another sweep gradient tiling test

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Idec1c3d7d4146fc5b33c56236553073b1d6d52c9
Reviewed-on: https://chromium-review.googlesource.com/598147Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491379}

The anonymous named getter is not part of the spec, and we are trying to
figure out how much it is actually used. The existing counter is triggered
whenever code tries to access a named property, this second counter is
triggered only when a property is found and should give us a better idea of
when named properties are not accessed by accident.

Bug: 689687
Change-Id: I7f255593d2a998a83a62ca60d814751b938db0af
Reviewed-on: https://chromium-review.googlesource.com/596975Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#491378}

When BookmarkContextMenuCocoaController is (re)creating menus, it first
creates a BookmarkContextMenuController, then takes the the menu model
created by it, and uses it to create a MenuController. If these objects
exist already, the old ones are destructed/dealloced when the smart pointers
holding them are reset with the new ones.

As the BookmarkContextMenuController holds the menu model in a unique_ptr,
this briefly leaves the MenuController with a dangling pointer to its model.
Unfortunately, as part of its dealloc, if the menu is still open,
MenuController will close it, and notify the model. Most of the time, this
doesn't happen, but something about VoiceOver requesting a bookmark button's
menu can make a reset happen before the menu closes.

It would probably be better to rearchitect around this, but nothing good is
coming to mind right now, so work around by manually calling |cance| on
MenuController before resetting, to ensure that the menu is closed before
dealloc.

Bug: 749213
Change-Id: I0890b341115487fe92b18d9c067e1f662b3f4958
Reviewed-on: https://chromium-review.googlesource.com/596793Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491377}

Bug: 745086
Change-Id: Ibf50d8eccd106357d00b955417fd17bfb07c3f20
Reviewed-on: https://chromium-review.googlesource.com/592701
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491376}

Allow ranges for font-weight in @font-face, compare
https://drafts.csswg.org/css-fonts-4/#font-prop-desc

Bug: 749091
Change-Id: I7e3fffe6f71d95ad5bc0703d4e01edbbb108cfd0
Reviewed-on: https://chromium-review.googlesource.com/581149Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491375}

This CL adds a function to push an article suggestion to the
top of Articles section in RemoteSuggestionsProvider. Also a button
added to snippets_internals to push a dummy suggestion.

Bug: 742225,735402
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic41f831884d9487a7e567db21b83371ae1834655
Reviewed-on: https://chromium-review.googlesource.com/585127
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491374}

Two more of these were recently, both of which are failing, and all the
old tests using the fixture are failing, too, so simplest just to
disable them all.

TBR=yzshen@chromium.org
NOTRY=true

Bug: None
Change-Id: I7e4751021dce0d2383e46a63ab7305b5e6e58676
Reviewed-on: https://chromium-review.googlesource.com/598111
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491373}

It was currently built at "optimize for size", which means important
function such as FMAC_C weren't getting autovectorized and unrolled.
Since this file is performance sensitive, using max optimization seems
reasonable.

BUG=750923

Change-Id: Id38e66365ee1b8b636e391ba07b83a804142eba1
Reviewed-on: https://chromium-review.googlesource.com/597017Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491372}

Set it to "NOT_SHIPPED" since googletest is only used for running tests. Not
setting it makes //tools/licenses.py complain.

Change-Id: I5146c7d6a7a64bcd19a194246bc24fcc47f12f32
Reviewed-on: https://chromium-review.googlesource.com/597907Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#491371}

The titles should be shown only if there are more than two sections.
This applies only to the section from ContentSuggestionsService.

Bug: 749125
Change-Id: If9d8320baa9f5cad287d47b70202cbe203f06727
Reviewed-on: https://chromium-review.googlesource.com/596050
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491370}

Bug: 751226
Change-Id: I84b42c04c16d3b5662ed6a5bf5d491b031b3c84a
Reviewed-on: https://chromium-review.googlesource.com/597014Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491369}

The FILE thread is deprecated.

Bug: 689520
Change-Id: I57db0b1e7150f2ec7ee4fbdb538912b1928cd9dc
Reviewed-on: https://chromium-review.googlesource.com/595030Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491368}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7b7658d8..5c85b29c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ie0526f93764f4b79c280e5e3dc66fa3da3a66630
Reviewed-on: https://chromium-review.googlesource.com/597831Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491367}

Bug: 749815
Change-Id: Ife1a72146c3f75020286fb588f5e78a12e8d747a
Reviewed-on: https://chromium-review.googlesource.com/596412Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491366}

This reverts commit 3dd3e056.

Reason for revert: Relanding original CL since the revert did not fix the bot.

Original change's description:
> Revert "Moved parsing logic to property APIs for grouped longhand properties"
> 
> This reverts commit 264ba723.
> 
> Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot.
> 
> Sample failed build:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635
> 
> Will reland if it does not fix the problem.
> 
> Original change's description:
> > Moved parsing logic to property APIs for grouped longhand properties
> > 
> > This patch:
> > - Moved parsing logic to property APIs for the following grouped
> >   properties:
> >     border-image-repeat
> >     border-image-slice
> >     border-image-outset
> >     border-image-width
> >     background-clip
> >     background-image
> >     background-origin
> >     -webkit-transform-origin-x
> >     -webkit-transform-origin-y
> >    -webkit-perspective-origin-x
> >     -webkit-perspective-origin-y
> >     -webkit-mask-box-image-repeat
> >     -webkit-mask-box-image-slice
> >     -webkit-mask-box-image-outset
> >     -webkit-mask-box-image-width
> >     -webkit-mask-image
> > - Replaced the bool literal argument in BorderImageUtils with a
> >   new enum class to comply with the style guide
> > - Added #includes to PositionUtils that should have been there
> >   when the file was created. For some reason this only started
> >   causing build errors in this patch
> > 
> > Bug: 668012
> > Change-Id: I796f0967e4222689c14700b12d7726df7ab35170
> > Reviewed-on: https://chromium-review.googlesource.com/597378
> > Reviewed-by: meade_UTC10 <meade@chromium.org>
> > Commit-Queue: Bugs Nash <bugsnash@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#491288}
> 
> TBR=meade@chromium.org,bugsnash@chromium.org
> 
> Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 668012
> Reviewed-on: https://chromium-review.googlesource.com/597888
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491346}

TBR=guidou@chromium.org,meade@chromium.org,bugsnash@chromium.org

Change-Id: I719f967cb722285f771fd123042da35996f4d284
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 668012
Reviewed-on: https://chromium-review.googlesource.com/598167Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491365}

The names are confusing, leading to bugs. Try to make
them more obvious.

R=pdr@chromium.org
BUG=739228

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5fe6b1c4432818279f4758397d07b581a0fbe408
Reviewed-on: https://chromium-review.googlesource.com/596847Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491364}

We previously only kept the wrapper alive as long as the scope had
timers attached. This requires us to kept explicit hidden references to
event listeners to prevent them from being garbage collected.

Relying on wrapper tracing requires us to keep the scope alive as long
as its context is alive.

This is a dependency for
  https://chromium-review.googlesource.com/c/576472/

Bug: 
Change-Id: I82c177f6e93a7ed15697e574f4e0e001957dff7a
Reviewed-on: https://chromium-review.googlesource.com/584875
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491363}

All generated RegisterNativesImpl functions are no-op already. Remove
all manual jni registration code in ui that calls these generated
RegisterNativesImpl calls.

TBR=garykac@chromium.org,zmo@chromium.org

Bug: 749244
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iebbb9d91e5cc78d62b323113c5ccecd59a7311a8
Reviewed-on: https://chromium-review.googlesource.com/592333
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491362}

https://skia.googlesource.com/skia.git/+log/21171e50f486..82d97bdbfc0a

$ git log 21171e50f..82d97bdbf --date=short --no-merges --format='%ad %ae %s'
2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 44183ccea..b0761934b (1 commit)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Ifd9ed9292d20b18cffd1968504cc7acd5df39fb8
Reviewed-on: https://chromium-review.googlesource.com/597967Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491361}

Bug: 712963
Change-Id: I9d88fb2153c9de3ff01c5542923a7d4e832ac382
Reviewed-on: https://chromium-review.googlesource.com/597610
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491360}

BUG=751543
TBR=pkasting@chromium.org

Change-Id: I9e33b2f01f0c71bb7b032d16ec4e16443fadf0b2
Reviewed-on: https://chromium-review.googlesource.com/597853Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491359}

In order to have the feature accessible, all the actions using gestures
(long press, swipe to dismiss) must have custom accessibility actions.
Also adds action sheet to Read Later cells.

Bug: 749131
Change-Id: I49171acf34b897035c998b8f0f8186bc6484d878
Reviewed-on: https://chromium-review.googlesource.com/597600Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491358}

This CL adds AccountSigninActivity.startFromAddAccountPage. This entry point
doesn't show account selection page, starting flow to add account on device
instead.

Bug: 749075
Change-Id: I58323c117db9d899119b55e5a2667e5aaebd09b1
Reviewed-on: https://chromium-review.googlesource.com/595983
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491357}

The OS_CHROMEOS define implies OS_LINUX. So a preprocessor conditional like:
    if defined(OS_LINUX) || defined(OS_CHROMEOS)
is redundant and should just be:
    if defined(OS_LINUX).

Bug: 290185 (kind of)
Change-Id: I382c636d2641ae95b2a00516fbfd3a494640a9fb
Reviewed-on: https://chromium-review.googlesource.com/534776Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491356}

This test has flaked sometimes on Android bots.

BUG=750566
TBR=jming@chromium.org

Change-Id: I2b347ba3d055abe8b93a5a2df6a63e32d72f1a24
Reviewed-on: https://chromium-review.googlesource.com/597851Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491355}

Bug: 
Change-Id: Ia000b6af703abd81e84880ffa7449b11a61c1d89
Reviewed-on: https://chromium-review.googlesource.com/596792Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491354}

First, parse WATCHLISTS. If it parses, scan the lines to check that:
- the entries are sorted
- WATCHLIST_DEFINITIONS matches WATCHLISTS.

The scanner doesn't parse the dictionary literal but extracts names
using re assuming that:
- the lines providing the name of rules matches a regexp pattern
- WATCHLIST_DEFINITIONS comes before WATCHLISTS
as it's sufficient for this purpose.

Stop grouping blink_.* rules and separating from the others in
WATCHLISTS_DEFINTIONS. WATCHLISTS already has them mixed.

As a bonus, remove an unused method GetDefaultTryConfigs().

Bug: 
Change-Id: I92ccc1e4d31b9bdfb97f5cf187ee44191397c895
Reviewed-on: https://chromium-review.googlesource.com/593708
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491353}

Add ExtensionsClient::GetUserAgent() for extension related
classes to use instead of querying the ChromeContentClient directly.

Bug: 446329
Change-Id: I3416a14d359ba50bec22d376410a0674d620b67f
Reviewed-on: https://chromium-review.googlesource.com/587403
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491352}

Bug: 
Change-Id: I40041b48ffed49826f2b725ab06a2b7b5964282e
Reviewed-on: https://chromium-review.googlesource.com/587353
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491351}

It's been wrong that this method was enclosed by the if with
cors_handling_by_resource_fetcher in its condition. CanRequest() is not
about CORS but CSP, etc.

However, this was not harmful. Since
ResourceLoader::WillFollowRedirect() just calls it on each redirect,
calling this in DidReceiveResponse() was just redundant.

So, remove it.

The only concern was that the CanRequest() uses the SecurityOrigin
on the ResourceLoaderOptions updated by HandleRedirect() on the last
redirect if any, and we remove that effect. But it looks actually
unnecessary.

Bug: 736308
Change-Id: I8d7b30a1eac6d7f5f6151a0385e7019ab815c86c
Reviewed-on: https://chromium-review.googlesource.com/581955
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491350}

Very rough plan I have in my mind for now (after this patch):
* Set-up URLLoader{Factory} in the renderer process for controllees using the
  EventDispatcher sent by the page (for now the event is sent to
  BrowserSideServiceWorkerEventDispatcher in the browser process)
* Implement BrowserSideServiceWorkerEventDispatcher::DispatchFetchEvent, which could call
  receiver_version's StartRequest, event_dispatcher's DispatchFetchEvent
  (to forward the fetch event) and then call FinishRequest.

Once the very basic part works we could possibly move BrowserSideServiceWorkerEventDispatcher
in the renderer side. (We'll need yet another controlling channel to the
browser side in the page side as well)

Naming bike-shedding welcome, while I'd like to keep landing things if possible.

BUG=715640

patch from issue 2954253003 at patchset 60001 (http://crrev.com/2954253003#ps60001)

Change-Id: I5095b22becc98e809f31c95dd32b9970ba886a6e
Reviewed-on: https://chromium-review.googlesource.com/547120Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491349}

As no one uses it, this CL removes was_ignored_by_handler from
ResourceRequestInfoImpl. This CL also unifies ResourceLoader::Cancel and
ResourceLoader::CancelAndIgnore.

Bug: 748491
Change-Id: Ic8522be4325bf4be54f34384f00fc5c3a4755aa2
Reviewed-on: https://chromium-review.googlesource.com/595291Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491348}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fca6d756..7b7658d8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

NOTRY=true
because of strange bot errors.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=machenbach@chromium.org, ulan@chromium.org

Change-Id: I94dffc086c933ef1f31276fd8a6d052251f8aa2e
Reviewed-on: https://chromium-review.googlesource.com/596973
Commit-Queue: Michael Hablich <hablich@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491347}

This reverts commit 264ba723.

Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot.

Sample failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635

Will reland if it does not fix the problem.

Original change's description:
> Moved parsing logic to property APIs for grouped longhand properties
> 
> This patch:
> - Moved parsing logic to property APIs for the following grouped
>   properties:
>     border-image-repeat
>     border-image-slice
>     border-image-outset
>     border-image-width
>     background-clip
>     background-image
>     background-origin
>     -webkit-transform-origin-x
>     -webkit-transform-origin-y
>    -webkit-perspective-origin-x
>     -webkit-perspective-origin-y
>     -webkit-mask-box-image-repeat
>     -webkit-mask-box-image-slice
>     -webkit-mask-box-image-outset
>     -webkit-mask-box-image-width
>     -webkit-mask-image
> - Replaced the bool literal argument in BorderImageUtils with a
>   new enum class to comply with the style guide
> - Added #includes to PositionUtils that should have been there
>   when the file was created. For some reason this only started
>   causing build errors in this patch
> 
> Bug: 668012
> Change-Id: I796f0967e4222689c14700b12d7726df7ab35170
> Reviewed-on: https://chromium-review.googlesource.com/597378
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Commit-Queue: Bugs Nash <bugsnash@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491288}

TBR=meade@chromium.org,bugsnash@chromium.org

Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 668012
Reviewed-on: https://chromium-review.googlesource.com/597888Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491346}

BUG=751492
TBR=twellington@chromium.org

Change-Id: Ia823694259de8e88ac1f121fafcf9393b821472b
Reviewed-on: https://chromium-review.googlesource.com/597767Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491345}

After style sharing code is removed, we no longer need the sibling and
uncommon attribute rulesets to reject style sharing. This also means
RuleFeatureSet no longer needs to be traced, so some oilpan cruft could
be removed.

The StyleEngine API UsesSiblingRules() relied on the size of the sibling
ruleset, but it was only used as what looked like an optimization for
:empty selector updates where :empty is found in non-rightmost compound
selectors. However, the presence of :empty itself would add a sibling
selector in the previous code, and :empty in non-rightmost compound not
followed by an adjacent selector would only have de-generate cases like
":empty span" which could never match anything, or ":not(:empty) span"
which would always be true if the whole selector matches. Therefore, it
makes sense to just drop the API/check.

Bug: 721517
Change-Id: I85100850cb8cec56b17947916d7755ebcf3f15ec
Reviewed-on: https://chromium-review.googlesource.com/597689Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Commit-Queue: Rune Lillesveen <rune@opera.com>
Cr-Commit-Position: refs/heads/master@{#491344}

This reverts commit a58af821.

Reason for revert: Relanding the original CL since the revert did not fix the error.

Original change's description:
> Revert "v8binding: Refactors MutationObserver and MutationCallback."
> 
> This reverts commit e4d81dae.
> 
> Reason for revert: Speculative revert.
> 
> Layout test tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html started failing reliably on WebKit Mac10.9 bot following this CL.
> It does not look very related, so I will reland it if the failure continues.
> 
> Original change's description:
> > v8binding: Refactors MutationObserver and MutationCallback.
> > 
> > Major changes in this CL are:
> > - Drops [CustomConstructor] from MutationObserver.idl.
> > - Replaces hand-written V8MutationCallback with code-generated
> >   MutationCallback. Note that the new (code-generated)
> >   MutationCallback is different from the old (hand-written)
> >   MutationCallback.
> > - Rewrote the old (hand-written) MutationCallback as
> >   MutationObserver::Delegate.  Note that the name
> >   "MutationCallback" is taken by the new (code-generated)
> >   MutationCallback.
> > 
> > This CL mostly follows the same way as https://crrev.com/c/581128 .
> > 
> > Bug: 
> > Change-Id: I3f8b36044499c50baade331e2bfafbbed4271e0d
> > Reviewed-on: https://chromium-review.googlesource.com/590832
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#491297}
> 
> TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org
> 
> Change-Id: Ie6aeebac4741cd3a7cac1dacd15c6f709e15ecab
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/597708
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491333}

TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,guidou@chromium.org

Change-Id: I4e2fba2f191aeb2caea234af1307b1a9dde144dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/597887Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491343}

Bug: 
Change-Id: I972758628679b0be7ec8627aade1d850fe0f5f3a
Reviewed-on: https://chromium-review.googlesource.com/597532Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491342}

Reland of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #1 id:1 of https://codereview.chromium.org/2985393002/ )

Reason for revert:
BUILD files have been fixed in a separate CL, so this is safe to reland.

Original issue's description:
> Revert of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #6 id:120001 of https://codereview.chromium.org/2969093002/ )
>
> Reason for revert:
> Breaking build https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/3356
>
> Original issue's description:
> > Make rendering of MediaStreams reflect changes to its set of tracks.
> >
> > Before this CL, MediaStreams assigned to a media element required
> > reassignment of the stream to the element in order to make changes
> > to the set of tracks visible.
> >
> > This CL fixes this problem by making WebMediaPlayerMS subscribe to
> > changes in the set of tracks of a MediaStream, and correspondingly
> > update audio and video renderers.
> >
> > BUG=720258
> >
> > Review-Url: https://codereview.chromium.org/2969093002
> > Cr-Commit-Position: refs/heads/master@{#490906}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8
>
> TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,guidou@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=720258
>
> Review-Url: https://codereview.chromium.org/2985393002
> Cr-Commit-Position: refs/heads/master@{#490920}
> Committed: https://chromium.googlesource.com/chromium/src/+/b35b4c271b7819e3661942ab2c72083673722910

TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,jkrcal@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=720258

Review-Url: https://codereview.chromium.org/2994473002
Cr-Commit-Position: refs/heads/master@{#491341}