- 07 Feb, 2020 40 commits
-
-
Wez authored
TBR=kmarshall Bug: 1050049, 973095 Change-Id: I71047a5f70b395cf78e9e8b7432b52b39a1f1e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044096Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#739393}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dd48b7e2d06e..693b8a8d95e3 git log dd48b7e2d06e..693b8a8d95e3 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 bclayton@google.com vscode: Add third_party/benchmark to include dirs Created with: gclient setdep -r src/third_party/swiftshader@693b8a8d95e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I36bd3a442b9d2231570de002490726c8cf0c440b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739392}
-
Dominik Röttsches authored
The previous change [1] to always apply opsz to Mac system fonts did not handle a situation in which loading a system font comes back with a null result. Cover this case for the base typeface as well as for the case where instantiating the variable font fails. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2020767 Bug: 1049391 Change-Id: I2aad15c31f7ad793abc389f66afab3fbdf963df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041667Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#739391}
-
Sam Maier authored
The upstream SDK is now being permanently used as our tools directory. Bug: 1049245 Change-Id: Idffe05b5c10e8d4a468bb2a663b3d438fb63e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040113Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#739390}
-
Egor Pasko authored
Discard CachedMetadata from ScriptCachedMetadataHandler after it has been 'consumed': deserialized into objects on v8 heap. This is done behind a base::Feature to allow experimentation. Also record a histogram every time GetCachedMetadata() is called. Reports the extracts of the history of the corresponding member: * present * had never been present * was present but then got discarded As a side effect discarding also ignores subsequent SetCachedMetadata(). This is mostly a precaution against unintentional memory usage and unnecessary disk writes in the future. We expect reuse-after-discard should happen rarely enough not to affect performance (the experiment should prove that). Resetting the CachedMetadata should be even less frequent because in order to reset, the callers must check whether the CachedMetadata exists. The main changes are in: * script_cached_metadata_handler.cc (the new state of being discarded, recording the histogram) * v8_script_runner.cc (asking to discard) Bug: 1045052 Change-Id: I983e1dee913a2816368fc16c92d6b6e6c44c9e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022649 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#739389}
-
Alexandre Courbot authored
The V4L2 device members are currently accessed in the GL/EGL image creation method, which runs on the child thread. But these members belong to the decoder thread and are not thread-safe. Fix this by passing the device used to create the GL/EGL image to the creation method. That way the member is accessed from the decoder thread, and the only thing that happens in the child thread is the call to V4L2Device::Create(E)GLImage, which is supposed to take place there. BUG=None TEST=video.Seek.switch_vp8 passing on Kevin. TEST=video.Seek.switch_vp8 passing on Hana. TEST=video.Seek.switch_h264 passing on Krane. Change-Id: Ie94745c1215989db77e85896ac1fda69cf43a080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026853 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739388}
-
Oleg Davydov authored
ContentVerifyJob has ability to inject test observer, but before this CL the observer is accessed from different threads, leading to flaky crashes in tests. See https://crrev.com/c/2032998. Now this observer (ContentVerifyJob::TestObserver and pointer to it from g_test_content_verify_gob_observer in content_verify_job.cc) supports thread-safe refcounted pointing, therefore is not destroyed too early. Also it's wrappend into lazy initialized since we need access to it be no-op outside of the tests. Bug: 796395, 958794 Change-Id: I7479216f23083d4fd41dae08cb2e7acb62da0abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033159Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#739387}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716a808922fb..27380a85d035 Created with: gclient setdep -r src-internal@27380a85d035 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049079 Tbr: jbudorick@google.com Change-Id: I5c35c4b6a7ecf7620ec80156e5a6fa9edc9b2caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043912Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739386}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/5f20251f863498d..d96ecdaaf35ed 2020-02-03 fayang Deprecate gfe2_reloadable_flag_quic_use_handshaker_delegate2. Change-Id: Ibe7d590d32717317f0600fa4029ff5a495f3fa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042310Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739385}
-
Istiaque Ahmed authored
This CL partially reverts I1bc55cd5da2cc106e8d74dba172122d2bf943d31 that added support for setIcon from Extension Service workers. This is because setIcon doesn't work for svg images. This CL also disables the relevant tests (*/BrowserActionApiLazyTest.Update with Service workers.) Bug: 1049214 Test: browser_tests -f *BrowserActionApiLazyTest*:*NavigatingExtensionPopupBrowserTest*:*BrowserActionApiCanvasTest* Change-Id: Ie3e755c198477b72d27935a54d934bd86dc79c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042142 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739384}
-
Sam Maier authored
This roll is part one of enabling class merging. The next step would be to actually use it with build rules. Bug: 1040534 Change-Id: Ife82863d74267c44a10bee4d0f427b937ae197ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033752 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3560b680e35..77fdf66946d2 git log f3560b680e35..77fdf66946d2 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 enga@google.com Revert "Cleanup program building a bit" Created with: gclient setdep -r src/third_party/skia@77fdf66946d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I3228d1c9c233965f6d9ae9b23e6162330cc19219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043921Reviewed-by:
-
Bo Liu authored
Also remove ericrk who has unfortunately left the chromium project. Change-Id: I7184d88d6cec1c264760d2c01e1301913d43c399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042289 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#739381}
-
Andrey Zaytsev authored
Also updated the unit tests and the SafetyCheckHandler class structure. Bug: 1015841 Change-Id: I711ae992d1b60f35a12c5cccebfa172d8e1ded54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986030 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#739380}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/537ed8164e47..1e74ce74a9fa git log 537ed8164e47..1e74ce74a9fa --date=short --first-parent --format='%ad %ae %s' 2020-02-07 tvanderlippe@chromium.org Add e2etest for Last-Modified parsing in network tab 2020-02-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-07 yangguo@chromium.org chmod +x scripts/test/run_e2e.py Created with: gclient setdep -r src/third_party/devtools-frontend/src@1e74ce74a9fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f25d3079da38cdf91350554e1a0bfd179e98b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043917Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I6bf8111fc3120ca748a0a6729180e82fd644bba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043920Reviewed-by:
-
David Benjamin authored
This is downcasting from a base class to a derived class, so it needs to be static_cast in case the pointer needs to be adjusted. (It's fine in this case because Key only has one base class.) Bug: none Change-Id: I141d142a00498b53632f9def7b615aa077ee69ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042268 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#739377}
-
Finnur Thorarinsson authored
This reverts commit a3d37b5f. Reason for revert: ChromeOS build bot... https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg ... started failing a CrSettingsAnimatedPagesTest.All consistently. Reverting to see if this is related. If test continues to fail, we can unrevert. Original change's description: > Settings: Port on_startup_page/* to Polymer 3 > > - Autogenerate Polymer 3 versions for files in on_startup_page/* > - Update closure compiler and polymer_modulizer/js_modulizer targets > for these files > - Autogenerate tests for the Polymer 3 files > > Bug: 1026426 > Change-Id: I122bcb77d366b7fc7fd979b235d13d283faf8d43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040626 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739259} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I91d6a678ce1d1b0324ca4da0746981982cf35e73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044113Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#739376}
-
Rushan Suleymanov authored
This reverts commit 631967a6. Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures. Original change's description: > Revert "Reintroduce sync cache GUID migration logic from directory to prefs" > > This reverts commit 37ca67ee with > various non-trivial updates to the patch due to git conflicts as well > as logic having evolved meanwhile. > > Reason for revert: users must have migrated to prefs after 9 months. > Clients that haven't migrated meanwhile will incur in additional data > downloaded from sync servers, and may worst-case run into undeletions if > they were unlikely enough to have pending local deletions. > > Original change's description: > > Reintroduce sync cache GUID migration logic from directory to prefs > > > > After some back and forth, we've concluded that there's too much risk > > involved in assuming most clients have already migrated to prefs, i.e. > > cache GUID and birthday populated. > > > > As middle ground, we keep considering the values in prefs the > > authoritative ones, but if empty, we populate them from the sync > > directory. This adds some complexity, but allows us to defer the more > > aggressive turndown (disable migration), which in addition can now be > > guarded behind a feature toggle. > > > > Bug: 923285 > > Change-Id: I11c4814dae1810c34c1473af36ace9a1b517067f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609242 > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#659030} > > Bug: 923285 > Change-Id: I35cad35fdd398db08ee3a5cea82eaee5ebd9e980 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022787 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735486} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923285, 1048771 Change-Id: Ie19c4d300428d59358921e55800337fbf10f0f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042617 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#739375}
-
Rushan Suleymanov authored
This reverts commit 44d3aa82. Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures. Original change's description: > Unify clearing of sync prefs > > SyncPrefs is a thin layer on top of preferences and hosts two groups > of preferences: > 1) Actual user-facing settings, such as type-selection, exposed via > SyncUserSettings. > 2) Local "bookkeeping" sync metadata, such the last synced time or the > client ID (cache GUID). > > In addition, there are two cases that fall somewhere in the middle, > whose behavior is changed in this patch: > a) FirstSetupComplete: which roughly represents the user having > consented to sync-the-feature (as opposed to transport-only upon > sign-in without explicit user consent). > b) The encryption-bootstrap-token: which represent an explicit > passphrase (usually custom passphrase) entered by the user, that > allows decrypting the incoming sync changes and encrypt outgoing > ones. > > The last two preferences above fit group 1 better, so this patch stops > clearing them in SyncPrefs::ClearPreferences(), now renamed to > SyncPrefs::ClearLocalSyncTransportData(). > > With such cleanup, what used to be > ClearDirectoryConsistencyPreferences() is now merged into a single > clearing function, ClearLocalSyncTransportData(), and all calling sites > are unified by directly clearing prefs in ShutdownImpl(DISABLE_SYNC), as > opposed to individual calling sites. > > This introduces -arguably desirable- behavioral changes because > codepaths like RESET_LOCAL_SYNC_DATA or STOP_SYNC_FOR_DISABLED_ACCOUNT > now actually clear all local metadata, which most notably includes > keystore keys. > > Change-Id: I2c42f98c4e068c7e340580d0b78a5cd5b5c46171 > Bug: 1046237 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023649 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735841} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046237, 1048771 Change-Id: I4ce9e941f12aa58b7b6b286e990e74a1e01dad69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043451 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Daniel Cheng authored
The goal is to split up modules_idl_files.gni into smaller .gni files that are owned by OWNERS of the corresponding module, so top-level module OWNERS don't need to review every CL that adds a new IDL file. This patch splits out the build files for IDLs that define dictionaries. Bug: 1048907 Change-Id: I1ec3d198ca89a02f69e088d7d739145da820f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043770 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
This reverts commit 10646707. Reason for revert: This is a speculative fix. Two Arc changelists went into this build... https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/34691 ... and I've already tried reverting the other one, but it didn't fix the issue. If ArcAppDeferredLauncher* tests continue to fail with this revert then this can be unreverted and the Arc tests need to be disabled. Original change's description: > arcvm: Get the board name from the generated prop file instead > > On some boards like nami, CrOS rootfs' build.prop doesn't have the > complete ro.product.board entry. It's sometimes a template. To always > get the board name on all boards, ArcDefaultAppList needs to wait > for ArcSessionManager to generate the board's own build.prop file > in its stateful partition. This is the same as what arc-setup does > today. > > This CL also stops special casing ARCVM and does the same for > ARC too. Also, when calling GetBoardName(), this CL uses > MayBlock() to make it debug build compatible. > > BUG=b:144199481 > TEST=try, ARCVM still starts > > Change-Id: Ie878d9ffff98ecf3b9dccb837fd6dce1a382a4be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026668 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739250} TBR=yusukes@chromium.org,khmel@google.com,khmel@chromium.org Change-Id: I5a75922a9b101aafb1bb03de86826003a41ce599 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:144199481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044152Reviewed-by:
-
Rushan Suleymanov authored
This reverts commit caf8eebf. Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures. This CL reverts a preference being introduced without the corresponding cleanup logic; but we intend to reland this patch anyway. Original change's description: > Verify consistency between sync and sign-in account IDs > > Local sync metadata belongs to one user account. Due to the distributed > nature of the locally persisted sync metadata, the cache GUID is used > as "epoch" to detect mismatched in edge cases like the browser crashing > during shutdown and before I/O gets flushed. > > However, prior to this patch, the cache GUID itself has no safety > mechanism to detect it maps to the intended account ID. In this patch, > a new SyncPref is introduced to achieve that, in away that both prefs > (cache GUID and account ID) are stored atomically. > > Because the pref is newly-introduced, migration logic is introduced to > populate it for the first time if initially empty. > > Change-Id: I2cdd9f997077c4acd16e9283df8c025f51d40546 > Bug: 1046237,1021527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023528 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736848} TBR=msarda@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046237, 1021527, 1048771 Change-Id: Ic9dcaf53780350984c3036f6acdb549f631893f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041669 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I423a56ae785d00d77f01b243d7fd91670ab4681c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041607 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#739370}
-
Finnur Thorarinsson authored
This reverts commit 6ed337de. Reason for revert: The new unit test fails on linux-chromeos-rel. See build where it was introduced: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/34701 Original change's description: > Add EDU login flow: EduAccountLoginHandler > > Add EDU account login handler to fetch user's family members and > getting ReAuthProof token for parent. > > Bug: 1043108 > Change-Id: Icf4b2782a4e6f114f452468baf09d2478db8d58c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033156 > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739305} TBR=khorimoto@chromium.org,dpapad@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Change-Id: I469bd5e3ed648880df75e49093610a8031cc313e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043838Reviewed-by:
-
Omar Morsi authored
This CL automate the packing of the enterprise platform keys test extension such that running google-chrome-stable --pack-extension=<test_extension_path> --pack-extension-key=<test_extension_private_key_path> to update the crx file after changing tests is not needed as the crx file will automatically be created before the tests run in the SetUp() function. reflected while running the tests without manually regenerating the crx file. Bug: chromium:716027 Test: Manual. Made some changes in the tests and made sure they are Change-Id: I3309b54d717d112ab41ee8cac6db78aa4a11cf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035898 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#739368}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ib4ce040e0cde7e321f6a4e51b0da881fe33cc703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043930Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739367}
-
Maksim Moskvitin authored
RequestAccessToken() has several calling sides and in the old implementation any call would bypass the exponential backoff. The fix is to just exit early if access token request is backed off. This CL also adds test for repeating access token request on failure, which ensures that access token requested again after backoff time and UpdateSubscribedTopics() call doesn't lead to backoff bypassing. Bug: 1020117 Change-Id: I6cd8db430ce32ae54eca60ad2fad321ffb5119a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043835Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#739366}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c43516c5f8a8..537ed8164e47 git log c43516c5f8a8..537ed8164e47 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 tvanderlippe@chromium.org Add click options to click helper 2020-02-07 tvanderlippe@chromium.org Add $$ helper 2020-02-07 aerotwist@chromium.org Updates 403 message in Hosted Mode server Created with: gclient setdep -r src/third_party/devtools-frontend/src@537ed8164e47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0cfe7b1f1957ec56e57340dd483296277b89a817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043911Reviewed-by:
-
Findit authored
This reverts commit 4c8e6831. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 739264 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjOGU2ODMxM2M4Y2RhYzc2ZDQwYWM1YjU0MGFiOGQ4YTVkNzBlNDEM Sample Failed Build: https://ci.chromium.org/b/8889134545144502000 Sample Failed Step: interactive_ui_tests Original change's description: > [CrOS Settings] Add OS-specific "path visited" metric > > Before this CL, navigating to a settings subpage on browser and OS > settings emitted to the same histogram. This caused issues, since some > separate subpages have the same name in each settings surface. For > example, the "/printing" subpage means a completely different thing in > OS vs. browser settings. > > Bug: 1049417, 1026353 > Change-Id: Ifbe15866c61377a8da0413694b8578228401a6fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040951 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739264} Change-Id: I1339475cc39696627dc2f14c796fb93f7d798620 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049417, 1026353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043915 Cr-Commit-Position: refs/heads/master@{#739364}
-
Benedikt Meurer authored
This refactors the `CallClientFunction` helper method into a new helper method `CallClientMethod`, which takes separate object and method name, and the arguments (as base::Values), with the intention of sending that information to the renderer in a second step, instead of generating a string with all the above embedded in it, which is then send to V8 as a new script. The motivation is that sending every single protocol message as a new script causes a lot of churn on the renderer, not only regarding the runtime performance, but also trashing the memory and resulting in fragmentation that can be avoided. Drive-by-refactoring: Reduce friction around the variable number of parameters passed to `CallClientMethod` and avoid the need to pass base::Value as pointers. This improves code readability a bit. Bug: chromium:1029427 Change-Id: I5ac578e2071d7ba63b9b42dff7e3b137a9908043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042713 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739363}
-
Yuichiro Hanada authored
We need to tell the observers of ArcInputMethod bounds when the input method surface is being removed. Without doing that, the observers can't know whether the input method surface is still there or not. device to clamshell mode. Bug: 1042549 Test: manual - show Chrome OS VK on an ARC++ app and flipping back the Change-Id: Ib3e8fed3aa24a856c016ebcf7d3f6af2b2e2e1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043186 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:Tetsui Ohkubo <tetsui@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#739362}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ea7d67030546..bcd98820a91c git log ea7d67030546..bcd98820a91c --date=short --first-parent --format='%ad %ae %s' 2020-02-07 hjd@google.com Merge "ui: Grey out counter tracks when thread/proccess dies" 2020-02-07 treehugger-gerrit@google.com Merge "Parse field names with type." 2020-02-07 treehugger-gerrit@google.com Merge "Strip arrays in DeobfuscateDatabase" 2020-02-07 lalitm@google.com Merge "trace_processor: enable json1 in SQLite" Created with: gclient setdep -r src/third_party/perfetto@bcd98820a91c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id132f14cc2ac32db9ca0dc2aabed631e9ca158af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043910Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ecd6fc84cf07..285f83d47bfd git log ecd6fc84cf07..285f83d47bfd --date=short --first-parent --format='%ad %ae %s' 2020-02-07 jonaso@webrtc.org Add support for injecting VideoBitrateAllocatorFactory also on IOS 2020-02-07 sprang@webrtc.org Reland "Remove PlayoutDelayOracle and make RtpSenderVideo guarantee delivery" Created with: gclient setdep -r src/third_party/webrtc@285f83d47bfd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib74087c0da7c535437b5c1675a6535bccb231242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043402Reviewed-by:
-
Lukasz Anforowicz authored
This CL starts treating |request_initiator| that doesn't match |request_initiator_site_lock| as a bad IPC message and ignoring such malformed resource requests. NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility UMA is non-zero in recent Canary releases. Therefore it is possible that this CL will get reverted after gathering sufficient number of DumpWithoutCrashing reports to understand why the lock doesn't match the initiator in some real world scenarios. Bug: 920634 Change-Id: If4fbdb6336703f53784c036ca5d9e408ff223d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006113 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#739359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55de83afeec7..51fd2958f9a2 git log 55de83afeec7..51fd2958f9a2 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 1f03ac10270a..fe10239f92f4 (1 commits) Created with: gclient setdep -r src/third_party/angle@51fd2958f9a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I4ea5583552a0eb17a23b1cb100db2638999dadf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043400Reviewed-by:
-
Gyuyoung Kim authored
This reverts commit ec6127ba. Reason for revert: Caused flaky test failure on WebKit Linux Leak. Original change's description: > Convert WebTestHostMsg_InitiateCaptureDump to Mojo > > This CL migrates the legacy InitiateCaptureDump IPC message > to the new Mojo defined in WebTestClient interface. > > Bug: 1039247 > Change-Id: Idd38ecf67d10593f3bfc6f3c48d9832514cec595 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032634 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739222} TBR=dtapuska@chromium.org,mkwst@chromium.org,gyuyoung@igalia.com Change-Id: Ie0bc76b7d3c8dd67481d67d0ee22b0338d87334f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043531Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#739357}
-
Swapnil authored
When we manually install an extension and then add it to force installed list, it should get updated. If the extension gets corrupted before the Manifest::Location of the extension is updated, the extension does not get reinstalled. This was because after updating the location, the function OnExternalExtensionUpdateUrlFound return false in each case. It should add the corrupted extension to pending extensions list instead. Bug: 1045371 Change-Id: I9af45488b64d6a7ecde89921023bd35941e1ed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023525Reviewed-by:
-
David Jean authored
CRWWebViewScrollViewProxy passes itself to its delegate, CRWWebViewScrollViewDelegateProxy, and both were keeping strong pointers to each other. Change-Id: Icb13eddcbb4cce14a2691c8b25fe5708cde6f699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041628Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#739355}
-
Fredrik Söderquist authored
Now with <script> elements in the HTML namespace. Because reasons. Change-Id: Ia3eba0f7856f265ed6fa601272a2d7c577b07c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043450 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#739354}
-
