GitLab

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b36c2d9991f1..aef2982079e5

2020-08-20 sigurds@chromium.org Surface more info about security and isolation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1051466
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If7b70a94969906a696e15ba540b3db6d86a6f2d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367174Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800179}

|mInitialScaleFactor| causes scrollable subframes to their width to fit
the size of their clip rect. This is not desirable, instead the subframe
should inherit the current scale factor of their parent.

Bug: 1099722
Change-Id: I0a45d52a59239b59a30d08349748ae80688c577c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363775
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800178}

Impacted -
Arabic: https://nimb.ws/VMt1LI
Hebrew: https://nimb.ws/f36byI

Reference (unchanged) -
English: https://nimb.ws/XFKJwq

With regard to the placement of the dropdown -
* left:0 is not needed at all - it is ignored in both ltr/rtl and struck
  out in the inspector.
* right:0 causes the iron-dropdown to align to the right hand side of
  the window for rtl languages

With regard to the click-ability of the burger icon
* In rtl, #leftSpacer is covered by #centeredContent, so the
  burger icon is not clickable because #centeredContent is set at
  width 100% to accurately center the search box in narrow mode. A
  z-index of -1 is applied to #centeredContent narrow mode in order
  to place it beneath the #leftSpacer. #centerContent was set to 100%
  in order to avoid the use of CSS translate transform,
  which would remove the need for a child to be centered based off
  the positioning of its parent which varies since OsToolbar shifts
  based off of the width of the window. Using that property was
  hard to follow, so I decided against it in [1].
* The width of the #leftSpacer is shrunk to 20px in narrow mode
  so that it does not overlap with the OsSettingsSearchBox in any
  width, so that any part of the CrToolbarSearchField is
  clickable.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2337277

Bug: 1119638
Change-Id: I5c609f68b4ad0a8d4c4b89b12b1cf4dcc2a1d06a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365974Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800177}

Bug: 1114029
Change-Id: I732e4c3c1820aec2c6b6cd1aa5fee3b52dae98b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367078Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800176}

Bug: 1084447
Change-Id: Ifb3ac180c673fff6de349018e649cd0f1d67f847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364615Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Cr-Commit-Position: refs/heads/master@{#800175}

Bug: 1094366
Change-Id: Id07f37da45219bfdfffc7cc9ccdae60c97c1df01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365227Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800174}

Bug: 893183
Change-Id: Ib8eea4c29e68ec0483c1f97522ac516e6d18fb44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360416
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800173}

This reverts commit b7c98d05.

Reason for revert: assertion failures on Intel GPU bots per https://bugs.chromium.org/p/chromium/issues/detail?id=1119491#c4

Original change's description:
> Work around where BRGA8 overlays are supported but not reported.
> 
> On Intel GPUs where YUV hardware overlays are supported, BRGA8
> overlays seem to be supported, but the system fails to report
> that.
> 
> BUG=1119491
> TEST=manual, gpu_unittests
> R=​magchen@chromium.org
> 
> Change-Id: I304aef3731f142c13c945ca22ce0df81afbcd21d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364580
> Commit-Queue: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Maggie Chen <magchen@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#799901}

TBR=zmo@chromium.org,sunnyps@chromium.org,magchen@chromium.org

Change-Id: If3f17c4fcab42d31a8285d55ca20c5a24808dbae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1119491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367116Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800172}

This reverts commit a89614a1.

Reason for revert: Seems to be causing heap-use-after-free failures on Linux ChromiumOS MSan/LSan/TSan builders:

https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20296

https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38328

Original change's description:
> Add time loading reporter for Chrome OS views-based multiprofile
> 
> Bug: 1066489
> Change-Id: Iceeaee0f33dff50d75361d1f14e14299a37a0830
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292477
> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800055}

TBR=antrim@chromium.org,asvitkine@chromium.org,rsorokin@chromium.org,tellier@google.com

Change-Id: Iaae1e4466b6b5ac06f609efacc2f02398ab27fd2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367193Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800171}

Implement initializer list support for creating arrays and dictionaries
in TracedValue::Build. Thus speed up adding debugging tracing of
multiple parameters, including container types.

Reland with fix the problem of: crrev.com/c/2346286 by keeping a copy of
a std::string instead of just keeping a reference to it.

Bug: 1043616
Change-Id: I731347c24eff278f6e0c47887267de4d280b654a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362657Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Karel Král <karelkral@google.com>
Cr-Commit-Position: refs/heads/master@{#800170}

Bug: 1115024
Change-Id: I0a025910e4362c9a118d725293f7c5c2f477a33c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362735
Commit-Queue: Thomas Tellier <tellier@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800169}

Bug: 973801
Change-Id: Ie07f6fc6e2f86bcfc1c81ec49335cc3bcbf19c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363850
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800168}

Add a new enum value HISTORY_DELETE to the
FlocIdComputed_EventTrigger enum. When history is deleted, recompute
the floc and log the event accordingly.

Bug: 1062736
Change-Id: I236df7cc3246cef8f836de752d405e5c209e2395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364208
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800167}

In preparation for moving the MediaSource core interface into the
MediaSourceAttachment interface, this change factors out a necessary
class for retaining the existing same-thread Oilpan collection of idle
unreferenced attached HTMLMediaElement+MediaSource object groups.

Specifically, adds MediaSourceTracer to specialize further in later
changes in modules concrete implementations how to handle Oilpan tracing
of an HTMLMediaElement and a MediaSource in same- versus cross-thread
attachments. Includes same-thread concrete specialization in this
change. Having this as a separate entity reduces complexity and
fragility on both of those sides of the attachment. Note that a same
thread non-oilpan concrete attachment cannot use "Member" since the
attachment class is unmanaged. Hence the need for this MediaSourceTracer
to encapsulate that "Member" linkage.

BUG=878133

Change-Id: I4153ade37a1d4303af2604c2c2e18f701a79834d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363703Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800166}

If you hover over the remove X, then quickly off the X and row,
OnMouseEntered and OnMouseExited are not called on the row. This causes
the row to display as focused and the X to show. You can also duplicate
it by quickly sliding moving the mouse over the rows where the X button
displays.

Bug: 1109473
Change-Id: Ie5621f6e1d780d80ff46c34846856b3476f566f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333393
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800165}

The progress tracker is responsible for counting the credentials
that have been processed by the check, as well as the number of
credentials that are still to be processed.

Since the bulk leak check tries to be as efficient as possible, it
performs a deduplication step before starting to check passwords. In
this step it canonicalizes each credential, and only processes the
combinations that are unique. Since this number likely does not match
the total number of saved passwords, the tracker updates the counts
with the number of saved passwords that share the same canonicalized
credential.

TBR=andzaytsev@google.com

Bug: 1102025, 1092444
Change-Id: I09dd04c0c563a70998e5a415956a619315d27656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363759
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800164}

https://android.googlesource.com/platform/external/perfetto.git/+log/2d613f1e1be9..56d9df4fa53f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ia6cd3d6444ec254ab00b7187828c577c4d60d849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800163}

To provide additional insight into the of data collected in the Access
Context Audit database, several UMA histograms are added:
	- Database size
	- Number of records
	- Unique cookie domain count
	- Unique storage API origin count
	- Unique top frame origin count

Bug: 1101675
Change-Id: I2c8b6e309e74c98a56067796edc86b5a927fc967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358743Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#800162}

Adds IPH for top-level menu button of the Discover feed header in the
NTP. Here is clip for the IPH appearing: http://shortn/_TejkyqTmah

Bug: 1085419
Change-Id: I7a713d1e8cdb66fda3902ceb1f5db843bf414f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354904
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800161}

Make it possible to enable TransferableStreams from the server side.
This will be useful if we find that we need it before the next branch
point.

Tested manually.

BUG=894838

Change-Id: I93eebe5f36c4a1277492febe1138503c040ac269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366953Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800160}

R=rushans@google.com, treib@chromium.org

Bug: 1102322
Change-Id: Iaaf74e0260e2b2ad560938dcb7d9fbbd0f899911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366719
Commit-Queue: Paula Vidas <paulavidas@google.com>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800159}

We cut some corners on privacy that were helpful for the early prototype
of Related Searches. Now those have been removed.

BUG=1064141

Change-Id: I193c60f63d62e915e3dfa28e596fbb4ad6fc8d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365213
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800158}

Split the report.body.type:

From:
  access-to-coop-page
  access-from-coop-page

To:
  access-from-coop-page-to-opener
  access-from-coop-page-to-openee
  access-from-coop-page-to-other
  access-to-coop-page-from-opener
  access-to-coop-page-from-openee
  access-to-coop-page-from-other

to match with the new specification updates.

Bug: 1090273
Change-Id: Ia8b9af6b2751ba5154f1c56793d01542cd736bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356404Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800157}

When a credential from the list changes (is added in a new check or
removed) the entire list has to change. However, in order to keep the UI
stable, the list should maintain its order, which has to be as follows:

1. Phished credentials appear before leaked credentials.
2. Compromised credentials found in previous checks should appear
in descending order of creation time (most recent first).
3. Compromised credentials found in the current check (and all checks
ran while the list UI is open) have to be appended to the list.
This means that they need to be ordered in ascending order of creation
time.

Bug: 1102025, 1092444
Change-Id: I9e262791227454065fd556c0974b12b43fc9843a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362609
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800156}

Add 2 histograms which exposes last packet sent time delta and connection duration when receiving PUBLIC_RESET.

R=dschinazi@chromium.org

Change-Id: I75ae9c95b13273ef1421b28113e11c5dd63bc59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366913
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800155}

There are other devices now.

Fixed: 1119603
Change-Id: I8ea42abcfe4d98397a02b8975ce89d4d30489e2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366312
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Fergus Dall <sidereal@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800154}

Fix this error in GCC compilation:
../../third_party/blink/renderer/platform/heap/member.h:251:13: error: explicit specialization in non-namespace scope ‘class blink::MemberBase<T, tracenessConfiguration>’
  251 |   template <>
      |             ^
../../third_party/blink/renderer/platform/heap/member.h:252:76: error: template-id ‘SetRaw<blink::TracenessMemberConfiguration::kUntraced>’ in declaration of primary template
  252 |   ALWAYS_INLINE void SetRaw<TracenessMemberConfiguration::kUntraced>(T* raw) {

To avoid it we change SetRaw to not be a template method, and just check
the traceness configuration. The generated code should be the same.

Bug: 819294
Change-Id: Ia03d7842918bd091beaf966caa3af5e8c647cd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360020Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#800153}

This changes site metadata checks for subresource filter activation
to check for a site activation key in the metadata dictionary.
If the dictionary or key does not exist we default to existing
behavior: using the presence of metadata as a signal for subresource
filter activation. Otherwise we use the activation status stored in
the dict.

This enables using the ADS_DATA metadata to persist other ads
related information for a limited duration (currently 7 days).
As persisting metadata in website settings comes with a performance
cost, this should only be applied to a very small subset of sites.
The followup change which uses this API only applies it to sites
with ads violations.

BUG=1099741

Change-Id: I02dac29dd717afadec373114fcaab45bc3e678c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283662Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#800152}

Bug: 973801
Change-Id: I047c76f8fd782dc7dce5486597b73fa5941c4bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363400Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800151}

This adds new UKM metrics as described in the design doc for the launch
crbug.com/1110887.

This CL also adds a JNI bridge for FieldTrialList::CreateFieldTrial.

Bug: b/162224259
Change-Id: Ic432fbc4501dd7364c2eb35137d70b958c85ca66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356006Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#800150}

Its purpose is to avoid creating spurious history entries in the case
where we replace the initial empty document with a different
about:blank document (which the spec says not to do, but I think every
major browser does). Explicitly track this case with a bit on
FrameLoader for whether we've ever loaded a non-empty document.

Change-Id: I2bd6d759ccf6f43d14feddeac1f72d2f871a80cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354995Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800149}

Cue-related events (enter, exit, cuechange) are fired up to 250ms late,
and there is a similar latency in their display which is quite
noticeable.

The underlying problem is that we only update cues alongside the
`timeupdate` event, which is fixed at 4 Hz.

My solution is to add a separate timer to CueTimeline
(`CueTimeline::cue_event_timer_`) which is given a timeout for the
next cue event based on the current playback position and rate. This
allows for significantly more precise cue timing accuracy without a
significant performance penalty.

Additionally, several web tests were written with the expectation that
the 'time marches on' algorithm is run before video playback begins
(ie, upon loading text track cues). This behavior is not in accordance
with the spec (as outlined in crbug/1050767), so this CL fixes those
expectations and adds a new test to prevent regressing.

Bug: 576310, 1050767
Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008079
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#800148}

This change moves one method UpdateSurfaceAndScreenInfo into WidgetBase.
Some intermediate methods needed to be added since some of the code
path is still in RenderWidget.

The big part of this change is that ScreenInfo is now stored on the
WidgetBase.

BUG=1097816

Change-Id: Ie4f19f8bc80d800ee58378682fd059628f1c9fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354513
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800147}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: Id83ba088026d563ceaaf84329fad31ab6e98693d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366283Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800146}

Bug: 973801
Change-Id: I9f379f98df5e6d0ffc232b395a31758206c24901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365133Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800145}

AppService is used to load icons for windows. AppService uses async
mojom. So it might be not very appropriate to test with update number
when we have the custom icon, because if the icon is updated fast from
AppService, then it might be updated 4 times, however if slow, then
there are 3 updates only, becuase it has got the customer icon, and the
icon update from AppService could be skipped.

Modify the test case LauncherPlatformAppBrowserTest.SetIcon to check
the final image. If the custom icon is set, check the window's icon is
set as the custom icon.

BUG=1115533

Change-Id: Ief034842fef9360a49a504effb54cf51c8d4c51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364156Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800144}

Show managed UI when SafeBrowsingEnabled policy is set by enterprise.

Bug: 1119647
Change-Id: Ia6ccb0af0d61964867dec60be0f901040553af22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366002Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800143}

The test: conformance/glsl/bugs/bool-type-cast-bug-int-float.html
is passing now.

Bug: chromium:905007
Change-Id: I754cfd896da07d516cb6adeb0a2090f377ede470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364513Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#800142}

These two tests pass.

Bug: chromium:1099979
Change-Id: I76b553918990e3a4d768c93888a9990391237dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363808Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#800141}

Trust Tokens is a new Chrome feature that adds origin-scoped state and
operations, associated with outgoing resource requests, that can mutate
this state. In order to avoid certain denial-of-service attacks,
executing two of the three Trust Tokens operations requires the
trust-token-redemption Feature Policy feature in the executing context.
To verify that this holds for outgoing subresource requests, we bind to
each frame-level URLLoaderFactory an "upper bound" on whether the frame
has the Feature Policy feature present. This state has two values,
"forbid" and "potentially permit". In theory, if it is "forbid," we know
for sure that we should not see these restricted Trust Tokens operations
from the frame, and, if a renderer initiaties a restricted Trust Tokens
request from such a frame, we kill the renderer because we "know" that
it is misbehaving.

We recently encountered a synchronization issue (crbug.com/1111735)
where the browser process's view of a frame's Trust Tokens state became
inconsistent with well-behaved renderers' views, leading to erroneous
renderer kills. It seems like a similar issue might be occurring with
the CorsURLLoaderFactory Feature Policy check. This change disables the
renderer kill in question as a stopgap to halt the erroneous crashes (we
believe almost all such crashes are false positives) and instead logs a
histogram and records a DumpWithoutCrashing.

R=csharrison

Bug: 1117458
Change-Id: Icb1aac4e9d5812fe8d11467f4884c1d4218cb002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363851
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800140}