- 16 May, 2019 40 commits
-
-
Siye Liu authored
On Windows 7, there are many IMM32-based IMEs are relying on IMM32 support. We should continue supporting those legacy IMEs on Win7. We should disable TSF on Win7 and use IMM32. All other Windows platforms are not affected. Bug: 963558 Change-Id: I8f77afbdb734c355f4393880e80fafd98e25ae88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613974Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660261}
-
Shakti Sahu authored
As a part of effort to reduce the apk size, this CL removes the usage of AppBarLayout from download home and clear browsing history. Bug: 956332 Change-Id: Ia8e71fa8b703610836c975fc86f7a354981ebeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611218 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#660260}
-
Maggie Chen authored
There are two gpu processes on Windows - a sandboxed for the main gpu functions and another short-lived unsandboxed for gpu info collection. Currently, both gpu process pid boxes pop up for gpu-startup-dialog command flag. To avoid confusion, this CL allows the pop-up of the main sandboxed gpu process pid only. enum GpuProcessKind is moved from gpu_process_host.h to gpu_data_manager.h Bug:961662 Change-Id: Ic5c161013ad6bde60ceb06be7ac51270ca9254f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606771 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#660259}
-
Shakti Sahu authored
This CL contains: 1 - Added an icon for All chip 2 - Added check icon for all the selected chips 3 - Updated dark mode style to have dark background with white text 4 - Updated keyboard accessory view to use the same style Bug: 953891 Change-Id: Id1970b796c895c5eedeb40f728b1e64bc9a7210c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612329 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/666290a263b8..9a7970de2813 git log 666290a263b8..9a7970de2813 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ee800955..34a27578 (660080:660187) 2019-05-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7991984f..ee800955 (659976:660080) Created with: gclient setdep -r src/third_party/webrtc@9a7970de2813 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia97b1803f122879ea3e8193d6f3191dcb4a79b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660257}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/af6a51e0db02..38ff3c70d561 git log af6a51e0db02..38ff3c70d561 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 tobine@google.com Vulkan:Allow same-named var in nested scope 2019-05-15 timvp@google.com Android: Fix symbol compression logic Created with: gclient setdep -r src/third_party/angle@38ff3c70d561 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I6753902b9f93e71d1d8f0f1255871bfae51beb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614399Reviewed-by:
-
Chris Hall authored
Restricting one return type to be non-nullable. Removing spacing from a few places to keep consistency. R=katie Change-Id: I63c10429fb9cf33d85ae011f157277d8b8313a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611064 Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#660255}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7ca25624e6db146fa9da944f4a0d964c9309bec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614241Reviewed-by:
-
Fabrice de Gans-Riberi authored
Improve time resolution to nanosecond resolution on Fuchsia. Bug: 760687 Change-Id: I1450f10bb028ad31643bdd6d1cbb90e107cb53e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609892 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#660253}
-
Yuki Shiino authored
The return value of onbeforeunload event handler is processed in a special way at js_event_handler.cc, outside a generated callback function class such as V8EventHandlerNonNull. If JS return value is {toString: function() { return ...; }} then, the type conversion from v8::Value to WTF::String causes an invocation of author function, and the author function must run as part of the IDL callback function, i.e. with the correct current realm and correct incumbent realm. This patch adds a hack to run the string conversion with the correct current and incumbent realms. Change-Id: Ia56141aecb5b3b7912fdb72a8b4e5349ff0d4b4c Bug: 963375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611699Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#660252}
-
Emil A Eklund authored
Cached character position data is crucial for line breaking performance and is preserved to speed up subsequent layouts due to document reflow, page zoom, window resize, etc. On Android though, reflow is less common page zoom isn't used (instead uses pinch-zoom), and the window can't be resized in most cases (apart from rotation). Furthermore mobile devices tend to have less memory. This patch discards the cache on Android post layout, trading slightly slower relayout for a medium memory reduction. Bug: 962108 Change-Id: I1a60411b4e5ac601a3281f0ccbbd75371bca9af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614133 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#660251}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/740995c0b1ec..61c0db71de93 git log 740995c0b1ec..61c0db71de93 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 jiawei.shao@intel.com Refactor the emulation of store and MSAA resolve Created with: gclient setdep -r src/third_party/dawn@61c0db71de93 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I55f7cd38f0a70dc4de5989c402d6ff8c317ef211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614398Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3c68de6ecde..9d1e964aad84 Created with: gclient setdep -r src-internal@9d1e964aad84 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I1eee918ac7b121e8d9391df3fc391cc328407c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614239Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660249}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/abe8aefc62af..99fe071354e3 git log abe8aefc62af..99fe071354e3 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 ehmaldonado@chromium.org Reland "bot_update: Pass target-ref to gclient." Created with: gclient setdep -r src/third_party/depot_tools@99fe071354e3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: Id84d052940ff86e34b4722d464a6bd57931ac10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614240Reviewed-by:
-
Devlin Cronin authored
ExtensionStorageMonitor existed to do two things: 1) First and foremost, monitor the storage of ephemeral apps, and warn the user when they were taking up too much space. 2) Record (with UMA) the storage usage of hosted apps. Neither of these are necessary any more. Remove the class, factory, and tests. Mark histograms as obsolete, and remove the string resources. -- Details -- 1) (monitoring storage of ephemeral apps) accounted for most of the logic; however, ephemeral apps are now long dead. This meant that the `should_enforce` bits for ExtensionStorageMonitor were always false. We'd never show any UI to the user or disable any extensions. This wasn't immediately obvious, because the associated browser tests set the ExtensionStorageMonitor to *all* types of extensions and apps, rather than just ephemeral apps. 2) (monitoring hosted app storage usage) is no longer useful; the metrics are not currently being looked at and are expired. Bug: 878100 Change-Id: I9a4d5825b0bb48f12c571aa060fe319bdce5aba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611028Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660247}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b1b9d3ec2d63..c3df392d69c9 git log b1b9d3ec2d63..c3df392d69c9 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 dhanyaganesh@chromium.org buildbucket_v2: CIDB search dissonance Created with: gclient setdep -r src/third_party/chromite@c3df392d69c9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I8b348d9a0697bef2c93bf0bbcb2af9321d5de09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613567Reviewed-by:
-
François Degros authored
Moved definition of interface ActionModelUI to its own file. FileManagerUI now explicitly implements ActionModelUI. Bug: 778674 Change-Id: Ibcda7b879cd06cedcb38e85ffd405a7f02b197fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611432 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#660245}
-
Brandon Tolsch authored
This reverts commit 9dc2f05b. Reason for revert: Causing linux 32-bit debug to fail all cc_unittests and viz_unittests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/58651 Original change's description: > gpu: Avoid texture uploads for hardware-accelerated image decodes. > > This CL adds support for avoiding texture uploads for hardware > accelerated image decodes. Specifically: > > - The gpu::ImageDecodeAcceleratorWorker interface is modified so that > implementations can return the decoded image in the form of a > GpuMemoryBufferHandle. In Chrome OS, this would refer to a dmabuf. For > now, we only support YUV 4:2:0 results. > > - The gpu::ImageDecodeAcceleratorStub is modified so that it decomposes > the GpuMemoryBufferHandle coming from the hardware decoder into separate > gl::GLImages (one per plane). Each image is attached to a texture and a > SkImage is created out of each texture. These 3 SkImages are used to > create the service-side transfer cache entry which builds a single YUV > SkImage. This allows us to specify the matrix used for converting from > YUV to RGB (assumed to be the JPEG conversion matrix for now). In an > earlier prototype, I had tried to create a single GLImage and attach it > to a single texture, but the YUV-to-RGB conversion was giving wrong > results, so I decided to go the Skia route. > > - The cc::ServiceImageTransferCacheEntry is modified so that it doesn't > do texture uploads for hardware decodes. Instead, it just takes the > 3 SkImages built in the previous step plus enough data to build the > final YUV SkImage. > > Bug: 868400 > Test: the ImageDecodeAcceleratorStub unittests pass. > Change-Id: I6f435707c6b2d4368613b55399b4d6d185a84c70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590530 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660130} TBR=sunnyps@chromium.org,khushalsagar@chromium.org,piman@chromium.org,andrescj@chromium.org Change-Id: I60b7a80d6f0ba462afd3771f9b6d6abcd686edb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614777Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#660244}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/84503583c6f0..9dfd4b835807 git log 84503583c6f0..9dfd4b835807 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 greg@lunarg.com Bindless Validation: Instrument descriptor-based loads and stores (#2583) 2019-05-15 33432579+alan-baker@users.noreply.github.com Validate loop merge (#2579) 2019-05-15 33432579+alan-baker@users.noreply.github.com Mem model spv 1.4 (#2565) 2019-05-15 stevenperron@google.com Start SPIRV-Tools v2019.4 2019-05-15 stevenperron@google.com Finalize SPIRV-Tools v2019.3 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9dfd4b835807 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I2e4a5beef81211d419adb2d120d8e5dde1a8feb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613570Reviewed-by:
-
Caleb Rouleau authored
Based on Dirk's comment on https://chromium-review.googlesource.com/c/chromium/src/+/1611503 . Change-Id: I9caa7421292dde93fce943eff6d8cd8a18b2dc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613563 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660242}
-
François Degros authored
Bug: 778674 Change-Id: I01505e865b99b0f589e6b1568ab0747faf7144c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612797Reviewed-by:
-
Devlin Cronin authored
Add coverage for the "action" manifest key in ExtensionActionManager unit tests. Bug: 893373 Change-Id: Ifa2cabc26fc53088b45aca44133fceef2252e9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614438Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94d8250f8929..0a79453af68f git log 94d8250f8929..0a79453af68f --date=short --no-merges --format='%ad %ae %s' 2019-05-15 nigi@chromium.org Modified embeddertests for FPDF_StructElement. 2019-05-15 thestig@chromium.org Remove testing/fuzzers/unittest_main.cc. 2019-05-15 thestig@chromium.org Do IWYU for core/fxcrt/fx_safe_types.h. 2019-05-15 thestig@chromium.org Update Git EOL policies for source files 2019-05-15 thestig@chromium.org Give buffers in experimental fpdf_attachment.h APIs clearer types. 2019-05-15 thestig@chromium.org Fix nits involving 'constexpr const' code. 2019-05-15 thestig@chromium.org Remove XFA_ReleaseLayoutItem_NoPageArea(). 2019-05-15 thestig@chromium.org Make CXFA_LayoutItem::GetPage() return a const pointer. Created with: gclient setdep -r src/third_party/pdfium@0a79453af68f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832129 TBR=pdfium-deps-rolls@chromium.org Change-Id: I038cdc65b4fdb3b3b33c6395c8b64d8a8bf961d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613569Reviewed-by:
-
Martin Kreichgauer authored
This changes MakeCredentialRequestHandler to reject requests with rk=true to the Touch ID authenticator, without dispatching them. The authenticator itself is also changed to reject such requests should it receive them, and to not return an arbitrary credential when receiving a GetAssertion request with an empty allow list. Bug: 941120 Change-Id: I7d70b2baaca66611ee8957445e54b17b91b6cc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600735 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#660238}
-
Vlad Tsyrklevich authored
Refactor common code into a test fixture. Change-Id: I91d31378ba62f3754c2324d1fcbce87342c883a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611222 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#660237}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c58f9baef52..d208655f57ca git log 8c58f9baef52..d208655f57ca --date=short --no-merges --format='%ad %ae %s' 2019-05-15 fmayer@google.com Merge "Improve comments in ProfilePacket." Created with: gclient setdep -r src/third_party/perfetto@d208655f57ca The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I66dc1a3bb52d010a4ac692d71ec7fd55c4f961d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613566Reviewed-by:
-
Austin Tankiang authored
GetDeviceProperties() in cros-disks returns information about a device. One of the fields, called |NativePath| in the D-Bus API, and |system_drive| in chromeos::disks, is not used. Considering the value is used as the parameter to lookup a drive in GetDeviceProperties(), ignore the field in the client as the client already knows the value. Bug: 961181 Change-Id: If667c35e806689badcc66bacf450b6f92c7cda52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602238Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#660235}
-
Steve Kobes authored
Bug: 963474 Change-Id: I29cdf63d82105644ba9f4fddbf38c17ae81aabdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613887 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#660234}
-
ssid authored
The counts in the memory dump cannot be easily correlated to trace events. So just add the info to the event too. Change-Id: I2a9a94aa8ce63320fd1b088c975bd255c9c0c7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566215Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#660233}
-
Brandon Tolsch authored
This reverts commit 6ec894bb. Reason for revert: Causing msan test failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12942 Original change's description: > Hide App Icons in KioskNextShell. > > Bug: 951212 > Change-Id: Ie69a2cd77aaa9d169d102cd3582a6d1902306001 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610501 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660091} TBR=xiyuan@chromium.org,msw@chromium.org,michaelpg@chromium.org,agawronska@chromium.org,yilkal@chromium.org Change-Id: I2c80824592e64f7f661cf8b9610ba6400c10a365 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614690Reviewed-by:
-
Nigel Tao authored
This fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="AppSearchProviderWithExtensionInstallType.*"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="AppSearchProviderWithExtensionInstallType.*"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: I48d68d6b2322780f22e46fab445fe58404dbb3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612858 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660231}
-
Clifford Cheng authored
Fix the media router e2e tests flakiness issue. The problem comes from reopening the dialog. Sometimes, it takes longer than expected to (finish) load. This causes Chrome to crash. Adding the wait time solves all issues. Change-Id: Ie8f49be079b0ed92ef269bbc03ce249a29fc3eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613794 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#660230}
-
Matt Menke authored
It's not being used anywhere, since consumers are now using network service APIs. This CL is needed to remove the legacy NetLog in the browser process, which doesn't actually do anything when the network service is enabled. TBR=seantopping@chromium.org Bug: 767450 Change-Id: I4121aee8b36597c1d781552284e2bf9514f4bdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612093 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#660229}
-
Joel Hockey authored
Caller specifies settings subpage which is validated against whitelist. Bug: b:131589705 Change-Id: I16fc5ae721eebf4c41c2470324a413865e8f91b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605440 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
-
Cathy Li authored
Bug: 961016 Change-Id: I62439347d68b73f7c7411eae83c1d81673988ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600779 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#660227}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9ef1b893d45..b3c0bf642613 git log f9ef1b893d45..b3c0bf642613 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 mtklein@google.com Revert "manually register codecs in DM" 2019-05-15 mtklein@google.com Revert "add runtime registration for encoders" 2019-05-15 mtklein@google.com Revert "remove #if guards in SkAndroidCodec.cpp" 2019-05-15 mtklein@google.com Revert "skip runtime registration on iOS" 2019-05-15 mtklein@google.com Revert "unguard SkFooEncoder.cpp" 2019-05-15 mtklein@google.com Revert "move encoders into codec_srcs" 2019-05-15 mtklein@google.com Revert "format public.bzl" Created with: gclient setdep -r src/third_party/skia@b3c0bf642613 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ib2d15b981b2bf78229d0a2df9edae19a02ef6c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614085Reviewed-by:
-
Yuly Novikov authored
For consistent naming. Adding gpu-try-linux-nvidia-dbg gpu-try-win10-nvidia-dbg Also update docs example TBR=kbr Bug: 908949 Change-Id: I66111fead635b4a58b7d5b402af776b27019c3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613674Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660225}
-
David Black authored
TrayBubbleView was recently set to a dark theme in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1597114 PaletteTray does not currently play nice with theming (see bug). If desired UI is that PaletteTray also respects theme we should make sure it is fully supported before enabling theming for PaletteTray. Bug: b:132702933 Change-Id: Icd085cf8c87710e9ac5544053fd84dcb33ea7289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614463Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#660224}
-
Matt Menke authored
Entering suspend mode causes live sockets to hang on OSX and Windows (Unclear what happens on other platforms). For brief suspends, it may also be possible to get an ERR_CONNECTION_CLOSE, which is also a problem, as it has semantic meaning for HTTP connections. Previously, URLRequestJob watched for entering suspend mode, and canceled the request when it happened. There are three problems with this: * Not all requests use the network. * Other types of TCP sockets didn't get to take advantage of this logic. * It cancels requests no matter where they are, and informs the caller of this. This has caused at least 4 or 5 crashers in the past, since it even informed callers when they weren't currently waiting on a notification from the URLRequest. This CL moves the logic down to TCPClientSocket, and only calls back into the caller with an error when the caller is expecting it. One potential downside of this approach is that this doesn't catch DNS lookups (At least when using UDP sockets, or GetAddrInfo), which may hang when changing networks, too, though there are already timeouts and retries at that layer, so there shouldn't be too big a regression there (hopefully...). Another change is that will mean the suspend logic no longer affects live QUIC requests. Since HttpNetworkSession::CloseIdleConnections() already doesn't close idle QUIC sessions on suspend, I assume we're fine there, though it's possible live QUIC sessions have issues related to suspend mode that idle ones did not have. Bug: 651120 Change-Id: I7ce56ea520b7f3672c4a9593ded3cf1e44d09abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610496Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#660223}
-
Sean Topping authored
These tests shouldn't be run on devices for a few reasons: 1. The test relies on source-hosted data files, and will fail without pushing the test data to the device. 2. Device builds create unusual interactions for internal browser tests, which trigger unusual crashes and failure conditions. Bug: internal b/131226913 Test: CQ Change-Id: I6c86a2fa2c25ff253da8a3b390d151f9a27e547e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612319Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#660222}
-
