- 30 Aug, 2019 40 commits
-
-
Lei Zhang authored
Delete or replace with the appropriate base/ headers. Fix a few lint errors and do IWYU along the way. Change-Id: If2066861079a6b7c82d5431b03f2da1db0b7159b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775447Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691961}
-
Luciano Pacheco authored
chrome://file_manager_test/ Add js_test_gen_html build template and script that works similarly to js_unit_tests, which generates a HTML file with all JS dependencies to be able to run the JS unit tests. The new js_test_gen_html has 3 different behaviours from js_unit_tests: 1. Point scripts to chrome:// URLs instead of using file system files and directories. The files are served from either regular chrome://resources or from the test-only chrome://file_manager_test/. This allows to run tests for Polymer elements that load JS/HTML from chrome:// URLs. 2. Takes care of special cases where file paths aren't directly served from chrome://resources e.g.: jstemplate and some Polymer pahts. 3. Add the "html_import" boolean config to allow to use HTML Imports instead of <script> for unittesting Polymer elements. Change TestFilesDataSource (which backs chrome://file_manager_test/) to serve: 1. From //src/ and from //$OUT/gen/. From //$OUT/gen is to be able to serve the generated HTML file, all other files are served from //src/. 2. Serve both roots //src/ and //$OUT/gen/ instead of narrowing down only to ./ui/file_manager/, this makes simpler to keep the difference from previous path style for all apps (Files, Gallery, etc). Convert all unittests from //ui/file_manager/file_manager/ to use js_test_gen_html instead of js_unit_tests. Test: browser_tests --gtest_filter="FileManagerJsTest.*" Bug: 991105 Change-Id: I61c17edd4af10ac5ba739725585c23472b27b49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767297 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#691960}
-
Michael Lippautz authored
Ownership has been refactored in https://crrev.com/c/1477233 some time ago. Since we are not accessing the shared data through weak cross-thread references there is no reason to try to get the lock. Bug: 992395 Change-Id: I344c4fb84353bb580f1eba46b8856903df4c56ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776038Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba0a2c7ad992..7409b73fa546 git log ba0a2c7ad992..7409b73fa546 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5d27a6961601..120b61d34ba8 (9 commits) 2019-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2dd36fa7..a461132e (466 commits) Created with: gclient setdep -r src/third_party/skia@7409b73fa546 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None,chromium:None Change-Id: I464c1922bd9cec3899f5b4d924fa154a4294c689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691958}
-
Kent Tamura authored
PointerID was defined indirectly through scroll_types.h. This CL splits out the PointerID definition from web_pointer_properties.h, and element.h includes the new header. This CL reduces estimated pre-processed size of element.h from 3.11MB to 2.37MB. Bug: 242216 Change-Id: Idfd35d73d315a9bdcc89938fb42915a41832877c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775885 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691957}
-
Tao Bai authored
This patch moves chrome/renderer/page_load_metrics to components/page_load_metrics/renderer, and is mostly moving the file, no feature change. OWNER file has been move to components/page_load_metrics, is changed to same as chrome/browser/page_load_metrics/OWNERS components/page_load_metrics/common/OWNERS is deleted. Bug: 995880 Change-Id: Idbd70e7dda295db2cacb0bdcad1c5ba13fb48fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773919 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#691956}
-
Julie Jeongeun Kim authored
This CL converts BlobURLTokenPtr and BlobURLTokenPtrInfo to new Mojo types. It updates BeginNavigation from frame.mojom, CreateWorkerHostAndStartScriptLoad from dedicated_worker_host_factory.mojom, and Connect from shared_worker_connector.mojom Bug: 955171, 978694 Change-Id: If9cbac3e3500803e9f9bb8914c59c8ba14ea2149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774422 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691955}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I996d2415fff94a084f1a48a7ec92b8d741fde42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777344Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#691954}
-
Alexandre Courbot authored
When checking for a V4L2 workaround, we first open the decoder device in order to check its name, before querying its supported profiles using GetSupportedDecodeProfiles(). However GetSupportedDecodeProfiles() DCHECKs that no device is currently opened, since it needs to open one itself - and the device is still opened at this time. Fix this by reinitializing the device before calling GetSupportedDecodeProfiles(). Bug: b:140222972 Test: assert of b:140222972 not triggered. Change-Id: I6ec44f6f6113c4fc69965d6012128b61a27cb473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775887 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691953}
-
Rika Fujimaki authored
Change-Id: I7e0eab7e405074df9c9de4922123938442dae5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772900Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#691952}
-
Miyoung Shin authored
This CL converts UsbDeviceManagerClient{AssociatedPtr, AssociatedPtrInfo} in chrome, components, extensions and services to the new Mojo types, and uses pending_associated_remote<device.mojom.UsbDeviceManagerClient> in usb_manager.mojom and web_usb_service.mojom.mojom. Bug: 955171, 978694 Change-Id: Ic64f0e43ef60cb184a35b5bf6391a7fb3bc38dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772837 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691951}
-
Yoshifumi Inoue authored
This patch makes |DirectionGranularityStrategy::UpdateExtent()| to check null position fo vertical movement to prevent constructing invalid selection for avoiding crash. This patch is similar to the CL[1], but we are not sure actual HTML causes this crash. This CL is an experimental to reduce candidates of crash. [1] http://crrev.com/c/1669133 Make DirectionGranularityStrategy::UpdateExtent() to check null position for word bounds Bug: 978784 Change-Id: Ica41e0dd75c0ded2beafa171f1d027bf5de9cae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775956 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691950}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/165ca3f85b7a..ba0a2c7ad992 git log 165ca3f85b7a..ba0a2c7ad992 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader eea9d35b8757..680d37610656 (7 commits) Created with: gclient setdep -r src/third_party/skia@ba0a2c7ad992 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None Change-Id: I1bb076f24afccfd921234468f874306ddf81805f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777125Reviewed-by:
-
Andrew Luo authored
Bug: 997759 Change-Id: I0d74d90617a0d3a72d22d34de4f830dcc6f3c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777065 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#691948}
-
Francois Buergisser authored
If a driver doesn't support the drain operation, the drain is simulated but the buffer ready timer is not cancelled. If the buffer ready timer is not cancelled, the unittest will return an error if the unittest doesn't end before 3s since processing the last frame. This patch simulate the drain operation by calling FlushEncoderDone function and cancelling the buffer ready timer in the same time. BUG=999013 TEST=tast with tast video.EncodeAccel* on veyron_minnie-kernelnext Signed-off-by:
Francois Buergisser <fbuergisser@chromium.org> Change-Id: Id2a8bcd71a8bf82e84970bebf6eb18f3b68ee636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772853Reviewed-by:
-
Chih-Yu Huang authored
Some devices select the video decoder implementation by the video configuration (e.g. codec). VideoDecoderPipeline needs to select a proper video decoder in Initialize() when a video configuration is specified. This CL implements the mechanism of selecting VD at Initialize() instead of Create() method. BUG=chromium:952730 TEST=Run video_decode_accelerator_tests on Kevin and Eve Change-Id: I76077df0bc1e1eeae730e618a62c6e1049e02500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708693Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Maggie Chen authored
The GPU process is now armed to detect hangs during shutdown. This also fixes a problem that ReportProgress() is called without Arm() first and a DCHECK is triggered due to the wrong Arm/InProgress/Disarm order. Calling Arm() when the GPU starts to shut down fix this order issue. Bug:949839, 674475 Change-Id: I5f8ec78787945a09ad6cf519506175386e24a646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775214 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691945}
-
Maksim Sisov authored
This CL makes the DWTHX11 subclass the DWTHPlatform and use the X11Window, which subclasses the XWindow. Also, DWTHX11 uses PlatformWindowDelegate instead of ui::XWindow::Delegate now. That is, to migrate X11 to Ozone, we need to make sure DWTHPlatform is mature enough. To avoid code duplicate, it was decided to make DWTHX11 subclass DWTHPlatform and move its code to DWTHPlatform step by step ensuring nothing is broken. However, it was not enough to just make DWTHX11 a subclass of DWTHPlatform. The way how we communicate with XWindow has had to be changed as well. The plan is to move all the code to DWTHPlatform and make the WTHPlatform create the X11Window. However, there are many intermediate steps to be done before doing it. As described before, first, DWTHX11 subclasses the DWTHPlatform and starts to receive messages and events from the XWindow through the PlatformWindowDelegate. It was ensured that the DWTHX11 intercepts all the calls to DWTH, WTH and PWD and does everything as it was doing previously. In the follow up CLs, I will start to move the code slowly to DWTHPlatform and WTHPlatform so that DWTHX11 no longer implements PDW and DWTH methods and the DWTHPlatform manages everything on its own for both Ozone and non-Ozone builds. Bug: 990756 Change-Id: If45b05d09609cf8aa826cc4894ec559f210dc0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771397Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#691944}
-
Eric Willigers authored
We now return rgb() values instead of color keywords in getComputedStyle() results for gradient images. Not yet addressed: lengths should also be made absolute, e.g. we should never have 'ex' units in getComputedStyle() results. Bug: 977042 Change-Id: If20dc6b773f8948370fbda63397e06c784e3d55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765133 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#691943}
-
Alexandre Courbot authored
Add image processor to the V4L2SVDA, which is required in order to decode on Kukui. Bug: b:132589320 Test: VDA unittest passing on Minnie, Kevin and Kukui. Test: VD tests passing on Minnie, Kevin and Kukui. Change-Id: Ia5d4af8b35e71a81e5b56759d0f35d7d39689931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743437 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 74c69a75. Reason for revert: causing first build failure on Deterministic Fuchsia (dbg). Sample build: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Fuchsia%20%28dbg%29/561 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903731569632286240/+/steps/First_build/0/stdout?format=raw [47036/47333] SOLINK ./lib/libweb_engine_core.so ... ld.lld: error: undefined symbol: switches::kEnableFeatures >>> referenced by context_provider_impl.cc:208 (../../fuchsia/engine/context_provider_impl.cc:208) >>> obj/fuchsia/engine/web_engine_core/context_provider_impl.o:(ContextProviderImpl::Create(fuchsia::web::CreateContextParams, fidl::InterfaceRequest<fuchsia::web::Context>)) ld.lld: error: undefined symbol: gl::kGLImplementationStubName >>> referenced by context_provider_impl.cc:212 (../../fuchsia/engine/context_provider_impl.cc:212) >>> obj/fuchsia/engine/web_engine_core/context_provider_impl.o:(ContextProviderImpl::Create(fuchsia::web::CreateContextParams, fidl::InterfaceRequest<fuchsia::web::Context>)) clang: error: ld.lld command failed with exit code 1 (use -v to see invocation) [47037/47333] AR obj/components/password_manager/core/browser/libbrowser.a [47038/47333] AR obj/components/sync_sessions/libsync_sessions.a Original change's description: > [Fuchsia] Handle VULKAN feature flag in WebEngine > > Now WebEngine will enable Vulkan only when ContextFeatureFlags::VULKAN > is specified for web::Context. Also Context process now explicitly > disables hardware-accelerated compositing when VULKAN is not enabled > (otherwise it restarts the GPU process several times before it falls > back to software compositing). > > Bug: 962617, fuchsia:35009 > Change-Id: I74a463a1514df99134d929981fe44151c1d9dd17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774967 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691856} TBR=backer@chromium.org,wez@chromium.org,sergeyu@chromium.org Change-Id: I71d9bb87b79928bbffa9f123408b4e4bafad31bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 962617, fuchsia:35009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775955Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#691941}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic4884c62af5e296e77d67c1fd28f1475f3bebf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777314Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of 06a7200b It updates WebSocketChannelImplTest::EstablishConnection with new Mojo types without InterfacePtr and MakeRequest. TBR=jam@chromium.org Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Bug: 955171, 978694 Change-Id: Iac237a20fb2ce98acfb473ef0ae08aa398ab7ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775947 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#691939}
-
Julie Jeongeun Kim authored
This CL cleans up binding.h from from locks/DEPS since it's completely removed from locks module and replaced with new Mojo types. Bug: 955171, 978694 Change-Id: I34a9f64bd87561bab31e158b66b77da76492999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777342Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691938}
-
Alison Maher authored
This change adds logic for painting a readability backplate behind text in forced colors mode for non-LayoutNG. Backplates are split by paragraph, as defined by two consecutive line breaks. A backplate is not drawn if forced-color-adjust is none. Tests are added for this in the LayoutNG change: https://chromium-review.googlesource.com/c/chromium/src/+/1749299 Bug: 970285 Change-Id: I51aec229d905de5fe7b233792c41555037c5b172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713333 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691937}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7919e0eeb73..e12f9bdfbf6a Created with: gclient setdep -r src-internal@e12f9bdfbf6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4de4442e42d7bb5df38a5e7409236c235adac617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777306Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691936}
-
Emil A Eklund authored
Bug: 999075 Test: fast/text/nowrap-with-saturated-padding.html Change-Id: Ie8aa9c98ab9cf2f868d24472a2362f54cad19273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775217 Auto-Submit: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Previously we included the total line-box size in the layout overflow calculation. With this patch we only consider the children, and the inline-size of the line-box. This has the effect of ignoring the bottom half-leading of the linebox. Bug: 996847 Change-Id: I65386ad564a4472a67606cd3410af558d5d01328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774314 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I89c1641c82681076623fbe95831ba4521d95fb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772898Reviewed-by:
-
Peter Kotwicz authored
This CL adds the WebappRegistry#webApkIdForPackage() convenience method for getting the WebappDataStorage ID from a WebAPK package name. BUG=None Change-Id: Ib8fd2dfead2e0cf77c06a72aff56a7db5a687081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776485Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691932}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d96f3e7d..be613476 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I790b0bdaa949a72533a2170cfe92eff6156a990d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774800Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691931}
-
Gyuyoung Kim authored
This CL converts below 3 mojo files to the new Mojo types. - geolocation_service.mojom. - public_ip_address_geolocation_provider.mojom. - geolocation_context.mojom. Major changes are as below, - Replace mojo::Binding with mojo::Receiver. - Replace GeolocationRequest with mojo::PendingReceiver<Geolocation>. - Apply pending_receiver into the request arguments in .mojom files. - Replace StrongBindingSet with UniqueReceiverSet - Replace BindingSet with ReceiverSet Bug: 955171 Change-Id: Idee7dfc51dd80bb0d536713155fe7bfc8e4018ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774419 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#691930}
-
chrome://flags/#omnibox-zero-suggestions-on-ntpMoe Ahmadi authored
- The new flag allows force enabling the NTP realbox zero suggest. - Removes the existing and unused chrome:/#ntp-zero-suggest. - Removes IsNtpRealboxEnabled() since chrome://flags/#ntp-realbox can be separately enabled in testing as well as its corresponding feature set in the same study group along with OmniboxZeroSuggestionsOnNTP. Bug: 996516 Change-Id: Iae611216b53d553cf916a974adb54283712a683a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775202 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#691929}
-
Kunihiko Sakamoto authored
TBR=horo@chromium.org,kinuko@chromium.org Bug: 999419 No-Try: true Change-Id: I6e297e706ccd6a27102d51d12f989fd682b52a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775657Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691928}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ibac8768f6b7d7e66bdbabc6fc4d0adeb313c515d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776641Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691927}
-
Yue Zhang authored
* Add more UMAs for tab grid dialog and drag-and-drop related actions. * Fix the problem that MobileTabSwitcher.GridTabSwitcher is not correctly logged. Bug: 996514, 996527, 996510, 996524 Change-Id: Ib54f558783ec7e8ef18dceef4f38000fb40fb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764934Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#691926}
-
kylechar authored
Finish removing an unused parameter and the function to check if the surface sync was enabled. Only cleanup in cc/* remains at this point. Bug: 985009 Change-Id: Iea8755eb15c1521d1e9fea282cc7718cab5ea325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776783 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#691925}
-
Ionel Popescu authored
This is a reland of 5cb1eeb5 Original change's description: > Updated the in-page UI for date related types. > > This CL contains the following changes: > - removed the clear button and spinner buttons from the in-page UI for > date, datetime-local, month, week and time types > - updated the calendar-picker-indicator to use a calendar icon for > date related types > > For time the calendar-picker-indicator will be updated when popup > support will be introduced for this type. > > Bug: 987050 > Change-Id: Ic7849a323ebb3723c5b6a467463a8604058f72ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716161 > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681392} Bug: 987050 Change-Id: Id5fecab7bc93c7cc0e6518de439d5558294aea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722970Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691924}
-
Miyoung Shin authored
This CL converts SpeechRecognizerPtr in blink and SpeechRecognizerRequest in content to the new Mojo types. Bug: 955171, 978694 Change-Id: I651a16c2d5982eb5a9f4004fa5b09d8be829ddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775683Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#691923}
-
Miyoung Shin authored
This CL converts UnhandledTapNotifier{Ptr, Request} in blink and chrome to the new Mojo types. Bug: 955171, 978694 Change-Id: Iaa143579ff70902998ee1586744f82dc893f8808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775943Reviewed-by:
-
