- 08 Nov, 2019 40 commits
-
-
Yi Gu authored
Tested locally and didn't see the crash mentioned in crbug.com/545547. Bug: 545547 Change-Id: I597c4ae170b3d5297a18472d3e4f1b7923856057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897244Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713860}
-
Chris Hamilton authored
This creates a policy engine that forwards calculated priority values out of the graph, applying the priorities to RenderProcessHosts (and subsequently to the process itself). BUG=971272 Change-Id: I11c8c040e5382a8fa6881c40f80f6885f26e88df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904367 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713859}
-
Greg Thompson authored
This function has historically been opening a file for exclusive r/w/d with FILE_ALL_ACCESS. FILE_ALL_ACCESS is nearly almost never, ever the right choice when opening a file. This is especially true when opening a file from an ordinary non-elevated user session, since it attempts to gain things like WRITE_DAC and WRITE_OWNER and will fail if it's not possible to gain those access rights. A better way to determine if a file is "in use" (and what we really mean is "is an executable that is running") is simply to try to write to it. This is because CreateProcess opens its target with only exclusive write mode (read and execute are shared for obvious reasons). This change also eliminates the exact copy of this function, which included the incorrect formatting from the original, that was used in the unittest. R=gab@chromium.org BUG: 474401 Change-Id: I0488e2a5333f74353f46ae6c87795e2833a30b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905948 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713858}
-
Friedrich Horschig authored
This cl removes an unnecessary break condition that prevented collection for CreditCards. The metrics recorder already supports recording non-password tabs (like addresses) but this artifact prevented recording sheet triggering. Bug: 926372 Change-Id: Ia4a92e06b2c21000ee61aa14a060bb4a521fc360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905687Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713857}
-
Mihai Sardarescu authored
This CL converts all ChromeOS code to use CoreAccountId instead of std::string for the account id. Bug: 959157 Change-Id: Ia27b9e566100ecd7c1ead3a5ca8e46da39e569ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906149Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713856}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c6f1f9af3f4..fc61fb037d2c git log 8c6f1f9af3f4..fc61fb037d2c --date=short --no-merges --format='%ad %ae %s' 2019-11-08 dburger@chromium.org config: mark grunt-unittest-only not important. Created with: gclient setdep -r src/third_party/chromite@fc61fb037d2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic9762f94cdd7cbbe558456837496a25508e5b30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713855}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b14632a5ba8..7eee1a626bd1 git log 3b14632a5ba8..7eee1a626bd1 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 almuthanna@google.com Cover Geometry.js with Karma tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@7eee1a626bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I93fc261f075067df575f9d6b92bada76bb3ed966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906288Reviewed-by:
-
Antonio Gomes authored
This CL fixes the clusterfuzz issues reported (see "Fixed" below) by using WTF::Bind and WrapPersistent in RTCRtpSenderImpl::ReplaceTrack. This is a regression from crrev.com/c/1899786, where code used to have a WebRTCVoidRequest wrapping RTCVoidRequest instances (garbage collected). Now that RTCVoidRequest is used directly, we need to properly wrap-persist its instances with WTF::WrapPersistent when passing it to callbacks. Reason: With Oilpan and WTF::Bind, raw pointers of garbage collected objects are not allowed. Fixed:1022558 R=hbos@chormium.org, jbroman@chromium.org Change-Id: I8f0fcf7275c9e07240e3b2e20f89c4cf96c72439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906506 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713853}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2bc811ea07b7..d6b9b0a1f413 git log 2bc811ea07b7..d6b9b0a1f413 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 danilchap@webrtc.org Cleanup MultiStreamTester Created with: gclient setdep -r src/third_party/webrtc@d6b9b0a1f413 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9b6e4aa2c4f191db79df4e7512a6fe1e6b6874c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906289Reviewed-by:
-
Sean Gilhuly authored
Create a Dawn device using D3D12 on Windows and Vulkan on Linux, and use it to create a Skia Dawn GrContext. On Windows, create a SkiaOutputDeviceDawn, which uses a native D3D12 swapchain for presentation. On Linux, use a SkiaOutputDeviceX11 for now, until the Vulkan swapchain is ready. Bug: 1021566 Change-Id: If3e1f435fe87132c9294f5613c85d675a7282b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899200 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#713851}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e6e728c..814c68a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0fcb4a1600db047f1944680dad357056a00928bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906066Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713850}
-
Robert Ma authored
Manual import because of https://crbug.com/1022519 (with https://crrev.com/c/1904340 applied locally to fix rebaseline-cl) Using wpt-import in Chromium a53cf24b. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 40c01af7 "[Chromedriver] Fix PerformAction to support multi touch points cases" 85c1bdf8 "Improve scroll to text WPT coverage." a42521dd "Roll WebGPU CTS" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/css-text/overflow-wrap meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=smcgruer No-Export: true Bug: 1022519 Change-Id: Idb9348b86ecf24b64fa94c79b92565671031a079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904343Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#713849}
-
Mikhail Khokhlov authored
This CL adds some basic support for traces in perfetto protobuf format. The traces are concatenated, converted to json and then processed as usual. For that to work, one needs to build trace processor shell with sqlite and json support, and supply it to results_processor via the --trace-processor-path command line argument. Bug: 990304 Change-Id: If6d7c903813fd1f860e4f11ea98bf22e4b70e057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903144Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#713848}
-
Ian Clelland authored
This adds support for the generalized 'List' syntax in https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-13. Since some types have changed slightly between revisions, the parser now takes a version parameter on construction, which can be used to switch between draft 9 (for compatibility with existing Web Packaging deployments) and draft 13 (for new headers). Bug: 1011101 Change-Id: Ie8a76384430f5319e1d564e51f4f62af7c0ada7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872764 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713847}
-
jonross authored
A recent change to support mixed Vulkan implementation and GrContext led to requiring an additional flag to enable Vulkan as the GrContext. It looks like one test suite was missed in that update. TEST=vulkan_content_browsertest Change-Id: I6474e113d45d3854edd67ec704a6704161585a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901800 Auto-Submit: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#713846}
-
Mohamed Abdelhalim authored
This uses only NavigationThrottleRunner::Delegate to construct NavigationThrottleRunner. Note: RegisterNavigationThrottles should only be called from NavigationRequest, where the Delegate is a NavigationRequest. Change-Id: Ifa6abf81799c5e3e8dda55781bcab9e8f98cc67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906346 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#713845}
-
Josh Nohle authored
During the first phase of the CryptAuth v2 DeviceSync rollout, v2 DeviceSync is enabled behind the flag kCryptAuthV2DeviceSync, and v1 and v2 DeviceSync run in parallel, with their results consolidated into a single set of device data. The second phase of the v2 DeviceSync rollout deprecates v1 DeviceSync behind the flag kCryptAuthV1DeviceSyncDeprecate that we add here. Bug: 951969, 1019206 Change-Id: Ic13a709649e3d3d8dd855563b1a57abed8c599db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899415 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#713844}
-
Jasmine Chen authored
This CL enables ZSL for one shot requests. It sets ANDROID_CONTROL_ENABLE_ZSL to true for still capture requests and a private usage flag to still capture streams so that adapter recognizes still capture output streams. BUG=b:130851309 TEST=Enabled ZSL and verified still capture works with ZSL CLs. Change-Id: Idb0741f56b55b93a157e7ee11aff4beff2024451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896480Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#713843}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: Ica2e5a7a9222d80a81bd70299219f82798c19855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901427 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713842}
-
Antonio Gomes authored
The replacement is now possible that all users are in Blink. Essentially, the former is a pure interface for the later. As a follow up step the use of WebString will be replace by WTF::String. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I921d2351533f54f00c3dd1b19d20a1b6f7a2a3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902445 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#713841}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0868b8947615..d9164777415c git log 0868b8947615..d9164777415c --date=short --no-merges --format='%ad %ae %s' 2019-11-08 perezju@chromium.org [Telemetry] Trim down story_run.Artifact object 2019-11-08 a-v-y@yandex-team.ru Fix breakpad symbolization of heap profiles when so is mapped from apk. 2019-11-08 perezju@chromium.org [Telemetry] Replace Will-/DidRunPage methods with results.CreateStoryRun Created with: gclient setdep -r src/third_party/catapult@d9164777415c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:973837,chromium:734705,chromium:973837 Change-Id: I84f582b5ef961c1bdd611535aff2222bd0976c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905906Reviewed-by:
-
Alexander Timin authored
We want to remove kInternalIPC task type as it's confusing and use kInternalNavigationAssociated instead as a more descriptive one. - Add kInternalNavigationAssociatedUnfreezable task type. - Make kInternalNavigationAssociated to be freezable to reflect the comment. - Use kInternalNavigationAssociatedUnfreezable in the places which expect to be unfreezable. - Convert kInternalFreezableIPC usage to kInternalNavigationAssociated. - Remove kInternalFreezableIPC task type. R=haraken@chromium.org,yuzus@chromium.org,hajimehoshi@chromium.org Change-Id: I80cfdad5c65bf928c65aeae02f2e080de3cf6873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890319 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Make the best effort to determine sizes. Bug: 1022764 Change-Id: I4b55302b36a2964cd3b11ff8c5c4540c69300bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905550 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#713838}
-
Jonathan Ross authored
On going work has resolved a number of bugs with SkiaRenderer + Vulkan. This change updates the pixel_expectations as well as blink_web_test expectations, in order to enable more tests. TBR=ynovikov@chromium.org TEST=vulkan_native_blink_web_tests vulkan_swiftshader_blink_web_tests vulkan_pixel_skia_gold_test Change-Id: Ia5533aae4f766fb1588344b3f5fcaf903f05dc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901801Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Antonio Gomes authored
The replacement is now possible that all users are in Blink. Essentially, the former is a pure interface for the later. As a follow up step the use of WebString will be replace by TF::String. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7c94b66363f933db7c15ca0e80236e61aac5828c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902443 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Henrique Nakashima authored
Bug: 1022107 Change-Id: Ie7b1cb7c41bca57e225a8821360dc9db80d87e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903928Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713835}
-
Bence Béky authored
Before this CL, a frame of reserved type was sent out after every HEADERS frame, even if the HEADERS frame had END_STREAM set, which is in violation with https://httpwg.org/specs/rfc7540.html#StreamStates. After this CL, reserved frames are sent before every DATA frame, when the stream is guaranteed to be in open or half-closed (local) state from the receiver's point of view. Reserved frames sent on stream 0 after the SETTINGS frame are not affected by this change. Bug: 1020233 Change-Id: I2ac5273c44486578d1e14920678ca07800278dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903946 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#713834}
-
Joe Mason authored
A lot of the plumbing that passes information from ChromePromptIPC to higher layers uses the PromptAcceptance enum and callback classes generated from chrome_prompt.mojom. This will make it harder to get rid of chrome_prompt.mojom when it's no longer supported. * Use PromptUserResponse::PromptAcceptance from chrome_prompt.proto, which is now the preferred IPC method. * Define callbacks in ChromePromptIPC that have similar signatures to the Mojo callbacks. * Convert to and from these types in MojoChromePromptIPC. The Mojo types are no longer referenced outside this class and its unit test. R=proberge Bug: 969139 Change-Id: Ie4028bc650aa2d155492225c33716cf6eaf69c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904846Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713833}
-
meacer authored
The letter "ə" (U+0259) can be confused with both "e" and "a" when used in domain names. IDN spoof checker currently doesn't have a way of treating a single character as confusable with multiple characters, so the only option is to map this letter to either "e" or "a" but not both. This is obviously not desirable since the Schwa can be used to spoof the non-mapped character. As a result, there is no straightforward solution other than limiting the character to .az domains (The letter is used commonly in Azerbaijani language). This fix affects ~250 registered domains containing the letter "ə". However, only ~40 of these domains serve some sort of content, the rest are either parked or don't serve content. Furthermore, only 1 of these domains appear in usage logs and the domain is not widely used, so this is probably a safe change. Bug: 1017707 Change-Id: Ied699b3b7bd067945d90dd360d2ecf3243912145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904761 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713832}
-
Gauthier Ambard authored
This reverts commit 87d8b793. Reason for revert: This breaks swipe to dismiss. See crbug.com/1022763 Original change's description: > Fix headers on reading list after deleting articles. > > -call |-removeEmptySections| in |-setEditing:animated:| before resetting the property. > > needsSectionCleanupAfterEditing needs to be removed when dropping iOS 12. > > Bug: 998491, 1022763 > Change-Id: I38cef305e1763120b402f1904f21c29c48ce024a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832273 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703237} TBR=kkhorimoto@chromium.org,gambard@chromium.org,ewannpv@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998491 Change-Id: I91e0004d962761c18514f1fa1f2e463c74491eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905849Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713831}
-
Anatoliy Potapchuk authored
Split function OnNetworkRequested(bool requested) into two more logical calls. Bug: 1015383 Change-Id: I3bb5af7fb530e0d3a7a5123069a41dbad44ed997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905709 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713830}
-
Olivier Robin authored
With slim navigation, the tab cannot be restored anymore. Directly add the tab to recently closed without creating a WebState (as the WebState is not used anyway). Bug: 1022298 Change-Id: I4979564e938fd49fb8b622c38561675ccf27a8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903354 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0663b3d6a615..0db29887459d Created with: gclient setdep -r src-internal@0db29887459d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic7d240e469b38af109f0b464373f4ca62d38c516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905889Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713828}
-
Tommy Steimel authored
This CL sets the focus behavior for the title and artist text in the media dialog to allow screen readers to focus it. This fixes an issue where screen readers could not read the title and artist. Bug: 1022553 Change-Id: I691a0b3ba1ed99b18264f34863943e0f289b9d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904538 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#713827}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c1fb4156d24..2bc811ea07b7 git log 7c1fb4156d24..2bc811ea07b7 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 danilchap@webrtc.org Mark checked_cast, dchecked_cast, and saturated_cast as constexpr 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 63455546..b19a2944 (713670:713775) 2019-11-08 gustaf@webrtc.org Remove legacy EchoControlFactory::Create 2019-11-08 mbonadei@webrtc.org RTC_EXPORT webrtc::GetScreenRect. 2019-11-08 tommi@webrtc.org Fix number of arguments being passed when setting the thread name on Windows. 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b4dd47d..63455546 (713546:713670) 2019-11-07 honghaiz@webrtc.org Revert "Stop using and delete DEPRECATED_SingleThreadedTaskQueueForTesting" 2019-11-07 peah@webrtc.org Further AGC refactoring in preparation for adding multichannel support 2019-11-07 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-07 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-07 minyue@webrtc.org Make Opus PLC always output 10ms audio. 2019-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 93ed153e..3b4dd47d (713404:713546) 2019-11-07 peah@webrtc.org Correcting the AGC saturation detection for multichannel input Created with: gclient setdep -r src/third_party/webrtc@2bc811ea07b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I39c7d0392e222496df1292ca515e2c5108df4f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905886Reviewed-by:
-
Daniele Castagna authored
ParseOverlayStrategies was mispelled to ParseOverlayStategies Test: no Change-Id: Ica6a73f174649756f99d3e772d3fb928380a428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904316 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713825}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c832dcd6c20..5e3eacac1ca1 git log 2c832dcd6c20..5e3eacac1ca1 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 ilkos@google.com Encapsulate the totals on the heap profiles metrics Created with: gclient setdep -r src/third_party/perfetto@5e3eacac1ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I90d2e53782c81faf2f66e9d91673524d3c112f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905890Reviewed-by:
-
John Budorick authored
Bug: 1022537 Change-Id: Ic0181f537b130c869c05be2a7ba1e7584e6ba0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904493 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713823}
-
ckitagawa authored
This CL implements the required code to capture paint previews in Blink. The majority of the code is shared with printing; however, new flags are introduced to handle the differences between printing and painting of previews. This CL *does not* introduce support for OOP iframe paint previews and scrolling them (to be handled in a separate CL). Desired Behaviors; - Paint Previews should look exactly like the current webpage and should not reformat in the way printing does. This includes ignoring print display tags and the simplifications used in painting. - Paint Previews should re-layout to be the full contents of the page not just the viewport. This is achieved by printing to a canvas the size of the document (single page). - Paint Previews should print to a single Skia Picture (per frame) rather than a Metafile Skia Document. Design doc: go/fdt-design Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Bug: 1001109 Change-Id: If0e947befea8ecc78b2cbee950e8c1cbd8e1281e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844057Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#713822}
-
kylechar authored
We are hitting DCHECK where two SkSurfaceCharacterizations don't match. It's a rare crash and I'm unable to reproduce it locally. Store both SkSurfaceCharacterizations on the stack and alias them so they are included in minidumps. Bug: 1022304 Change-Id: I8844f0f4483486896e7ecc7ef89fd17f6f88531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904449Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713821}
-
