- 01 Feb, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baff0d095ac5..7b1368c196a9 Created with: gclient setdep -r src-internal@7b1368c196a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I68cfb89d2df1ba4a321a0a8f9a459c3d131d8b22 Reviewed-on: https://chromium-review.googlesource.com/c/1449086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628251}
-
Brandon Maslen authored
Audio and video element requests typically involve custom headers and range requests that are more complicated and nuanced than other resource requests. As a result, despite potentially being preloaded, audio/video resources do not typically hit the preload cache. In order to rectify this issue the Fetch spec needs to specify how the preload/media cache should behave and implementors need to adopt this behaviour. This is tracked here: https://github.com/w3c/preload/issues/97 While the preload spec does describe preloading media resources (as=audio/video), and the current behaviour does match the spec, the behaviour is misleading for developers given that indications are the resource is preloaded and yet the video element typically will re-fetch the resource. This can cause unintended behaviour and potentially even double downloads. In order to mitigate the current cache behaviour and send a clear signal to developers about how their page will behave the current thought is to remove the audio and video "as" declarations from the preload implementation until the Fetch spec issue is resolved. This change removes the audio/video ResourceTypes as a valid preload types. In addition the upstream W3C preload tests have had exceptions added to specify the newly expected behaviour. As this is likely to revert in the future and not result in a preload spec change the original tests have been left as-is. A new test has also been added to the web_tests preload test suite to validate that audio/video types are indeed not preloaded. Intent to Temporarily Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QnwPuiiYuQE Bug: 735014 Change-Id: I82ad3200d486ce531795dd42f89e6683087047a2 Reviewed-on: https://chromium-review.googlesource.com/c/1440522 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#628250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e2a76c334ce..baff0d095ac5 Created with: gclient setdep -r src-internal@baff0d095ac5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f5ac4f662ee310c044d964b8cb52d6695f67e5c Reviewed-on: https://chromium-review.googlesource.com/c/1449083Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ceab6936. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 2376792a "Enable analyser tests to run with Chrome" f62d379c "Revert "Enable analyser tests to run with Chrome"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I27e2eb760d48f958ec32fd4b3c4e056d2770d1f0 Reviewed-on: https://chromium-review.googlesource.com/c/1449319Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628248}
-
tzik authored
SecurityOrigin used to use |this| pointer value to identify opaque unique origins, which does not work well with IsolatedCopy(). After this CL, the nonce value of the unique origin is involved for the comparison, so that the return value of IsolatedCopy() equals to the original one. Change-Id: I54bc49ead8b711b40902503656e3356e9a5c75f3 Reviewed-on: https://chromium-review.googlesource.com/c/1445034Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#628247}
-
Alexandre Courbot authored
SetPlaneBytesUsed() was incorrectly using the >= operator instead of > to decide whether the bytes used were larger than the size of the buffer. Fix this. Bug: None Test: Run VDA unittest on Hana. Change-Id: I32cd3018e5bdc6ce088eddf6e0f0dc86c09e84af Reviewed-on: https://chromium-review.googlesource.com/c/1448001Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#628246}
-
Amos Lim authored
MultiCacheQueryOptions inherits CacheQueryOptions and contains cacheName[1]. MultiCacheQueryOptions in match of CacheStorage replaces CacheQueryOptions. On the other hand, match in Cache takes CacheQueryOptions without cacheName. [1]: https://w3c.github.io/ServiceWorker/#cachestorage It was added in https://github.com/w3c/ServiceWorker/pull/1341 Bug: 919077 Change-Id: I86b68fe9197dacb431f989fa3958daebe0fd1dba Reviewed-on: https://chromium-review.googlesource.com/c/1395998Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#628245}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01f64e0eb22d..831bd96138e9 git log 01f64e0eb22d..831bd96138e9 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 julien.isorce@chromium.org Remove unnecessary memset to DesktopFrame 2019-01-31 jonaso@webrtc.org Add field trial for ExtraICEPing 2019-01-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 71d81bd2..9963b4a7 (627987:628101) 2019-01-31 steveanton@webrtc.org Add steveanton@ to media/ OWNERS 2019-01-31 steveanton@webrtc.org Modify pc/ WATCHLISTS definition 2019-01-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a91ca6cb..71d81bd2 (627878:627987) 2019-01-31 terelius@webrtc.org Add field trial to configure averaging window for BitrateEstimator. Created with: gclient setdep -r src/third_party/webrtc@831bd96138e9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7e5d351eb1f9adb6a07d029d25753f1e261bf19d Reviewed-on: https://chromium-review.googlesource.com/c/1449021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628244}
-
Hajime Hoshi authored
The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual JavaScript invocation from the task runner: Layout test: external/wpt/content-security-policy/generic/filesystem-urls-do-not-match-self.sub.html This is a following patch of https://chromium-review.googlesource.com/c/1442399 Bug: 913912 Change-Id: I8e7b9e97fa1c7643435d41ebdafed77bd74b3756 Reviewed-on: https://chromium-review.googlesource.com/c/1448071Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ebe5f7fad064..debaacab10b5 git log ebe5f7fad064..debaacab10b5 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 chiur@google.com Add presubmit config for kokoro Created with: gclient setdep -r src/third_party/swiftshader@debaacab10b5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic9147963bf44be745afc6afece678a8ea8bec271 Reviewed-on: https://chromium-review.googlesource.com/c/1449079Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf976fb07d97..9e2a76c334ce Created with: gclient setdep -r src-internal@9e2a76c334ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If1859fc4376ed4b2a52f10a99dd2fd2130b04c17 Reviewed-on: https://chromium-review.googlesource.com/c/1449080Reviewed-by:
-
Kenichi Ishibashi authored
It could be very large and could be a source of out-of-memory. Bug: 907311 Change-Id: I2fd3d00a0b9046ba1fe4d102204b5605dc35e49e Reviewed-on: https://chromium-review.googlesource.com/c/1448000 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#628240}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d02e1c7fb7f..4f738c1fe581 git log 0d02e1c7fb7f..4f738c1fe581 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4f738c1fe581 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5b463c5b5de1cefa6b2a6bc4d97b4f47eb88cafe Reviewed-on: https://chromium-review.googlesource.com/c/1449026Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48d040e8c524..1a07524dce2e git log 48d040e8c524..1a07524dce2e --date=short --no-merges --format='%ad %ae %s' 2019-02-01 jiajia.qin@intel.com Fix the misuse of deepCopy() Created with: gclient setdep -r src/third_party/angle@1a07524dce2e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie1d3f41a0863821094abae48b12c2f72e9386b42 Reviewed-on: https://chromium-review.googlesource.com/c/1449023Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I8e7075eefe45fa21b135bd3e4da292b56db56c00 Reviewed-on: https://chromium-review.googlesource.com/c/1449372Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#628237}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95b014790f93..925f6ab9b18a git log 95b014790f93..925f6ab9b18a --date=short --no-merges --format='%ad %ae %s' 2019-02-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@925f6ab9b18a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Iff19b019e6268c1bb88313fe8b31701501e5b513 Reviewed-on: https://chromium-review.googlesource.com/c/1449081Reviewed-by:
-
Alli Murray authored
instances and classes which extend, such as EntryListItem. Removable roots are EntryListItems and need eject functionality to set up an eject button. Bug: 918795 Change-Id: Icad38a3e44ff308d826a0fb2c3debcd5f0a7c69a Reviewed-on: https://chromium-review.googlesource.com/c/1446258Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alli Murray <alliemurray@google.com> Cr-Commit-Position: refs/heads/master@{#628235}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/12c34f6d21aa..fc911b7d1f81 git log 12c34f6d21aa..fc911b7d1f81 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 dhanyaganesh@chromium.org BuildStore: Add buildbucket equivalent for UpdateMetadata 2019-02-01 seanabraham@chromium.org chromite: Use the new lucicfg generator method, since core.generator is gone. 2019-02-01 xixuan@google.com PaygenTest: Add support of using skylab tool to create test. Created with: gclient setdep -r src/third_party/chromite@fc911b7d1f81 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I62623bd586ad3769955acab79eca3e0da66f0a72 Reviewed-on: https://chromium-review.googlesource.com/c/1449025Reviewed-by:
-
Peng Huang authored
Known issues: * flickers on the search result page. * webview becomes blank after rotation. * rendering to fbo doesn't work Bug: 919865 Change-Id: I577b2df1c48320c11be4397c10595db748f02b79 Reviewed-on: https://chromium-review.googlesource.com/c/1440072 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628233}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7a629886aed9..0e08d5911290 git log 7a629886aed9..0e08d5911290 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 thestig@chromium.org Clean up parts of CXFA_TextLayout::DoLayout(). Created with: gclient setdep -r src/third_party/pdfium@0e08d5911290 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5be7c20283057447b890fe6107b93e0377adb6ce Reviewed-on: https://chromium-review.googlesource.com/c/1449024Reviewed-by:
-
Kunihiko Sakamoto authored
- Update to draft-ietf-httpbis-header-structure-09 - Now Tokens and Keys are different syntax elements. - Update spec refs and terms (e.g. Binary -> Byte Sequence) - Allow byte sequences without base64 padding - Disallow non-printable ASCII characters in strings - Stricter parsing of Tokens / Keys / Integers - Add unit tests Bug: 923229 Change-Id: I812ddaf43f2964f242e0a6f1a63107d70595b72c Reviewed-on: https://chromium-review.googlesource.com/c/1420506 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#628231}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b6cc5a6baf93..3d5023b90cd0 git log b6cc5a6baf93..3d5023b90cd0 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 simonhatch@chromium.org Dashboard - Add histograms for benchmarks under "all" bot 2019-02-01 benjhayden@chromium.org Add python Histogram.Create(). 2019-02-01 benjhayden@chromium.org Switch pinpoint to chops-signin. Created with: gclient setdep -r src/third_party/catapult@3d5023b90cd0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:924564,chromium:918193 TBR=sullivan@chromium.org Change-Id: I497bf61b2d87da07ceb5b7a9931cf38f92561f2e Reviewed-on: https://chromium-review.googlesource.com/c/1449078Reviewed-by:
-
Vladislav Kaznacheev authored
Currently if the Chrome icon is clicked while there are multiple browser windows (or multiple tabs when clicked with Shift), the most recently active browser window will be activated, then the disambiguation menu will be shown. This startles the user, especially if the browser window was previously minimized. This CL prevents this from happening. Bug: 926980 Test: manual Change-Id: Ia86f9eb43c589928b22e9556e3c4c97abc194837 Reviewed-on: https://chromium-review.googlesource.com/c/1449104Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#628229}
-
chaopeng authored
This issue is because we use a fixed transform to compute PositionInWidget for each wheel or touchpad gesture event. If the OOPIF scrolled, use of the fixed transform would give wrong coordinates. In this patch, we recompute all scroll event's PositionInWidget in scroll sequence. This patch only changes wheel and touchpad gesture event. Touch and gesture events be fixed in a fix in following patch. Bug: 923560 Change-Id: I557d65e756f0933f2efbc26802179b3531c03826 Reviewed-on: https://chromium-review.googlesource.com/c/1427607Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#628228}
-
Keishi Hattori authored
This reverts commit 0634e8dd. Reason for revert: MimeHandlerViewCrossProcessTest.NavigationRaceFromCrossProcessRenderer is failing on Mac bots crbug.com/927564 Original change's description: > [ MimeHandlerView ] Fix an error in test > > The |query_index| was not defined and the test was not actually > navigating the test page to the desired URL. > > TBR=wjmaclean@chromium.org > > Bug: 659750 > Change-Id: I8f9658ac80adaa20f3cdceb0c19f799b59f96987 > Reviewed-on: https://chromium-review.googlesource.com/c/1448776 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628125} TBR=ekaramad@chromium.org,wjmaclean@chromium.org Change-Id: Iae21364b81a5a031c96ba6342b5ffa9186e21076 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 659750 Reviewed-on: https://chromium-review.googlesource.com/c/1448087Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628227}
-
Aga Wronska authored
Rename methods related to parent access shelf button to avoid confusion when showing parent access dialog on lock screen is added. Add UMA metrics for parent access shelf button. Bug: 911326 Change-Id: I430ab94e419eb4aa0e19630a060aa2dc7722376c Reviewed-on: https://chromium-review.googlesource.com/c/1446798Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#628226}
-
Alexander Alekseev authored
This Cl removes WebUI Lock code. ShutdownPolicyLockerTest is rebuilt to use Views code. TBR=dmazzoni@chromium.org Bug: 926638 Change-Id: I3477ebff7fe25c68d03bf2e2a710dfdfab898989 Reviewed-on: https://chromium-review.googlesource.com/c/1447378Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#628225}
-
Eugene But authored
GetPendingItem can return null inside webView:didCommitNavigation: This is due to crbug.com/925304, which allows to discard pending items by another navigations prematurely. If pending item is null, it means that Navigation Manager will not commit that item and WebStateObservers can crash because they expect to have at least one committed item. This CL leaves navigation as "uncommitted" if there was no pending item inside webView:didCommitNavigation: Bug: 925304 Change-Id: If9bedd0f74a428946a9026d142da7fc360fd7138 Reviewed-on: https://chromium-review.googlesource.com/c/1448683 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628224}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39b0b8e32a4e..0d02e1c7fb7f git log 39b0b8e32a4e..0d02e1c7fb7f --date=short --no-merges --format='%ad %ae %s' 2019-02-01 tandrii@chromium.org delete no longer used cq.cfg. Created with: gclient setdep -r src/third_party/depot_tools@0d02e1c7fb7f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:926635 TBR=agable@chromium.org Change-Id: I12befebb8ddc066707ff1500f9e59ce4da3d04fd Reviewed-on: https://chromium-review.googlesource.com/c/1449022Reviewed-by:
-
rbpotter authored
Fix the settings multidevice smart lock subpage test to work with Polymer 2: - Check for undefined properties before dereferencing them in observers - Set on-close handler on the dialog directly, rather than adding it as a listener, since the event does not bubble in Polymer 2. Bug: 738611 Change-Id: If7d892f97885b2c136d820b13193fa1befb290f0 Reviewed-on: https://chromium-review.googlesource.com/c/1448878Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#628222}
-
John Abd-El-Malek authored
Note nothing is done for kIgnoreCertificateErrors flag as that's already handled by NetworkContext's call to ParseCommandLineAndFieldTrials. Bug: b/123321526 Change-Id: I336d68f262a4754d0396d85978de2608b2e3572e Reviewed-on: https://chromium-review.googlesource.com/c/1448990 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. Bug: 927166 Change-Id: I60ae5578a49b237f91dbe92732dda8ad6f823304 Reviewed-on: https://chromium-review.googlesource.com/c/1448084 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628220}
-
Takuto Ikuta authored
This is to fix compile noop failure in internal builder. http://shortn/_t5pHTnebHY Bug: 914264 Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/1448085 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628219}
-
Aga Wronska authored
While implementing sending user credentials with policy fetch, the way lock screen is forced by Time Limits was changed. It might be causing a bug in parent supervision therefore move the change behind the feature flag kDMServerOAuthForChildUser to allow further investigation. Bug: 839025, 924844 Change-Id: I682e388e91dbc4b473a8c5de8ebc884e5dfd4c76 Reviewed-on: https://chromium-review.googlesource.com/c/1446697Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#628218}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e5e7db63cd9..12c34f6d21aa git log 2e5e7db63cd9..12c34f6d21aa --date=short --no-merges --format='%ad %ae %s' 2019-01-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@12c34f6d21aa The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I034c8c8a98159db7312fbe3a6cbeef410aa1d653 Reviewed-on: https://chromium-review.googlesource.com/c/1449252Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88bfed46ab6e..95b014790f93 git log 88bfed46ab6e..95b014790f93 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-31 reed@google.com remove (dead) legacy measuretext 2019-01-31 kjlubick@google.com Add CMake bot Created with: gclient setdep -r src/third_party/skia@95b014790f93 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I8ed75ff3cd24bda61a5e709d38c5f2fa5e7d32dc Reviewed-on: https://chromium-review.googlesource.com/c/1448569Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2cde328881f0..cf976fb07d97 Created with: gclient setdep -r src-internal@cf976fb07d97 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:905792 TBR=mmoss@chromium.org Change-Id: Ifedc583754d07a341ef6ccc54541aeada8e0520a Reviewed-on: https://chromium-review.googlesource.com/c/1449019Reviewed-by:
-
Kent Tamura authored
Move namespace handling code in MarkupFormatter::AppendOpenTag() to MarkupAccumulator::AppendOpenTag(), and move MarkupFormatter::ShouldAddNamespaceElement() to MarkupAccumulator. MarkupFormatter::AppendOpenTag() is used by MakupAccumulator and StyledMarkupAccumulator, however only MarkupAccumulator needs the namespace handling. This CL doesn't change any behavior. Bug: 927166 Change-Id: I941a6c4dc1154fdbd57fd7f48bae0bd1cda33b18 Reviewed-on: https://chromium-review.googlesource.com/c/1448083 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Reilly Grant authored
This comment was added in r518002 but is no longer relevant because both Generic Sensors API and deviceorientation / devicemotion events are now using Feature Policy to control access from iframes. Bug: 787019 Change-Id: Ia66eb56fee88681e258017fb9a1c9522e1931f7b Reviewed-on: https://chromium-review.googlesource.com/c/1449313 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
Don't use explicitly link against fuzzer_no_main-x86_64.lib since it duplicates symbols that are in some of the asan runtime libraries. This likely breaks the old instrumentation (which we dont use) and definitely breaks compiling libFuzzer targets on Windows without ASAN (which we don't use on CF). It is unclear if there is a problem for Windows users of LF or if this was just a chrome problem since Chrome doesn't link using the compiler driver. Bug: 927352 Change-Id: Iefb657cee55c31b8ea2546d3a1e39a5235875f9d Reviewed-on: https://chromium-review.googlesource.com/c/1449163 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#628212}
-
