- 01 Feb, 2018 40 commits
-
-
Christian Dullweber authored
This CL changes StoragePartition to wait for localstorage deletions to finish before calling its callback. Some extension tests can leak memory because they don't wait until StorageParitition deletions are finished. This CL adds a method to StoragePartition to check if it is done and changes extension tests to always wait for StoragePartition. Bug: 796151 Change-Id: Ica6f6ef47457eb34f82923ec6ae144f6b5b67fda Reviewed-on: https://chromium-review.googlesource.com/852234 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533707}
-
phweiss authored
If the admin installed a certificate that gets piped through to the Android side, the user should not be able to remove the cert in Android settings. Therefore, we set the configCredentialsDisallowed policy in clouddpc, that gets mapped to the DISALLOW_CONFIG_CREDENTIALS user restriction. Bug: b/67891423 Test: $OUT-DIR/unit_tests --gtest_filter=ArcPolicyBridgeTest.CaCertificateTest Change-Id: I7f3f349225c88c0eb4561e71bf235a081c153b16 Reviewed-on: https://chromium-review.googlesource.com/881443 Commit-Queue: Philipp Weiß <phweiss@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533706}
-
Bence Béky authored
The underlying bug of the three linked issues found by Clusterfuzz is that if a QUIC PUSH is received with an empty hostname, it used to be passed on to X509Certificate::VerifyHostname(), where a DCHECK() would fail. This has been fixed at https://crrev.com/c/893625 by wangyix. The current CL is adding a regression test for this. Note that it has been suggested at https://crbug.com/797825#c7 that the connection be terminated (not only the stream reset) on such a malformed input. Bug: 788537, 797825, 801811 Change-Id: I96bb1528264549ca05e64da914de3f3a70d0f7c4 Reviewed-on: https://chromium-review.googlesource.com/851194 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533705}
-
Danyao Wang authored
With WKBasedNavigationManager, after the back navigation, the URL has an extra '#' at the end as a result of the link click. LegacyNavigationManager reloads the URL on back navigation so doesn't have this problem. However, the new behavior is consistent with Safari, Firefox and Blink. Changed test to check for the content of the first link instead of looking at the URL. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia98f5a6f69b3aa322781c4a48cf4a8bef90fad2f Reviewed-on: https://chromium-review.googlesource.com/896683 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533704}
-
Gauthier Ambard authored
This CL adds a cancel button to stop editing the location bar. It also adds the appearance/disappearance animation. Bug: 804750 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibb9723fe3df94e1f43b332116128518c309b817b Reviewed-on: https://chromium-review.googlesource.com/897364 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#533703}
-
Gauthier Ambard authored
The ContractOmnibox command was only forwarding its call to the OmniboxFocuser's cancelOmniboxEdit method. This CL removes ContractOmnibox and directly calls the OmniboxFocuser. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8a18cb967e6dd114ded4bcff978ac4d3402d7cd3 Reviewed-on: https://chromium-review.googlesource.com/895532Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533702}
-
https://skia.googlesource.com/skia.git/+log/16aa82a974f6..5f9ee7cc53d2 $ git log 16aa82a97..5f9ee7cc5 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 rmistry Fixes to trigger_wait_ac_task.py Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I061ed52c2c6711d3614f5e4a4ea7577eda7a15d9 Reviewed-on: https://chromium-review.googlesource.com/897344 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533701}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes NavigationURLLoaderTest.LoaderDetached and adds BrowserSideNavigationBrowserTest.FetchResponseAfterNavigationURLLoaderDeleted. Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Change-Id: I0c133c5f464d483df187c111853031766218e7a1 Reviewed-on: https://chromium-review.googlesource.com/868136 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533700}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes NavigationURLLoaderTest.RequestBlocked and adds BrowserSideNavigationBrowserTest.RequestBlockedByResourceDispatcherHostDelegate. Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2c2788e25182d8c3302daf77557160fa57313b84 Reviewed-on: https://chromium-review.googlesource.com/867951 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533699}
-
kylechar authored
VizMainImpl thread shutdown issues have been fixed. Enabled tests that were disabled because of that problem. Bug: 785023 Change-Id: I6dc21fabbfaacd7d0e458fb06697b03651a3f396 Reviewed-on: https://chromium-review.googlesource.com/893534 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#533698}
-
Matt Falkenhagen authored
These started passing after https://github.com/w3c/web-platform-tests/commit/e5febc7 was imported in r533346. TBR=shimazu Bug: 626703, 678905 Change-Id: I1525f8a34ae060db9f0fc404a60f4e5a11ddee61 Reviewed-on: https://chromium-review.googlesource.com/897073Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533697}
-
Dave Tapuska authored
This message is only generated for sync compositor and was discarded when we weren't using the browser compositor. That makes the message useless. Seems to be left over from when viz moved its begin frame messaging. BUG=722928 Change-Id: I65fa542b937c87568e63c25faca436e6a4939365 Reviewed-on: https://chromium-review.googlesource.com/889324 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533696}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes... * NavigationURLLoaderTest.DownloadAllowed. * NavigationURLLoaderTest.DownloadDisallowed. ...and adds: * BrowserSideNavigationDownloadBrowserTest.AllowedResourceDownloaded * BrowserSideNavigationDownloadBrowserTest.AllowedResourceNotDownloaded * BrowserSideNavigationDownloadBrowserTest.Disallowed Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Change-Id: Id81668b6dc2f55916db796d870968aa335cadc01 Reviewed-on: https://chromium-review.googlesource.com/867061 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533695}
-
Stefan Zager authored
*** PLEASE DO NOT REVERT *** This CL is the culmination of literally years of work. If you believe it is breaking something, please contact szager@chromium.org or skobes@chromium.org before reverting. With this change, all blink layout tests will run with root layer scrolling enabled. The main components of this patch: 1) Set the runtime_enabled_features.json5 entry for "RootLayerScrolling" to "experimental". 2) Remove virtual/rootlayerscrolls prefix from entries in LayoutTests/TestExpectations and FlagExpectations/*, and resolve redundancies with existing expectations lines. 3) Copy the current contents of LayoutTests/TextExpectations to LayoutTests/FlagExpectations/no-root-layer-scrolls 4) Append the contents of FlagExpectations/root-layer-scrolls to TestExpectations 5) Remove the "rootlayerscrolls" entries from VirtualTestSuites, and remove the "--root-layer-scrolls" flag from all remaining entries in that file. 6) Delete the directory LayoutTests/virtual/rootlayerscrolls, and all of its contents. 7) Move/copy test expectations files in LayoutTests/flag-specific/root-layer-scrolls and in the canonical (i.e., not flag-specific) LayoutTests/ locations as follows: - for each layout test that has at least one expectation file in flag-specific/root-layer-scrolls/: - if the test has any .png files in flag-specific/root-layer-scrolls/: - move all .png files in the canonical location to flag-specific/no-root-layer-scrolls - move all .png files in flag-specific/root-layer-scrolls/ to the canonical location. - if the test has any .txt files in flag-specific/root-layer-scrolls/: - move all .txt files in the canonical location to flag-specific/no-root-layer-scrolls - move all .txt files in flag-specific/root-layer-scrolls/ to the canonical location. BUG=417782 R=skobes@chromium.org,bokan@chromium.org,chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7a13ad251efc573acc5b737bd9ca29adf21a5c87 Reviewed-on: https://chromium-review.googlesource.com/893624 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533694}
-
Shivani Sharma authored
There was an extra Read being invoked by the consumer of HttpCache::Transaction in some cases and the transaction state machine was not handling it well (crashing with dcheck/infinite loop in DoLoop). This CL fixes the handling. Tested that the unit test indeed asserts without the fix if dcheck is enabled (if not, the DoLoop will go in an infinite loop since we were entering it with next_state_ set as STATE_NONE and then in the while loop setting it as STATE_UNSET). Test: net_unittests --gtest_filter=HttpCache.SimpleGET_ExtraRead Bug: 806344 Change-Id: I8b9472b48b15ed9f6c2132863f66941010b7aa52 Reviewed-on: https://chromium-review.googlesource.com/896145 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533693}
-
Danyao Wang authored
This CL moves form repost detection for WKBasedNavigationManager to in |webView:decidePolicyForNavigationAction|, where WKWebView gives a clear signal about form reposting (WKNavigationTypeFormResubmitted). This allows simplifying reload for WKBasedNavigationManager to directly delegating to [WKWebView reload]. FormsTestCase now pass with WKBasedNavigationManager. Bug: 807428,705020 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 Reviewed-on: https://chromium-review.googlesource.com/894892 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533692}
-
https://pdfium.googlesource.com/pdfium.git/+log/f5ca90c00198..1fc533150a27 $ git log f5ca90c00..1fc533150 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 bratell [jumbo] Compile fix: Move a GetPageContent to a more limited scope Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib75b3b9c7153f3ae159e277a3e0c7edd3dbf6ce8 Reviewed-on: https://chromium-review.googlesource.com/896399 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533691}
-
Friedrich Horschig authored
This is a reland of 1a544c78. Original change's description: > Remove influence of group name on NTPPopularSites studies > > Recently, a misnamed study (see deleted test config) caused the feature > to fall back to the default popular sites. This isn't a big problem but > when it was finally named correctly, the names of the groups disabled > all popular sites. > > Popular sites should not be so easy to disable. Therefore, remove the > group name condition. > > A forced cmd line flag should cover all possible cases and make the > intention very clear. This is already in place and remains untouched. > > Bug: 794329 > Change-Id: I71458d41de6d0e0d5f0d8fcde1b636b0fe18618c > Reviewed-on: https://chromium-review.googlesource.com/827072 > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528301} Bug: 794329 Change-Id: I0c391668095cd66be012f0d1d483ff0970cbb018 Reviewed-on: https://chromium-review.googlesource.com/888560Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533690}
-
Steven Valdez authored
Bug: 765161 Change-Id: I1793dc689489c0648d7f6cc2988483355b81ff34 Reviewed-on: https://chromium-review.googlesource.com/893805Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533689}
-
Stephen McGruer authored
position:sticky shipped always-on in M56. Bug: 231752 Change-Id: I7bff1d34540745a7220358965a933141d6f172e7 Reviewed-on: https://chromium-review.googlesource.com/896143Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#533688}
-
John Budorick authored
Bug: 797321 Change-Id: I1847985d9df8638531ecae8b90d9d74fe3aa3d7b Reviewed-on: https://chromium-review.googlesource.com/896972 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533687}
-
Gauthier Ambard authored
This CL adds an orchestrator for the animation triggered when the omnibox is focused. This orchestrator is responsible for coordinating the animation occuring in multiple stages and through multiple object. Having one central object ensure all animations are occuring with the same timing. Bug: 804748 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I07583f0fabde6b2fea8c0f9b2a7830fbb7e3cbc8 Reviewed-on: https://chromium-review.googlesource.com/895443 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#533686}
-
Becky Zhou authored
Bug: 803525 Change-Id: Ie97cf5306fbad1f095306651a4680e5718d3088c Reviewed-on: https://chromium-review.googlesource.com/896393Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#533685}
-
Hajime Hoshi authored
This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/890981, but includes fix for H264 encoder. This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. TBR=hajimehoshi@chromium.org Bug: 786332 Change-Id: Ifffbfbfb5fffb2e9b8619ba4e4b2e116633b6ebb Reviewed-on: https://chromium-review.googlesource.com/897319 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533684}
-
Colin Blundell authored
DnsProbeBrowserTest.OtherErrorWithCorrectionsFailure passes after the change made to dns_probe_browsertest.cc in https://chromium-review.googlesource.com/c/chromium/src/+/853301, wherein this browsertest can now handle requests to http(s)://mock.failed.request with the Network Service enabled (without the Network Service these requests are handled by URLRequestFailedJob). Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I36a3180fa222a50eec7ca21ab30dbb086624aea8 Reviewed-on: https://chromium-review.googlesource.com/897666Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533683}
-
Varun Khaneja authored
This reverts commit 0941a32d. Reason for revert: Causing build failures https://bugs.chromium.org/p/chromium/issues/detail?id=807391 Original change's description: > [1] Add unrar source code (v5.6.1.4) to third_party. > > Safe Browsing Download Protection for .RAR files: > This library will be used to unpack any .rar files > downloaded by the user to ensure that they are safe. > This code would execute inside a sandboxed process. > > This code is being fuzzed via OSS-Fuzz here: > https://github.com/google/oss-fuzz/tree/master/projects/unrar > > Here's the author's permission to use this library > for fuzzing and inclusion in Chrome: http://go/wknlc > > Followed the process listed at: > https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_third_party.md > > Bug: 750327 > Change-Id: Ia6978fcf43f1ba570d6e8dad5daf2903cbdb3834 > Reviewed-on: https://chromium-review.googlesource.com/855044 > Commit-Queue: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Justin Schuh <jschuh@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531767} TBR=thakis@chromium.org,jschuh@chromium.org,xam@google.com,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org,rend@google.com,jschuh@google.com,morbo@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 750327, 807391 Change-Id: Id2494b74b1eceebd67cef769219e0b2149dad8d9 Reviewed-on: https://chromium-review.googlesource.com/895399Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533682}
-
https://chromium.googlesource.com/angle/angle.git/+log/1776fd08e9f2..8efd1268eb2e $ git log 1776fd08e..8efd1268e --date=short --no-merges --format='%ad %ae %s' 2017-12-19 jiajia.qin ES31: Add max combined interface blocks validation Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I0aa5aad6b1ba505e8d6c81553cd679c295716630 Reviewed-on: https://chromium-review.googlesource.com/897822Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533681}
-
Olga Sharonova authored
This change renames public/interfaces to public/mojom and *_struct_traits_* to *_mojom_traits_* in /services/audio. Bug: 806965, 792441 Change-Id: I64ae6176bc9a8b88b0dc5fd1cc2c0746e13c3d23 Reviewed-on: https://chromium-review.googlesource.com/897665Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533680}
-
Bence Béky authored
Use the shiny new CompletionOnceCallback introduced in https://crrev.com/c/853092 instead of the not-quite-obsolete CompletionCallback, in //net/spdy, wherever possible without changing code outside //net/spdy. Bug: 807724 Change-Id: I770427a3273ad15c6d215277a3f1cf1e050e19cc Reviewed-on: https://chromium-review.googlesource.com/895706Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533679}
-
Mathieu Perreault authored
The experiment was never launched. Bug: None Test: existing Change-Id: Id43517130547b474d090d69ef1ab738c44a3b6b8 Reviewed-on: https://chromium-review.googlesource.com/896802Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#533678}
-
Bence Béky authored
This is in preparation for the transition to CompletionOnceCallback: many of these lines would need to be touched anyway, and using ResetAndReturn() is more concise, elegant, and agnostic to callback type. Bug: 807724 Change-Id: I5b2f06905c152931e41713ae72bd515592e86550 Reviewed-on: https://chromium-review.googlesource.com/895783Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533677}
-
Raphael Kubo da Costa authored
|try_results| was removed in 140c584f ("WPT Import: when checking CQ status, only check CQ builds"), but was still being referenced in a log message. R=qyearsley, robertma Change-Id: Ibba90533a31f94ddf4cbaad0fe5fb0dc96fff7bc Reviewed-on: https://chromium-review.googlesource.com/897501Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#533676}
-
Hans Wennborg authored
This reverts commit 2ba21bcd. Reason for revert: This broke browser_tests in official chrome-branded builds. See for example: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/78737 Also see the bug. Original change's description: > Replace the NTP Interceptor with Throttle > > This change replaces the NewTabPageInterceptorService with a > NewTabPageNavigationThrottle. The throttle reduces complexity, but it > is also neutral regarding the network stack / network service, so it > fixes the NewTabPageInterceptorServiceTests that were broken with the > NetworkService feature enabled. These tests are now renamed > NewTabPageNavigationThrottleTest. > > BUG=802926 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Iec0664df33e79d6bcc18f60aecc4017de7f65858 > Reviewed-on: https://chromium-review.googlesource.com/868994 > Commit-Queue: Conley Owens <cco3@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530370} TBR=cco3@chromium.org,reillyg@chromium.org,mmenke@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 802926, 808011 Change-Id: I6bedcaea58a7009cd0302469390645f2e496203e Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/897423Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533675}
-
François Beaufort authored
This is still incomplete as it still needs to reject pending requestPiP promises. Bug: 806249 Change-Id: I256cf5fa092e4e03a7a82135761e2160fbdba043 Reviewed-on: https://chromium-review.googlesource.com/891958Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#533674}
-
Mark Cogan authored
The existing fix for the NTP flickering in when the FRE view is shown doesn't work when the BVC itself is presented. This CL improves that fix by not depending on the BVC's view having a window when -presentViewController:animated: is called. Bug: 798042 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ddb8a1867ff84d15b912e607dfce3f180d011e9 Reviewed-on: https://chromium-review.googlesource.com/895685 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#533673}
-
Peter Boström authored
Bug: chromium:654115 Change-Id: I9aa312a5eeb1041bb5a1c725e22db774d91900c8 Reviewed-on: https://chromium-review.googlesource.com/896325Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533672}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/00909549..2fc50dd0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3717208b8b9b524e5185fa2acdf0d402db99a0a7 Reviewed-on: https://chromium-review.googlesource.com/896988Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533671}
-
Eugene But authored
This test uses ExabyteResponse which never stops respondind and then shuts down the server after the navigation is comitted to fail the load. Bug: 614168,789585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4571fbfa58c35072438a8cc74e4c2eeca5c2dd08 Reviewed-on: https://chromium-review.googlesource.com/895913Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533670}
-
Juan Antonio Navarro Perez authored
Dex limit is being reached on some builders. TBR=sdefresne@chromium.org Bug: 807936 Change-Id: Ic8bcff99759ebb348ae336489ab52ca921b6d958 Reviewed-on: https://chromium-review.googlesource.com/897808Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#533669}
-
Nicolas Dossou-gbete authored
Removes unnecessary support library target aliases and their usage. Bug: 807641 Change-Id: I957d0490eedd4202a3f460469bb2b37771fafbcc Reviewed-on: https://chromium-review.googlesource.com/895450Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#533668}
-