- 28 Jul, 2018 40 commits
-
-
dpapad authored
This not only results to smaller file size, but also makes the code more portable, since it is less dependent on chrome:// URLs, and can eventually lead to running those elements and tests outside the context of a browser_tests and without js2gtest. Bug: 866236 Change-Id: I26b4a22f61b10cbbd1a19c5e055bb5c0f2aaf471 Reviewed-on: https://chromium-review.googlesource.com/1150931Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578913}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/201a484d..d9576eff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28dc165546b82d0a75ab68b5e87c337c901363d2 Reviewed-on: https://chromium-review.googlesource.com/1154191Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578912}
-
rbpotter authored
These tooltips do not exist in the original UI and were accidentally added to the new one. Since the text is identical to the displayed title, there is no reason for them to exist. Remove them by renaming the "title" property to "listName", as the title attribute is used to create tooltips. Bug: 867838 Change-Id: Ie2e6dfa5bd38f9a7c2aea80b2742a46abd866aa1 Reviewed-on: https://chromium-review.googlesource.com/1152451 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578911}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee78b5c0fb0f..e8b6729e6510 git log ee78b5c0fb0f..e8b6729e6510 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 vapier@chromium.org validation_pool: fix lint error in previous commit 2018-07-28 dhanyaganesh@chromium.org chromite: Starter Guide 2018-07-28 dgarrett@google.com prototype-firmwarebranch: Create/publish artifacts. 2018-07-28 vapier@chromium.org signing: convert README to markdown Created with: gclient setdep -r src/third_party/chromite@e8b6729e6510 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0241e31f3a47f231d02a8c6363c483233fc98fa Reviewed-on: https://chromium-review.googlesource.com/1154171Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578910}
-
Eric Karl authored
This reverts commit b148b478. This change was causing hangs on Android. Was able to repro locally and bisect with high confidence. I agree that this logically should be removable, but for some reason isn't. We should re-visit in a future milestone. TBR=danakj,piman Bug: 846709 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1029fa57bc3bfb919121535fc2b70f6884e88a15 Reviewed-on: https://chromium-review.googlesource.com/1154198Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#578909}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Id43ff4f2cb9fb28fa1d7e86123255e2830bbe5ee Reviewed-on: https://chromium-review.googlesource.com/1153857Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578908}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9813d2fdd13..1e61f6096b9a git log b9813d2fdd13..1e61f6096b9a --date=short --no-merges --format='%ad %ae %s' 2018-07-27 dtu@chromium.org [pinpoint] Use Material metrics for margins, gutters, and base font. 2018-07-27 simonhatch@chromium.org Switch to using new LUCI linux tryserver. 2018-07-27 dtu@chromium.org [pinpoint] Side-by-side commit comparisons view. Created with: gclient setdep -r src/third_party/catapult@1e61f6096b9a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825434 TBR=sullivan@chromium.org Change-Id: Ia6d699368a00d6a132d4318a923f7fe8a4880ff8 Reviewed-on: https://chromium-review.googlesource.com/1154008Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578907}
-
Aldo Culquicondor authored
The backing SkMatrix constructor is also constexpr. The change made evident unused variables by the compiler. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a9ba10e30cd12cb35dbdb369274374c8403a550 Reviewed-on: https://chromium-review.googlesource.com/1153451Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578906}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/865c199d93d8..42c75b14f495 git log 865c199d93d8..42c75b14f495 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 buildbot@webrtc.org Roll chromium_revision 8c2846e5..743fc877 (578726:578837) Created with: gclient setdep -r src/third_party/webrtc@42c75b14f495 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2cfb614c3ebb31396205d8a5f34abf2ae7b84a8a Reviewed-on: https://chromium-review.googlesource.com/1154169Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578905}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80eb42ba9ee8..6192d6f0f94b git log 80eb42ba9ee8..6192d6f0f94b --date=short --no-merges --format='%ad %ae %s' 2018-07-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 21e9baf71e6e..306b6c168dc7 (7 commits) Created with: gclient setdep -r src/third_party/skia@6192d6f0f94b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I679bc7dfd66c295f05769611c293a3d10ef22ffa Reviewed-on: https://chromium-review.googlesource.com/1154170Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578904}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0415e02db77d..8584902d81ff git log 0415e02db77d..8584902d81ff --date=short --no-merges --format='%ad %ae %s' 2018-07-28 tsepez@chromium.org Remove CXFA_TraverseStrategy_ContentLayoutItem. 2018-07-28 tsepez@chromium.org Add CPDSDK_Annot::AsBAAnnot() checked downcast method 2018-07-28 tsepez@chromium.org Add ToXML{Instruction,Text,CharData}() checked conversion functions Created with: gclient setdep -r src/third_party/pdfium@8584902d81ff The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I23a32da297352d94c9778b2d92fbce59b72c2f6f Reviewed-on: https://chromium-review.googlesource.com/1154167Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578903}
-
Jun Mukai authored
ash/shell.h is referred in the file, but it turns out unnecessary. Simply removing the include is just fine. TBR=stevenjb@chromium.org Bug: 646565 Test: build succeeds Change-Id: Ic0709c0bcb4a01b5fd2744ad89fb53c0936b2088 Reviewed-on: https://chromium-review.googlesource.com/1148931 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578902}
-
Kenneth Russell authored
Pass --disable-features=WebRTC-H264WithOpenH264FFmpeg to viz_content_browsertests on "chromium.win:Win10 Tests x64" similarly to how it's being done for content_browsertests. Tbr: dpranke@chromium.org Bug: 867536 Change-Id: Ib04e95a3b1dd94b29027f7cda26b5780e1a16a92 Reviewed-on: https://chromium-review.googlesource.com/1154141Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578901}
-
Alexey Kozyatinskiy authored
Some clients needs to intercept messages on frontend side. BUG=none R=pfeldman@chromium.org Change-Id: Ia14cc0a88ae91eead3834a47276ddcfc6701bcf7 Reviewed-on: https://chromium-review.googlesource.com/1154036 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578900}
-
Takuto Ikuta authored
This is a part of effort to remove /wd4018 warning suppression. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1152755 This CL was uploaded by git cl split. R=ortuno@chromium.org Bug: 868248, 588506 Change-Id: I6f381e608322431356681f57a315271dca409d83 Reviewed-on: https://chromium-review.googlesource.com/1152843Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578899}
-
Peter Kasting authored
This is a reland of 8c35e22c Original change's description: > Add background tab colors and inactive images to the theme system. > > These will eventually be used for three purposes: > (1) To allow generating different background tab images from a common tint for > the inactive and incognito cases, thus allowing background tabs that blend > into the frame for custom themes. > (2) To allow autogenerating the background tab colors from the background tab > images, thus letting us autocalculate better tab text/separator/etc. colors. > (3) To allow theme authors to customize/override this behavior more precisely. > > Reasons (1) and (2) dictated the design here; reason (3) is basically a free > bonus. I thought about not making these resources overrideable by theme > authors, but there was some technical reason that turned out to not be easily > feasible, and there seems little reason to prevent it. > > This also allows us to read THEME_TAB_BACKGROUND_INCOGNITO on Mac (Views). > > This shouldn't result in a visual change on its own. > > Bug: 862664 > Change-Id: Icc57f78fd526d68b83c692fbac669a7371bb38ff > Reviewed-on: https://chromium-review.googlesource.com/1147869 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578790} Bug: 862664 Change-Id: I341bbce16853095f17b2608a7639bf0fd105c2cc TBR: estade, oshima, bsep, kylixrd Reviewed-on: https://chromium-review.googlesource.com/1154148Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578898}
-
Alexey Baskakov authored
This is a move-and-rename CL, no behavior changes. Results: - web_app_shortcut.h contains extension-independent stuff. - web_app_extension_shortcut.h contains extension-based code. - All shortcut-related code moved from shell_integration_linux.cc to web_app_shortcut_linux.cc (so no circular dependency on web_app.h) This CL untangles all circular dependencies listed in web_applications/BUILD.gn. Modernize: - Replace arraysize with base::size. - UTF8String -> SysNSStringToUTF8. - BindOnce. Bug: 862049 Change-Id: I9bf098d00f363aa8ed1a0c45514dc04cb9923e9e Reviewed-on: https://chromium-review.googlesource.com/1138042 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#578897}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/306b6c168dc7..5b3b5cc126a7 git log 306b6c168dc7..5b3b5cc126a7 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 zmo@chromium.org Suppress more tests on Android for NVIDIA Shield TV bot. Created with: gclient setdep -r src/third_party/angle@5b3b5cc126a7 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idce15cae04293f8c304882fc94690016a281cd69 Reviewed-on: https://chromium-review.googlesource.com/1154168Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578896}
-
Khushal authored
Currently skia is limited to ES 2.0 for GPU raster, also apply this limitation for OOP raster since we suspect this might be causing crashes on Adreno (TM) 405 devices. TBR=vollick@chromium.org R=piman@chromium.org Bug: 866613 Change-Id: Icd4ed5116a28a31e3b4ba2121955fa595d837f33 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1083883 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578895}
-
Sergey Ulanov authored
Previously runner scripts were capturing debug logs from test instance only after successful SSH connection to the test device. This made it hard to debug issues that break system boot (mainly after SDK updates). This CL sets SSH connect timeout to 5 seconds (previously there was no timeout) and updates Target._WaitUntilReady() to capture logs with loglistener while waiting for SSH connection. The logs are printed to the output after second failed connection attempt. Change-Id: I4b57d3a13f3baa520d9e7bdd08a6e6a9236e7ecc Reviewed-on: https://chromium-review.googlesource.com/1148939 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#578894}
-
Xunran Ding authored
Bug: 760102 Change-Id: I3811976622dcc06845ac970de7436d7f1fb6896e Reviewed-on: https://chromium-review.googlesource.com/1146122Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Xunran Ding <xunran.ding@samsung.com> Cr-Commit-Position: refs/heads/master@{#578893}
-
Zhenyao Mo authored
BUG=868596 TEST=GPU FYI TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e32c3dfa4a6b8ea07b92159793fe8749f6ae031 Reviewed-on: https://chromium-review.googlesource.com/1154042 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#578892}
-
Peter Collingbourne authored
This is a reland of e3971799 Fixed test failures under msan, which were caused by accessing memory which was uninitialized because the read was invalid. All such accesses are now protected with a validity check. Original change's description: > cc, gpu: Make serialization code bitness agnostic. > > With this change we use the same serialization regardless of whether > we are targeting a 32-bit or a 64-bit machine. > > Bug: 865796 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b > Reviewed-on: https://chromium-review.googlesource.com/1139106 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577038} Bug: 865796 Change-Id: Id9dae1d2e5e2389ce96574c917314d63f5de5494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1152370Reviewed-by:
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d201c0289f2..131b85f314db Created with: gclient setdep -r src-internal@131b85f314db The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:828550 TBR=mmoss@chromium.org Change-Id: I6ee1d3fe40a13f0715c7aebfcece085b3c3b7cf6 Reviewed-on: https://chromium-review.googlesource.com/1153927Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578890}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3e03eba0a7e2..ee78b5c0fb0f git log 3e03eba0a7e2..ee78b5c0fb0f --date=short --no-merges --format='%ad %ae %s' 2018-07-27 bhthompson@google.com Disable bvt-arc suite on quawks-paladin Created with: gclient setdep -r src/third_party/chromite@ee78b5c0fb0f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib492a2f76dd13cf95c705a874308aae13229b458 Reviewed-on: https://chromium-review.googlesource.com/1153293Reviewed-by:
-
Sergey Ulanov authored
Some cleanups for the ui::PlatformWindowDelegate interface 1. Removed device_pixel_ratio parameter from OnAcceleratedWidgetAvailable. It wasn't used anywhere and the passed value was incorrect for most PlatformWindow implementations. 2. Removed OnAcceleratedWidgetDestroying() - it wasn't used anywhere. 3. Clarified OnAcceleratedWidgetDestroyed() should not to be called from destructor. It's only useful on Android. Wayland and scenic implementations were calling it incorrectly in destructor. This also fixes the crash in the attached bug. TBR=piman@chromium.org (trivial change in //gpu) Bug: 866729 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I164888802c65295bd07d9aa8d882332bbacbdbd9 Reviewed-on: https://chromium-review.googlesource.com/1147754 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578888}
-
Kyle Horimoto authored
Previously, the setup flow used fake data and did not actually perform setup. This CL integrates the WebUI dialog by: (1) Adding Mojo bindings to the dialog's WebUIController. (2) Adds externs for Mojo types to the Closure compiler pass. (3) Updates WebUI code to use Mojo JS bindings. Bug: 824568 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I53acbc227b9d965f9337fbbdb84c90e285665745 Reviewed-on: https://chromium-review.googlesource.com/1139222 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578887}
-
Peter Kasting authored
This is a reland of ec2cd434 Original change's description: > Misc. cleanup to browser_theme_pack_unittest.cc; no functional change. > > * Add GetDefaultColor() mapping function to make it easy to fix DCHECKs due to > this code using raw _INCOGNITO color constants but > ThemeProperties::GetDefaultColor() not expecting them. This is the change > that led me to get annoyed and do all the other stuff here. > * Convert typedefs to type aliases. > * Add TP = ThemeProperties type alias for brevity. > * Use =default. > * Mark functions that don't touch member variables "static". > * Fix wrapping issues. > * Because the class here is so long, split it into declaration and definition > pieces so it's easier to see what's the API and what's helper functions. > * Make the API protected; make helpers private. > * Make data members private. Add a const accessor for the one member tests use. > > Bug: none > Change-Id: I4cc058bb29747cfa84835edbc5ce765401e14527 > Reviewed-on: https://chromium-review.googlesource.com/1152108 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578775} Bug: none Change-Id: I0a6e9543722f886c2528700e457fd0ef0d75dccd TBR: estade Reviewed-on: https://chromium-review.googlesource.com/1154147Reviewed-by:
-
Johannes Henkel authored
Will use this in the InspectorDOMDebuggerAgent and elsewhere, since Keys() returns vector<WTF::String> and it's a bit inefficient / ugly to call .empty() on that. Change-Id: I99f9cb6024077bbc60ada38e46240ac602bf8669 Reviewed-on: https://chromium-review.googlesource.com/1154038Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#578885}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3bc69f238f5..80eb42ba9ee8 git log c3bc69f238f5..80eb42ba9ee8 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 herb@google.com Take advantage of newly const ref text stack 2018-07-27 bsalomon@google.com Update .clang-format to handle Objective-C files Created with: gclient setdep -r src/third_party/skia@80eb42ba9ee8 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: If52c64653b770d9c7ae838d446540b559116deff Reviewed-on: https://chromium-review.googlesource.com/1153928Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e635e9807dab..865c199d93d8 git log e635e9807dab..865c199d93d8 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 buildbot@webrtc.org Roll chromium_revision 75645bae..8c2846e5 (578612:578726) Created with: gclient setdep -r src/third_party/webrtc@865c199d93d8 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3d85f6ecdd4b0fa70cfe144d759f0d18772b8364 Reviewed-on: https://chromium-review.googlesource.com/1153929Reviewed-by:
-
Alexander Alekseev authored
This Cl replaces static images with animations. Bug: 852038 Change-Id: Id58f69e4275231dc4b6491358d10a343f529fc2f Reviewed-on: https://chromium-review.googlesource.com/1153832 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578882}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f737a90..201a484d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78f7544261c08bc0fc81b869fe982c6d52caedd7 Reviewed-on: https://chromium-review.googlesource.com/1153984Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6146214d30ab..0415e02db77d git log 6146214d30ab..0415e02db77d --date=short --no-merges --format='%ad %ae %s' 2018-07-27 thestig@chromium.org Roll DEPS for testing corpus to 4e2bafc0. 2018-07-27 thestig@chromium.org Make pixel_tests pass on Windows 10. 2018-07-27 thestig@chromium.org Make pdfium_embeddertests pass on Windows 10. 2018-07-27 hinoka@google.com [cq.cfg] Flip CQ to LUCI 2018-07-27 tsepez@chromium.org Tag XFA data bound to V8 Objects. Created with: gclient setdep -r src/third_party/pdfium@0415e02db77d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:828177,chromium:828177,chromium:828177,chromium:860896 TBR=dsinclair@chromium.org Change-Id: I2fdc495ac5cc8249ff9ac7bb61189292deeae037 Reviewed-on: https://chromium-review.googlesource.com/1154007Reviewed-by:
-
Johannes Henkel authored
For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. Change-Id: I69c43a22b0a20a8badba5ae907ca23ed93610614 Reviewed-on: https://chromium-review.googlesource.com/1153296 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
glevin authored
Bug: 865800 TEST: Disabled!! Change-Id: Ib4f9622e031ace72111cfbe6e1f5fead36905e8b Reviewed-on: https://chromium-review.googlesource.com/1153660 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#578878}
-
Johannes Henkel authored
- InspectorWorkerAgent - InspectorTracingAgent - InspectorAnimationAgent - InspectorPageAgent (started earlier) For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. Change-Id: Id0e94a9c944341fa2c08dcb3d7bfb00c4b437614 Reviewed-on: https://chromium-review.googlesource.com/1152695Reviewed-by:
-
Xida Chen authored
Under paint-touchaction-rects, the new result is actually correct. This CL changes the expected.txt and mark this test pass. A new test is added to show that with PaintTouchActionRects, the result is correct with clipping. Bug: 853912 Change-Id: Id6138081e9a782333edc2911a9e9f53997f0b564 Reviewed-on: https://chromium-review.googlesource.com/1151709Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578876}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia22c42dc512988b686ff68ae4fbcde272d6eca7a Reviewed-on: https://chromium-review.googlesource.com/1154137Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#578875}
-
Yuwei Huang authored
As discussed previously, people who care about mobile data usage can limit mobile data usage from the app, so we can remove the warning dialog for now and see if there is any feedback lamenting its loss. Bug: 868194 Change-Id: I3efb1adb10b4207c67605c68195d480fbe7a7b3a Reviewed-on: https://chromium-review.googlesource.com/1152547Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#578874}
-
