- 22 Feb, 2019 40 commits
-
-
Dan Beam authored
mojo_bindings_lite.js should be used in new (and eventually current) code. R=dpapad@chromium.org BUG=931798 Change-Id: I6499a02c848412d7a2ba4c3d84fcc202e2813bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1474517 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#634547}
-
Oksana Zhuravlova authored
This change adds .mojom-blink-test-utils.h to the list of allowed header suffixes in the presubmit checks. Bug: 922875 Change-Id: I2cb51817c43a56480ad780f40372dca67ae14e71 Reviewed-on: https://chromium-review.googlesource.com/c/1481088Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#634546}
-
Elly Fong-Jones authored
Per email discussions, this will expire for now in M76. Bug: None Change-Id: Iaad798936c451a8e5dbf7f93ec2bf9bb9902d53f Reviewed-on: https://chromium-review.googlesource.com/c/1479836 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#634545}
-
Alex Danilo authored
Sub-menus are reduced in height when the viewport height is reduced so the sub-menu won't fit without clipping, however it isn't increasing height when viewport height is increased. This CL fixes it, by always setting the sub menu height and toggling the overflowY behaviour (auto or scroll). Bug: 934207 Tests: Ran all browser and unit tests, added unit test. Change-Id: I33ec8720b8350924b8e631debede8cad4eb5fb05 Reviewed-on: https://chromium-review.googlesource.com/c/1481285Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634544}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee4fa0785090..b9039bf76bf3 git log ee4fa0785090..b9039bf76bf3 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 syoussefi@chromium.org Vulkan: fix numerous formats missing support Created with: gclient setdep -r src/third_party/angle@b9039bf76bf3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ia79cef965f2e4d60fdac184d9722b0a760a66f19 Reviewed-on: https://chromium-review.googlesource.com/c/1481967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634543}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/76fb06310126..5100fd8f459d git log 76fb06310126..5100fd8f459d --date=short --no-merges --format='%ad %ae %s' 2019-02-22 simonhatch@chromium.org Pinpoint - Use buildset tags instead of properties. 2019-02-22 rmhasan@google.com Adds a new function to the serially executed browser test API 2019-02-22 sadrul@chromium.org Reland "speed: Look only for the appropriate devices/browsers." 2019-02-22 crouleau@chromium.org Make testScrollDistanceSlowWheel accept more delta Created with: gclient setdep -r src/third_party/catapult@5100fd8f459d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:828649,chromium:698902,chromium:932409,chromium:934537 TBR=sullivan@chromium.org Change-Id: I62a1e8a42e9b4c494612049e188e60f42b6c868b Reviewed-on: https://chromium-review.googlesource.com/c/1481963Reviewed-by:
-
Takuto Ikuta authored
This reverts commit cd38dfe2. Reason for revert: speculative revert for https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-cronet-arm-rel/14109 Original change's description: > [Mojo Lite] Remove externs generators and use for-compile generators everywhere. > > This CL removes the Mojo Lite externs generators and compiles all WebUIs > with the for-compile targets instead. > > Structurally, all Mojo types are now Closure record typedefs, and their > generated business logic is underneath a Spec object to prevent the name > collisions that were happening in the original implementation. > > All goog.requires have also been dropped, and goog.provides are now > per interface/struct/enum. > > This CL paves the way for generating single file Closure compiled blobs > that have all the Mojo bindings for a single WebUI. > > TBR=kinuko@chromium.org > > Bug: 914149 > Change-Id: I8866fa9eaa707b2db42369e695ed0a51c373c6b6 > Reviewed-on: https://chromium-review.googlesource.com/c/1476886 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#634527} TBR=kinuko@chromium.org,calamity@chromium.org,rockot@google.com Change-Id: I58267fe8c16088a33fcc067a61b2d869b855a899 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914149 Reviewed-on: https://chromium-review.googlesource.com/c/1482430Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#634541}
-
Ramin Halavati authored
Incognito Window Counter's view is moved from incognito_window_count_view.* into profile_chooser_view.* to make it compatible with other profile menues. Bug: 896235, 931320, 932048, 933697 Change-Id: I21600e64560be6a0bd309e73ff735ad59b13cafa Reviewed-on: https://chromium-review.googlesource.com/c/1477012Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#634540}
-
CJ DiMeglio authored
Previously, the user got no indication via screenreader that a media element was unplayable. This CL adds aria attributes onto the element to indicate the unavailability of playback. Bug: 926277 Change-Id: I2fc1c4b3a5a95d0a8686b3dd3aa20041780b105b Reviewed-on: https://chromium-review.googlesource.com/c/1444813 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634539}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I340703d1ec143fb45cb1be12e797b3ee2b0446d4 Reviewed-on: https://chromium-review.googlesource.com/c/1482147Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#634538}
-
Prabir Pradhan authored
This CL creates the creates the relative pointer manager that uses the wayland extension relative-pointer-unstable-v1. It also adds and implements the RelativePointerDelegate, which the is used to send relative motion events through the OnPointerRelativeMotion method. Whenever pointer capture is requested, we hide the pointer and send relative movements though the RelativePointerDelegate. If a RelativePointerDelegate is created, we assume that pointer capture is enabled, and when it is destroyed, we assume pointer capture is disabled. Bug: 121287287 Change-Id: Ie7f662afcc15cb2e538cd22ad56409798d1757c1 Reviewed-on: https://chromium-review.googlesource.com/c/1388298 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#634537}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9912ca049a0..6a00e68a3448 git log e9912ca049a0..6a00e68a3448 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3fc635ac4a7f..b607bc8800c1 (2 commits) Created with: gclient setdep -r src/third_party/skia@6a00e68a3448 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I577f13f997658afb096cad7c0b76b37f15f03b2d Reviewed-on: https://chromium-review.googlesource.com/c/1481966Reviewed-by:
-
Zhenyao Mo authored
This is a followup from https://chromium-review.googlesource.com/c/chromium/src/+/1480973 BUG=867155 TEST=GPU Win10/Intel bots,manual R=sunnyps@chromium.org Change-Id: I6dbc86fab7c056498d57fa72b4df83b3ef845ced Reviewed-on: https://chromium-review.googlesource.com/c/1482132Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634535}
-
Nate Fischer authored
No change to the legacy code path. This implements #hasCookies for the network service code path. Because removeExpiredCookies() depends on this, this fixes that API as well. This removes passing tests from the filter. Bug: 931641, 933629, 902641, 933462 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest.testRemoveSessionCookiesNullCallback: \ Test: CookieManagerTest.testCookiesExpire: \ Test: CookieManagerTest.testHasCookie: \ Test: CookieManagerTest.testRemoveAllCookies: \ Test: CookieManagerTest.testSetCookieNullCallback Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Iee74af405862b34225b779c5b7636052772da5df Reviewed-on: https://chromium-review.googlesource.com/c/1477922 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634534}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: Iea1c080d824d24932eb8b9fc07adf7db741aae45 Reviewed-on: https://chromium-review.googlesource.com/c/1478312Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634533}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36974ad871c9..2fdee39b44ee git log 36974ad871c9..2fdee39b44ee --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2fdee39b44ee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifa0cf5222600b57f33a15173fd71951888e0578e Reviewed-on: https://chromium-review.googlesource.com/c/1481965Reviewed-by:
-
Dominic Mazzoni authored
When adding automated descriptions to images in the accessibility tree, add a contextualization string, "Appears to be:" for a caption, or "Appears to say:" for OCR, to clearly distinguish to the user. Only OCR is completely hooked up, the full label is blocked on one more change landing first. (Note: these strings have already been reviewed by Shimi.) Bug: 905419 Change-Id: Ib39ad7ff8cb43019809dad26f0c9cd32d6f9007a Reviewed-on: https://chromium-review.googlesource.com/c/1480351 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#634531}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c27f11d2e607..dda2895279c9 Created with: gclient setdep -r src-internal@dda2895279c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie89babaab98610e2af95a0617ad00e426d3737a1 Reviewed-on: https://chromium-review.googlesource.com/c/1481623Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634530}
-
Ryan Sturm authored
This rule will prevent Previews from being shown for 5 minutes after a page is reloaded that was a Preview. This is behind a finch feature to launch as an experiment. Bug: 933566 Change-Id: Ied3be1779991023ef8a0ca469c0bb97d0c30f3f7 Reviewed-on: https://chromium-review.googlesource.com/c/1481804 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#634529}
-
Wez authored
Bug: 931860 Change-Id: I60c351d290186ffeb6a8bc02ecb6ffdf91bfb863 Reviewed-on: https://chromium-review.googlesource.com/c/1480531 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634528}
-
Christopher Lam authored
This CL removes the Mojo Lite externs generators and compiles all WebUIs with the for-compile targets instead. Structurally, all Mojo types are now Closure record typedefs, and their generated business logic is underneath a Spec object to prevent the name collisions that were happening in the original implementation. All goog.requires have also been dropped, and goog.provides are now per interface/struct/enum. This CL paves the way for generating single file Closure compiled blobs that have all the Mojo bindings for a single WebUI. TBR=kinuko@chromium.org Bug: 914149 Change-Id: I8866fa9eaa707b2db42369e695ed0a51c373c6b6 Reviewed-on: https://chromium-review.googlesource.com/c/1476886 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
This is helpful when debugging grd exceptions. Change-Id: Ib78d6bf75bed82d98b6e8bdceff97a9c8fa03dd1 Reviewed-on: https://chromium-review.googlesource.com/c/1482131Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#634526}
-
Ryan Sturm authored
Other previews finish all general checks in the Allowed path. We should move all possible checks earlier. This is especially important for triggering both implementations consistently. Both implementations will use the same set of checks that are behind the PreviewsState . Bug: 921755 Change-Id: I30899661a0ccc756d1bcb829c453f90b3fedd579 Reviewed-on: https://chromium-review.googlesource.com/c/1480230 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634525}
-
Christopher Lam authored
Bug: 934384 Change-Id: I03b044e674f82705c52b91bbfee53b160610a6cc Reviewed-on: https://chromium-review.googlesource.com/c/1482093Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#634524}
-
Xiao Yang authored
1. This policy will allow Assistant to access screen context. 2. If the policy is on, Assistant will be allowed to access screen context. If disabled, Assistant will not be allowed to access screen context. 3. If the policy is not set, user will be allowed to decide. Change-Id: I3b282780b7886f9ddd4f178a16954e95e5c7b4f2 Bug: b/124113875 Reviewed-on: https://chromium-review.googlesource.com/c/1468587 Commit-Queue: Xiao Yang <yanxiao@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#634523}
-
Ian Kilpatrick authored
Previously we considered text-align for inline-level OOFs inside a block-level context. But we also needed to avoid floats. This is surprisingly consistent across browsers! However no tests. :( So fixed and added tests! Most of the complexity in this patch is making sure the logical->line->logical coordinate transforms are done correctly. Bug: 933996 Change-Id: I78207f8b7cba62e9d6f48f087fd5202178b42910 Reviewed-on: https://chromium-review.googlesource.com/c/1480071Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#634522}
-
Luciano Pacheco authored
Make Files, Gallery and Audio apps work with HTML Imports polyfill. The tests aren't passing yet, which I'm fixing on CL:1462640, but I have tested these 3 apps manually locally with: --disable-blink-features=HTMLImports and they seem to be working. However, I haven't tested them heavily, but I did test things related to Polymer elements which are affected by HTML imports. Add connect-src chrome://resources to Audio and Gallery's manifests (content_security_policy) to allow HTML import polyfill to URL fetch resources (via xmlHTTPRequest). File Manager's manifest already had this CSP setting. Bug: 924873 Change-Id: I43dc5962be9d8cbdcf795b35b8de909578ac4279 Reviewed-on: https://chromium-review.googlesource.com/c/1480296Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#634521}
-
Tsuyoshi Horo authored
Bug: 910516 Change-Id: I01f776e0a787e97430cc033d55bb1a32e900f9e9 Reviewed-on: https://chromium-review.googlesource.com/c/1480363 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#634520}
-
Kunihiko Sakamoto authored
This removes SignedHTTPExchangeOriginTrial feature, and its accompanied SignedHTTPExchangeAcceptHeader feature which is used for the Accept header opt-in. Bug: 827939,887201 Change-Id: I0794b886715a63cb6ac43c37a0adaddeb31f2af8 Reviewed-on: https://chromium-review.googlesource.com/c/1481181Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
As one of the servicification support, this CL makes that IdentityManager::DiagnosticsObserver can handle OAuth2TokenService::DiagnosticsObserver::OnAccessTokenRequestCompleted callback. The test case observe access token fetch request error when account has no refresh token, when access token request succeeded with no error, when access token request fails after revoking refresh token. Bug: 931246 Change-Id: I2d8d1d497c9a8f740e9cc0614141dbd9dc4571e2 Reviewed-on: https://chromium-review.googlesource.com/c/1474958 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634518}
-
Aga Wronska authored
Bug: 839025 Change-Id: I19967724efab49c6ae3b27bac0676a9e9aeebc74 Reviewed-on: https://chromium-review.googlesource.com/c/1449314Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#634517}
-
Abhijeet Kandalkar authored
cross_origin_attribute_value.h is related to fetching. Hence this CL moves cross_origin_attribute_value.h to platform/loader/fetch and port other dependent files to refer to a new include path. Bug: 933886 Change-Id: I7f10e662434caebf82b9b6bdfbc5f613620ef2b5 Reviewed-on: https://chromium-review.googlesource.com/c/1481147Reviewed-by:
-
David Jacobo authored
Manual style fix, just to keep cols to 80 where easily avoidable. Bug: None. Change-Id: I3d8fc15351e8911ce3976d4903ff15e50393b6cc Reviewed-on: https://chromium-review.googlesource.com/c/1481793Reviewed-by:
-
Oksana Zhuravlova authored
This change adds a way of overriding RenderFrameImpl's document interface broker with a custom implementation. Bug: 718652 Change-Id: Ia1fb901d0188858e67b930121d79e099506a167a Reviewed-on: https://chromium-review.googlesource.com/c/1464923 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#634514}
-
Luke Halliwell authored
This reverts commit c513d32f. Reason for revert: See internal b/124450506 Ultimately, this code gets bitten by these horrors: https://codesearch.chromium.org/chromium/src/services/service_manager/embedder/set_process_title_linux.cc?q=process_title&sq=package:chromium&g=0&l=114 Original change's description: > [fuchsia] Read the command-line from /data/cast/ > > The command-line will now be populated from > /data/cast/castagent-command-line. > > Bug: b/122267826 > Test: Add command-line to show verbose logging, cast_shell_unittests > Change-Id: I741a1a32e59bea07a2ce857d24df57712cf32761 > Reviewed-on: https://chromium-review.googlesource.com/c/1396135 > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Reviewed-by: Sergey Volk <servolk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625457} TBR=wez@chromium.org,servolk@chromium.org,yucliu@chromium.org,awolter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/122267826 Change-Id: I5ce28fa732ac6f1af8f3e19a51d66bceab081681 Reviewed-on: https://chromium-review.googlesource.com/c/1482135Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634513}
-
Nate Fischer authored
No change to the legacy code path. This implements #removeSessionCookies and #removeAllCookies for the network service code path. This implements both APIs on top of CookieManager::DeleteCookies(). This removes 3 tests from the filter (the remaining related test is blocked on fixing #hasCookies). Bug: 931641, 933629, 902641, 933462 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest#testRemove* Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Idb8f1bb5c464993fd142f29681395598c2f65cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1478459 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Zhenyao Mo authored
This reverts commit bccf0827. Reason for revert: we got the extra logging we needed from user Original change's description: > Add VLOG to DirectCompositionChildSurfaceWin::SetDrawRectangle > > This is for investigation purpose and will revert after this gets > in Canary and we get the error message from user. > > BUG=914911 > TEST=bots > R=piman@chromium.org > > Change-Id: I67761a335c7e6dee36a2beb8c593f03c4b2d1958 > Reviewed-on: https://chromium-review.googlesource.com/c/1396847 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620164} TBR=zmo@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 914911 Change-Id: I7e3f9daf0abd50b81f8c27a7e08e8ebe56ba1196 Reviewed-on: https://chromium-review.googlesource.com/c/1480070Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634511}
-
Stephen Chenney authored
libxslt fixed an issue with type confusion in xmlXPathNextPrecedingSibling. R=dcheng@chromium.org BUG=930663 Change-Id: Ib8055551b370c7d64957152e0fda57090110dee8 Reviewed-on: https://chromium-review.googlesource.com/c/1477805 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634510}
-
Takashi Sakamoto authored
This reverts commit 56a50dae. Reason for revert: Suspect causing browser_tests, viz_browser_tests, non_single_process_mash_browser_tests failures on Linux Chromium OS ASan LSan Tests (1). E.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31690 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8920872960619542176/+/steps/browser_tests/0/logs/DownloadNotificationTest.IncognitoDownloadFile__status_CRASH_/0 ==19438==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0001b7a80 at pc 0x55f331c5ce2d bp 0x7f3096281310 sp 0x7f3096281308 READ of size 8 at 0x60d0001b7a80 thread T6 (Chrome_IOThread) #0 0x55f331c5ce2c in content::URLLoaderFactoryGetter::SetNetworkFactoryForTesting(network::mojom::URLLoaderFactory*, bool) ./../../content/browser/url_loader_factory_getter.cc:226:5 ... Original change's description: > Enable NetworkService by default on ChromeOS > > Bug: 920038 > Change-Id: I577d9d497bc564b885a4a96ce5baf4f3326ce1a8 > Reviewed-on: https://chromium-review.googlesource.com/c/1464069 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634333} TBR=jam@chromium.org,jbudorick@chromium.org,rmcelrath@chromium.org Change-Id: Ibfeeadd47f94d4ff4a87ed9518c9bc0d7f2e30b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920038 Reviewed-on: https://chromium-review.googlesource.com/c/1482099Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#634509}
-
David Grogan authored
I didn't realize it was already calculated, it just needed to be passed to the fragment builder. Bug: 845235 Change-Id: I6ac97cd9326b545a395677e3ae03d09a7f341def Reviewed-on: https://chromium-review.googlesource.com/c/1479816Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634508}
-
