GitLab

Removed Ash.AppList.TimeBetweenTaskSwitches and Ash.Tab.TimeBetweenSwitchToExistingTabUserActions histograms.

These histograms are triggered in the chrome process but are actually
recorded in ash (which is in a different process). This is problematic
for the mus+ash refactoring and since there are no clear decisions
being made from these metrics they are being removed.

BUG=616581
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2390793002
Cr-Commit-Position: refs/heads/master@{#422885}

BUG=563793

Review-Url: https://codereview.chromium.org/2395473002
Cr-Commit-Position: refs/heads/master@{#422884}

This regressed in r420175 because a different code path is taken that doesn't go through browser_navigator.cc's CreateTargetContents.

BUG=650349

Review-Url: https://codereview.chromium.org/2388803003
Cr-Commit-Position: refs/heads/master@{#422883}

BUG=630118
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2389043003
Cr-Commit-Position: refs/heads/master@{#422882}

The crrev.com/2384783003 introduced a regression where tabbedEditorContainer
starts opening file for every created persistence binding.

This patch fixes the issue.

BUG=none
R=pfeldman, dgozman

Review-Url: https://codereview.chromium.org/2390333002
Cr-Commit-Position: refs/heads/master@{#422881}

This Cl adds the test case for the case sensitivity of getEntriesByType and
getEntriesByName.

BUG=chromium:651507

Review-Url: https://codereview.chromium.org/2393633002
Cr-Commit-Position: refs/heads/master@{#422880}

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2393463002
Cr-Commit-Position: refs/heads/master@{#422879}

This patch adds MarginStrut.BlockEndSum to the fragment's content size
if the fragment establishes a new formatting context.

The change is tested with layout_ng virtual test suite located in fast/block/basic.

BUG=635619

Review-Url: https://codereview.chromium.org/2389823003
Cr-Commit-Position: refs/heads/master@{#422878}

https://pdfium.googlesource.com/pdfium.git/+log/78c271dd9ee8..89f9ee3b8f3b

$ git log 78c271dd9..89f9ee3b8 --date=short --no-merges --format='%ad %ae %s'
2016-10-04 npm Use FX_SAFE_UINT32 on CPDF_ToUnicodeMap::Load

BUG=652232

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2385063004
Cr-Commit-Position: refs/heads/master@{#422877}

https://chromium.googlesource.com/chromium/src/+/d338af9fe

BUG=630695
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/2384083006 .

Cr-Commit-Position: refs/heads/master@{#422876}

* Zero out |total_size_| member in SpdyReadQueue::Clear(), otherwise the next
  call to IsEmpty() would crash.
* Add test for SpdyReadQueue::Clear().
* Add a comment to document class invariant.
* Move SpdyReadQueue tests into namespace test.

This is a follow-up to
https://crrev.com/2386883002/diff/40001/net/spdy/spdy_read_queue.cc#newcode53

Review-Url: https://codereview.chromium.org/2388243003
Cr-Commit-Position: refs/heads/master@{#422875}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8b1e6e937be3..9d498f565765

$ git log 8b1e6e937..9d498f565 --date=short --no-merges --format='%ad %ae %s'
2016-10-04 dproy Export loading_metric constants

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2385423003
Cr-Commit-Position: refs/heads/master@{#422874}

R=dschuyler@chromium.org
BUG=651720

Review-Url: https://codereview.chromium.org/2391803003
Cr-Commit-Position: refs/heads/master@{#422873}

This patch hides the new navigator design behind the experiment.

BUG=none
R=pfeldman, dgozman

Review-Url: https://codereview.chromium.org/2388303003
Cr-Commit-Position: refs/heads/master@{#422872}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aaa05f8f..04593858

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2393623002
Cr-Commit-Position: refs/heads/master@{#422871}

https://chromium.googlesource.com/skia.git/+log/b25c3522446c..779582280747

$ git log b25c35224..779582280 --date=short --no-merges --format='%ad %ae %s'
2016-10-04 liyuqian Implement AnalyticAA for convex shapes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/2392633003
Cr-Commit-Position: refs/heads/master@{#422870}

This is the first in a batch of CLs. There are a bunch of tests to adjust.

Also deleted some composited selection gap tests rather than adjust them.

BUG=647831

Review-Url: https://codereview.chromium.org/2393443002
Cr-Commit-Position: refs/heads/master@{#422869}

Convert a handful of js-test tests to testharness, with an eye towards
adding more and eventually upstreaming them.

R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2390083002
Cr-Commit-Position: refs/heads/master@{#422868}

This change removes all uses of IsModeMaterial() in c/b/ui/c/bookmarks and
refactors the code a bunch as a result.

BUG=649368

Review-Url: https://codereview.chromium.org/2394523002
Cr-Commit-Position: refs/heads/master@{#422867}

This CL removes the icons from the wallpaper and these rows (I believe
that is approved by Alan). This also avoids having the themes page open
up when resetting (removing) the current theme.

BUG=651715
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2390553004
Cr-Commit-Position: refs/heads/master@{#422866}

Frame detach and frame close don't really have any relationship. Update
the naming and comments to make this clear.

BUG=472140

Review-Url: https://codereview.chromium.org/2379293002
Cr-Commit-Position: refs/heads/master@{#422865}

Group nav (paragraph nav) is bound to Search+Ctrl+up/down. Define groups as loosely as possible and don't sync so nav remains as high up as possible for role/predicate matches to occur.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643840

Review-Url: https://codereview.chromium.org/2380073005
Cr-Commit-Position: refs/heads/master@{#422864}

clang-format wraps long lines, so java_cpp_enum.py should also
handle multi-line enum entries.

Also changed the HeaderParser to ignore empty comments.

BUG=652018

Review-Url: https://codereview.chromium.org/2396533002
Cr-Commit-Position: refs/heads/master@{#422863}

Use the taskId rather to determine if finish() should be called
on Preferences. Previously, if a user navigated in Preferences,
sResumedInstance got set to the sub-Preference and the main
Preference got finished. Since they belong to the same task, this
shouldn't happen.

BUG=652572

Review-Url: https://codereview.chromium.org/2386213004
Cr-Commit-Position: refs/heads/master@{#422862}

Committed: https://crrev.com/f34c072397b99c313e79cd10a77f5ca397154399
Review-Url: https://codereview.chromium.org/2365893002
Cr-Original-Commit-Position: refs/heads/master@{#422655}
Cr-Commit-Position: refs/heads/master@{#422861}

A recent CL introduced some new GN dependencies that broke internal Cast
variants:
  https://codereview.chromium.org/2354633002

Correct the dependencies here. Also put stronger asserts in x11 targets.

BUG=

Review-Url: https://codereview.chromium.org/2371583002
Cr-Commit-Position: refs/heads/master@{#422860}

This allows UsbDeviceHandleUsbfs to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114

Review-Url: https://codereview.chromium.org/2391633002
Cr-Commit-Position: refs/heads/master@{#422859}

There's no change in behaviour. Now that we setPaginationStrut() on the row,
we don't need to call paginationStrutForRow() outside of layout anymore.

BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2389913002
Cr-Commit-Position: refs/heads/master@{#422858}

Change the pattern of delegation to chrome to use mojom::SystemTrayClient.
This is more consistent with how we want to handle ash delegates going
forward. It eliminates a couple layers of indirection.

* Add wrapper methods to SystemTrayController in ash
* Remove Show* methods from SystemTrayDelegate in ash
* Delete SystemTrayCommon in chrome, move code to SystemTrayClient

Also delete unused tray_display.cc, left over from another cleanup CL
https://codereview.chromium.org/2217713002

BUG=647412
TEST=existing browser_tests, manually verifying system tray help and
settings buttons open web UI in chrome

Review-Url: https://codereview.chromium.org/2395523002
Cr-Commit-Position: refs/heads/master@{#422857}

With this CL, WaitableEventWatcher uses SequencedTaskRunnerHandle
instead of MessageLoop::current() to post back to the sequence that
called StartWatching().

Also, WaitableEventWatcher no longer registers itself as a destruction
observer of the MessageLoop from which StartWatching() is called. If
the watched WaitableEvent is signaled after the MessageLoop is
destroyed, the task posted by WaitableEventWatcher to the
SequencedTaskRunner will simply not run (no crash).

MessageLoop::current() and destruction observer do not work with
TaskScheduler.

BUG=650318

Review-Url: https://codereview.chromium.org/2368423002
Cr-Commit-Position: refs/heads/master@{#422856}

Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
Adds mojom files for Bluetooth service definition and internals page handler.
Adds basic Bluetooth device retrieval using starter Bluetooth service
implementation for logging on web front end.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=651282

Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9
Review-Url: https://codereview.chromium.org/2357383002
Cr-Original-Commit-Position: refs/heads/master@{#422570}
Cr-Commit-Position: refs/heads/master@{#422855}

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2382943002
Cr-Commit-Position: refs/heads/master@{#422854}

BUG=640268

Review-Url: https://codereview.chromium.org/2385383002
Cr-Commit-Position: refs/heads/master@{#422853}

BUG=None

Review-Url: https://codereview.chromium.org/2391993002
Cr-Commit-Position: refs/heads/master@{#422852}

BUG=

Review-Url: https://codereview.chromium.org/2389063002
Cr-Commit-Position: refs/heads/master@{#422851}

This CL adds code to update row view in the chooser when mouse button
is down and moves over rows.

BUG=645693

Review-Url: https://codereview.chromium.org/2382373002
Cr-Commit-Position: refs/heads/master@{#422850}

This includes defining a new NetLog event (SAFE_BROWSING_PING), which begins
when a ping is queued up, and ends when the result callback is fired. Covers
both the SafeBrowsingHit and ThreatDetails pings.

BUG=648323

Review-Url: https://codereview.chromium.org/2361963002
Cr-Commit-Position: refs/heads/master@{#422849}

We are already disabling GPU acceleration to avoid readbacks caused
by calls to getImageData. This change applies the same principle
to canvas-to-canvas drawImage calls in order to avoid probable
future readbacks.

BUG=652126, 651517, 650116, 642539, 640144

Review-Url: https://codereview.chromium.org/2388293002
Cr-Commit-Position: refs/heads/master@{#422848}

This CL was created programmatically by:

thakis@thakis:~/src/chrome/src$ cat pre.txt
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
thakis@thakis:~/src/chrome/src$ cat post.txt
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
 * DAMAGE.
thakis@thakis:~/src/chrome/src$ cat replace.py
import sys

pre = open('pre.txt').read()
post = open('post.txt').read()

for f in sys.argv[1:]:
  t = open(f).read()
  t = t.replace(pre, post)
  open(f, 'w').write(t)
thakis@thakis:~/src/chrome/src$ git grep -l "* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS \`\`AS IS'' AND AN" | xargs ./replace.py

BUG=563793

Review-Url: https://codereview.chromium.org/2395513002
Cr-Commit-Position: refs/heads/master@{#422847}

This avoids having to copy the data between std::vector<char> and IOBuffer within the implementation of WebSocketChannel.

As a follow-up, I plan to see about eliminating a similar copy at the Mojo bindings layer in content/browser/websockets/.

Review-Url: https://codereview.chromium.org/2267233002
Cr-Commit-Position: refs/heads/master@{#422846}