- 12 Mar, 2020 40 commits
-
-
Fabian Sommer authored
ChallengeResponseAuthKeysLoader now waits until force-installed login screen extensions are installed before requesting a certificate from these extensions, avoiding an incorrect error message. In order to know which extensions to wait for, stored ChallengeResponseKeys now contain the id of the extension that signed them. ChallengeResponseAuthKeysLoader will only wait for 5 seconds, then the error is displayed anyway (e.g. if the extensions failed to load). Bug: 1052404 Change-Id: I8a24b87cb63f4d899d36a3b0ab30237a6d82f691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078584Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#749676}
-
Peter Wen authored
Found by errorprone. I'm surprised that they were not caught earlier. Tbr: Comment changes. Bug: None Change-Id: Ia26be03885df3a416978686ad6581be9cd1ec376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100708Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749675}
-
Daniel Vogelheim authored
These tests have a very high flakiness because they bump against the timeout limit, and they are also run on other bots. So we can just save the effort and drop them from MSAN. Bug: 1060138, 856601 Change-Id: I7861f65721747334bbc925d48dd4669aedebb5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096736 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#749674}
-
Nohemi Fernandez authored
Adds logging for first run and sign-in flows. Bug: 971989 Change-Id: Ieec769b0db013959396be3ee533eb84f206cb9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087403 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749673}
-
Theresa authored
This reverts commit a8ed939a. Reason for revert: Moving to different directory Original change's description: > Move //chrome/android/public/ to //chrome/browser/android/ > > Change 1 of 2. The next CL will update downstream dependencies. > > Note that this will break the downstream build temporarily. Since there > are JNI files generated, unless the package is updated we cannot keep > a temporary mirrored build target as was done in > https://chromium-review.googlesource.com/c/chromium/src/+/2095444 > > BUG=1052382 > > Change-Id: Ib4d2e6f8143a7c0c6ead75d7701fea69a21db3a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095760 > Commit-Queue: Theresa <twellington@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749666} TBR=dtrainor@chromium.org,twellington@chromium.org Change-Id: Ieb5026e18ccbc629be00c6a10762253908a98ae2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100709Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749672}
-
Nohemi Fernandez authored
Streamlines the existing OWNERS files and adds fernandex@ to sign-in. Bug: 1060993 Change-Id: I20e91d74fc6d6013904aa5d9faea502b1ee66985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098629 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Plus resource_sizes.py tweaks: * Fixes failed sanity check for TrichromeWebView.apk * Teaches it that TrichromeLibrary is a shared apk Plus converts milestone_apk_sizes.py to python3 Bug: 1056320 Change-Id: I7691e9ccd7498dab180e104428ed7fe909c18fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099765Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749670}
-
Andrew Grieve authored
The robolectric_processor annotation processor need extra data files for it to operation, which GOMA has no way to know to make available. Easiest fix is to just disable GOMA for the three targets that use the annotation processor. Bug: 726475 Change-Id: Idb9c6d6edd9f199a3430499d4835051a4db9ca2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098762 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
Bug: None Test: Compiled Change-Id: I70c10e9c03f937c0e383df55a75014020214d92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100707 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#749668}
-
David Van Cleve authored
Currently, runtime_enabled_features.json5, the central registry of Blink runtime-enabled features, has a relatively large OWNERS alias (to API owners and Blink core owners). Adding a new runtime-enabled feature associated with an embedder-side base::Feature often involves adding boilerplate to WebRuntimeFeatures and //content/child/runtime_features.cc. Unfortunately, these files are in far-removed directories with few common owners. This CL expands those files' per-file owners to include renderer/core's owners, just as blink/renderer/platform/OWNERS currently does for runtime_enabled_features.json5. For the case of content/child/runtime_features.cc, the change also adds all top-level Blink owners. This should reduce the number of approvals needed to land a new runtime-enabled feature. It might also improve the quality of scrutiny these changes get: the comments accompanying these OWNERS aliases (copied from the comment next to runtime_enabled_features.json5's OWNERS alias) require that the reviewers have context about the functionality being affected by the runtime-enabled feature; currently, it might be hard to find owners for public/platform, renderer/platform, and //content/child who have context on one's specific feature. Change-Id: If420895d0256347ca2831e835ef970f766420ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092905Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749667}
-
Theresa Wellington authored
Change 1 of 2. The next CL will update downstream dependencies. Note that this will break the downstream build temporarily. Since there are JNI files generated, unless the package is updated we cannot keep a temporary mirrored build target as was done in https://chromium-review.googlesource.com/c/chromium/src/+/2095444 BUG=1052382 Change-Id: Ib4d2e6f8143a7c0c6ead75d7701fea69a21db3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095760 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#749666}
-
Aaron Leventhal authored
TBR=aboxhall@chromium.org NOTRY=true Bug: None Change-Id: I43b293e9ef1247458bd6f500ace250b285a7a934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099568Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749665}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I5c32614984a2398d83001d5b4e48c7689f7991d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087585 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749664}
-
Ulan Degenbaev authored
This changes the reporting in performance.measureMemory to reveal only the URL at the frame creation time for cross-origin iframes and thus prevents URL information leak if the iframe navigates after loading. This is done by saving the first cross-origin URL loaded in LocalFrame in LocalFrame::DidAttachDocument and using that URL for reporting. The patch also adds a new test for redirecting iframe and fixes the existing tests to wait until child iframes are loaded. Bug: 1049093 Change-Id: I0162efb82061f036450586dea0b191cacdce23f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098722 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Patch #10: Set minimal UI fields of the payment app and rename PaymentApp.java methods to the new terminology of "minimal UI". Before this patch, the abstract class PaymentApp.java had methods isReadyForMicrotransaction(), setMicrotransactionMode(boolean), accountBalance(), while the concrete class ServiceWorkerPaymentApp.java overrode these methods with demo-only stubs. After this patch, the abstract class PaymentApp.java has stub methods isReadyForMinimalUI(), setIsReadyForMinimalUI(boolean), disableShowingOwnUI(), setAccountBalance(String), accountBalance(), which are overridden by the concrete class ServiceWorkerPaymentApp.java. Bug: 1005076 Change-Id: Id5d5dd131b7e12e982639106f9a963d362e4f408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087907 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e5def0b4eb6..95001d898186 Created with: gclient setdep -r src-internal@95001d898186 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I67aa24b09d8adfefbdfcffcba8afccb1cdd96b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100567Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749661}
-
Ewann authored
If the URL scheme corresponds to Chrome on iOS, the icon shouldn't be set. Bug: 1038919 Change-Id: I3f23fd8a23a3c10accb139d341d75d952e6faae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096555 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#749660}
-
Andrey Zaytsev authored
Moved TestPasswordsPrivateDelegate into a separate file so it can be later used by safety check passwords unit tests Bug: 1015841 Change-Id: Id1662ec772f20eb8e33a98eb35b7b94be4fac422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096588 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
-
Tien Mai authored
Change-Id: I2832ea85e93e9ec6439f23327f191c31ca5dfd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095879Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749658}
-
Mark Cogan authored
Changes the URL loading notifier keyed service into a browser agent. This removes the notifier service as a direct dependency on the URL loading service; instead the loading service fetches the notifier when it is assigned a Browser. Bug: 1046375 Change-Id: I302858f854d310749660922c994ae8b9238a24b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093441 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749657}
-
Jason Lin authored
Bug: 1019034 Change-Id: Iaaf06362ba428414a4bc59414c355f34cc258992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089541Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#749656}
-
Aaron Leventhal authored
If this line is removed, tests fail because pseudo elements no longer have static text children. The comment originally associated with it was incorrect. NOTRY=true TBR=aboxhall@chromium.org Bug: None Change-Id: I7bb1e9c3af01d02c2199c769f70e40755cd2876f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100728Reviewed-by:
-
Rouslan Solomakhin authored
Patch #9: Pass minimal UI response from C++ to Java and report the error message, if any. Before this patch, Java received only the "can make payment" boolean from C++. After this patch, Java receives the following fields: 1) Optional error message <--- reported. 2) Can make payment. 3) Ready for minimal UI. 4) Account balance. Bug: 1005076 Change-Id: I4d30a5685416f0cadfc9e39db5557b92e7ff9aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088291 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9841983ed0df..559b7c953589 git log 9841983ed0df..559b7c953589 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@559b7c953589 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic91cb4c37a417f9bdf1d58ca47503c2d1bed01ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749653}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Iae243b05cdbdacc4997059bbc3a9ee555365cc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099323 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749652}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: Icf06ad3161e9139070894215e80fffa1f8e23a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098803 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749651}
-
Viktor Semeniuk authored
This change adds a strings for confirmation dialog when user tries to delete compromised credential inside password check section. Bug: 1047726 Change-Id: I7a585e1bf4cb5c1d9fca4d4c6923d46766a390cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098704 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749650}
-
Peter Kasting authored
It refers to working around some bug that no longer seems to exist. Bug: none Change-Id: I040aad0433f620cf68aec3909379f61b53dccf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100021 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#749649}
-
Etienne Pierre-doray authored
Record timestamp and location in ScopedBlockingCall to show up in hang dumps. This is useful to investigate hangs related to IO & flush. Bug: 1058194 Change-Id: Iee336ad9ec88a9b5d34a5d2e1a1e2a80c8248fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091547 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#749648}
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Bug: 1054892 Change-Id: Iac6a9f58d5b605812599012ac8ccdd86da3be497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088685 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
Currently the claimed URL of unsigned Web Bundle file is used only for relative path computation in the document. This is done by setting the base URL of the document. (https://crrev.com/c/1802902) Note: |base_url_override_for_bundled_exchanges| was renamed to |base_url_override_for_web_bundle| by https://crrev.com/c/1923786. And this CL renames it to |web_bundle_claimed_url|. But the file path of the Web Bundle file is still available using window.location and document.URL. This is problematic from the privacy point of view. This may leak the user name. Note: The same problem exists in opening local HTML files (https://crbug.com/990216). To solve this problem, this CL changes window.location and document.URL to use the claimed URL. This behavior is written in the explainer doc of “Navigation to Unsigned Web Bundles”. https://github.com/WICG/webpackage/blob/master/explainers/navigation-to-unsigned-bundles.md#loading-an-untrusted-bundle Bug: 995177,1023929 Change-Id: I922c4b40504fc1ed87e78cf77c6877b59110dedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040500Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#749646}
-
Colin Blundell authored
This CL componentizes ExternalNavigation{Delegate, Handler} for reuse by WebLayer. After a long series of leadup CLs cleaning the files of //chrome dependencies, the componentization is straightforward. In this CL we avoid changing any names within the moved files to keep the CL as targeted as possible. A followup CL will generalize references to "Chrome" in names and comments within these files. Followup work will also componentize ExternalNavigationHandlerTest. This CL also tightens an overly-aggressive presubmit check that fired here. Bug: 1031465 Change-Id: Ic50518242c62690cf57249a613860332ef13e0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096702Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#749645}
-
Yutaka Hirano authored
Do not call BindCacheStorageInternal until we have a COEP reporter to pass to RPH::BindCacheStorage. Change-Id: I25fd317cbcd6fd84d924472ca73facc007b50c71 Bug: 1060980 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100056 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749644}
-
Hiroshige Hayashizaki authored
As a part of turning down Built-in Modules in Blink. This CL also removes built-in modules/fallback support from import maps. After this CL, the non-virtual WPT tests will run against import maps without built-in modules support, and thus virtual/import-maps-without-builtin-modules tests are removed. Bug: 829084, 848607 Change-Id: Ic57c9ee3aac77d882ef08ba6b02c288a371fe537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096165 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Chen-Tsung Hsieh authored
This base should be treated as an internal device. Bug: b/150268720 Change-Id: Ib92a7532189a7fa0b23c10bd056e47776d786add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100196 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749642}
-
David authored
This cl also * adds show_in_launcher to SystemAppInfos * reads show_in_launcher in extension_apps.cc * adds tests to SystemWebAppManagerBrowserTest and MediaAppIntegrationBrowserTest Bug: b/150831266, 877898, 1054195 Change-Id: Iff6128bf858071906cdc9e961cef717d91354854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097799 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749641}
-
Mikhail Khokhlov authored
We'd like to use some SQLite features currently disabled in Chrome in a developer trace-analyzing tool called trace_processor_shell. As discussed on the thread [1], it's undesirable to enable them Chrome-wide. This CL adds an "sqlite_dev" build target and third_party/sqlite/dev include directory with a separate sqlite library that has most of the features enabled. [1] https://groups.google.com/a/chromium.org/g/storage-dev/c/OkwAfpYWAa0 Bug: b/150127983, b/150125501 Change-Id: If328bb737679b6d352904bcb543bc6ed1c522b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082389Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#749640}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84780f7dc5e1..40c7a20f9bf9 git log 84780f7dc5e1..40c7a20f9bf9 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 2ff8b6a6f4d5..be663d752e45 (8 commits) 2020-03-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src e2176c91b23c..9b620aa0c12d (2 commits) 2020-03-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 136207a63495..29adf277cb19 (1 commits) Created with: gclient setdep -r src/third_party/angle@40c7a20f9bf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I0b3c9964f9607fb42d9b78d3f269b51dd0a0b6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099215Reviewed-by:
-
Ehimare Okoyomon authored
Begin cookie settings redesign by replacing the two toggles with a four-state preference, hidden behind a flag. Adjust tests to use the new four-state preference. https://screenshot.googleplex.com/r22q4q6hH7O.png Bug: 1060118 Change-Id: I5f660b473112e8ab688b8ac5604f8bcceb7f35a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095124 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
Simon Zünd authored
After the CL https://crrev.com/c/2096712 moved side-effect checking for auto-complete suggestions completely to V8, we can re-enable the corresponding web test again. Please note that accessing iframe is currently considered side-effecting by V8, so we don't get any auto-complete suggestions when typing "iframeName.", thus, we need to update the tests expectations. R=petermarshall@chromium.org Bug: chromium:1031243 Change-Id: I32b1fb391a0d49785bb2ad17c5d763a35e2a8282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098725Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#749637}
-
