- 29 Nov, 2018 40 commits
-
-
Peter Boström authored
Bug: chromium:909818 Change-Id: I0c0df3d6aa2e01a3107f6ed0e4920437d38a6f95 Reviewed-on: https://chromium-review.googlesource.com/c/1355611Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612418}
-
Akihiro Ota authored
TalkBack does not explain how to open a new tab in Chrome when focusing the tabs button in the toolbar. Updated the content description for this button to communicate how to open new tabs Bug: 851175 Change-Id: I6dc16d09fe0a2a2902401e9e3060eaef91913e35 Reviewed-on: https://chromium-review.googlesource.com/c/1330759 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#612417}
-
Greg Kerr authored
This removes all of the obsolete unit testing code from the V1 sandbox. Bug: 902597 Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 Reviewed-on: https://chromium-review.googlesource.com/c/1327527 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#612416}
-
Sebastien Seguin-Gagnon authored
This reverts commit 81b9c8b4. Reason for revert: Owner landed a fix at the same time. Original change's description: > [Sheriff] Update expecations for worklet-animation-currentTime.html > > Tbr: yigu@chromium.org > Bug: 910295 > Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 > Reviewed-on: https://chromium-review.googlesource.com/c/1355255 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612406} TBR=sebsg@chromium.org Change-Id: I003b62c838453c6ce1a7df9787ace6bc372f1988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910295 Reviewed-on: https://chromium-review.googlesource.com/c/1355987Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612415}
-
Zhongyi Shi authored
- Net.QuicStreamFactory.AttemptMigrationBeforeHandshake.FailedConnectionType tracks the connection type of the default network when the original connection fails with handshake not confirmed. - Net.QuicStreamFactory.MigrationBeforeHandshake.NewConnectionType tracks the connection type of the altenate network when the original connection fails with handshake not confirmed and a new connection is about to be retried on the alternate network. These histograms may give us hints why the altenate network is not availabe when the connection on the default network fails. Current theory is that the default network is on Cellular, and there is no alternate network. Bug: 790547 Change-Id: Ibfd63efed9a1b72b7d6de95453af55feacd9cef6 Reviewed-on: https://chromium-review.googlesource.com/c/1354320Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612414}
-
Dave Tapuska authored
BUG=879657 Change-Id: Ifc3ba15e517c79286158e77a8bb83c3c30ea1a75 Reviewed-on: https://chromium-review.googlesource.com/c/1355881Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612413}
-
Andrew Comminos authored
Verfies that the UA measures the time before the end of header parsing in responseStart by simulating a delay after writing the status line and flushing to the client. Chrome fails this test for now, but Firefox passes. Bug: 568024 Change-Id: I61569c6a5b0d8ea2f3a06cb37a3d1ed36c06d40f Reviewed-on: https://chromium-review.googlesource.com/c/1354645 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#612412}
-
Alice Boxhall authored
Original reviews: https://chromium-review.googlesource.com/c/chromium/src/+/1206050 https://chromium-review.googlesource.com/c/chromium/src/+/1242572 https://chromium-review.googlesource.com/c/chromium/src/+/1345714 TBR=dmazzoni@chromium.org Bug: 906310, 908916 Change-Id: Ie56e5030db4bb3039816c5d5d9576279435835e6 Reviewed-on: https://chromium-review.googlesource.com/c/1353062Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612411}
-
Yusuke Sato authored
cmtm@ primarily uses the other account. BUG=None TEST=None Change-Id: I12ec23590fa3a8744d7717b63a7cda94b5ef2c52 Reviewed-on: https://chromium-review.googlesource.com/c/1355922Reviewed-by:
Christopher Morin <cmtm@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612410}
-
Joe Mason authored
The logo now has a title attr in it for screen readers. But when its set as the background of a <span>, or as an <img> src, screen readers don't look at the tags inside. For the screen reader to view the tag, it seems the <svg> element must be part of the DOM tree, such as when it's added with <embed>. Bug: 767130 Change-Id: I5d28030fc90c269aa6a13a605f24c698915f6c5d Reviewed-on: https://chromium-review.googlesource.com/c/1352822Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#612409}
-
Jered Gray authored
This is a reland of 1b420fdb The flakiness in the original CL with ResourceLoadingHintsBrowserTest and PreviewsNoScriptBrowserTest has been fixed. RetryForHistogramUntilCountReached() now flushes the task scheduler and keeps trying until the test times out. Original change's description: > Eliminate unnecessary proto::Configuration copies > > The previous logic in OptimizationGuideService created an > optimization_guide::proto::Configuration object on a background thread > and then used task posting to send it on to > PreviewsHints::CreateFromConfig(), where it was used to create a > PreviewsHints object on another background thread. In all, there were > two tasks posted that included the config object as a parameter, one on > the background thread and one on the UI thread. Including it as a > parameter in a task requires a full copy of the protobuffer. This means > that a full copy of the config protobuf, which can be as large as 1.8MB > (the size of the current Brazil one on Canary), was occurring on the UI > thread. > > In local performance measurements, making a single copy of a 600KB > version of the protobuf took several milliseconds (it amounted to > roughly 60% of the time taken by the initial component string parsing > and 60% of the time taken by PreviewHints::CreateFromConfig()). Given > that we were incurring the cost of two copies, one of which was on an > extremely high priority thread, it makes sense to change the logic to > eliminate the need for the copies. > > The logic has been altered so that OptimizationGuideService no longer > immediately processes the component, but instead notifies the > observers that it is available and allows them to trigger the > processing. This eliminates both copies of the configuration protobuf, > as it is now created where it is used. > > Additionally, OptimizationGuideServiceObservers are now immediately > notified of the hints component when they register if one is already > available. This will enable the PreviewsOptimizationGuide to wait until > the HintCacheLevelDBStore is fully initialized before registering for > the component, and in the future will potentially allow it to avoid > processing the configuration altogether when the store already has the > latest version cached. > > New unittests have been added and older ones have been updated to > accommodate the new logic. > > The related browser tests have also been modified to be more robust, > where they now wait for a signal from a local histogram indicating > that hint processing is complete. Bug: 908985, 910251 Change-Id: I90407db4c19dac29e10f756a6de87294a9ab683b Reviewed-on: https://chromium-review.googlesource.com/c/1355256 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#612408}
-
Vincent Boisselle authored
Change-Id: Ic84e3b2fc4126937a4227d20f0acf03a2f8bcfba Reviewed-on: https://chromium-review.googlesource.com/c/1355425Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vincent Boisselle <vincb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612407}
-
sebsg authored
Tbr: yigu@chromium.org Bug: 910295 Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 Reviewed-on: https://chromium-review.googlesource.com/c/1355255Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612406}
-
Gary Kacmarcik authored
Currently, this just sends a message with the desktop display configuration so that it can be added to the client logs. The display information must be gathered in the Desktop Process (DesktopSessionAgent) and then IPC'ed over to the Network Process. A temp hook from the DesktopSessionProxy to the ClientSession is added since there is no webrtc path for this message (so it can't follow the normal path from DesktopSessionProxy -> VideoFrameCapturer -> VideoStream -> ClientSession). Change-Id: I0a6b620b3b21aa16e6d978a92ece94f8440dc02c Reviewed-on: https://chromium-review.googlesource.com/c/1352730Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#612405}
-
Devlin Cronin authored
Update the permissions API documentation to note that: - "origins" contains origins associated with content scripts - The API can be used to request permission that were withheld by the user. Bug: 889654 Change-Id: I63cbc3f4e80e6cc26532e9714dd8de7a8086b97c Reviewed-on: https://chromium-review.googlesource.com/c/1347039 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612404}
-
Emil A Eklund authored
When shaping the content of an inline node in NGInlineNode::ShapeText we assume that the number of runs is small and iterate over all of the runs for each inline item. This assumption holds true for most content, there are certain cases where the assumption is incorrect however, such as the euckr-decode-ksc_5601.html WPT test where each CJK glyph is wrapped in a span and separated by space characters of a different glyph. This causes each of the 10k+ items to iterate over 10+ runs which is very expensive. This patch adds an optional context argument to ShapeResult::SubRange so that context (the relevant run) may be maintained across invocations and thereby avoids an extra loop over all of the runs for each SubRange call. Change-Id: I2ee610a60e33fe4389277fc275a9b8d670453a31 Reviewed-on: https://chromium-review.googlesource.com/c/1354561Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#612403}
-
Yi Gu authored
In crrev.com/c/1343558 I incorrectly marked an innocent test as flaky. TBR=hiroshige@chromium.org Bug: 910297 Change-Id: Ide4bd6e50c4a4a89f577367d640939efedbb30df Reviewed-on: https://chromium-review.googlesource.com/c/1355776Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612402}
-
Ella Ge authored
This CL adds two metrics for scroll event prediction to help analyse prediction behavior, Scroll.OverPredict and Scroll.UnderPredict. The new metrics only records the y direction difference of prediction result instead of euclidean distance, since y direction scroll is more popular and only record one direction is easier for determine over/under predict. Bug: 836352 Change-Id: I2f83fa5404b02c52f8856dfb64fa0151b7b686d6 Reviewed-on: https://chromium-review.googlesource.com/c/1354314Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#612401}
-
Dale Curtis authored
This is part 2/4 CLs to move the <audio>/<video> elements off of a synchronous API that can lead to renderer hangs and premature audio renderer errors. Specifically this will allow us to create AudioRendererMixerInputs with an authorization timeout of zero when the asynchronous API is the only one in use. BUG=905506 TEST=compiles. R=olka Change-Id: I298550db1e7bac9b73033566c17cff8f1d2252b3 Reviewed-on: https://chromium-review.googlesource.com/c/1347146 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612400}
-
Clark DuVall authored
This fixes the last DRP related browser test in the filter file. Bug: 721403 Change-Id: Id535fb2fea2636770ba567e601b10b3a273fd1fe Reviewed-on: https://chromium-review.googlesource.com/c/1355769Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612399}
-
Sam Maier authored
Bug: 910319 Change-Id: I5fa81395b39d877e68eb8a49a3d4d1ffab016a39 Reviewed-on: https://chromium-review.googlesource.com/c/1355855 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612398}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c3daaa87ec17..5a88d16b87f5 git log c3daaa87ec17..5a88d16b87f5 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 thestig@chromium.org Build pdfium_diff for coverage tests. 2018-11-29 thestig@chromium.org Remove some useless calculations in fxbarcode. 2018-11-29 tsepez@chromium.org Squeeze some more 0s out of wide font names. 2018-11-29 tsepez@chromium.org Squeeze out some 0s from cxfa_node_statics.cpp wide strings. 2018-11-29 thestig@chromium.org Roll third_party/freetype/src/ fb0d66d04..3dd4e76b1 (14 commits) 2018-11-29 thestig@chromium.org Add a pixel test for a CPDF_CMapParser bug. Created with: gclient setdep -r src/third_party/pdfium@5a88d16b87f5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:909762 TBR=dsinclair@chromium.org Change-Id: I144d909b776d173a9c24f2ac29bf0dca3fb80ccb Reviewed-on: https://chromium-review.googlesource.com/c/1355623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612397}
-
Hiroshige Hayashizaki authored
TBR: sdefresne@chromium.org,sebsg@chromium.org Bug: 910216 Change-Id: Ia88cb0d9352ac4867921919d98c019c80f80dee9 Reviewed-on: https://chromium-review.googlesource.com/c/1355778Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#612396}
-
Maks Orlovich authored
... and adjust clients to pass in the proper configuration for that. Rather than using URLRequestContextGetter-based ChromeAsyncSocket, which may not always work right with network service on. Bug: 875032 Change-Id: I3f2c19f35c97d770eb63da94755f9d1d42b58bc9 Reviewed-on: https://chromium-review.googlesource.com/c/1315948Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#612395}
-
Jacob Dufault authored
The base class convoluted the inheritance structure and it is simpler to directly derive from InProcessBrowserTest. Bug: 899777 Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 Reviewed-on: https://chromium-review.googlesource.com/c/1345244 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612394}
-
Carlos Knippschild authored
This CL changes the way zombie prefetch items are expired to be based on an expidation time, 7 days after changing to this state. Before they would be deleted when a new set of suggestions was received which didn't include their URLs. That didn't work well with the way the Feed provides suggestions hence the need for this change. Bug: 841516 Change-Id: I74c53e491cb6442ad71a2d9a275506677fdf813d Reviewed-on: https://chromium-review.googlesource.com/c/1351594 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#612393}
-
Christopher Cameron authored
Adding egregious glFlush calls fixed this issue when GPU Raster was going through the command buffer (in issue 863817). Adding a flush here to see if it will fix the issue. If this does not fix the issue, then the next steps are to * Flush in DoRasterCHROMIUM (far more frequent) to see if that fixes the issue. * Add crash instrumentation to see which commands are being issued when we do crash. Bug: 906453 Change-Id: I7d88ea2d74b52751f641faaf8b848e9a1358a770 Reviewed-on: https://chromium-review.googlesource.com/c/1352508 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612392}
-
Paul Miller authored
$ sed -i s/Feture/Feature/ android_webview/{browser/aw_feature_list_creator.*,lib/aw_main_delegate.cc} BUG=887468 Change-Id: I531c027f857f35d1dda91684dc2a5b56403dc1e2 Reviewed-on: https://chromium-review.googlesource.com/c/1355940Reviewed-by:Tao Bai <michaelbai@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#612391}
-
Yun Liu authored
Add a custom ActivityTestRule for DownloadActivity which can turn off animation scales during tests. Spinner is removed in Download Home V2 Bug: 904030 Change-Id: If00ea1400b17bdbbc49fe2414d0c80a5ec47885b Reviewed-on: https://chromium-review.googlesource.com/c/1278207 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612390}
-
Ken Rockot authored
This deletes all code supporting the deprecated ServiceTest framework and also cleans up a bunch of superfluous dependencies on service stuff around the tree. TBR=sky@chromium.org Bug: 906239 Change-Id: I56db6c5a4c1d0ffab1be5dde08692383c424d5b6 Reviewed-on: https://chromium-review.googlesource.com/c/1354507 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612389}
-
Darren Shen authored
Allows the metric to appear on the dashboard. We're indexing by form factor because virtual keyboard usage depends heavily on the form factor. Bug: 752657 Change-Id: I7d32135c45fee05d86c3ce96b43831cc1ba648e3 Reviewed-on: https://chromium-review.googlesource.com/c/1353043Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#612388}
-
Charlene Yan authored
InkDropGestureHandler is now InkDropEventHandler and handles mouse and gesture events. https://chromium-review.googlesource.com/c/chromium/src/+/1344262 Bug: 910050 Change-Id: Iab91ca41f100cf3d0ba34b54112bc1fecf49406d Reviewed-on: https://chromium-review.googlesource.com/c/1355490Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612387}
-
Jonathan Ross authored
RenderWidgetHostViewMac explicitly sets NeedsBeginFrames upon startup. This was setup to address some race condition. However this is not handled by the browser process when Viz Display Compositor is enabled. DelegatedFrameHost is spamming debug logs with NOTIMPLEMENTED messages as a result. All other paths to this is already checking the Viz status and not calling in. Once Viz has launched we'll remove this legacy path. This change updates RenderWidgetHostViewMac to not explicitly set NeedsBeginFrames upon startup when Viz Display Compositor is enabled. Bug: 907246 Change-Id: I9a584c4bedcdb1da897f8155eb151ff63ef3c8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1355479Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#612386}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8f20452..a972758 BUG=chromium:904265 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6b5a14c70cc6f3324542923b95bf2f1a87b336cc Reviewed-on: https://chromium-review.googlesource.com/c/1355524Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#612385}
-
Marc Treib authored
Not working on chromium anymore, so probably not interested in doing any more code reviews. Bug: none Change-Id: I5dd7adbba724fb9e33803a2a3478d32c9926506f Reviewed-on: https://chromium-review.googlesource.com/c/1355128Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612384}
-
Jonathan Metzman authored
Bug: 906214 Change-Id: I6e8b74c892535143e0d25709e6e170152acaa2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1355337 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612383}
-
Eugene But authored
mahmadi@ made a number of codereviews and direct contributions to this directory. Additionally mahmadi@ is an owner on Autofill on iOS. Bug: None Change-Id: I96e269a06691351376644d0c0e984d597dd7a63a Reviewed-on: https://chromium-review.googlesource.com/c/1354236 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612382}
-
Michael Giuffrida authored
Simple browser test for time limits that signs in a child user, sets a LOCK override, and verifies that the screen becomes locked. Adds test clocks to ScreenTimeController so browser tests can trigger a variety of scenarios in a deterministic way. Follow-up tests should expand on this, adding common test helpers to child_account_test_utils.h. Bug: 895816 Change-Id: Ibbfff2c20cb8829138fad7a94f7db922742d6b56 Reviewed-on: https://chromium-review.googlesource.com/c/1352031 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#612381}
-
Henrique Nakashima authored
AllowStartingServiceManagerOnly already gates starting the service manager early in the native code. Make the Java code check the flag too. Bug: 899225,899226 Change-Id: Iadc7d03b4e3b559815a72de66ff249f2ad36bbbb Reviewed-on: https://chromium-review.googlesource.com/c/1318362Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612380}
-
Avi Drissman authored
In https://codereview.chromium.org/2674002, Google code was put into the third_party/mozilla/NSPasteboard+Utils.h|mm files. This was not imported code from Mozilla and did not belong there. This utility code is moved into a Chromium file (with slight modernization.) The lawyers have approved this. BUG=none TEST=no visible change intended Change-Id: Icf3a91d10d7d52757b7dd220b2703acf3ff45b4d Reviewed-on: https://chromium-review.googlesource.com/c/1355525Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612379}
-