- 18 Sep, 2019 10 commits
-
-
Lily Chen authored
This adds a histogram that logs whether a cookie's SameSite attribute is present, and if so, whether its attribute value is empty, unrecognized, or one of the currently recognized values. Bug: 993120 Change-Id: I4bf3d86cd58e4a60975eee76e192331bcfa51e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803762Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#697415}
-
Matt Simmons authored
Extend the existing impl rather than reimplementing SuggestionsUiDelegate. Bug: 1004609 Change-Id: I6b79967c925be304dcaf93ceb8c65942ce34fecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808787 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697414}
-
Jason Lin authored
Bug: 929571 Test: Turn on flag crostini-webui-installer and install crostini from settings Change-Id: I78895c2a84800d87d4e885e4bc35195d2329db74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798072Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#697413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7fd753567d3c..384489020136 git log 7fd753567d3c..384489020136 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 lamontjones@chromium.org paygen: use image_lib.LoopbackPartitions Created with: gclient setdep -r src/third_party/chromite@384489020136 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I511d73776128c1edf247afdebc101eb2d8851ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697412}
-
Daniel Rubery authored
For WebProtect real time reporting, we would prefer to report dangerous downloads when the warning is seen, and when the warning is dismissed, rather than when the file is opened from within Chrome. This CL adds real time events for dangerous download warnings seen and bypassed, and removes the events for dangerous downloads opened. Bug: 1002976 Change-Id: Ic736390bf8db5fb88bc2b2b68ce824c09d159b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802524 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697411}
-
Hirokazu Honda authored
We set mb_skip_coeff and loop_filter_adj_enable to 1 in crrev.com/c/1773662. They are mainly for a workaround that some decoders shows artifacts with the VP8 stream produced by an intel encoder. After some investigations, it turns out they are a proper fix. This CL updates the reasons in the comment why those parameters are set to 1. no artifact is there Bug: b:139766881, b:138840822 Test: decode VP8 stream produced by Intel encoder on eve and atlas, and confirm Change-Id: I6e4e4425edfd59e9be70680c32786d5a95aa9d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792219Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697410}
-
Lei Zhang authored
Add browser tests to make sure PdfNupConverterClient works as expected: - 2-up conversion for a 3 page document generates 2 page output. - 4-up conversion for a 3 page document generates 1 page output. - Garbage data input results in a conversion error. Bug: 1004529 Change-Id: Ie31397dc0b9eb9d098763de3395f99bf69846889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808581 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697409}
-
ssid authored
The threads after startup tracing is cancelled should write to trace writer created by perfetto producer instead of startup registry. This can be done by incrementing the session id when cancelling startup registry. BUG=993799 Change-Id: Ib2ad173a788dd4fe6d3fb563b761c5bc12549fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809918 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#697408}
-
Collin Baker authored
Bug: 1003122 Change-Id: Ic1301579a3eff6a418bf5a8c3cea7d3938fd5085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809411 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#697407}
-
Khushal authored
Make fuzzers happy. R=ericrk@chromium.org Bug: 1001916 Change-Id: I7b0c32848f321171407b9e4fdf6d6cb5cfb0ca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803959 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697406}
-
- 17 Sep, 2019 30 commits
-
-
Kyle Milka authored
This was caused by https://crrev.com/c/1805253. Bug: 1004696 Change-Id: I848d28e0ddb4f6ea1ab1cd7eb9df554832f3479e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809401 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#697405}
-
Dirk Pranke authored
Previously run_web_tests implemented an overly simplistic variant of the test runner api documented in bit.ly/chromium-test-runner-api, in that it only supported a single occurrence of the flag, it didn't support negative (skip) filters, and it implemented it as if you had just listed the globs as positional arguments instead. This CL implements the full semantics of the flag, so that you can specify the arg multiple times, and negative (skip) filters work correctly. This is a non-backwards-compatible change, because it changes things such that we first filter by positional arguments and *then* apply the filters from --isolated-script-test-filter. However, it seems unlikely that anyone is using the combination of the two and so hopefully this will not break things. If it does, we'll need to update callers. BUG=994943 Change-Id: I7cc10c92364e145e84f3750f0c773b8ab9d371f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790432Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697404}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/368d002e489e..86314cfb5dc0 git log 368d002e489e..86314cfb5dc0 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 srte@webrtc.org Cleaning up C++14 move into lambda TODOs. Created with: gclient setdep -r src/third_party/webrtc@86314cfb5dc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2e041559aa675ae9d6551b663636c7c58862ae43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697403}
-
Eric Roman authored
Bug: 1004516 Change-Id: I5c489ce94d9bea9d7b16fd8954008a28f7ddb8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808116Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697402}
-
Matt Jones authored
With the growing number of bottom sheet users, it no longer makes sense to initialize it based on a list of feature flags. Instead, the bottom sheet is initialized the first time someone queries for the controller. Bug: 986310, 1002277 Change-Id: I61e68a1a89c98f72bfa9ef5e9d75cf6172cd51cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808180Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697401}
-
Brian Sheedy authored
Switches latency_perftests to use PerfResultReporter instead of PrintResult and whitelists it for conversion to histograms before uploading to the perf dashboard. Shouldn't affect anything on the bots since these tests seem to currently only be used for local testing. Bug: 923564 Change-Id: I0386ad93c65e6bb79928f0f9c4fe4a2d27d9716e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793790Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#697400}
-
Marialicia Villarreal Garcia authored
This fix is needed to make touch work in the browser frame when a screen reader is on. It consists in two main parts: 1. Apply the scale factor to the hit point received after touching any element in the frame. 2. Add unit tests for the scale factor. Bug: 990560 Change-Id: I00c3cd4de4ea49e8e8f881eb1db17c6a649b873c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796888 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697399}
-
David Bienvenu authored
These will be used to register the file extensions the PWA handles in the Windows registry, and set up the shim app, when a PWA is installed, once the Windows-specific code is implemented. Bug: 960245 Change-Id: Id6142b59277c60cb72204c37f086f4df3c0ffb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797024 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#697398}
-
Nico Weber authored
Revert "win: Pass /libpath: on Windows too, and use /lldignoreenv to make lld ignore the %LIB% env var." This reverts commit 1a693093. Reason for revert: Apparently breaks cross builds: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/yhbrbPU0yLQ Original change's description: > win: Pass /libpath: on Windows too, and use /lldignoreenv to make lld ignore the %LIB% env var. > > See https://reviews.llvm.org/D67456 > > Makes the build a bit more hermetic, and should have no behavior change. > > Bug: none > Change-Id: I90080aa7f8ec814e6ec9b1a4fbcad464e12a450d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807154 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697369} TBR=thakis@chromium.org,rnk@chromium.org Change-Id: Idccc2a0bd54f6543734bf6f24a5cd73bbe0295d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808036Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697397}
-
Kyle Milka authored
Use CachedMetrics to prevent a crash when notifications are clicked before the native code is loaded. Bug: 994438 Change-Id: Iabe6dffc10c66c719b4af65dea68abfd374e5e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809544Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#697396}
-
jonross authored
A few new tests in vulkan_pixel_skia_gold_test have begun failing. Though they are only failing on Intel, not NVidia. TBR=ynovikov@chromium.org NOTRY=true TEST=vulkan_pixel_skia_gold_test Pixel_Canvas2DRedBox Pixel_Canvas2DTabSwitch Pixel_WebGLGreenTriangle_AA_Alpha Pixel_WebGLGreenTriangle_AA_NoAlpha Pixel_WebGLGreenTriangle_NoAA_NoAlpha Bug: 1004837, 1004840 Change-Id: I1f716568e40f89e77c484f3f40c92533b16f9842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808810 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697395}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I4d835faab274c7d2fb726b96458f0380a1a3a5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808804 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697394}
-
Caroline Rising authored
Bug: 984115 Change-Id: Ia41c894f47b2ca1ed130704c96ddbae8f1335bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807793 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#697393}
-
jonross authored
We originally disabled this test on Vulkan due to failures on Intel. However it seems to have been fixed since. Patchset 3 ran the test 100 times without failures. Let's try to re-enable it. Originally disabled here: https://chromium-review.googlesource.com/c/chromium/src/+/1801053 TBR=jam@chromium.org TEST=SnapshotBrowserTest.AsyncMultiWindowTest Bug: 1003375 Change-Id: I74d9002a42de8e1b638d52efa97a2ec9915ab6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808594Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#697392}
-
John Budorick authored
For use in crrev.com/c/1803434 Bug: 976218 Change-Id: Ia0a3cae9bf386a2d279b42b1e0aae622e90b0fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809501Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#697391}
-
Sam Maier authored
Bug: 1003433 Change-Id: Ia9269aa8c8bcf2aad69c57fa5746d9e26c21cc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802391Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#697390}
-
Andrew Luo authored
Change-Id: I25ecb9da049bb69f3f19c325a102d14eaaa438a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799314Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697389}
-
Tiancong Wang authored
This is one of the efforts to move AFDO-related stuff from Chrome OS ebuild to Chromium tree. This patch adds three files to specify latest profile for each architecture. The files will be updated by skia autoroller. Add calls to download the profiles to DEPS file. Bug: chromium:1001227 Test: gclient sync Change-Id: I4d5fecf6089a8f43b0c3a5b030e8e8daa9ca9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809664Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#697388}
-
Jamie Walch authored
We've had some reports that killall cannot locate the host process if it is specified by name, which might explain why some users are still running old versions of the host. This CL specifies the full binary path instead, which is more reliable. It also removes a TODO that's no longer relevant. Change-Id: I50611ed43431a6790010c66d90ddfd05a3519789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808488Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#697387}
-
Jérôme Lebel authored
Adding into ios/third_party/material_components_ios/BUILD.gn: - src/components/private/Color/src/UIColor+MaterialBlending.h - src/components/private/Color/src/UIColor+MaterialBlending.m Bug: 1004348 Change-Id: I6cf8ef9317fd61ca9bb0cf47e391ffb3df471279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808868 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#697386}
-
Fabrice de Gans-Riberi authored
This is a reland of bbd8d150, now that the peer-component's implementation of the UrlRequestRewriteRulesProvider works correctly. Original change's description: > [fuchsia] Handle UrlRequestRewriteRulesProvider in CastRunner. > > * Implement handling of the > chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner. > * Remove handling of the fuchsia.web.AdditionalHeadersProvider API in > CastRunner as it is deprecated. > * Adapt the integration test to use the new API. > > Bug: 976975 > Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695766} TBR=fdegans Bug: 976975 Change-Id: Iac657c5431056f94744767506432956eb09cfdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809808Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#697385}
-
Joel Hockey authored
Note, this should only be submitted once tremplin changes in crrev.com/c/1795682 are in prod. Bug: 995649 Change-Id: I8306d67ceca64f2c54a6e85af94fc1c14724bff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797510Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697384}
-
Andrew Grieve authored
Reland "Disable monochrome_public_apk when !public_android_sdk. Add @CheckDiscard to LifetimeAssert" This reverts commit f15999f7. Reason for reland: Missed one dep (fixed in PS2) > > The APK when built in this mode is not configured correctly since > > system_webview_apk does not exist when !public_android_sdk. TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,smaier@chromium.org Bug: 1000763 Change-Id: I8147cc85cc8efbc147a72e829d45f2dc990be666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808112 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697383}
-
Henrique Nakashima authored
This is an identical reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1774268 Extra deps in clank/javatests will fix the build error that caused the revert: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1804387/ TBR=dtrainor@chromium.org,twellington@chromium.org Bug: 995916,1004913 Change-Id: I99b48aae909cbda69b10786faf4ffe1cbc42d0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809782Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697382}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b18323b096a7..7fd753567d3c git log b18323b096a7..7fd753567d3c --date=short --no-merges --format='%ad %ae %s' 2019-09-17 mmortensen@google.com Update generated proto api for sysroot_pb2.py and test_pb2.py . 2019-09-17 tcwang@google.com afdo: Fix a bug that to check existing profiles in Chrome verification builder. Created with: gclient setdep -r src/third_party/chromite@7fd753567d3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic34066a484bf207564361650667f3d8a250bf8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697381}
-
jonross authored
We had duplicate expectations in use-vulkan=native and enable-gpu-rsterization. This removes the duplicates, and has vulkan_native_blink_web_tests use the additional expectation file. This also re-enables some tests which have since been fixed. TEST=vulkan_native_blink_web_tests Bug: 972096, 978628 Change-Id: I0a354b1e0dd911b4a6912e2d6e685738e4e034af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804377Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#697380}
-
wutao authored
Previous result sorting was based on score only, therefore it could happen that the results with specified location are sorted at the end of the results list in the provider group and is truncated. This patch modifies the sorting criteria to include the result display index as well to ensure those results will be at the beginning of the sorted results and return to the UI. Bug: 1003471 Test: new unittest MixerTest.ResultsWithDisplayIndex Change-Id: I3a5d57b55ac2b08a3b00a8f3d89b87b51a41be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808705 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697379}
-
Willie Koomson authored
This change, in preparation for addition of crostini throttling, moves the ArcThrottleObserver class to chrome/browser/chromeos/ and renames it (and all usages) to ThrottleObserver. This is because the class is no longer ARC++-specific. Additionally, moves WindowThrottleObserverBase to chrome/browser/chromeos/ Bug: 997397 Test: Run unit tests of affected classes (ArcInstanceThrottle,ThrottleObserver,ArcActiveWindowThrottleObserver,ArcBootPhaseThrottleObserver) Change-Id: Ib3a7cc82d77d120149a90c7b3ca8559ce8b84ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809780 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697378}
-
Anushruth authored
This reverts commit cd4d366b. Reason for revert: Compile failure. See crbug.com/1004964 for details Original change's description: > Convert SimpleURLLoader to use mojom types. > > This CL Converts the SimpleURLLoader to use the mojom URLResponseHead > struct instead of the native ResourceResponseHead struct. > > Change-Id: I016b0731930b4589ba6169aa2e24ad45dc6675cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790273 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Charles . <charleszhao@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697317} TBR=avi@chromium.org,hashimoto@chromium.org,kinuko@chromium.org,khorimoto@chromium.org,rkaplow@chromium.org,dtrainor@chromium.org,hajimehoshi@chromium.org,mmenke@chromium.org,sorin@chromium.org,tbansal@chromium.org,zmin@chromium.org,danyao@chromium.org,bsazonov@chromium.org,lfg@chromium.org,charleszhao@chromium.org Change-Id: Ibdbe0af4cd38b0a09954c81c989f9f3a3afe8e70 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809099Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#697377}
-
Sammie Quon authored
1) Remove extra PositionWindows call when rotated since SetBoundsAndUpdatePositions calls it already. 2) Allow SetBoundsAndUpdatePositions to not animate and use no animation when rotation. 3) Pause the occlusion tracker when rotating. Ash.Rotation.Smoothness has around 70~80 before, 80~90 after. always using 8 windows and NTP page Test: interactive_ui_tests ScreenRotationTest.RotateInTabletOverview, Bug: 1004820 Change-Id: Ie7bb137185d34ceb1b0c0e42f7aba021a673ecee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809502 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697376}
-