- 14 Oct, 2019 40 commits
-
-
Sergey Kuznetsov authored
https://chromium-review.googlesource.com/c/chromium/src/+/1658231 is't enough for arm64, because __NR_membarrier (which code is 283) is greater than MAX_PUBLIC_SYSCALL (which is 279) -> rules was not applied. Increase MAX_PUBLIC_SYSCALL && add test. Bug: 966433. Change-Id: I99ed038dea7b2a332dd70fb75b97d908f5d2ca9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856160 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705572}
-
edchin authored
This CL adds |-willCloseAllWebStates()| and |-didCloseAllWebStates()| to the WebStateListObserver. This allows observers to know when CloseAll has been called. This gives observers ability to batch process operations instead of processing each close individually. This CL will be quickly followed up with the first use case -- RecentTabs. In RecentTabs, the close all operation should be batched instead of being processed one at a time, which causes a UI freeze. Bug: 994229 Change-Id: I9dd47786c508409690e4a753593505d5da71d11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854463 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705571}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be6f2ffa0faf..50dc0de928ba git log be6f2ffa0faf..50dc0de928ba --date=short --no-merges --format='%ad %ae %s' 2019-10-14 hjd@google.com Merge changes Iebde5f76,I8e5b4e64,I21d2b89e Created with: gclient setdep -r src/third_party/perfetto@50dc0de928ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6ad7fae0f12761c6629a36f98b3fb1760e797d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705570}
-
Thomas Tangl authored
... to the regular and the guest profile menu. Bug: 995720 Change-Id: I3fc6e47dce135e42b5861ed593a65ba81cde1a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859991Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#705569}
-
Raymond Toy authored
To facilitate optimizations for the delay node processing, split out the sample-accurate path and non-sample-accurate path into independent bits of code (mostly duplicated now). Then we can look at optimizing each path independently. No functional changes. Bug: 1012198 Change-Id: I6170aaa3a6c0dfc7ecf96c20963a4edcdac8a920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856725Reviewed-by:
Andrew MacPherson <andrew.macpherson@soundtrap.com> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705568}
-
Rune Lillesveen authored
Bug: 680331 Change-Id: I0ac853b95d453221cdc62517ef201858c55e0696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859785Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705567}
-
Deepanjan Roy authored
- Adds a directory under tools/perf/core where all the tbmv3 code will be landed as we're experimenting with them. - Adds a very basic run_tbmv3_metric script. Currently it consumes the output of trace processor and prints it back to the terminal. In subsequent CLs we will turn this output into a python histogram and output that instead. - Adds console_error_metric as an example tbmv3 metric. You can run it using ./run_tbmv3_metric.py --trace TRACE_FILE --metric console_error_metric Bug: chromium:1012687 Change-Id: I668268e707ae633b271256125e8a6d78701906f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846065 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#705566}
-
Juan Antonio Navarro Perez authored
These benchmarks no longer work as intended. These have been superceeded by gcMetric at: https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/blink/gc_metric.html Bug: 1011787 Change-Id: I6f20d4df4491de5c611fb9ff3376d68029c5feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859963Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#705565}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c834ea5451c..9bc8545214f9 git log 1c834ea5451c..9bc8545214f9 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 wbbradley@chromium.org build api metrics: ingest metrics from build_image Created with: gclient setdep -r src/third_party/chromite@9bc8545214f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If34f7b10df19f0eaa426dc16c88270d2a934a7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860134Reviewed-by:
-
Mikhail Khokhlov authored
This is a reland of [1] with file paths in tests fixed for windows platform. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1849855 Bug: 981349 Change-Id: Ie52c40573f47a30363b3bae3db0ad5052115c1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857131Reviewed-by:
-
Amr Aboelkher authored
A device policy which controls the full-screen and docked magnifier accessibility features on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_screen_magnifier_enabled policy to 1, open System Tray => "Accessibility", check that "Fullscreen magnifier" is displayed with a green check in the login screen, and "Docked magnifier" is not displayed in the login screen. 2. Set the login_screen_screen_magnifier_enabled policy to 2, open System Tray => "Accessibility", check that "Docked magnifier" is displayed with a green check in the login screen, and "Fullscreen magnifier" is not displayed in the login screen. 3. Set the policy to 0, open System Tray, check that "Docked magnifier", and "Fullscreen magnifier" are not displayed in the login screen. Bug: 552439 Change-Id: I0f736f3c2c2410d8e281d03f61e3fb85e6ea4619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859981 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705562}
-
Philip Rogers authored
Previously, "transform: translateZ(0)" was used as a compositing trigger in web tests. This patch updates these cases to use "will-change: transform" which is more explicit. Bug: 1012775 Change-Id: I35cccc654da8df868ce54e0d4e4ad9e1551b1552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854168 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705561}
-
Jochen Eisinger authored
Looks like the helper was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1640718 Bug: 934009 Change-Id: I04ea55f0b550d0d5ff80af5b913ad7ce073377dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859978 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#705560}
-
Ben Pastene authored
Those rotations were moved to internal configs a while ago, so milo/rotang can't see who's oncall. So they've been listed as 'none' for a while now. Also remove the 'chromiumos' header, which nothing in this file uses. Change-Id: I60282240593acfc24eae3662cfe3929ec45ace66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857097Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#705559}
-
nancy authored
When ArcAppListPrefs is destroyed, ExtensionApps doesn't clear the arc_prefs_. So ExtensionApps still calls arc_prefs_ to remove itself from the observer list, which could cause the memory issue, when ArcAppListPrefs is deleted first. Update ArcAppListPrefs to notify the observer, ExtensionApps, when ArcAppListPrefs is destroyed. Note: ExtensionApps doesn't depend on ArcAppListPrefs, becuase even if no ARC on the Chrome OS, ExtensionApps still exists. BUG=1013850 Change-Id: I389e7b7c2d4e11a5af7f927a1595f75d7b2cc1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857840 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705558}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/5843bfd65204..f76cf2ae5e7a $ git log 5843bfd65..f76cf2ae5 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 wub gfe-relnote: Implement QUIC MTU discovery v2. Protected by --gfe2_reloadable_flag_quic_mtu_discovery_v2. 2019-10-11 bnc Make QpackDecoderStreamSender buffer serialized instructions. 2019-10-11 rch Rename QuicSpdySession::SendMaxHeaderListSize() to QuicSpdySession::SendInitialData(). Make this method private and use max_inbound_header_list_size_ explicitly instead of requiring it to be passed in by the caller. 2019-10-11 rch Improve QuicSpdyStreamTest to call OnCryptoHandshakeEvent on the session to ensure that the various HTTP/3 initialization steps happen, matching what happens in production. 2019-10-11 vasilvv Create a shared interface to access QuicTransport*Session::IsSessionReady(). 2019-10-11 vasilvv Implement the QuicTransport server session subclass. 2019-10-10 rch Disable EndToEndTestServerPush.ServerPushOverLimitNonBlocking when http/3 is used Flip the chrome value for v99 to true Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: Idfc9ef147b5115a5ca2511b6180018f4f9205074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859494Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#705557}
-
Asanka Herath authored
While //net's header parser will reject strings with embedded NULs, HttpCHttpContentDisposition can be invoked directly on some arbitrary string. It should handle NULs gracefully in this case. Bug: None Change-Id: I31b7a89d27ebc01d8311d5fde156672d974543e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857520Reviewed-by:
-
Tommy Steimel authored
This reverts commit c8281a39. Reason for revert: compile failing on many bots. Example: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/80546 Original change's description: > Include bloat: don't include browser_process_platform_part.h in browser_process.h > > Avoiding this include reduces the number of preprocessor tokens in > browser_process.h from 1,336,923 to 359,170. > > TBR=antrim > > Bug: 1014009 > Change-Id: Icc613c2889a6ca5fd5dd4b55a6bdd6b2772bcd4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856965 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705554} TBR=antrim@chromium.org,thakis@chromium.org,hans@chromium.org Change-Id: I5cb9d9c669bd7bf991a6eac0a24fca9076fb3d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860277Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705555}
-
Hans Wennborg authored
Avoiding this include reduces the number of preprocessor tokens in browser_process.h from 1,336,923 to 359,170. TBR=antrim Bug: 1014009 Change-Id: Icc613c2889a6ca5fd5dd4b55a6bdd6b2772bcd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856965 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705554}
-
Oleh Lamzin authored
Add comment to the ApplyUsbEthernetMacAddressSourceToShill function if MAC address source is not specified yet. BUG=b:132240657 TEST=none Change-Id: I086eacbaeed7ddaf1b3ea4d9568b8cf78210be7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849857Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#705553}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34e434df0d7..a4828a13c27a git log c34e434df0d7..a4828a13c27a --date=short --no-merges --format='%ad %ae %s' 2019-10-14 egdaniel@google.com Remove GrPixelConfigIsAlphaOnly call and transition calls to it. 2019-10-14 robertphillips@google.com Plumb GrPrimitiveType down to GrProgramDesc::Build Created with: gclient setdep -r src/third_party/skia@a4828a13c27a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Ia8ed9bf3914dbc6ca819311d1d1d45620cfd7ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859943Reviewed-by:
-
Francois Doray authored
This was reverted because of navigation failure on Android Kit Kat in IndexedDBExecutionContextConnectionTrackerBrowserTest* (https://crbug.com/1014015). Since the purpose of these tests is to test usage of IndexedDB connections, not navigation, this reland disables them on Android Kit Kat until we find a way to make navigation work. Original CL: https://crrev.com/c/chromium/src/+/1848794 Diff from original CL: https://crrev.com/c/chromium/src/+/1860094/1..4 With this CL, content::LockObserver is notified when the number of IndexedDB connections (active or pending) in a frame switches between zero and non-zero. The information is plumbed to the Performance Manager which uses it to avoid freezing pages with IndexedDB connections. This is because freezing a page with active IndexedDB connections can prevent other pages from performing IndexedDB operations. In the future, we would like to get more granular information about when it is really problematic to freeze a frame because of its current usage of IndexedDB, but this is a good first step to allow shipping page freezing without breaking usage of IndexedDB. More details at https://docs.google.com/document/d/1CUE1pfS5pGhJt6X0EKwv2sQYP5PcdzyGZKKtdBYzEOw/edit?usp=sharing TBR=kinuko@chromium.org,dmurph@chromium.org,siggi@chromium.org Bug: 980533, 1014015 Change-Id: I0a63e86af88a2e5ee306c33b8df00e7f7817d814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860094Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#705551}
-
dalyk authored
This change is a no-op. It puts into place the needed support in net/socket for disabling DoH and pipes the disable_secure_dns field to the host resolver. A follow-up cl will add handling of a similar field in net/quic, net/spdy, and net/http. Change-Id: I8bee0f5523dc6a70e26b3f7fa195d959306e9594 Bug: 1012268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842563 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c7af59115ee3..0b3653782e33 git log c7af59115ee3..0b3653782e33 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 khokhlov@google.com [Telemetry] Save measurements as dict Created with: gclient setdep -r src/third_party/catapult@0b3653782e33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:999484 Change-Id: Icbb79b0f0d6da7c671fd41f439b13dcadca089c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859942Reviewed-by:
-
Tom Anderson authored
R=sky Change-Id: If5ff32465c9261b8d0a1e9b7ca839bfacff50b15 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859937 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#705548}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6529b908a53e..be6f2ffa0faf git log 6529b908a53e..be6f2ffa0faf --date=short --no-merges --format='%ad %ae %s' 2019-10-14 fmayer@google.com Merge "Add profileable app to heapprofd CTS." Created with: gclient setdep -r src/third_party/perfetto@be6f2ffa0faf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: If0a0f8b75da0082913f8c6abd703e1229481b0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859945Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9e64afcb91f7..b6acae6d353d git log 9e64afcb91f7..b6acae6d353d --date=short --no-merges --format='%ad %ae %s' 2019-10-14 cwallez@chromium.org Suppress BufferUploadPerf for setSubData of 16MB on Vulkan 2019-10-11 cwallez@chromium.org Vulkan: Properly handle errors for fences and commands 2019-10-11 cwallez@chromium.org Vulkan: Proper error handling for submission. 2019-10-11 cwallez@chromium.org Vulkan: Handle errors when creating VkRenderPass 2019-10-10 bryan.bernhart@intel.com BufferUploadPerf: Measure various buffer sizes. 2019-10-10 rafael.cintron@microsoft.com Add CommandRecordingContext to D3D12 2019-10-10 cwallez@chromium.org Make the offset of SetIndexBuffer default to 0 Created with: gclient setdep -r src/third_party/dawn@b6acae6d353d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I463353be99d696810be76baaa148822fe01f2ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859944Reviewed-by:
-
Henrik Boström authored
This is the same as CL https://chromium-review.googlesource.com/c/chromium/tools/build/+/1798122 but for the codepath executed by RunsOneWayCall60SecsAndLogsInternalMetricsDefault and other tests. Bug: 999136 Change-Id: Ib2000128c983f57c65abfba68bdff4bbe3febcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860018Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705545}
-
Thomas Tangl authored
- Move all incognito code to incognito_menu_view.cc (to avoid special casing for ChromeOS) - Add "Exit incognito" button - Re-enable browser tests Bug: 995720 Change-Id: I55674e9192065d4a185b712af391a56fdc56095a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859962Reviewed-by:
-
Michael Lippautz authored
https://crrev.com/695748 introduced an issue as the refactoring missed out on preserving a crucial null check for already destructed nodes. The problem is that we create a fast path by checking for whether a node is initialized already outside of the lock but forgot to recheck after we entered again. The check is put in FreeNode() to avoid repeated atomic loads. Bug: 1013915 Change-Id: Iffa5b982791ac8d239650499bcab355a3e2fa5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860022Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705543}
-
Clemens Arbesser authored
This CL adds support for additional user data form sections that can be configured from the backend. The additional sections are shown either above or below the set of existing sections. Two types of sections are supported: static text and text input sections. For text input sections, the result is stored in client memory, which in turn can be used in a subsequent SetFormFieldValue action. This CL also adds a usability improvement: while the soft keyboard is shown (which pushes the bottom shelf up), the close button on the shelf will close the keyboard instead of immediately closing autofill assistant. Finally, support for italic text spans is added to text sent from the backend. Bug: b/142113908 Change-Id: I8bd3758a33b1039b44c7bca5f8dabdfec05723ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840637 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#705542}
-
Arthur Hemery authored
With the recent addition of infinite bfcache storage for tests, we have two extra regressions on Linux that need to be filtered out. Change-Id: Id329c4fcd25e623d82c8dafac4df4678bbf79d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859956Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705541}
-
Hans Wennborg authored
This is a reland of 7196b2e0, plus a fix to cookie_controls_handler.cc. Original change's description: > Include bloat: reduce number of includes in profile.h > > This reduces the number of preprocessor tokens in profile.h from > 1,455,853 to 586,241 (or from 8,594,906 to 3,254,002 bytes). > > Bug: 1014009 > Change-Id: Ia52ef458f78b2e7c0fdfe341cd4e753be70eccb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857323 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705529} TBR=thakis Bug: 1014009 Change-Id: I025801140c505037ab5420e7a42db8b1c388cfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860021Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#705540}
-
Marc Treib authored
The flags "autofill-always-show-server-cards-in-sync-transport" and "fcm-invalidations" were already removed, so just remove the metadata entries as well. The flags "enable-sync-uss-nigori" and "enable-sync-uss-passwords" are still needed, so extend them to M80 for now. Bug: none Change-Id: I85e28c4d961d1b5ff0416be964714c880d22c26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859957 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705539}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f0640c4401d3..c7af59115ee3 git log f0640c4401d3..c7af59115ee3 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 dberris@chromium.org Implement performance bisection task+evaluators Created with: gclient setdep -r src/third_party/catapult@c7af59115ee3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:988912 Change-Id: I3f168e5070236a8a1f5a495a775588022d59bd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859874Reviewed-by:
-
Sigurd Schneider authored
This CL adds a simple exponential back-off & retry strategy to the inspector's loadNetworkResource method. A retry is only attempted if the load failed with net::ERR_INSUFFICIENT_RESOURCES. Retrying ensures that the kMaxOutstandingRequestsPerProcess limit in the network component does not cause load failures to the front-end. Before this CL, bursty loads from the DevTools front-end, such as they occur during fetching of source maps for large webpages, could result in load failures of source maps, when in reality the problem was that too many source maps where loaded at once. The initial back-off delay was chosen to be 250ms, as the intention is to give the network stack some time to finish outstanding requests, which are expected to take some time if there are so many of them that the request limit triggers. The back-off delay is 250ms*1.3^n and retrying is aborted when the delay exceeds 10s (14 tries in total). Bug: chromium:1013124 Change-Id: I2759cfa035fc3952d960d43958536d5e9df613b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852212 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705537}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ffbe4873. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I7e4c44d798824e7e18ce1e8d575a91b5f6d2ec6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859835Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705536}
-
Oleg Davydov authored
Historically InstallationTracker was made to get a broad picture of what happens with force-installed extensions. So case "policy changed shortly after login so extension was not installed because it is not needed more" was ignored as something that happens rare. This CL support that case too. Note that if policy changed shortly after login, we still ignore new extensions. We do this intentionally: for such a new extension we may want to know "whether it is installed five minutes after it appear in policy", not "five minutes after login". Bug: 981891 Change-Id: If700a222d43504092bad8fb69f811fad0d54fd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853404 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705535}
-
Juan Antonio Navarro Perez authored
Add an integration tests for benchmark running and results processing. This includes writing traces and running metrics on them. The test can also serve as an example for writing other integration tests (e.g. for ad hoc measurements). This test is intended to replace the existing testTBM2ForSmoke: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py?rcl=0b1af463167af25923a31dd190b41a32841e05fe&l=99 Note: depends on landing first https://chromium-review.googlesource.com/c/catapult/+/1847392 Bug: 1012227 Change-Id: I784a0e08a495f3489e46ac4c8b9e83857ff8cc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847340 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#705534}
-
Morten Stenshorne authored
We need to report unbreakable block-size from the column layout algorithm, in cases where we have nested column balancing. Set up the fragment builder to be block-fragmented when inside a nested multicol that performs the initial column balancing pass, so that spanners report unbreakability (happens automatically via NGBoxFragmentBuilder::AddResult(), when set up correctly). When we fall back to legacy layout, we also need to set up the builder so that we report unbreakable block-size rather than space shortage (those two share data storage). We don't actually have to report any size, though, (0 is fine) since this is always monolithic content, which is taken care of by the parent algorithm (BreakBeforeChildIfNeeded() in NGBlockLayoutAlgorithm). Bug: 829028, 1013716 Change-Id: Ib507cbedbacf2ed05c1db5a58f7738c070f3ab79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859786Reviewed-by:
-
