GitLab

- Refactor PartialScreenshotEventFiler so that it can be reused, and renamed it to OverlayEventFilter
- Use OverlayEventFilter for the keyboard overlay

BUG=129834
TEST=Manually check accelerators do not work when the keyboard overlay.


Review URL: https://chromiumcodereview.appspot.com/10825026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148504 0039d316-1c4b-4281-b951-d872f2087c98

They would get dropped by the recipients anyway.

BUG=138893
TEST=


Review URL: https://chromiumcodereview.appspot.com/10830023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106072
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148502 0039d316-1c4b-4281-b951-d872f2087c98

xkeyboard_data.h is no longer necessary.

BUG=None
TEST=The scripts runs as before


Review URL: https://chromiumcodereview.appspot.com/10823020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129016
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10827021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138347

Review URL: https://chromiumcodereview.appspot.com/10831014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135254
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10817016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148498 0039d316-1c4b-4281-b951-d872f2087c98

This CL is the part 1 (of 2) for fixing 138512.
Makes file uploder to refer to the actual size of the cache
file, not the possibly out-of-sync metadata in GDataEntry.

BUG=138512
TEST=UpdateFileByResourceId_PersistentFile
TEST=Manual:
- edit a file by photo editor and save as a different file.
- verify the full content of the edited file is upload even if feed update intervenes.


Review URL: https://chromiumcodereview.appspot.com/10832002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148497 0039d316-1c4b-4281-b951-d872f2087c98

Sort of. SendNotification() is still there. Perhaps we want to split the interfaces completely.

BUG=124149
TEST=tests should still pass, no observable behavior change
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147801

Review URL: https://chromiumcodereview.appspot.com/10702074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137131

TEST=


Review URL: https://chromiumcodereview.appspot.com/10808115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148493 0039d316-1c4b-4281-b951-d872f2087c98

The problem is dialog passes file's local cache path in 
FileSelected. Last selected directory paths get set to cache 
dir, which file manager does not understand, so it opens 
default dir. In order to properly remember last selected 
dir, we should also pass file's drive path to dialog 
listeners and use it to remember last selected dir. 


BUG=126923
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10804026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148492 0039d316-1c4b-4281-b951-d872f2087c98

Pixel test baselines have now been updated for new checkbox style.

BUG=125773
TEST=

Review URL: https://chromiumcodereview.appspot.com/10827027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148491 0039d316-1c4b-4281-b951-d872f2087c98

runtime.onSuspendCanceled() is sent after runtime.onSuspend() to indicate that
the extension / app will not be suspended after all.


BUG=136469


Review URL: https://chromiumcodereview.appspot.com/10804020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148490 0039d316-1c4b-4281-b951-d872f2087c98

mac-release-10.6/intl1/times: http://build.chromium.org/f/chromium/perf/mac-release-10.6/intl1/report.html?history=250&rev=148450

TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/10830030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148489 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148488 0039d316-1c4b-4281-b951-d872f2087c98

functions.

R=eroman, jar, sky

Review URL: https://chromiumcodereview.appspot.com/10827026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148487 0039d316-1c4b-4281-b951-d872f2087c98

Fix a typo in the Chrome string; unify the language across Chrome and
Chromium, and say what error specifically people should fix (their broken
clock, not just "any error" or "the error").

Review URL: https://chromiumcodereview.appspot.com/10818033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138959
TEST=

Review URL: https://chromiumcodereview.appspot.com/10821014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148485 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137264
TBR=viettrungluu
Review URL: https://chromiumcodereview.appspot.com/10824029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148484 0039d316-1c4b-4281-b951-d872f2087c98

Adds two new methods: AlignedAlloc and AlignedFree for creating and
destroying dynamic aligned allocations respectively.  Also adds a
helper class, ScopedPtrAlignedFree, for use with scoped_ptr_malloc.

AlignedAlloc uses posix_memalign for OS X (now that we're targeting
10.6), Linux and _aligned_alloc() on Windows.  Android and NaCl use
memalign() since they do not expose posix_memalign() and memalign()
is safe to use with free() on those platforms.

Also hacks around a bug in Visual C++ where __alignof will sometimes
return zero:
http://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types

BUG=none
TEST=base_unittests + new test, trybots.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147988

Review URL: https://chromiumcodereview.appspot.com/10796020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148483 0039d316-1c4b-4281-b951-d872f2087c98

if Pygments isn't installed, and escape HTML (especially obvious with generics)
when syntax highlighting is turned off.


Review URL: https://chromiumcodereview.appspot.com/10833024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148482 0039d316-1c4b-4281-b951-d872f2087c98

Add droppedFrameCount, totalPaintTime, and totalRasterizeTime to chrome.gpuBenchmarking.renderingStats().


BUG=chromium:130790, chromium:137756
TEST=Launch Chrome with --enable-gpu-benchmarking and per-tile painting, open a tab to a composited page, and type chrome.gpuBenchmarking.renderingStats(). All the above fields should be present.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148413

Review URL: https://chromiumcodereview.appspot.com/10823023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148481 0039d316-1c4b-4281-b951-d872f2087c98

Before, the compiler raised an exception when a function was used as a property,
which happens whenever a function is passed as a parameter.

The solution presented here is to create a bool has_<function_name> to allow
the hand-written C++ code to know whether or not the function was passed in.

BUG=138850
TEST=function_as_parameter


Review URL: https://chromiumcodereview.appspot.com/10824002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136962
TEST=this runs through most of the input file displaying lots of pretty frames before segfaulting in the SEC-OMX library: DISPLAY=:0 ./Debug/omx_video_decode_accelerator_unittest  --gtest_filter=DecodeVariations/VideoDecodeAcceleratorTest.TestSimpleDecode/0 --test_video_data='test-25fps.vp8:320:240:250:250:50:175:11'


Review URL: https://chromiumcodereview.appspot.com/10828022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148479 0039d316-1c4b-4281-b951-d872f2087c98

ToplevelWindowEventFilter:
* Use location in root window for drag_location

DocInfo::GetLocalProcessWindowAtPoint
* Use ScreenPositionClient to convert a point in screen to window
* Use correct root window at the position.

MultiWindowResizer
* Use ScreenPositionClient to convert a point in screen to window.
* show_bounds_ should be screen coordinates.

I also renamed {screen|parent}_{location|position| to
{location|position}_in_{screen|parent} to be more explicit and consistent with the rest of the code.

I'll work on the test separately as we discussed offline.

BUG=138997,138868
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10827022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131282
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10831019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148477 0039d316-1c4b-4281-b951-d872f2087c98

CID=103708
BUG=
TEST=
TBR=tommi

Review URL: https://chromiumcodereview.appspot.com/10834013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148476 0039d316-1c4b-4281-b951-d872f2087c98

CID=104393
BUG=
TEST=
TBR=mihaip@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10828021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148475 0039d316-1c4b-4281-b951-d872f2087c98

Now that http://crbug.com/115123 is fixed, we can remove the views implementation, and
along the way we can remove the ShowAboutChromeDialog function from BrowseWindow
and the platform-specific overridden functions.

BUG=138724
R=pkasting@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10800096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148474 0039d316-1c4b-4281-b951-d872f2087c98

Clearing the stream_parser_map_ (which represents the list of source buffers) creates an inconsistent state where source buffers should still be available to WebKit (JavaScript) but they have been removed internally. Source buffers should only be removed when RemoveId() is called or upon destruction. 

This change was originally committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=148149 (Patch Set 1) and then reverted because it exposed a memory leak. Turns out the StreamParser was holding on to a reference to the ChunkDemuxer until after the initialization in order to ensure the init callback got called. So for tests that never append an initialization segment, the StreamParser reference prevented the ChunkDemuxer from being deconstructed, causing the memory leak. Before this patch, Shutdown() would remove all the StreamParsers so this wasn't a problem. 

A subsequent patch will not allow StreamParser to hang on to its ChunkDemuxer reference. This is ok because if ChunkDemuxer gets deconstructed, the callback is no longer relevant. 

For reference, the memory leak looks like this: 
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/11523/steps/memory%20test%3A%20media/logs/stdio 

BUG=138578
, WK88949 
TEST=http/tests/media/media-source/video-media-source-add-and-remove-ids.html, ChunkDemuxerTest.TestEndOfStreamWithNoAppends


Review URL: https://chromiumcodereview.appspot.com/10822024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148473 0039d316-1c4b-4281-b951-d872f2087c98

named.

BUG=none
TEST=none
R=oshima@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10828026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148471 0039d316-1c4b-4281-b951-d872f2087c98

Tested this by running Duke Nukem w/i NaClBox with
http://codereview.chromium.org/10823018/ patched into native_client,
using the command line:

bash -c 'ulimit -v 1000000;  /mm/bsy/chromium/chromium64.git0/src/out/Release/chrome --user-data-dir=/tmp/udd'

to verify that the crash log shows up.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2776
TEST= Manual.


Review URL: https://chromiumcodereview.appspot.com/10823019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148470 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=3
CID=104154,104155,104156
BUG=
TEST=
TBR=jeremy


Review URL: https://chromiumcodereview.appspot.com/10829024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139061


Review URL: https://chromiumcodereview.appspot.com/10834019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148468 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148467 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tomhudson@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148466 0039d316-1c4b-4281-b951-d872f2087c98

When trying to re-login, we might be at the user pods screen.


R=ivankr@chromium.org
BUG=None
TEST=chromeos_login.ChromeosLogin.testLogoutWithNoWindows
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10820021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148465 0039d316-1c4b-4281-b951-d872f2087c98

Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_browsertests.

BUG=90448
TBR=viettrungluu
Review URL: https://chromiumcodereview.appspot.com/10823029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=
CID=102400
TBR=jamesr

Review URL: https://chromiumcodereview.appspot.com/10829028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148462 0039d316-1c4b-4281-b951-d872f2087c98

(Views only) Replace the content settings icons and the dummy icons on the Website Settings UI with the set of new content settings icons.


BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10828002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148461 0039d316-1c4b-4281-b951-d872f2087c98