- 10 Mar, 2015 40 commits
-
-
rdsmith authored
Specfiically: * Highlight top level responsibilities. * Clarify detailed responsibilities around data gathering, filing crasher bugs, and monitoring Gasper/UMA. BUG=None R=mmenke@chromium.org Review URL: https://codereview.chromium.org/970953002 Cr-Commit-Position: refs/heads/master@{#319903}
-
mmeade authored
This is due to the fact that after calling these methods the calling code is not able to read the buffered stdout and stderr output since the process has been removed completely. I ran into this in a few testing scenarios where I needed to kill Chrome after some timeout period but wasn't able to read the output after the call. BUG= Review URL: https://codereview.chromium.org/985503004 Cr-Commit-Position: refs/heads/master@{#319902}
-
davidben authored
Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/09bdb2a..bf0df92 BUG=none Review URL: https://codereview.chromium.org/994823002 Cr-Commit-Position: refs/heads/master@{#319901}
-
achaulk authored
Clearing the pixmap in Destroy fixes the apparent allocation ordering issues BUG=370522 TEST=~15 minutes of HD youtube video on link with size changes between 360p, 480p, 720p, usually this would fail immediately Review URL: https://codereview.chromium.org/974583002 Cr-Commit-Position: refs/heads/master@{#319900}
-
sky authored
This is needed so that I can land patches straddling the v8 and chrome repos. BUG=465456 TEST=none R=jochen@chromium.org Review URL: https://codereview.chromium.org/987373002 Cr-Commit-Position: refs/heads/master@{#319899}
-
sergiyb authored
R=phajdan.jr@chromium.org BUG=451020 Review URL: https://codereview.chromium.org/988833002 Cr-Commit-Position: refs/heads/master@{#319898}
-
skyostil authored
TEST=out/Debug/chrome --disable-blink-scheduler Review URL: https://codereview.chromium.org/994983002 Cr-Commit-Position: refs/heads/master@{#319897}
-
engedy authored
BUG=None Review URL: https://codereview.chromium.org/994903002 Cr-Commit-Position: refs/heads/master@{#319896}
-
tfarina authored
Tested on Linux with the following command lines: $ gn gen out-gn $ gn check out-gn //ui/* More work is needed to get this enabled on .gn. BUG=367595,376000 TEST=see above R=sky@chromium.org Review URL: https://codereview.chromium.org/988463003 Cr-Commit-Position: refs/heads/master@{#319895}
-
avi authored
BUG=369661 TEST=no code changes; this adds new tests Review URL: https://codereview.chromium.org/987923002 Cr-Commit-Position: refs/heads/master@{#319894}
-
dpolukhin authored
This patch re-enabled GAIA preloading, removes 'focusready' message per agreement and add focus passing logic. BUG=462337 TEST=manual Review URL: https://codereview.chromium.org/995753002 Cr-Commit-Position: refs/heads/master@{#319893}
-
melandory authored
In case infobar is triggered by credential management API infobar should have different appearance. BUG=454815 Review URL: https://codereview.chromium.org/967193002 Cr-Commit-Position: refs/heads/master@{#319892}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17e6b228..9399e20e Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/991303002 Cr-Commit-Position: refs/heads/master@{#319891}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/ba98761..eb15141 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=mtklein@google.com Review URL: https://codereview.chromium.org/991293002 Cr-Commit-Position: refs/heads/master@{#319890}
-
yukishiino authored
Blink bindings team is going to stop supporting per-JS-context enabled features, so this CL disables history.pushState / replaceState APIs on the side of Chromium. BUG=465624 Review URL: https://codereview.chromium.org/988293002 Cr-Commit-Position: refs/heads/master@{#319889}
-
melandory authored
Adding test for Liveinternet. Test passes. Credential description string: test account for liveinternet.ru BUG=369521 R=vabr@chromium.org Review URL: https://codereview.chromium.org/991283002 Cr-Commit-Position: refs/heads/master@{#319888}
-
gab authored
It has been flaky on Win8 Aura bots (https://build.chromium.org/p/chromium.win/builders/Win8%20Aura?numbuilds=200) ever since it was introduced in r319567. Example failure log: SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs (run #1): [ RUN ] SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs Backtrace: `anonymous namespace'::InvalidParameter [0x058B8A74+4] invalid_parameter [0x750DA856+54] std::vector\u003Ccontent::FrameTreeNode *,std::allocator\u003Ccontent::FrameTreeNode *> >::operator[] [0x036462AC+156] ScopedVector\u003Ccontent::FrameTreeNode>::operator[] [0x036461EA+26] content::FrameTreeNode::child_at [0x036494C0+32] content::SitePerProcessBrowserTest_NavigateRemoteFrameToBlankAndDataURLs_Test::RunTestOnMainThread [0x006B446E+4094] content::ContentBrowserTest::RunTestOnMainThreadLoop [0x0082330C+364] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x008A7832+354] base::internal::RunnableAdapter\u003Cvoid (__thiscall content::BrowserTestBase::*)(void)>::Run [0x008A7F8B+27] base::internal::InvokeHelper\u003C0,void,base::internal::RunnableAdapter\u003Cvoid (__thiscall content::BrowserTestBase::*)(void)>,base::internal::TypeList\u003Ccontent::BrowserTestBase * const &> >::MakeItSo [0x008A73EA+26] base::internal::Invoker\u003CIndexSequence\u003C0>,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid (__thiscall content::BrowserTestBase::*)(void)>,void __cdecl(content::BrowserTestBase *),base::internal::TypeList\u003Ccontent::BrowserTestBase *> >,base::i [0x008A7EB6+54] base::Callback\u003Cvoid __cdecl(void)>::Run [0x004E9EAF+47] content::ShellBrowserMainParts::PreMainMessageLoopRun [0x0084AE38+264] content::BrowserMainLoop::PreMainMessageLoopRun [0x03866A29+249] base::internal::RunnableAdapter\u003Cint (__thiscall content::BrowserMainLoop::*)(void)>::Run [0x0386715B+27] base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall content::BrowserMainLoop::*)(void)>,base::internal::TypeList\u003Ccontent::BrowserMainLoop *> >::MakeItSo [0x0386629A+26] base::internal::Invoker\u003CIndexSequence\u003C0>,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall content::BrowserMainLoop::*)(void)>,int __cdecl(content::BrowserMainLoop *),base::internal::TypeList\u003Cbase::internal::UnretainedWrapper\u003Cconte [0x03866F98+56] base::Callback\u003Cint __cdecl(void)>::Run [0x03FC2DCF+47] content::StartupTaskRunner::RunAllTasksNow [0x044EFEFE+126] content::BrowserMainLoop::CreateStartupTasks [0x03861FE1+705] content::BrowserMainRunnerImpl::Initialize [0x0386FAC0+720] ShellBrowserMain [0x00A49654+68] content::ShellMainDelegate::RunProcess [0x00A4513F+223] content::RunNamedProcessTypeMain [0x035F26AF+127] content::ContentMainRunnerImpl::Run [0x035F24F2+578] content::ContentMain [0x035DE940+144] content::BrowserTestBase::SetUp [0x008A85D8+1448] content::ContentBrowserTest::SetUp [0x0082346C+140] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x00972057+55] testing::Test::Run [0x0098FE2B+107] testing::TestInfo::Run [0x0099010D+221] testing::TestCase::Run [0x0098FFAF+239] testing::internal::UnitTestImpl::RunAllTests [0x009905E6+726] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x00972147+55] testing::UnitTest::Run [0x0099029B+267] RUN_ALL_TESTS [0x00B10A6F+15] base::TestSuite::Run [0x00B10C33+179] content::ContentTestLauncherDelegate::RunTestSuite [0x00A4309C+60] content::LaunchTests [0x008BB407+967] main [0x00A43141+113] __tmainCRTStartup [0x00A40CA9+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626) mainCRTStartup [0x00A40DED+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466) BaseThreadInitThunk [0x76D1495D+14] RtlInitializeExceptionChain [0x77E898EE+132] RtlInitializeExceptionChain [0x77E898C4+90] TBR=lfg, nasko BUG=446575 Review URL: https://codereview.chromium.org/995833002 Cr-Commit-Position: refs/heads/master@{#319887}
-
rtenneti authored
BUG=436671 R=mmenke@chromium.org, vadimt@chromium.org, ttuttle@chromium.org, Review URL: https://codereview.chromium.org/992773002 Cr-Commit-Position: refs/heads/master@{#319886}
-
pkotwicz authored
When pressing an accelerator, the user may release the modifier key first. e.g. press Ctrl, press A, release Ctrl, release A This CL prevents the cursor from being hidden in this scenario. BUG=454902 TEST=WindowManagerTest.UpdateCursorVisibilityAccelerator Review URL: https://codereview.chromium.org/960073002 Cr-Commit-Position: refs/heads/master@{#319885}
-
michaelbai authored
make it using base::android::OnJNIOnLoad BUG=447393 Review URL: https://codereview.chromium.org/994543003 Cr-Commit-Position: refs/heads/master@{#319884}
-
paulirish authored
BUG= Review URL: https://codereview.chromium.org/973583002 Cr-Commit-Position: refs/heads/master@{#319883}
-
earthdok authored
Adding *.gn, *.gyp, *.gypi, *.isolate. BUG=385395 R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/964513002 Cr-Commit-Position: refs/heads/master@{#319882}
-
jonross authored
Remove the message loop wait that changes timing of tests on valgrind. None of the tests are checking for delayed state changes, so the waits are unnecessary. Remove the filter to test failures on the bots. TEST=ShelfViewTest.AppListButtonTouchFeedback, ShelfViewTest.AppListButtonTouchFeedbackCancellation, SystemTrayTest.TrayPopupItemContainerTouchFeedback, SystemTrayTest.TrayPopupItemContainerTouchFeedbackCancellation, TrayDetailsViewTest.HoverHighlightViewTouchFeedback, TrayDetailsViewTest.HoverHighlightViewTouchFeedbackCancellation, TrayDetailsViewTest.TrayPopupHeaderButtonTouchFeedback, TrayDetailsViewTest.TrayPopupHeaderButtonTouchFeedbackCancellation, WebNotificationTrayTest.TouchFeedback, WebNotificationTrayTest.TouchFeedbackCancellation BUG=421888 Review URL: https://codereview.chromium.org/968873005 Cr-Commit-Position: refs/heads/master@{#319881}
-
boliu authored
getUrl/getOriginalUrl logic already implemented in chromium layer. Move js interface annotation to chromium layer, and fix tests that did not have @JavascriptInterface annotation. BUG=464491 Review URL: https://codereview.chromium.org/992833002 Cr-Commit-Position: refs/heads/master@{#319880}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/ba5c202..b9a7d5e TBR=dstockwell@chromium.org Review URL: https://codereview.chromium.org/996603004 Cr-Commit-Position: refs/heads/master@{#319879}
-
kaliamoorthi authored
The CL ensures that when destroyConfig is called for a configuration that is connected and active, disconnect message is generated before the destroyConfig is acknowledged. BUG=462235 Review URL: https://codereview.chromium.org/974443002 Cr-Commit-Position: refs/heads/master@{#319878}
-
treib authored
Was disabled previously in https://codereview.chromium.org/988493002. BUG=464271, 465662 Review URL: https://codereview.chromium.org/986303002 Cr-Commit-Position: refs/heads/master@{#319877}
-
gab authored
Revert of Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder (patchset #3 id:40001 of https://codereview.chromium.org/910393003/) Reason for revert: Appears to be causing iOS Device compile errors on waterfall: https://build.chromium.org/p/chromium.mac/builders/iOS_Device Last 4 builds all fail with this log: === BUILD TARGET net_unittests OF PROJECT net WITH CONFIGURATION Release === Check dependencies Ld /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/net_unittests.app/net_unittests normal armv7 cd /Volumes/data/b/build/slave/iOS_Device/build/src/net export IPHONEOS_DEPLOYMENT_TARGET=7.0 export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/chrome-bot/slavebin:/Volumes/data/b/depot_tools:/usr/local/git/bin:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin" /Volumes/data/b/build/slave/iOS_Device/build/src/net/../third_party/llvm-build/Release+Asserts/bin/clang++ -arch armv7 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS7.1.sdk -L/Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos -L/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS7.1.sdk/System/Library/Frameworks -F/Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos -filelist /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/net.build/Release-iphoneos/net_unittests.build/Objects-normal/armv7/net_unittests.LinkFileList -dead_strip -Wl,-search_paths_first -stdlib=libc++ -miphoneos-version-min=7.0 /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libbase.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libbase_i18n.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libbase_prefs_test_support.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libdynamic_annotations.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libcrcrypto.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libgmock.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libgtest.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libchrome_zlib.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/liburl_lib.a -lbalsa -lnet -lnet_extras -lnet_test_support -lquic_tools /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libcrnspr.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libcrnss.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libcrssl.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libbase_static.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/liballocator_extension_thunks.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libmodp_b64.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libicui18n.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libicuuc.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libbase_prefs.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libnss_static.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libsqlite_regexp.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libcrnssckbi.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libzlib_x86_simd.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libsdch.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libsql.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libtest_support_base.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libxml.a /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/libtld_cleanup_util.a -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework UIKit -lsqlite3 -framework CFNetwork -framework MobileCoreServices -framework Security -framework SystemConfiguration -lresolv -lxml2 -Xlinker -dependency_info -Xlinker /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/net.build/Release-iphoneos/net_unittests.build/Objects-normal/armv7/net_unittests_dependency_info.dat -o /Volumes/data/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/net_unittests.app/net_unittests Undefined symbols for architecture armv7: "net::SpdyFrameBuilder::WriteStringPiece16(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&)", referenced from: net::SpdyFramerTest_DuplicateHeader_Test::TestBody() in spdy_framer_test.o net::SpdyFramerTest_MultiValueHeader_Test::TestBody() in spdy_framer_test.o ld: symbol(s) not found for architecture armv7 clang: error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder > > As the comment in net/spdy/spdy_frame_builder.h by hkhalil@, > rename WriteString to WriteStringPiece16. > > BUG=458880 > R=bnc@chromium.org > > Committed: https://crrev.com/d588d971032596c63dd082b3d5c7438997467ddd > Cr-Commit-Position: refs/heads/master@{#319804} TBR=bnc@chromium.org,asanka@chromium.org,mmenke@chromium.org,zhuoyu.qian@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458880 Review URL: https://codereview.chromium.org/991313002 Cr-Commit-Position: refs/heads/master@{#319876}
-
http://crrev.com/988863002/huangs authored
http://crrev.com/988863002/ triggered use-after-free in ASAN because it passes ("#" + color_str).c_str() to FindColor() (which takes char*), then dereferences the returned pointer, which has been deallocated. This is a redo of the CL that fixes the problem. BUG=455063 Review URL: https://codereview.chromium.org/989313002 Cr-Commit-Position: refs/heads/master@{#319875}
-
fmalita authored
With a standalone BenchmarkingCanvas, we can now unexport the src/core headers. Also remove unused SkDebugCanvas sources. BUG=457691 R=reed@google.com,robertphillips@google.com,mtklein@chromium.org Review URL: https://codereview.chromium.org/993533005 Cr-Commit-Position: refs/heads/master@{#319874}
-
jochen authored
Since content_shell doesn't support tabs, we can't otherwise tell apart background tabs from foreground tabs in layout tests. BUG=454222 R=mkwst@chromium.org,rbyers@chromium.org Review URL: https://codereview.chromium.org/995773002 Cr-Commit-Position: refs/heads/master@{#319873}
-
magjed authored
WebRTC 8667:8668 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b0ea939..17fbf57 TBR=tommi Review URL: https://codereview.chromium.org/991243002 Cr-Commit-Position: refs/heads/master@{#319872}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/732a92d..ba98761 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=mtklein@google.com Review URL: https://codereview.chromium.org/994933002 Cr-Commit-Position: refs/heads/master@{#319871}
-
bartfab authored
VpnService concatenates the third-party VPN provider's extension name and the user-provided configuration name into a combined name in a non-18n-aware manner. This CL removes the concatenation. The extension name and configuration name will be combined visually by the UI as required instead. BUG=434711,460428 TEST=Manual, together with follow-up CLs that wire up the UI Review URL: https://codereview.chromium.org/990993003 Cr-Commit-Position: refs/heads/master@{#319870}
-
chrome://serviceworker-internalsdominicc authored
BUG=442618 Review URL: https://codereview.chromium.org/998433002 Cr-Commit-Position: refs/heads/master@{#319869}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#319868} -
melandory authored
Adding test for Alexa. Test passes. BUG=369521 R=vabr@chromium.org Review URL: https://codereview.chromium.org/992223002 Cr-Commit-Position: refs/heads/master@{#319867}
-
magjed authored
We can use cricket::VideoFrame::Copy() to make a shallow reference counted copy. Review URL: https://codereview.chromium.org/877283004 Cr-Commit-Position: refs/heads/master@{#319866}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/8fc89ec..ba5c202 TBR=dstockwell@chromium.org Review URL: https://codereview.chromium.org/997503003 Cr-Commit-Position: refs/heads/master@{#319865}
-
vasilii authored
It will simplify ManagePasswordsUIController. The tests are the same as in ManagePasswordsUIControllerTest. BUG=461801 Review URL: https://codereview.chromium.org/993513006 Cr-Commit-Position: refs/heads/master@{#319864}
-
