GitLab

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * platform/chromium/ChromiumDataObject.cpp:
        (WebCore::ChromiumDataObject::clear):
        (WebCore::ChromiumDataObject::hasData):
        (WebCore::ChromiumDataObject::ChromiumDataObject):
        * platform/chromium/ChromiumDataObject.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::setData):
2010-02-07  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * public/WebDragData.h:
        * src/WebDragData.cpp:
        (WebKit::WebDragData::downloadMetadata):
        (WebKit::WebDragData::setDownloadMetadata):

git-svn-id: svn://svn.chromium.org/blink/trunk@54469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717

* fast/frames/flattening/resources: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.



git-svn-id: svn://svn.chromium.org/blink/trunk@54468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        Using inlines and function-level statics don't mix, according to gcc.
        https://bugs.webkit.org/show_bug.cgi?id=34663

        De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

        It appears that the initialization check, generated by gcc doesn't account
        for a possibility that the function may be inlined, resulting in lazy
        initialization failure for more than one inlined instance of the function.

        No behavior change, so no new tests.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::deviceRGBColorSpaceRef):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods.  In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/Parser.cpp:
(JSC::Parser::parse):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@54464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=34670
        TestNetscapePlugin should work with Firefox

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
        browser doesn't tell what it supports.



git-svn-id: svn://svn.chromium.org/blink/trunk@54463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * platform/gtk/Skipped:
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_page_number_for_element_by_id):
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageNumberForElementById):

git-svn-id: svn://svn.chromium.org/blink/trunk@54461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.
        
This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
* platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.



git-svn-id: svn://svn.chromium.org/blink/trunk@54460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@54459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        [Chromium] Rename autocomplete* to suggestions* to prepare for the
        refactoring of AutocompletePopupMenuClient.

        https://bugs.webkit.org/show_bug.cgi?id=34664

        * public/WebView.h:
        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::popupDidHide):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::textFieldDidEndEditing):
        (WebKit::EditorClientImpl::doAutofill):
        * src/WebViewImpl.cpp:
        (WebKit::):
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::applyAutofillSuggestions):
        (WebKit::WebViewImpl::hideAutofillPopup):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        (WebKit::WebViewImpl::refreshSuggestionsPopup):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::suggestionsPopupDidHide):

git-svn-id: svn://svn.chromium.org/blink/trunk@54458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        [BREWMP] Define SYSTEM_MALLOC 1
        https://bugs.webkit.org/show_bug.cgi?id=34640

        Make BREWMP use system malloc because FastMalloc is not ported.

        * wtf/Platform.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed revert of r54454, until I can generate new results

        * media/video-loop-expected.txt:
        * media/video-loop.html:



git-svn-id: svn://svn.chromium.org/blink/trunk@54456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=34348
        
        The correct virtual function in GraphicsLayerCACF is now being
        called. We also fixed an issue in QTMovieWin where the size
        of the movie was not being set correctly because the call order
        was changed.
        
        I also changed the order of a couple of calls in QTMovieWin to account
        for changed calling order from the logic above.



git-svn-id: svn://svn.chromium.org/blink/trunk@54455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=33671
        [GTK] media/video-loop.html fails intermittently on Gtk Bots

        Rewrite test to make it less timing dependent.

        * media/video-loop-expected.txt:
        * media/video-loop.html:



git-svn-id: svn://svn.chromium.org/blink/trunk@54454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        Add a simple test implementation and the WebKit Mac implementation
        for the layout_tests/port package. Also add a simple test driver of
        that interface.

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/webkitpy/layout_tests/driver_test.py: Added.
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/mac.py: Added.
        * Scripts/webkitpy/layout_tests/port/test.py: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@54452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Siedel.

        Refactor the port package into an object-oriented style and merge
        path_utils into it. We add a 'base' and a 'chromium' object to the
        port package; this will allow us to easily add new ports (like
        WebKit Mac).

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/rebaseline-chromium-webkit-tests:
        * Scripts/run-chromium-webkit-tests:
        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/base.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:




git-svn-id: svn://svn.chromium.org/blink/trunk@54449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        [Chromium] Remove an unused forward declaration in WebKitClient.h.

        https://bugs.webkit.org/show_bug.cgi?id=34622

        * public/WebKitClient.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=34661
        <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
        * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
        (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.



git-svn-id: svn://svn.chromium.org/blink/trunk@54447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848
        
Reviewed by Simon Fraser.

Added a manual test.

* manual-tests/win: Added.
* manual-tests/win/horizontal-scroll-composited.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):



git-svn-id: svn://svn.chromium.org/blink/trunk@54446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

* platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.



git-svn-id: svn://svn.chromium.org/blink/trunk@54445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update expected results after r54441 to make buildbot happy.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.



git-svn-id: svn://svn.chromium.org/blink/trunk@54444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        Implement WebInputElement::isActivatedSubmit().

        https://bugs.webkit.org/show_bug.cgi?id=34623

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::isActivatedSubmit):

git-svn-id: svn://svn.chromium.org/blink/trunk@54443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        Implementation of GlyphPage::fill() for Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        Covered by existing tests.

        * platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp

git-svn-id: svn://svn.chromium.org/blink/trunk@54442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add expected frame flattening results for Qt.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@54441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=32717

Reviewed by Dave Hyatt.

WebCore:

The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.

Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.

Tests: fast/frames/flattening/frameset-flattening-advanced.html
       fast/frames/flattening/frameset-flattening-grid.html
       fast/frames/flattening/frameset-flattening-simple.html
       fast/frames/flattening/frameset-flattening-subframe-resize.html
       fast/frames/flattening/frameset-flattening-subframesets.html

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):
* page/Settings.h:
(WebCore::Settings::frameSetFlatteningEnabled):
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::layoutWithFlattening):
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):
* rendering/RenderFrameSet.h:

WebKit/qt:

Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.

* Api/qwebpage.cpp:
(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):
* Api/qwebpage_p.h:

WebKitTools:

Add support for testing frame flattening with the Qt DRT

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setFrameSetFlatteningEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Frameset flattening layout test, plus expected result for Qt.

* fast/frames/flattening/frameset-flattening-advanced.html: Added.
* fast/frames/flattening/frameset-flattening-grid.html: Added.
* fast/frames/flattening/frameset-flattening-simple.html: Added.
* fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
* fast/frames/flattening/frameset-flattening-subframesets.html: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@54440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

on a per file or folder basis, via a configuration variable.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=33684

* Scripts/webkitpy/style/checker.py:
  - Added _PATH_RULES_SPECIFIER configuration variable.
  - In ProcessorOptions class--
    - Changed the CategoryFilter attribute to FilterConfiguration.
    - Added path parameter to is_reportable().
  - Renamed ArgumentDefaults filter_rules attribute to
    base_filter_rules.
  - Updated ArgumentPrinter class.
  - Added filter rule validation to ArgumentParser (instead of
    in CategoryFilter constructor).

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated unit tests as necessary.
  - Added unit tests for PATH_RULES_SPECIFIER.

* Scripts/webkitpy/style/error_handlers.py:
  - Updated DefaultStyleErrorHandler to use file path when
    calling is_reportable().

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated unit tests as necessary.

* Scripts/webkitpy/style/filter.py:
  - Marked CategoryFilter internal with an underscore.
  - Removed argument validation from CategoryFilter.
  - Added FilterConfiguration class.

* Scripts/webkitpy/style/filter_unittest.py:
  - Updated CategoryFilterTest class.
  - Added FilterConfigurationTest unit tests.

* Scripts/webkitpy/style/processors/cpp.py:
  - Removed _is_test_filename() code.
  - Removed hard-coded path checks from check_include_line().

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Removed three unit tests related to exempted files.

git-svn-id: svn://svn.chromium.org/blink/trunk@54439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Changing display type of parent of input on focus causes input field to not receive key events
        https://bugs.webkit.org/show_bug.cgi?id=34620
        <rdar://problem/7584572>

        When layout affects a text input, the RenderTextControl gets destroyed and
        recreated, which in turn makes a new innerTextElement. However, if the text field was
        focused, the VisibleSelection is left pointing to the old innerTextElement, so text
        input no longer works.

        The fix is to call updateFocusAppearanceSoon() when attaching the input element,
        which will update the selection if necessary.

        Test: fast/forms/restore-selection-after-layout.html

        * dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable,
        m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection
        (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter.
        (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
        * dom/Element.cpp:
        (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
        * dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.

git-svn-id: svn://svn.chromium.org/blink/trunk@54438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Ariya Hidayat.

* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
* QtLauncher/webview.h:
(WebViewGraphicsBased::setItemCacheMode):

git-svn-id: svn://svn.chromium.org/blink/trunk@54437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Timothy Hatcher.

        Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

        https://bugs.webkit.org/show_bug.cgi?id=34646

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.show):
        (WebInspector.CookieItemsView.prototype._update):
        (WebInspector.CookieItemsView.prototype._updateWithCookies):
        (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
        (WebInspector.CookieItemsView.prototype._createDataGrid):
        (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare):
        (WebInspector.CookieItemsView.prototype._populateDataGrid):
        (WebInspector.CookieItemsView.prototype._createSimpleDataGrid):
        (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid):
        (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
        (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
        (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        (WebInspector.DataGrid.prototype.autoSizeColumns):
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.prototype._queryFinished):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.dataGridForResult):


git-svn-id: svn://svn.chromium.org/blink/trunk@54436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Timothy Hatcher.

        Web Inspector: group cookies by frame, show total
        cookies size, allow sorting cookie table.

        https://bugs.webkit.org/show_bug.cgi?id=34617

        * English.lproj/localizedStrings.js:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::deleteCookie):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype._updateWithCookies):
        (WebInspector.CookieItemsView.prototype._cookiesForDomain):
        (WebInspector.CookieItemsView.prototype.dataGridForCookies):
        (WebInspector.CookieItemsView.prototype._createNodes):
        (WebInspector.CookieItemsView.prototype._sortData.localeCompare):
        (WebInspector.CookieItemsView.prototype._sortData.numberCompare):
        (WebInspector.CookieItemsView.prototype._sortData.expiresCompare):
        (WebInspector.CookieItemsView.prototype._sortData):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.showCookies):
        (WebInspector.CookieSidebarTreeElement):
        (WebInspector.CookieSidebarTreeElement.prototype.onselect):
        (WebInspector.CookieSidebarTreeElement.prototype.get subtitle):
        (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):


git-svn-id: svn://svn.chromium.org/blink/trunk@54435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        More robust conversion from BString to String for Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        Covered by existing tests.

        * platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.

git-svn-id: svn://svn.chromium.org/blink/trunk@54434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Adam Roben.

* WebCore.vcproj/WebCore.make:



git-svn-id: svn://svn.chromium.org/blink/trunk@54430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Dirk Schulze.

[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784

WebCore: 

* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::debugString): Path dumping style is aproached to Mac.

LayoutTests: 

Expected files updated.

* platform/qt/svg/css/arrow-with-shadow-expected.txt:
* platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
* platform/qt/svg/css/clippath-with-shadow-expected.txt:
* platform/qt/svg/css/mask-with-shadow-expected.txt:
* platform/qt/svg/css/path-with-shadow-expected.txt:
* platform/qt/svg/css/stars-with-shadow-expected.txt:
* platform/qt/svg/custom/empty-mask-expected.txt:
* platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
* platform/qt/svg/custom/marker-opacity-expected.txt:
* platform/qt/svg/custom/marker-referencePoint-expected.txt:
* platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
* platform/qt/svg/custom/mask-with-default-value-expected.txt:
* platform/qt/svg/custom/relative-sized-content-expected.txt:
* platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/qt/svg/custom/transformedMaskFails-expected.txt:
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/qt/svg/filters/feComposite-expected.txt:
* platform/qt/svg/filters/feGaussianBlur-expected.txt:
* platform/qt/svg/filters/feMerge-expected.txt:
* platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
* platform/qt/svg/filters/feOffset-expected.txt:
* platform/qt/svg/filters/feTile-expected.txt:
* platform/qt/svg/filters/shadow-on-filter-expected.txt:
* platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
* platform/qt/svg/filters/subRegion-one-effect-expected.txt:
* platform/qt/svg/filters/subRegion-two-effects-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@54429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
        https://bugs.webkit.org/show_bug.cgi?id=34569

        With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
        if the return value of malloc and calloc is 0.
        
        However, these functions can return 0 when the request size is 0.
        Libc manual says, "If size is 0, then malloc() returns either NULL,
        or a unique pointer value that can later be successfully passed to free()."
        Though malloc returns a unique pointer in most systems,
        0 can be returned in some systems. For instance, BREW's MALLOC returns 0
        when size is 0.

        If malloc or calloc returns 0 due to allocation size, increase the size
        to 1 and try again.

        * wtf/FastMalloc.cpp:
        (WTF::fastMalloc):
        (WTF::fastCalloc):
2010-02-05  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=34317

        * GNUmakefile.am:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        (WebCore::doGstInit):
        * platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gtk/WebKitWebSourceGStreamer.h:
        Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure.
        This makes sure that referer, cookies, authentication information
        and all kinds of other context are passed to GStreamer for websites
        like Vimeo or YouTube.


git-svn-id: svn://svn.chromium.org/blink/trunk@54428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=34317

        * GNUmakefile.am:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        (WebCore::doGstInit):
        * platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gtk/WebKitWebSourceGStreamer.h:
        Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure.
        This makes sure that referer, cookies, authentication information
        and all kinds of other context are passed to GStreamer for websites
        like Vimeo or YouTube.

git-svn-id: svn://svn.chromium.org/blink/trunk@54427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Kenneth Rohde Christiansen.

DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.

We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.

* Api/DerivedSources.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@54426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        [V8] Clean up code for getting a v8::FunctionTemplate.
        
        https://bugs.webkit.org/show_bug.cgi?id=34606

        * bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
        * bindings/v8/V8Binding.cpp:
        (WebCore::configureTemplate):
        * bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead.
        (WebCore::V8DOMWrapper::getConstructor):
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::lookupDOMWrapper):
        * bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates.
        (WebCore::V8ClassIndex::getTemplate):
        * bindings/v8/V8Index.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::toV8):
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::v8HTMLAudioElementConstructorCallback):
        (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::v8HTMLImageElementConstructorCallback):
        (WebCore::V8HTMLImageElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLImageElementConstructor.h:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::v8HTMLOptionElementConstructorCallback):
        (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLOptionElementConstructor.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::createInjectedScriptHostV8Wrapper):


git-svn-id: svn://svn.chromium.org/blink/trunk@54425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.

* platform/qt/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@54424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tor Arne Vestbø.

        Add .gitattributes file to tell git about files with Windows linefeeds
        https://bugs.webkit.org/show_bug.cgi?id=34645

        On Windows git defaults to "true" for core.autocrlf, meaning all text
        files in the working directory are converted from CRLF to LF on checkin
        time. Some files present in the repository have been checked in with
        CRLF linefeeds and git should not try to convert them. The added
        .gitattributes file tells git to not do any CRLF conversion.

        * .gitattributes: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@54423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34597

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.

* plugins/PluginView.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54422 bbb929c8-8fbe-4397-9dbb-9b2b20218538