GitLab

Bug: 881513
Change-Id: I7545077ccf34528b9053561749f65bd1553e8ca2
Reviewed-on: https://chromium-review.googlesource.com/c/1474600Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kyle Ju <kyleju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633824}

Suggested by jonann@.

Bug: none
Change-Id: I6ce09c78087964ccb9b768dfaf750c03cadc3185
Reviewed-on: https://chromium-review.googlesource.com/c/1475489Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633823}

This is probably a more interesting change.

Whenever we perform layout from NG->Legacy this enables us to reuse an
old layout result stored on the object (even if that object is a LayoutBox).

This decreases the size of LayoutBlock by a pointer, but increases the size
of LayoutBox.

Bug: 635619
Change-Id: I5be1bbf72f0a45623e90cb4f2767e5bd47bd4001
Reviewed-on: https://chromium-review.googlesource.com/c/1476567
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633822}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=creis@chromium.org

Bug: 714018
Change-Id: I45ef06c750df8d491227b7b7a8d9fdf233f06f04
Reviewed-on: https://chromium-review.googlesource.com/c/1475642
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633821}

This is a preliminary change followed by https://crrev.com/c/1474887.
Document::CheckCompleted should be immune to excessive calls, so this
should not be a problem.

Bug: 914739
Change-Id: I3b33b01fc434d04f328865777166e30c9abddf55
Reviewed-on: https://chromium-review.googlesource.com/c/1478318
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633820}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is migrating PassphraseType into @IntDef using rules similar to other @IntDef inside Chromium project:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Notes:

1. PassphraseType.java is moved into Passphrase.java
2. functions inside Passphrase are using ordered List instead of Set
3. we remove Parcelable interface for PassphraseType

BUG=919666

Change-Id: I2b8854d0638780eb817e42fbfc2bfc15df8e4a2a
Reviewed-on: https://chromium-review.googlesource.com/c/1461877Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#633819}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5994ae2a0450..76730a46a1d8


git log 5994ae2a0450..76730a46a1d8 --date=short --no-merges --format='%ad %ae %s'
2019-02-20 9856269+sarahM0@users.noreply.github.com In Vulkan, disallow BufferBlock on StorageBuffer variables  (#2380)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@76730a46a1d8

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id3c2e8281fc720a4f2762509371e058c41900d5c
Reviewed-on: https://chromium-review.googlesource.com/c/1478444Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#633818}

https://chromium.googlesource.com/angle/angle.git/+log/3d544fffe7ff..902ceed39986


git log 3d544fffe7ff..902ceed39986 --date=short --no-merges --format='%ad %ae %s'
2019-02-20 timvp@google.com Revert "Create Container ANGLE APK"


Created with:
  gclient setdep -r src/third_party/angle@902ceed39986

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I9e38f319b1ec3be4dd4bb3fb4771858239db85a4
Reviewed-on: https://chromium-review.googlesource.com/c/1477883Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#633817}

The newly added test and its expected.txt are mostly the same
as its classic version of same-origin-test.js, except for:
- notStreamedReason (it's always "module script"),
- tracing event name (v8.compileModule), and
- Set type=module.

Bug: 841466
Change-Id: Id64fdbb91ffd406a002c3e907065720e475d157b
Reviewed-on: https://chromium-review.googlesource.com/c/1475071
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633816}

This CL implements the rasterization part for a paint image that is
generated by PaintWorklet, which is the DrawImageOp::RasterWithFlags.

Bug: 907897
Change-Id: I993d29035f1ad09e7cbe3caecc5445876078ac01
Reviewed-on: https://chromium-review.googlesource.com/c/1426015Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633815}

To remove ExecutionContext::Url() call from WorkerFetchContext.

Bug: 878274, 931532
Change-Id: I40eaa79c72cc0c9b6ff9c7a7ecc2b206ee39bc28
Reviewed-on: https://chromium-review.googlesource.com/c/1394382Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633814}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/177cd13347a9..4534fdbeafdc


git log 177cd13347a9..4534fdbeafdc --date=short --no-merges --format='%ad %ae %s'
2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@4534fdbeafdc

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I0aa1610973d804e8377ba625f5737165475ea999
Reviewed-on: https://chromium-review.googlesource.com/c/1477882Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#633813}

Bug: None
Change-Id: I1bf4f33b8bb92b7932981b9373994ecf6f71e680
Reviewed-on: https://chromium-review.googlesource.com/c/1478496
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633812}

Bug: 922699
Change-Id: Icb3454e12b0dcecae9aaa1773b39c206e9dd78b4
Reviewed-on: https://chromium-review.googlesource.com/c/1479151
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633811}

This fixes a couple presubmit issues when running on Windows:

* check_gn didn't properly normalize paths
* eslint didn't execute in node successfully since the bin style for the
npm install was unix specific (it's a CMD file on Windows)


Bug: 929919
Change-Id: Iec7e1057254047bd0a6539e16df964dc8a58d528
Reviewed-on: https://chromium-review.googlesource.com/c/1459576Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#633810}

This test occasionally crashes with the network service enabled because
a request hits the Interceptor after its been deleted.

Change-Id: Ib09e8c6cdf1208ced3297af37e2261c880bae0f1
Reviewed-on: https://chromium-review.googlesource.com/c/1478307Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633809}

Work-around some issues with the component launcher implementation by
falling-back to using LaunchInfo-provided services if the
ApplicationConfigManager cannot be found in the CastRunner's incoming
service directory.

Bug: 893229
Change-Id: I500920cb21186fdbd60f59783f359fdaf65aecaf
Reviewed-on: https://chromium-review.googlesource.com/c/1476594Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633808}

BUG=801780
R=thakis

Change-Id: I60588de2dd5de1fe92f9731592d7ebd4468764c2
Reviewed-on: https://chromium-review.googlesource.com/c/1479410
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633807}

Change-Id: I212670f81a9e4f01f06ba70cb312585fdaceab1c
Reviewed-on: https://chromium-review.googlesource.com/c/1478658Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633806}

The AndroidMessagesIntegration feature flag was added to control
launch of messages integration in ChromeOS. This feature is now
enabled by default. This CL removes this flag and it's references.

Bug: 930985
Change-Id: Id389f972d976fc5878c95a5e702e953018eb83b9
Reviewed-on: https://chromium-review.googlesource.com/c/1476116Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633805}

Bug: 931436
Change-Id: Iecf75ad198afdd0a9d01486e610d62e4e31cdce6
Reviewed-on: https://chromium-review.googlesource.com/c/1477928Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633804}

Original CL:
  https://chromium-review.googlesource.com/909216
  [MIPS][tcmalloc] Fix mipsel compile errors

  tcmalloc is using very old version of linux_syscall_support.h

  The following mipsel related changes are pulled from lss project:

  https://chromiumcodereview.appspot.com/10067027
  https://codereview.chromium.org/13846002
  https://codereview.chromium.org/913723002/
  https://codereview.chromium.org/836473006

  Bug: 810356, 794147

BUG=724399,b:119055259

Change-Id: I9609460412d27ab8ed963577af6c284d8cb898d4
Reviewed-on: https://chromium-review.googlesource.com/c/1475153Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633803}

This is more in-line with the other simplechrome trybots, which don't
have DCHECKs enabled.

R=achuith, dpranke, jbudorick

Bug: 931794
Change-Id: I5347d222ef823d4c1318057c7d1833d7afef43a9
Reviewed-on: https://chromium-review.googlesource.com/c/1478947Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633802}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd080e04f1e4..ad6d56748d98


git log fd080e04f1e4..ad6d56748d98 --date=short --no-merges --format='%ad %ae %s'
2019-02-20 gmeinke@chromium.org cbuildbot: plumb snapshot revision flag
2019-02-20 nya@chromium.org artifact_stages: Upload Tast private test bundles.


Created with:
  gclient setdep -r src/third_party/chromite@ad6d56748d98

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I5faf2e4d7c0d773e6bfd5ddd338bd25fd7b98815
Reviewed-on: https://chromium-review.googlesource.com/c/1478938Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#633801}

This required updating several tests to use "safe" download types,
such as jpg or txt. For the download browser tests, the URL is forced
to be "download-known-size", so I changed the expectation to match
the format "Unconfirmed <number>.crdownload". A little bit of test data
needed to be changed, namely:

- simple_exe.cc was renamed simple_exe.txt, since cc is uncommon
- zipfile_no_binaries.zip now has contents "simple_exe.txt" instead of
  "simple_exe.cc", for the same reason.
- small_archive.rar now has contents "limerick.txt" instead of
  "limerick", since "limerick" is an uncommon extension.

Bug: 918991
Change-Id: Iaef193e32a825b3b977fdae55ec43e7c5aaa327f
Reviewed-on: https://chromium-review.googlesource.com/c/1459317Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633800}

Change-Id: I09d3416dc11140754a35033b4fbb45a76a44ee6a
Reviewed-on: https://chromium-review.googlesource.com/c/1478082Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633799}

Horray! There should be no behaviour change.

Bug: 635619
Change-Id: I12507f3e8144353fb58dc5837d33f4bc567d58b3
Reviewed-on: https://chromium-review.googlesource.com/c/1476514
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633798}

This makes it possible to see precursor and nonce info for the
origin for diagnostics, following r631964.

Bug: 918565, 919144, 931895
Change-Id: I7b07e4e34177a0a532c254e313d65ad28e28cdd7
Reviewed-on: https://chromium-review.googlesource.com/c/1478096
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633797}

https://webrtc.googlesource.com/src.git/+log/109b5fb5f5b2..76d7ce275223


git log 109b5fb5f5b2..76d7ce275223 --date=short --no-merges --format='%ad %ae %s'
2019-02-20 srte@webrtc.org Disabling flaky RecievesVp8SimulcastFrames test.
2019-02-20 nisse@webrtc.org Reland "Update VP9EncoderImpl to use EncodedImage::Allocate"


Created with:
  gclient setdep -r src/third_party/webrtc@76d7ce275223

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ide3de360c9d5172234f987a013ab1706c22ebae2
Reviewed-on: https://chromium-review.googlesource.com/c/1477404Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#633796}

This was never added to the BUILD.gn file, so was never actually built or
tested.

Change-Id: I07b614c628146e0aee639bd5908bb8ff877c407e
Reviewed-on: https://chromium-review.googlesource.com/c/1478500Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#633795}

Bug: 908139
Change-Id: I9219f576a344873f8cb5414ab7a1ba5e156f5527
Reviewed-on: https://chromium-review.googlesource.com/c/1474632Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633794}

Bug: 931541
Change-Id: Ic30aa92c18ebcb4dc09216fef7a09f5e430bf572
Reviewed-on: https://chromium-review.googlesource.com/c/1477807Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633793}

When a leveldb_proto database is requested we try to open both the
unique and shared databases, when only one of those opened we used to
return that database, regardless of whether we should, this CL
incorporates the init and migration status to that logic to avoid
returning a database with stale data

Bug: 870813
Change-Id: Ide70a7d8c861f017fd55ae5faa53f5f73369f228
Reviewed-on: https://chromium-review.googlesource.com/c/1471378
Commit-Queue: Salvador Guerrero <salg@google.com>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633792}

Previously we stored two objects if we wanted to cache a layout result, the
layout result, and the constraint space.

This patch stores the constraint space which generated the layout result on the
layout result itself.

We only store a "valid" constraint space on a layout object if the NGLayoutResult
holds onto a box-fragment with an associated layout_block_flow. E.g. we *don't*
store it for line-box results, or inline-level box fragments generated from an
NGInlineItem (borders of a span, etc).

This also means that the NGConstraintSpace reference is stored with the
NGContainerFragmentBuilder when performing layout. This removes the const
reference from the NGLayoutAlgorithms to the constraint space, and moves it into
the fragment builder.

The logic within layout_scrollbar.cc was needed in order to pass:
scrollbars/custom-scrollbar-changing-style-relayout-body-scrollablearea.html

Effectively we were now caching a layout that we weren't previously. As
scrollbar size is a "side-input" to our layout system we need to properly
invalidate the "owner" of the scrollbars if the size may have changed.

Bug: 635619, 932990
Change-Id: I358d3a501916602aed3cedff0dd5c96137d6fe97
Reviewed-on: https://chromium-review.googlesource.com/c/1476510
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633791}

Uses real hostnames for the test servers instead of localhost.

Change-Id: Ib57c83ff1295b3b2cd47c515d2c7e1ec9d8f80c8
Reviewed-on: https://chromium-review.googlesource.com/c/1478501Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633790}

This CL implements a basic FTL client that can retrieve a list of ICE servers,
and an executable for playing with it.

Bug: 927962
Change-Id: I351d4af231689b5de533f3c34252a91cee2e5211
Reviewed-on: https://chromium-review.googlesource.com/c/1445312
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633789}

Recent changes to the handling of user_input_in_progress caused a
regression in OmniboxViewViews::OnBlur() where the edit state is not
reverted when the current text exactly matches the permanent text. This
resulted in page icons such as the bookmarks star from remaining hidden
when they should be shown.

This change adds a check to see whether the text has been edited but
currently is an exact match for the permanent text and does a revert.
This is necessary because users may have no idea that they are
currently in "edit mode" because the text looks unchanged.

Bug: 932782
Change-Id: Ie6d7218daa27a4f59eafaac9c76477925b50e384
Reviewed-on: https://chromium-review.googlesource.com/c/1475947
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633788}

The only part of the widget that's actually drawn by Ash is the
header, which has its own layer. The client area is drawn by
the browser process. Therefore the native widget's aura::Window
can be LAYER_NOT_DRAWN.

Bug: 931873
Change-Id: I5d27505d7ed1d662ae811a8b719170494c72d9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1471348
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633787}

- Remove semicolons after the _CLASS_PROPERTY_TYPE macros. Since they
  add something in namespace ui, it's difficult to require a semicolon
  after them and most clients don't have one there anyways. This part
  of the CL was created by running:

        for p in DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE \
                 DEFINE_EXPORTED_UI_CLASS_PROPERTY_TYPE \
                 DEFINE_UI_CLASS_PROPERTY_TYPE ; do
          git grep -l $p | xargs perl -i -p0e 's/('$p'\([^)]+\));?/\1/g'
        done

- Also remove semicolons after DEFINE_(OWNED_)UI_CLASS_PROPERTY_KEY
  for consistency with DEFINE_UI_CLASS_PROPERTY_TYPE since these
  two macros are often used next to each other:

        for p in DEFINE_UI_CLASS_PROPERTY_KEY \
                 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY ; do
          git grep -l $p | xargs perl -i -p0e 's/('$p'\([^)]+\));?/\1/g'
        done

Bug: 926235
Change-Id: I73913d93b99d8b1e6eef774b923beee612e6c480
Reviewed-on: https://chromium-review.googlesource.com/c/1478071Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633786}

ordering="prefix" turns out to be not the right thing.  The
variant name is intended to be at the end, such as:

Media.Learning.MediaCapabilities.DroppedFrameRatioTask.BaseTree

Change-Id: Ib71ede8b9214edd08f6c25c1e1a771158309ece1
Reviewed-on: https://chromium-review.googlesource.com/c/1477751Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633785}