- 30 Oct, 2017 40 commits
-
-
Sunny Sachanandani authored
Scanout has a precise meaning and is something that we explicitly control on ChromeOS only. Rename this method to avoid confusion. R=reveman BUG=NONE Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib551a7c810ffeb3e7c5bad8e974477daae3012a8 Reviewed-on: https://chromium-review.googlesource.com/737129 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512645}
-
Wez authored
Bug: 772031 Change-Id: I9aa7df5c39537b5866f3f35c4c1765f54dc2d7be Reviewed-on: https://chromium-review.googlesource.com/744262 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#512644}
-
Peter Boström authored
Exposes GetContentsBounds() alongside GetLocalBounds() when they are different. This visualizes inset usage inside views and can show why some content may be clipped. Bug: None Change-Id: I2f1269fc2b2f93c8c4ba3fd5455fd7f070fffc5a Reviewed-on: https://chromium-review.googlesource.com/741687Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#512643}
-
Francois Doray authored
With this CL, calls to Process::WaitForExit*() must be done within the scope of a base::ScopedAllowBaseSyncPrimitives*. Since calls to Process::WaitForExit*() can potentially deadlock, it is desirable to have them reviewed by a //base OWNER. Bug: 766678 Change-Id: I1d5cc98984b84a412492db5f83c8db4b20396367 Reviewed-on: https://chromium-review.googlesource.com/703475 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512642}
-
David Benjamin authored
PK11_FindKeyByAnyCert retains wincx on the resulting SECKEYPrivateKey, which may be used on PK11_Sign. To keep the lifetimes correct, we must retain a reference to the password delegate in SSLPlatformKeyNSS. Bug: 779090 Change-Id: Ia769ebe967582e83fbcbcaa5bca7ef788c1345a6 Reviewed-on: https://chromium-review.googlesource.com/743847Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#512641}
-
Eugene But authored
Bug: 684616 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If162f88f88e455a1115a72da8d9c6508fcea5d90 Reviewed-on: https://chromium-review.googlesource.com/742746 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#512640}
-
Tetsui Ohkubo authored
When the settings button in a notification popup is clicked, the notification is activated and hidden almost at the same time. In such case, the notification is deactivated without OnWindowActivated for the activation being called. We have to manually ignore such case in TrayBubbleWrapper::OnWindowActivated. TEST=manual BUG=778973 Change-Id: I90802a99a64bd8a9d8de56e48735e0fd7abe6ed6 Reviewed-on: https://chromium-review.googlesource.com/740928Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#512639}
-
Xianzhu Wang authored
For valid repaint text differences and invisible subpixel differences. TBR=wangxianzhu@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I86bdfbbe92ce36e2cd5705eb8211d492e7c3e6b4 Reviewed-on: https://chromium-review.googlesource.com/744970 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512638}
-
Wez authored
This requires filtering out some tests: - Some PartitionAllocTests which fail under ARM64, and were just being skipped under x64. - BuildTime.InThePast which current fails under ARM64. Bug: 772031, 779645, 779668 Change-Id: Ic764f276d8298bf309c815af6b60eed4ea5d3c4f Reviewed-on: https://chromium-review.googlesource.com/744315 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Charles Harrison authored
Currently, we populate website data metadata for sites which activate as ENABLED. This metadata is used to trigger showing the "Ads" setting in the settings UI, OIB, and page info. However, we also activate as ENABLED for warning sites, and decrease activation level downstream in the driver factory. This means that warning sites will show up in the various settings UIs as having intrusive ads. This CL makes it so that warning sites do not populate the metadata. Bug: 779673 Change-Id: I972faf6aeda6884b584c8383918fa7a9ba966b6c Reviewed-on: https://chromium-review.googlesource.com/744442Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#512636}
-
Geoff Lang authored
Update the build_gles2_cmd_buffer.py script to auto-generate extension and version checks for all auto-generated entry points and update hand-written handlers to do the same. Move unknown command validation out of the Doer functions. Covered by new gpu_unittests. BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ica1b0f244138ed7a086f410b008c71783811ce53 Reviewed-on: https://chromium-review.googlesource.com/743692 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512635}
-
Matt Menke authored
He is no longer working Cronet (And hasn't for quite some time). Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia8b1a44a2e0823d37e51754627eda5c0725ade17 Reviewed-on: https://chromium-review.googlesource.com/744681Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512634}
-
Dave Schuyler authored
This CL changes the extension shortcut input UI from using a system of firing events and listeners for unit testing. It now uses a delegate at runtime and during testing. This cleans up the code and makes the tests simpler. This is a step toward putting the extension shortcut UI into a cr-lazy-render to improve the MD extensions startup time. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib338954407169fc5bb21e4055dca52d75c0dbf18 Reviewed-on: https://chromium-review.googlesource.com/741079 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#512633}
-
Brett Wilson authored
This is currently unused. I will use it in a follow-up patch to control some tab experiments I will be doing. Bug: 778461 Change-Id: Iec9a72c6bc682719f45a619f0a3bd752eebbfae5 Reviewed-on: https://chromium-review.googlesource.com/740950 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#512632}
-
Joel Einbinder authored
We don't highlight dom nodes when they are part of an object preview, so it was misleading to have a blue hover effect on them. Bug: none Change-Id: I4254032016b749208f27654f7ddefdecf6937bd6 Reviewed-on: https://chromium-review.googlesource.com/740673Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#512631}
-
Xianzhu Wang authored
Bug: 771401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I694526e70973702c575a71b414bf7980a5579a21 Reviewed-on: https://chromium-review.googlesource.com/741032 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512630}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/1a5cf00f7634..6fd9f08dcb0b $ git log 1a5cf00f7..6fd9f08dc --date=short --no-merges --format='%ad %ae %s' 2017-10-30 bsheedy Fix WebVR metric randomly not producing histograms Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I70275130f3002f611dfa2687fc6e119cf88a147a Reviewed-on: https://chromium-review.googlesource.com/744481 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512629}
-
Sergey Ulanov authored
Previously cast build bots were not building all cast tests, which made it easy to break an internal build. Change-Id: I250c114d30a7939cec395198ff567e0082f740ac Reviewed-on: https://chromium-review.googlesource.com/736860Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512628}
-
Christopher Cameron authored
Bug: 777756 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1df061c05bf176214c356def235e09eb9b145952 Reviewed-on: https://chromium-review.googlesource.com/741065Reviewed-by:
-
Penny MacNeil authored
Fuzzathon 2017. Bug: 648076,749793,773426,768111,754972,734401,734200 Change-Id: Ic608c5a374252809443a879ad4e2ddf8f6184697 Reviewed-on: https://chromium-review.googlesource.com/736159 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#512626}
-
Lukasz Anforowicz authored
This CL moves most of handling of view-source into the //content layer, exposing it through a single public API: void RenderFrameHost::ViewSource() This move helps to - Avoid passing PageState to the //chrome layer (e.g. via content::CustomContextMenuContext). - Create browser tests that can simulate triggerring a view-source from the code (e.g. without having to simulate mouse clicks). - Ensure that the right navigation entries are used - preventing incorrect reusing of main frame's site instance for showing a subframe's view-source (https://crbug.com/770946) This CL adds regression tests for https://crbug.com/523 that ensure that view-source for HTTP POST works fine in case of main frame and subframe. Works fine = no new network requests are issued (verified by a response nonce added to the /echoall default handler in the embedded http test server). Bug: 770487, 770946, 774691, 699493 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ic0afeed898b4f0900f3f8ad47a903f83f2c589d3 Reviewed-on: https://chromium-review.googlesource.com/695913Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
James Cook authored
Some methods date back to when aura::Window could not be used in mash, which is no longer the case. Inline laser pointer, partial magnifier, and modal window calls where they are used. Also allow laser pointer and partial magnifier to be enabled under mash, since the controllers exist now. Bug: none Test: ash_unittests (normal, --mus, --mash) Change-Id: I545450a863c2935ba3f262fa2a9a62e0772a033b Reviewed-on: https://chromium-review.googlesource.com/742494Reviewed-by:
-
Daniel Cheng authored
Use of pthread_once / InterlockedCompareExchangePointer dates from when GURL didn't live in the same repository as the rest of Chrome code. Change-Id: Ibce6c19eb87356b71245610bc1f7ffb3f0078dc5 Reviewed-on: https://chromium-review.googlesource.com/744384Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#512623}
-
Peter Wen authored
This allows editing all java targets in android studio when the --all flag is passed to generate_gradle.py. When --split-projects is used then it makes sense to restrict the number to a manageable amount, but when the modules are all merged it does not make much of a difference. Bug: 620034 Change-Id: Ie31e3d8c87338a27c5a3dd95b33a3876d25ff7a6 Reviewed-on: https://chromium-review.googlesource.com/744342Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#512622}
-
Vladislav Kuzkokov authored
This was a latent bug until Callback was changed to OnceCallback because callback could be called more than once. Bug: 778149 Change-Id: I8268de7e61c31406aa20f9005f37c08055bab03d Reviewed-on: https://chromium-review.googlesource.com/744023Reviewed-by:
Gene Gutnik <gene@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#512621}
-
Xiaohan Wang authored
Move |cdm_| to the bottom of the declaration list so that it is destructed first when CdmAdapter is destructed. This would help prevent |cdm_| from accessing other deleted member during destruction. Also clean up the declaration of other members to map initialization order. BUG=510088 Change-Id: I7c8535c503226089db1d7fd3ce6afcd22bc38dce Reviewed-on: https://chromium-review.googlesource.com/742327Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#512620}
-
Siddhartha authored
AllocationContextTracker tracks PCs just like pseudo stack when native stack is not available. Also remove NO_STACK mode. Remove behavior of adding type_name from trace category. BUG=760702 Change-Id: I884ae9f8c853ecdea5d531f8ebe6c871901b8255 Reviewed-on: https://chromium-review.googlesource.com/729548 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#512619}
-
Leonard Grey authored
Fixing crash for now, will deal with the larger question about whether chrome:// URLs should be shareable separately. Bug: 779575 Change-Id: I756c7912bc4d9dc51ea7a893498498b652125efa Reviewed-on: https://chromium-review.googlesource.com/744505Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#512618}
-
Lei Tian authored
ApiCompatibilityUtils.getUriForImageCaptureFile calls IO in UI thread in ShareHelper. Move it into AsyncTask.doInBackground to fix the problem. Bug: Null Change-Id: Id48bac34d269c5718b8abdc104042bd6b9f3e5d1 Reviewed-on: https://chromium-review.googlesource.com/742644 Commit-Queue: Lei Tian <ltian@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512617}
-
Jialiu Lin authored
Password manager code calls SaveSyncPasswordHash(..) every time user signs into google in the content area, thus triggers the preference change event that consequently trigger OnGaiaPasswordChanged(). This CL checks if the value of kSyncPasswordHash actually changed (vs. same password saved again) before triggering OnGaiaPasswordChanged() call. Bug: 767633 Change-Id: Iacb9c5bf75b7cd9ae92f24a2d0049ad44c99ffab Reviewed-on: https://chromium-review.googlesource.com/677883 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#512616}
-
Sunny Sachanandani authored
Use TexStorage2DImageCHROMIUM to allocate service side anonymous GpuMemoryBuffers instead of allocating GMBs client side. Add a new texture hint that can be used to allocate textures this way, and use it for overlay resources in GLRenderer. R=piman,ccameron BUG=768108 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1564dcb4d444b0b9c77e0486f38fd7ddea3da351 Reviewed-on: https://chromium-review.googlesource.com/714654 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#512615}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/87c358839ccd..e7c5f4f05c87 $ git log 87c358839..e7c5f4f05 --date=short --no-merges --format='%ad %ae %s' 2017-10-30 jmadill Fix compilation on mips devices. 2017-10-30 geofflang Disable WebGL texture_rg tests on all OpenGL ES. 2017-10-25 oetuaho Always consider type arrayness for atomic counters Created with: roll-dep src/third_party/angle Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Icca3ea25cf813b79d3071d640930b4acc5ed8a01 Reviewed-on: https://chromium-review.googlesource.com/744333Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512614}
-
dpapad authored
This eliminates usage of the deprecated paper-item, and also reduces the size of the optimized HTML file by 2kb (236->234). Bug: 778877 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I688b1ed7eb603ee6fa81e17a6956dce869519704 Reviewed-on: https://chromium-review.googlesource.com/742322 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#512613}
-
David Reveman authored
This improves the flash animation for photo taking by removing the use of a mask-image in favor of a border that can be animated and doesn't conflict with flash animations. This makes the removal of the circular frame used for preview less jarring. It also adjusts the delay of animations and defers image processing so that flash animations have a chance to finish running. Single photo mode uses white color ease-in animation, while video mode uses a less intense flash with 0.67 opacity. Last, it uses the first frame of PNGs as placeholder while larger animated PNGs are loading from object URLs. This prevents the loading from appearing as a flash. Bug: 773987 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibd1a2ec06984a38df685d6f5e29963debcc91190 Reviewed-on: https://chromium-review.googlesource.com/742801 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#512612}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/ce50239558ae..1d4c152a3836 $ git log ce5023955..1d4c152a3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7092b4c604af1613373061afdf9db7f0529b2a08 Reviewed-on: https://chromium-review.googlesource.com/744337Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512611}
-
Philip Rogers authored
This patch rebaselines 37 passing paint/invalidation tests. These baselines now match the non-RLS path with minor changes for scrolling layer differences. The updated expectations were generated by copying the non-RLS expectations and adjusting for the scrolling layer differences. Change-Id: Ib31f17a57a7abf7afc85cc1c0ee225ce42cdbb39 Reviewed-on: https://chromium-review.googlesource.com/742238Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512610}
-
sunxd authored
The test failed because we fix a cc picture layer tiling issue. It used to ignore any scale factors, so fixing it would bring pixel differences in the test. This CL increase the version number for rebaseline. Bug: 774354 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I38fee772dd9a8ed779c420acc6508077b45ebe1f Reviewed-on: https://chromium-review.googlesource.com/735074Reviewed-by:
-
Yuwei Huang authored
This is a reland of 9cbdf3dd Original change's description: > [CRD iOS] Workaround memory access bug in glTexSubImage2D > > The implementation of glTexSubImage2D from iOS seems to be buggy. It > attempts to read memory that is out of the expected upper bound: > kBytesPerPixel * (width + (height - 1) * stride). Given that SIGSEGV > only happens when offset_y + subimage_height == desktop_height, it > seems they attempt to read one more row of buffer for no obvious > reason (no extra artifact compared to Android). > > This CL introduces a PaddedDesktopFrame to workaround this problem > by padding the desktop frame data with one extra row, so that > glTexSubImage2D doesn't land on protected memory. > > Bug: 778550 > Change-Id: I250012e4fc6c43bb99c277a0275912c1ca120d51 > Reviewed-on: https://chromium-review.googlesource.com/742622 > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Commit-Queue: Yuwei Huang <yuweih@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512349} Bug: 778550 Change-Id: I2f6ea5db226aea7b68f34decf90fa7b97ed7d75c Reviewed-on: https://chromium-review.googlesource.com/742655Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#512608}
-
Hidehiko Abe authored
Before this change, PipeReader cannot report an error. With this change, it can. Also, simplify the cancel flow. Now, as a common pattern used across chrome repository, just deleting the instance will cancel the inflight operation. Also, PipeReaderForString was the only subclass. So merged PipeReader. Added unittests. BUG=776310 TEST=Ran bots. Change-Id: I6cda997b36db1703f79f9fe5e682f95af923ff3d Reviewed-on: https://chromium-review.googlesource.com/727445Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512607}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6e27fea..e2febff BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia48f19ed5895d22d38799cd13bbb7b42a98b9e52 Reviewed-on: https://chromium-review.googlesource.com/743698Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
