- 02 Jul, 2020 40 commits
-
-
Jeremy Roman authored
Bug: 1045521 Change-Id: Ib052ee6b6d763257538142164a5459ef9d2e0ae8 Tbr: khushalsagar@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280141Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784885}
-
Jeremy Roman authored
They are flaky in several different configurations. Bug: 1099847 Change-Id: Ic4d45a619bd72e070dbf7eb75ee3e55687341560 Tbr: jkrcal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280221Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf6b1c6739b7..28d76057f343 2020-07-02 tvanderlippe@chromium.org Fix dependencies for Rollup action in devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I403e4b120080eba5d79a11f35624de348e467b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id5f7e4468423f38ead625ac186a68e22024b3a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278857Reviewed-by:
-
Benoit Lize authored
They are still needed (experiment in progress), give them two more milestones. Bug: 1029320 Change-Id: Ice8d15f47711b21eafd602de90131a8661527446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279792Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784881}
-
danakj authored
Don't use test-only switches in production content_shell code. This moves all of the support for "headless" content shell out of production and into WebTestShellPlatformDelegate implementations. R=avi@chromium.org Bug: 866140 Change-Id: Ide5fe95da6019420faa418547bc6d46c6c53f919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276637Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784880}
-
Jeffrey Kardatzke authored
This is the media::CdmFactory implementation that utilizes the Chrome OS CdmFactoryDaemon to create CDMs in the Chrome OS daemon. Bug: b:153111783 Test: Prototype works w/ full implementation Change-Id: Idafb710bb710994dbdf77f13e0e742750a8d898c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274779 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784879}
-
Hirokazu Honda authored
Vp9Metadata is returned in VEA::BitstreamReady() on vp9 temporal layer encoding. RtcVideoEncoder propagates the metadata as webrtc::CodecSpecific as webrtc::CodecSpecific. It is important information so that libwebrtc and webrtc server works manages the video call to work effectively. Design doc: go/vaapi-vp9-TL Bug: 1030199 Test: blink_platform_unittests Test: appr.tc/?debug=loopback&vsc=vp9&vrc=vp9 with --force-fieldtrials=WebRTC-SupportVP9SVC/EnabledByFlag_1SL3TL/ --enable-features=VaapiVP9Encoder Change-Id: I0e2b4bb3b98bc04e55c767a7bba9316b6bea4eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153458 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#784878}
-
Lukasz Anforowicz authored
This CL adds a temporary CHECK to verify in the wild the hypothesis that the default URLLoaderFactory is only ever used for requests where network::ResourceRequest::request_initiator is an opaque origin. This CL should be reverted once we gather enough data to confirm or disprove this hypothesis / assertion. See also the discussion in network-service-dev@chromium.org at https://groups.google.com/a/chromium.org/d/topic/network-service-dev/hCk6fJJkNF4/discussion Change-Id: I846937c04583164880cb5893a350d26ec30b0048 Bug: 1098938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276756 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#784877}
-
Jamie Madill authored
This also adds a small runner script that will eventually move into the ANGLE repo. The standalone tests run as an isolated script. Also removes gpu_command_buffer_perftests from ANGLE Win bots to streamline the test set. Bug: angleproject:3162 Tbr: dpranke@google.com Change-Id: I210d935909c8a26970839405dbb14fa49e548b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239898 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784876}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I04d345d6340a7b72c55201fa52c6848aaf076378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277677Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784875}
-
Nicolás Peña Moreno authored
Expected Queueing Time (EQT) is no longer being used as a responsiveness metric. This CL makes the remaining UMA and UKM histograms obsolete and removes the code that computes EQT in the renderer. Change-Id: I28b66dabcfd764d6ab9a7b77a2cdc2572fa25b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268520Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#784874}
-
Eleonora Rocchi authored
This CL adds the handling of the click on the help button in the menu bar for the check passwords view. It also refactor some classes. Particularly, it separates the component UI from the feature component. Bug: 1092444 Change-Id: Id07a4914a3eb36600a3f0d0da47ac9788d8be2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275451Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#784873}
-
Vasiliy Telezhnikov authored
This CL adds two timestamps to SwapTimings: * Time when DisplayCompositor thread submitted work to GPU. For SkiaRenderer it's first PostTask with draw to main thread. For GLRenderer it's when flush happened. * Time when this work started to run on main thread. For SkiaRenderer it's the time when corresponding task started. For GLRenderer it's the time when flush started on gpu thread. Bug: 1064734 Change-Id: Id2f46a08cdbfec08377e022bd3a707e2c412ce05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260955Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#784872}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 Add the IPC InstallCoopAccessMonitor to the LocalMainFrame interface. This is called by the browser process whenever an access in between two windows would be blocked if COOP was enforced. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] this patch. TBR=mkwst@chromium.org Bug: chromium:1090273 Change-Id: I366ef78ec5ac59ca9475871928afd05d2e02fddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270185Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784871}
-
Kurt Catti-Schmidt authored
This change adds grid track collections to the NGGridLayoutAlgorithm, builds them and tests them, but does not use them. I also changed all usage of NGGridTrackRepeater::RepeatType to the previously existing enum AutoRepeatType. Bug: 1045599 Change-Id: I48b77823f4368138d5c361ad7f3ec0162fd25186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258901 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784870}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2d6b37bbda59..5d4c9817d54e 2020-07-02 capn@google.com Fix /DEBUG:FASTLINK usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iba13faeb08a90c861fe129bbda9c168e48c6d70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279635Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7236b38447586a20a1bb0cbdcfc0a5d662b69f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278854Reviewed-by:
-
Philip Rogers authored
This refactoring lets PendingLayers come from different PaintArtifacts by storing a PaintArtifact reference in each PendingLayer. PendingLayers from different PaintArtifacts cannot be merged because PendingLayer just has indices of paint chunks from one PaintArtifact. This patch is preparation for supporting SVG compositing and has no behavior change. Prototype of compositing in SVG: https://crrev.com/c/2250514 Bug: 1101002 Change-Id: I6d670e987eda1cd0162b03b0abe29b6423c879b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275492Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784867}
-
Mikel Astiz authored
Change-Id: I3305dc882881a3c69233e66ddf900958b608f66c Bug: 1089547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279203 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#784866}
-
Wei Lee authored
Bug: 980846 Test: None Change-Id: Ib3de228756edc6f1f4e4ecd69269a7b7098c5488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279252 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#784865}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29444c65244a..ec0af26ff8aa 2020-07-02 eshr@google.com [Adaptation] VideoStreamAdapter broadcasts adaptations 2020-07-02 sprang@webrtc.org Revert "Reland "Allows FEC generation after pacer step."" 2020-07-02 sprang@webrtc.org Reland "Allows FEC generation after pacer step." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1b4cfb39a1e16e16fa668444061865087cb1f088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279636Reviewed-by:
-
Matthias Körber authored
Currently, Autofill does not import address profile data from fields that are not focusable. This is problematic because such fields are often used in combination with synthetic form fields. To resolve this, a finch flag is implemented that allows importing profiles from unfocusable fields. This is a reland of f2db4e69 to fix a bad name for a finch experiment. Bug: 1101280 Change-Id: I9e8e734942dee897fa63959cc1f0cc441f0419e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278266Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784863}
-
Philip Rogers authored
This is a reland of https://crrev.com/784367 with the viewport leak tests fixed with https://crrev.com/c/2278083. The original change description is listed below: Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, dirtying TestRunner state for the next test. A navigation to about:blank is done after every test. This patch resets the TestRunner state after the navigation to about:blank, when we are sure no test javascript can change TestRunner state. This fixes a class of flaky bugs. This behavior happened with video-overlay-scroll.html which would set a custom layout dump (setCustomTextOutput) in a fullscreenchange event handler. This event handler was not removed at the end of the test (this will be fixed in a followup), and would run a second time, after the custom text output setting was reset. This caused later tests to run with custom text output from video-overlay-scroll.html. With this patch, video-scrolled-iframe.html is no longer flaky. Code in WebFrameTestProxy::BeginNavigation to intercept navigations relied on TestRunner::PolicyDelegateEnabled being reset before it ran. This patch now skips WebFrameTestProxy::BeginNavigation when the test is not running. Bug: 1048597 Change-Id: I454832953266bc93a0ad02e373009a168f724eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277871 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784862}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2b8d80936336..b7d4c458e24c 2020-07-02 fmayer@google.com Merge "Do not batch frees." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I52d0a3cb44907293565f6b1b32543e21e23b2029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279637Reviewed-by:
-
Philip Rogers authored
The web testing infrastructure has special logic for tests under the viewsource directory. This testing approach is difficult to maintain (see [1]) and is discouraged in favor of WPT tests. A recent change (see [2]) of when test settings are reset caused these viewsource tests to report leaks because the about:blank load between tests was run in viewsource mode, which did not match the hardcoded leak detector values (see [3]). This patch moves these viewsource tests to unit tests and removes the viewsource web test logic that is now unused. [1] https://groups.google.com/a/chromium.org/g/blink-dev/c/pi235gcfHZc/m/rDLQBFufDwAJ [2] https://crrev.com/784367 [3] https://cs.chromium.org/chromium/src/content/shell/browser/web_test/leak_detector.cc Bug: 1048597 Change-Id: I04fec3f5aee99237ae69ed6bcc26d02a1ae84a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278083Reviewed-by:
-
Ella Ge authored
Bug: 1007635 Change-Id: I6130122826e752443bdc7019cec05b1657f1fe92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279911 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#784859}
-
John Chen authored
This reverts commit 81525fe7. Reason for revert: Build failures on perf waterfall (https://crbug.com/1101820) Original change's description: > Roll src-internal from 30ceaafc85cb to 232b0b4dc0b5 (2 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30ceaafc85cb..232b0b4dc0b5 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC fdegans@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1025990,chromium:1101477 > Tbr: fdegans@google.com > Change-Id: Ie5458b19051dd27a52daa2bb2fc81f2e5564cdf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278214 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#784598} TBR=fdegans@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I750697fee1cfedb80630d7205233bae8cd81d376 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1025990, chromium:1101477, chromium:1101820 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278858Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784858}
-
Gauthier Ambard authored
This CL updates how the NTP animations to shift tiles up (i.e. when the omnibox is focused), using an animator instead of the regular UIView -animate:completion:. It allows to stop the animation in the middle without having the animated properties in an undefined state. Bug: 1101331 Change-Id: Iadff66283784c7a339770b58270099678cf2616c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278253 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784857}
-
Matthias Körber authored
The input and output file prefix of the test files start with 000 while the parameters for testing starts with 001. Consequently, the error message which test is failing is off by one. By renaming 000_* this should be fixed. Bug: 1100855 Change-Id: Ib90f68dd7754215e9b77b7eb6d4258d5ddccb746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275955 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#784856}
-
Stephen McGruer authored
This brings in support for the second HTTPS port. Bug: 1101075 Change-Id: I88fc627e4509648c323cde0ff37abf757975c5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277349Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#784855}
-
Dave Tapuska authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2243266 I missed that the edit commands were dispatched at the focused frame from the root frame widget. This caused a slight issue with Ctrl-left arrow on gmail causing a history back navigation. BUG=1099459 Change-Id: Iadb39bd3e031dca6e7c1165bf1be674b5de1f978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275490 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784854}
-
edchin authored
Test: Enable DragAndDrop flag. On iPad multitasking: drag item from reading list to another app. Bug: 1099921 Change-Id: Ief8508e18f178e3cc59e41b9a71a42b65bbe302b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277245 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#784853}
-
Christoph Schwering authored
AutofillHandler::OnFormsSeen() ignores cache hits unless the found form is a credit card form. As a consequence, the newly seen form overrides existing cache entry. In particular, the newly seen form's values are stored in the cache. This violates the invariant that cached forms' values are the initial field values. In particular, it means that user-filled values may be considered initial values, in which case they are ignored at submission time. This CL makes OnFormsSeen() treat credit-card and address forms equally (i.e., not ignore cache hits), provided that kAutofillKeepInitialFormValuesInCache is enabled, except that in these cases where cache hits were formerly ignored. As a temporary solution to avoid breaking the captured-site tests, one difference between credit-card and address forms remains: in those cases where the pre-experiment code ignores cache hits, the experimental code ignores the cached signature, i.e., updates the form's signature to the newly seen one's. Bug: 1091401, 1096990 Change-Id: I76aa6d2374a33a11433628adb7560af8cad9c557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273068 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784852}
-
Olivier Robin authored
Test now pass thanks to https://chromium-review.googlesource.com/c/chromium/src/+/2278763 Tbr: rohitrao Bug: 1099435,1099358,1101099,1099430,1099436,1099425 Change-Id: I9b82eb19959a4273005ec77e350071251501824a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274895Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784851}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53c05a8f0110..bf6b1c6739b7 2020-07-02 petermarshall@chromium.org tests: Make e2e --test-file arg relative to gen dir and document it If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1056140 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2e6239d9105e3c845fa5a20b4a1d6b5c5ff74cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279634Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65c9ff30..c5b71d2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie5669c7216d9dbe0e59041685b2fb0b669a0caab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279710Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784849}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/16ca52cc16ab..f695264d30e6 2020-07-02 cwallez@chromium.org Broaden -Wno-tautological-type-limit-compare 2020-07-02 jiawei.shao@intel.com Fix bugs in the multi-layer copies with BC formats on D3D12 and OpenGL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I22fd4f3a2332f84366674d163d44492dd45eff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279632Reviewed-by:
-
Guillaume Jenkins authored
Moves ChromeBrowserCloudManagementRegistrar to components/enterprise so it can be reused by iOS code. Bug: 1091930 Change-Id: Id91f8f85191cb14a0afde72debb7e172a3e236a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270348 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
Leo Lai authored
In order to make a better unittest for this function and to re-use the function in the rewritten attestation flow in the future, the mentioned function is moved out as a stand-alone function. BUG=b:158955123 Change-Id: Ia83e7bf701fe013a2d4935e7e779783e407a104b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279254Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#784846}
-
