GitLab

This reverts commit ff67881b.

Reason for revert: Updated credentials but that uncovered a bug with how we handle responses from the Gerrit API.

Original change's description:
> [WPT Export] Create GitHub PRs from Gerrit CLs
> 
> Bug: 700092
> Change-Id: I7fd398d1e25b77493eef609cbf818747216cd140
> Reviewed-on: https://chromium-review.googlesource.com/479931
> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#471061}

TBR=qyearsley@chromium.org,jeffcarp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: 700092

Change-Id: Ieb6f34d9762184033c10d6ba7c3b4e8208a7fe5b
Reviewed-on: https://chromium-review.googlesource.com/503553Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471109}

It makes the code simpler.

BUG=710535

Review-Url: https://codereview.chromium.org/2865403006
Cr-Commit-Position: refs/heads/master@{#471108}

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541

Review-Url: https://codereview.chromium.org/2875823004
Cr-Commit-Position: refs/heads/master@{#471107}

The functionality to store prefs under different keys in the in-memory
pref store that overlays the underlying profile's user prefs is unused.
Removing this functionality simplifies the code and helps the effort
of converting prefs to a Mojo service.

Bug: 654988
Change-Id: I5ae8455f64cbce685953b2c9ade6d17f17550921
Reviewed-on: https://chromium-review.googlesource.com/502387Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Johan Tibell <tibell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471106}

Use full URL spec if it ends with /

BUG=719982

Review-Url: https://codereview.chromium.org/2876053002
Cr-Commit-Position: refs/heads/master@{#471105}

changes default em font size to 16
changes default viewport size to 0x0

BUG=721498

Review-Url: https://codereview.chromium.org/2877823002
Cr-Commit-Position: refs/heads/master@{#471104}

Instead of disabling all GPU features because Intel HD 3000 is crash prone,
we force Chrome to use discrete GPU.

On the up side, now we can get WebGL back. On the down side, now Chrome on these
macbooks will burn energy more quickly.

BUG=720152
TEST=affected macbook
R=ccameron@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2874163003
Cr-Commit-Position: refs/heads/master@{#471103}

For some unknown reason, crrev.com/468815 caused multiple
telemetry tests to timeout. This patch partially reverts
that revision, applying another fix to original bug by
re-requesting target type on demand.

BUG=718952,717003

Review-Url: https://codereview.chromium.org/2873393002
Cr-Commit-Position: refs/heads/master@{#471102}

Include a user interaction in order to trigger beforeunload dialog.

BUG=chromedriver:1803

Review-Url: https://codereview.chromium.org/2878703003
Cr-Commit-Position: refs/heads/master@{#471101}

BUG=675877,720442

Review-Url: https://codereview.chromium.org/2872273004
Cr-Commit-Position: refs/heads/master@{#471100}

This CL moves around some code for Chrome OS OOM handling to make
the code a bit easier to follow:

* Previously, code for selecting "protected" processes was scattered
  around the file. One was in TabManagerDelegate::GetSortedCandidates
  for protecting PERSISTENT processes from *both* Chrome and kernel
  OOM handler, and the other was in LowMemoryKillImpl for protecting
  FOCUSED and VISIBLE processes from *only* Chrome. This CL moves the
  former to AdjustOomPrioritiesImpl to simplify the code.
* Previously, tab_manager_delegate_chromeos.cc also directly used
  arc::mojom::ProcessState enums. This CL moves the code to
  arc::ArcProcess with unit tests to hide ARC details from the
  TabManagerDelegate class.
* Previously, AdjustOomPrioritiesImpl had an assumption that the
  processes the function protected from the kernel always had -1000
  OOM adjustment scores. The assumption is fine, but will make it
  difficult for us to e.g. protect arc::mojom::ProcessState::TOP
  processes from the kernel because unlike PERSISTENT ones, TOP
  processes change time to time and may have positive OOM adjustment
  scores. With this CL, AdjustOomPrioritiesImpl explicitly sets
  -1000 for processes the function protects to remove the assumption.
  In the future, we can modify ArcProcess::IsKillableForKernel as we
  like to experiment various OOM scoring policy without any
  artificial restrictions.
* Add more unit tests for better code coverage.

This CL does NOT change the current Chrome/kernel OOM handling
behavior at all. This is pure code refactoring. Also, this CL
does not touch the code for handling Chrome tabs. This is only
for ARC.

BUG=719537
TEST=try
TEST=just in case, manually confirmed PERSISTENT processes still
 have -1000 adjustment.

Review-Url: https://codereview.chromium.org/2874543002
Cr-Commit-Position: refs/heads/master@{#471099}

Until we have a distinction between owned and unowned prefs sending
these around just wastes CPU cycles. This makes startup 2ms faster on a
Nexus 9.

Bug: 654988,719770
Change-Id: I87e5c8da9d93226dfdf47acedf42c75f07f01a77
Reviewed-on: https://chromium-review.googlesource.com/497113Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Johan Tibell <tibell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471098}

- implement mapping for inline styles in HTML locally in CoverageDecorationsManager as a workaound for bindings deficiencies;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG=719113

Review-Url: https://codereview.chromium.org/2861393004
Cr-Commit-Position: refs/heads/master@{#471097}

Deprecated in favor of passing such arguments to test_runner.py
directly.

BUG=700366

Review-Url: https://codereview.chromium.org/2855483003
Cr-Commit-Position: refs/heads/master@{#471096}

In ComputedStyle::InheritFrom, we assume that the UserModify() field is
always stored in RareInheritedData. After we generate the user-modify
property, we might want to change where it is stored, so UserModify may
no longer be in RareInheritedData. This patch rearranges the logic in
the function so that UserModify can be stored in any subgroup without
breaking the code. There are no changes in behaviour.

BUG=628043

Review-Url: https://codereview.chromium.org/2829773003
Cr-Commit-Position: refs/heads/master@{#471095}

This histogram *should* be named OptOuts, but I gave it the wrong name
in the code. For now, I just want to be able to see it in UMA.

Review-Url: https://codereview.chromium.org/2875073002
Cr-Commit-Position: refs/heads/master@{#471094}

Using wpt-import in Chromium 52eb504e.

Trying a manual import after the failure of
https://chromium-review.googlesource.com/c/499769/.

NOEXPORT=true

Change-Id: I452e04153af14f50f73c2d483e768dc8d5f779ce
Reviewed-on: https://chromium-review.googlesource.com/499507
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471093}

SameSizeAsComputedStyle is meant to be tracking the data layout of
ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle
to ComputedStyleBase without updating the size assert. This was a
silent issue because we changed only the layout, not the size.

This patch updates SameSizeAsComputedStyle to reflect the current state
of ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2863423002
Cr-Commit-Position: refs/heads/master@{#471092}

BUG=721502

Review-Url: https://codereview.chromium.org/2875103003
Cr-Commit-Position: refs/heads/master@{#471091}

Autosizing can be triggered through devtools on desktop nowadays.

BUG=675877

Review-Url: https://codereview.chromium.org/2874783003
Cr-Commit-Position: refs/heads/master@{#471090}

Remove obsolete PaintImage trace from StyleFetchedImage::KnownToBeOpaque
and StyleFetchedImageSet::KnownToBeOpaque. Trace was originally added in
late 2014 (in r186030) to the ImageResource::currentFrameKnownToBeOpaque
method as it, at the time, caused a forced decode for the image. That is
no longer the case yet the trace call has stubbornly survived unchanged.

R=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2880573003
Cr-Commit-Position: refs/heads/master@{#471089}

Revert of Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder (patchset #2 id:20001 of https://codereview.chromium.org/2854363002/ )

Reason for revert:
Builder failing: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Original issue's description:
> Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder
>
> This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead
> of an AudioFifo, to avoid copying data needlessly.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2854363002
> Cr-Commit-Position: refs/heads/master@{#471039}
> Committed: https://chromium.googlesource.com/chromium/src/+/678c74cf3e17aaef9562ee13df8c803e1d014fc6

TBR=mcasas@chromium.org,miu@chromium.org,c.padhi@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2873123005
Cr-Commit-Position: refs/heads/master@{#471088}

Fragmented PaintLayers do not paint atomically (though each fragment
does). PaintController, however does not support a fragment as a
DisplayItemClient key for subsequences.

BUG=717335
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2865403002
Cr-Commit-Position: refs/heads/master@{#471087}

This CL is in response to perf regression (see referenced bugs).

BUG=697947, 697665

Review-Url: https://codereview.chromium.org/2871843003
Cr-Commit-Position: refs/heads/master@{#471086}

The app custom bindings (and handler counterparts) had issues. Fix some
of them.

BUG=None

Review-Url: https://codereview.chromium.org/2859233003
Cr-Commit-Position: refs/heads/master@{#471085}

BUG=718674

Review-Url: https://codereview.chromium.org/2858683006
Cr-Commit-Position: refs/heads/master@{#471084}

https://chromium.googlesource.com/angle/angle.git/+log/b4cf565..82830ed

BUG=
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2878593004
Cr-Commit-Position: refs/heads/master@{#471083}

https://chromium.googlesource.com/external/swarming.client.git/+log/e6fc9383ad7c..a941a089ff10

$ git log e6fc9383a..a941a089f --date=short --no-merges --format='%ad %ae %s'
2017-05-11 maruel Revert "named caches: move instead of symlinking"
2017-05-10 nodir named caches: move instead of symlinking
2017-05-10 maruel swarming: fix support for raw command + isolated file
2017-05-09 qyearsley Rephrase a message in run_isolated to be more polite/formal.
2017-05-09 maruel swarming.py: remove old auto-isolate support

Created with:
  roll-dep src/tools/swarming_client

The last commit above may break users, if they specified the isolated hash
as an unnamed argument, i.e. not using the -s/--isolated flag. At worst it is
safe to revert.

R=iannucci@chromium.org

Bug: 
Change-Id: I21f53429a8e16dbd5754770bc1194fc018bf5615
Reviewed-on: https://chromium-review.googlesource.com/503507Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471082}

Before this patch, a PaymentRequest for USD $100.00 would show all
available payment apps in Chrome UI, even if some of the apps do not
carry enough balance.

This patch adds a "total" parameter to IS_READY_TO_PAY service. This
parameter is JSON-stringified PaymentCurencyAmount. For example:

  {"currency": "USD", "value": "10.00"}

After this patch, payment apps can decide to return "false" to
IS_READY_TO_PAY query if they do not carry enough balance. These apps
would not be available in Chrome UI when a PaymentRequest for too high
of an amount is created.

Spec:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

BUG=620173

Review-Url: https://codereview.chromium.org/2873503006
Cr-Commit-Position: refs/heads/master@{#471081}

BUG=703369

Review-Url: https://codereview.chromium.org/2872983002
Cr-Commit-Position: refs/heads/master@{#471080}

https: //codereview.chromium.org/2877553003/)
Review-Url: https://codereview.chromium.org/2881603002
Cr-Commit-Position: refs/heads/master@{#471079}

Before this CL, the ConditionValidator::MeetsConditions(...) method only
returned a bool value whether all conditions were met. This made it
harder to track what went wrong in a generic way across all validators,
so this CL changes the return value to be a struct that contains
information about all conditions, and whether they were met.

In addition, to prepare for an upcoming CL that will need to use the
current day to figure out whether conditions are met, that parameter
is added in the current CL.

BUG=706309

Change-Id: I73815d88facfc1fbee9e6a0058790cd4b73dc714
Reviewed-on: https://chromium-review.googlesource.com/502731Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471078}

BUG=666502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2614423002
Cr-Commit-Position: refs/heads/master@{#471077}

After ES6 modules loading for PaintWorklet (issue 627945) is introduced, layout
tests for PaintWorklet are no longer able to run on non-http environment because
ES6 modules does not support "file://" url (See https://crbug.com/594639#c86).

This CL moves the tests in inspector/console/ to http/tests/inspector/console/
to enable them to run with module loading.

BUG=719857

Review-Url: https://codereview.chromium.org/2881443003
Cr-Commit-Position: refs/heads/master@{#471076}

Since the dep is also conditional, not doing this fails gn check.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2876873002
Cr-Commit-Position: refs/heads/master@{#471075}

BUG=522168

Review-Url: https://codereview.chromium.org/2878713002
Cr-Commit-Position: refs/heads/master@{#471074}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Switching from MessageLoopForIO to ScopedTaskEnvironment in
NetTestSuite allows Scoped(Async)TaskScheduler to be removed
from individual net unittests.

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584

Review-Url: https://codereview.chromium.org/2839663002
Cr-Commit-Position: refs/heads/master@{#471073}

Broken in 40a227b7, we currently don't build for subrepo (and the script
fails).

BUG=695182

Review-Url: https://codereview.chromium.org/2876033002
Cr-Commit-Position: refs/heads/master@{#471072}

BUG=704259

Review-Url: https://codereview.chromium.org/2851603002
Cr-Commit-Position: refs/heads/master@{#471071}

It was written assuming its only caller would be Blink, but that's no longer the
case. Separate the Blink-specific stuff into a new Blink documentation file.

BUG=NONE
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2870213002 .
Cr-Commit-Position: refs/heads/master@{#471070}