- 15 Nov, 2019 9 commits
-
-
Demetrios Papadopoulos authored
Ther accidentally converts |controlElementsWithAutocomplete| to a string before passing it to __gCrWeb.fill.formOrFieldsetsToFormData(). Bug: None Change-Id: I7d97914d55d96639296bed2af0c8090fee1fb99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914798Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715512}
-
Michael Spang authored
This reverts commit 5989e357. Reason for revert: Wrong culprit as Determinic Linux (dbg) is still red after reverting. The failure is in pak files which this shouldn't affect. Original change's description: > Revert "views: Enable toolkit_views on Chromecast builds that use views" > > This reverts commit 57ee9cf0. > > Reason for revert: Speculative revert for the failures on deterministic builds, e.g. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/12654 > > Original change's description: > > views: Enable toolkit_views on Chromecast builds that use views > > > > Chromecast uses views, but does not set toolkit_views=true. Set this to > > true & remove desktop-oriented code that breaks in this case. > > > > This replaces !defined(OS_CHROMEOS) with a new > > BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views. This > > is needed because Chromecast doesn't use desktop_aura and uses aura > > similarly to Chrome OS by creating one WindowTreeHost for the display > > [alternative suggestions on how to handle this distinction welcome]. > > > > This does not enable views in content(_shell) yet. That's left to the > > next patch as it changes the UI. > > > > As of this change, views_unittests passes in Chromecast Linux builds. > > > > Bug: 1021770 > > Test: views_unittests, content_browsertests on is_chromecast=true build > > > > Change-Id: I54e79402a761572feb76f122ed846558e84210b6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Michael Spang <spang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#715183} > > TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org > > Change-Id: I17c9efdff45b51d3a215bccd3be9eb9418478de0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1021770 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917294 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715327} TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org,steimel@chromium.org Change-Id: Ic7385336d896988c7bac9fd06f24f3cc048ba3af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918287Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715511}
-
Michael Spang authored
This function creates a gfx::Transform which is a floating point matrix. Change the gfx::Size argument to gfx::SizeF. This is needed to de-duplicate with ash::CreateRotationTransform, which sometimes transforms non-integer sizes. Bug: 1019015 Change-Id: I49294b123c546a7e54fe9f1ef2a63c62307dec38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914960 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#715510}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c98dded5. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." f55f08c7 "[Background Sync] Update idlharness test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mcasas@chromium.org: external/wpt/geolocation-API NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8197dff6f639da9d067dc4159004113622e0c889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917087Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715509}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7434231471c18588061be575cfe765020bb2ff80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918182Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#715508}
-
Lambros Lambrou authored
The IT2Me host bundle did not have any bundle icon. This bundle appears in Security & Privacy permissions lists with a stock Apple icon, so this CL adds a proper .icns file to the bundle. Change-Id: I115f35e2cfeaccd402064d1403a9ce26f08a63bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918026 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#715507}
-
Yuchen Liu authored
This fixed the build failure when ENABLE_CAST_RENDERER but not USE_CHROMECAST_CDMS. Without the internal part, CastMojoMediaClient always creates CastCdmFactory which is a dummy impl. Also remove USE_CHROMECAST_CDMS on the use of MediaDrmStorageImpl mojo connection. In addition, add missing header file to cast_content_browser_client_receiver_bindings.cc. Bug: None Test: Build, CQ Change-Id: I7376441b342e5320cdb3c7322a5ad5d7a7ed5e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913474Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715506}
-
Karan Bhatia authored
addDynamicRules method was recently removed in r714353 and replaced with updateDynamicRule. Remove the last mention of addDynamicRules from the docs. BUG=1023501 Change-Id: Ia00669bc84fbb0136a9f2cfe73d37b474e3579bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918519Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715505}
-
Connie Wan authored
- Removed IsTabPinned() check: This was only necessary before crrev.com/c/1898620, where groups were potentially created pre-navigation. There are already post-nagivation checks to make sure that a pinned tab is never grouped, so that it will never spawn a grouped tab: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=1981&rcl=16740b37447c5c07bebcfe2162e868b63b50ec1d - Checked for valid index: This isn't strictly necessary because GetTabGroupForTab() handles this gracefully (https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=873&rcl=16740b37447c5c07bebcfe2162e868b63b50ec1d), but it's still the desired behavior to return early in this case, and it's better to be explicit with this check. This was the root cause of the crash in the attached bug, when combined with IsTabPinned(). Bug: 1024485 Change-Id: I8650da21eb6d72539753ecf740644018a624aa02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917319 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#715504}
-
- 14 Nov, 2019 31 commits
-
-
kylechar authored
The GPU.CompositingMode histogram will periodically record what compositing mode is being used. Since we can switch from GL to software compositing at any time for a variety of different reasons this will provide a more comparable measure. Include Vulkan and Metal in the compositing modes enum as they are necessary soon. Bug: 1021645 Change-Id: Id78a34a171c771c000822ab474865c2931434a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899559Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715503}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/168bb0dc14f2..102fd19c65f4 git log 168bb0dc14f2..102fd19c65f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 amaiorano@google.com PixelRoutine: const-qualify reference parameters Created with: gclient setdep -r src/third_party/swiftshader@102fd19c65f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/143351714 Change-Id: I60fe61c5a5776e949ddb7fcbc3f6e1a331c21eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917989Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc70a4f8a96a..026ada55a386 Created with: gclient setdep -r src-internal@026ada55a386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3f3c0ee44ea89087a505cfc6d9d3dba7e07d8860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918044Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715501}
-
Yue Zhang authored
Instead of getting location of the animation source card relative to recyclerView, this CL gets its global position to make the animation more robust to different layouts. Bug: 995423 Change-Id: I349e219356cabc1e5704ba1a1cc62b92791a7ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896297Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715500}
-
Edward Jung authored
This updates Enabled B setting to a slower 300-800ms range. Reduces the tab strip mouse out and return buffer to 300ms. Change-Id: I6f19d45aae8cb5b5d6dbc30cdd6521c4093f9918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914361Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#715499}
-
Ce Chen authored
suggestions. Bug: 925072 Change-Id: Ia22128991b70a5ce69f48ab2eb89c20e6af10b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918119 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715498}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/58dbfcae38f4..9b67273de9e5 git log 58dbfcae38f4..9b67273de9e5 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 ellyjones@google.com build: assert use_dawn Created with: gclient setdep -r src/third_party/dawn@9b67273de9e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:None Change-Id: I55404f6de3f1cbf5838ad7a02e68d9e6edecdbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917990Reviewed-by:
-
Toby Huang authored
Currently, ParentAccessServiceTest uses LoginPolicyTestBase to log in as child user for tests. We should deprecate LoginPolicyTestBase in favor of LoggedInUserMixin instead. This CL converts ParentAccessServiceTest to replace LoginPolicyTestBase with LoggedInUserMixin for logging in as child user for tests. Bug: 1014663 Change-Id: Ied5b53ee8ec2f44d5dc2193f011b741217080eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909273Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#714592} Signed-off-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914348 Cr-Commit-Position: refs/heads/master@{#715496}
-
Toni Barzic authored
AppListControllerImpl: if overview mode starting animation was canceled, the overview is about to start exiting, so update app list visibility accordingly - app list will not be occluded by overview, so its visibility should be determined by whether any windows are visible (this avoids changing the app list visibility to false for a moment before overview exit starts). In ShelfLayoutManager do not reset workspace update blockers as another overview animation is about to start. BUG=1024510 Change-Id: Ia5ac80f394a1d977c25b3dcac9cdae89c93dae16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914532Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715495}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5c144f39feb1..dad08eab03cc git log 5c144f39feb1..dad08eab03cc --date=short --no-merges --format='%ad %ae %s' 2019-11-14 ilkos@google.com Merge "Write process tree when polling /proc irrespective of on-demand quirk" Created with: gclient setdep -r src/third_party/perfetto@dad08eab03cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3b99d8abd299b16126b7c74c5b1dad320d3ae65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917992Reviewed-by:
-
Daniel Murphy authored
During phase one of a transaction commit, all to-be-written blobs need to have their keys generated and then added to the primary journal (to be renamed to 'recovery' journal). This operation has to happen independently of the transaction, as many transactions can be writing blobs independently of one another. In a refactor I did, I mistakenly made the transaction used to save the primary journal AND the 'next blob key' data as part of the committing transaction. This results in the possibility of two transactions, both saving blobs, trying to save data to the same file. It also means that if a crash or error occurs during commit, that primary journal wasn't updated correctly and any blobs that were written to disk won't be cleaned up. This patch fixes this by making those writes happen independently of the committing transaction. R=enne@chromium.org Bug: 1024375 Change-Id: I997854218a59952f8bcfff2b53a147d28397e731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914297 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#715493}
-
Peter Boström authored
With this change the |point| argument is replaced by Button::GetMenuPosition which callers can call if they need it. Most callback sites did not make use of it. There's a remaining TODO to make sure that MenuButtonController never gets a nullptr Event. For now, as ButtonListener requires an event, we just synthesize one. Fixing this requires some additional forwarding of events. There's also some semi-gross event bouncing in BookmarkBarView as I couldn't trivially figure out how to unify the two ButtonPressed callbacks (from MenuButton and Button respectively). Bug: None Change-Id: I153798dbae9863293cb3888fcf2de4a1a39f45d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917747 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bacb84b99758..966c82596b15 git log bacb84b99758..966c82596b15 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 jrn@google.com Revert "List which tests are googlesource.com qualification tests" Created with: gclient setdep -r src/third_party/chromite@966c82596b15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I440de2085d28be01573ff0be93540518951e2e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917985Reviewed-by:
-
Ryan Hansberry authored
crrev.com/c/1758837 intended to restrict OOBE HID detection logic to only run on devices that it should (e.g., Chromeboxes), but overlooked the instantiation of HidDetectionScreen, which once created, goes ahead and tries to connect to all HID devices even when the actual screen is not shown. This CL corrects that oversight and only creates HidDetectionScreen when it is known to be needed. This CL also adds a WizardController::HasScreen() method to facilitate testing. Using WizardController::GetScreen() to test the absence of the HIDDetectionScreen does not work because it triggers a DCHECK in SCreenManager [1]. 1) https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/screen_manager.cc?l=25 Bug: 1007500, 1024479 Change-Id: I362a05bad73a2876d4b3a937b99823a90fa3e3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915080 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#715490}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=mseaborn@chromium.org Bug: 1024981 Change-Id: I2d6317c780f849bb47e943d48868fe24283120f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918157 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#715489}
-
Tommy Steimel authored
This test was recently marked as flaky on debug builds, but it is also flaking on release builds. Example: https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/419689 TBR=cmp@chromium.org Bug: 1022915 Change-Id: Ieca4c3b5b0f435862c28aa818f237ade814e1389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918087Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715488}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=tguilbert@chromium.org Bug: 1024981 Change-Id: I3b28a9c786a9e58707716ce0b2162c9e18dad02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918150 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#715487}
-
Tommy Steimel authored
This reverts commit 6a44cbfb. Reason for revert: Causing ozone_unittests failures on msan bots: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16285 Original change's description: > Disable Render Buffer Compression on external displays. > > When Getting format modifiers, exclude I915_FORMAT_MOD_Y*_TILED_CCS > (Intel color control surface (CCS) for render compression) if it's not > an internal display. > This solves the bandwidth issue when driving more than 1 4K monitor with > rbc enabled. > > BUG=996011,996036,994341,979736 > TEST=External display doesn't pick I915...CSS modifier > > Change-Id: I9d7aa06f5f9331d232a3cbd7e74bd41771bc4030 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912460 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715332} TBR=spang@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org,tutankhamen@chromium.org,markyacoub@google.com Change-Id: Ie9495bbd892a5b736f1f70cb60edbf1b14c21eed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996011, 996036, 994341, 979736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918364Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1024981 Change-Id: I11e16eb6457e3de133bf6528b437f0753e73b5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918322 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715485}
-
Reilly Grant authored
Bug: 1007783 Change-Id: I0f7fd63da98bfc9ea6d869cea97072c7c94a30be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917741Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715484}
-
Roger Tawa authored
SafeBrowsingPrivateEventRouter should have tests that verify the feature flag works as expected. Bug: 1021935 Change-Id: I1dd181b2c68b319cb3193ed021e9633dd7c0cbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912141Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#715483}
-
Brian Sheedy authored
This reverts commit 4430c28a. Reason for revert: https://crbug.com/1024954 Original change's description: > Use grey triangle icon for HTTP when experiment enabled (Android) > > Bug: 1008219 > Change-Id: If02a36539fe61e71d1434528ec5af31d3914439b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889116 > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714377} TBR=mthiesse@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008219 Change-Id: I3f63150118c21da153c995529848fc92cd18bd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918103Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715482}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3da78c4bb7dc..336e51f68564 git log 3da78c4bb7dc..336e51f68564 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 ehmaldonado@chromium.org depot_tools: Execute tests using bot's vpython instead of depot_tools' vpython Created with: gclient setdep -r src/third_party/depot_tools@336e51f68564 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ie966f0772192a856bd3803dd8b80a2dd5428949d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918043Reviewed-by:
-
zhaoyangli authored
Bug: 1024699 Change-Id: Iffaf410380e85376abbfcffad44a56952c905fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917602Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715480}
-
Ian Clelland authored
This aligns the end date with other FP histograms. Bug: 1021139 Change-Id: Ic132a07c1dfe804d8e7d0456b8f641e8c15cd10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913869 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715479}
-
Robert Ogden authored
Launching feature Bug: 914577 Change-Id: I4e050a6e2f3be795ee4402d5a8f87876122a9ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913524Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8fccd236..ef60c912 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4779f85a8cc5208b2836c89082f36a9756268a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917086Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715477}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 1024981 Change-Id: If554e4d375338cb2a814196a4436694cf697f8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918223 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#715476}
-
Garrett Beaty authored
Change-Id: I269cf8994e966eb9dae19e7c6c7c86e66e2f8a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918085 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
The flag was removed through https://crrev.com/c/1873384. Bug: 959850 Change-Id: I49916760f106bb5e07f468eb9bb04e547b52d231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918101Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#715474}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3120d0337382..c95e54b558d9 git log 3120d0337382..c95e54b558d9 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 rmistry@google.com Specify only luci buckets instead of hardcoding trybot names 2019-11-14 ahujabharat93@gmail.com Issue- >Skia tiled bitmap rendering is too slow when tildmodeX is not same as tileModeY. 2019-11-14 jvanverth@google.com Reduce scaling of large SDF glyphs on Mac. 2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c95e54b558d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:1003270 Change-Id: I8bd17b0fcf9ab00c77c458821bd208de023d83dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918041Reviewed-by:
-
