- 28 Aug, 2019 40 commits
-
-
Kent Tamura authored
This CL reduces estimated pre-processed size of animatable.h from 3.52MB to 1.97MB. This CL avoids unnecessary copy of a UnrestrictedDoubleOrKeyframeAnimationOptions object on animate(). Bug: 242216 Change-Id: I066c1b6e92a0fbbdd1ee141403d134a97258978b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774001 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691056}
-
Julie Jeongeun Kim authored
This CL converts TrustedURLLoaderHeaderClientRequest, TrustedURLLoaderHeaderClientPtrInfo and TrustedURLLoaderHeaderClientPtr to new Mojo types. Bug: 955171, 978694 Change-Id: I282ceb552522adc42e8b03d64d26b1bf1c2dd5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768841 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#691055}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e36b85f34d27..cd3216543d0a git log e36b85f34d27..cd3216543d0a --date=short --no-merges --format='%ad %ae %s' 2019-08-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 57ad1e1287dd..886698bc3fdd (7 commits) 2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 31c682b2..c96d445d (397 commits) Created with: gclient setdep -r src/third_party/skia@cd3216543d0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None,chromium:None Change-Id: I06b588baa2feded3bc8b72cf0cf51041bf8728b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774221Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a8dc5068079..7d2e5f8ebe67 Created with: gclient setdep -r src-internal@7d2e5f8ebe67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ieefddf6855fbbaa7c96f45b7af3c5eed515c78e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768653Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691053}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f96048c9. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib24c68cae0f3b66364a8b2a05d6237809356c28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774118Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691052}
-
Jinsuk Kim authored
Replaces gesture navigation arrow bubble drawable with a 9-patch one that doesn't need raw color constants. And made the size a little bigger (40dp for bubble, plus drop shadow) as suggested. Bug: 991785, 993506 Binary-Size: Increase needed for binary resources. Change-Id: I36da352899428291ffbbfd8797b3abec581ea9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771638 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#691051}
-
Mario Sanchez Prada authored
Add a new override for InterfaceGetter<> to handle a PendingReceiver<T> and compatible callback, so that we don't need to implement wrappers all around when migrating to the new Mojo types. Additionally, clean up all the instances where such wrappers have been used so far, now that we can use the PendingReceiver<T>-based methods. TBR=mvanouwerkerk@chromium.org Bug: 955171 Change-Id: I028faefc9c50b7d422d4713cdd7c8f87ccded220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769449 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#691050}
-
Kent Tamura authored
This CL reduces estimated pre-processed size of css_primitive_value.h from 2.93MB to 2.01MB. Bug: 242216 Change-Id: I3e73fbb893368ec3b2fbe9e4c3445a60f805243e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772781 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#691049}
-
Robert Liao authored
This is a refactor change and is preparation for menu text to use STYLE_SECONDARY for minor labels (labels appearing alongside the main label in a menu like for keyboard shortcuts). This also fixes a definition in chrome/browser/ui/views/chrome_typography.h to correctly align CHROME_TEXT_STYLE_START with the beginning of the enum. BUG=865318 Change-Id: I01a12ca482e498d820675e7553e9a3fd92562c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766771 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#691048}
-
Meredith Lane authored
Spec: https://whatpr.org/html/3917/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes:element This change: - updates v8 bindings and IDL - Implements (most) of the HTML spec for the three attributes listed above. This change is part of the experimental AOM project, and allows attributes that reflect ARIA relationships to return an element reference corresponding to the ID stored in the content attribute, rather than the string ID itself. These attributes are exposed on the IDL interface AriaAttributes. See https://rawgit.com/w3c/aria/master/#AriaAttributes for more information. Attributes reflecting multiple element references will be implemented using FrozenArray<Element> in a follow up CL. BUG=981423 Change-Id: I35164b436c7e2ffd67a80ebd26e4233189e445b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687013 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691047}
-
Canon Mukai authored
WebSocketDeflaterTest.WindowBits11 was added by accident in https://chromium-review.googlesource.com/c/chromium/src/+/1767285. Remove it. Bug: 757387 Change-Id: I41e66514eaedf1b76612b2bc4f929f69bf51c979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773883Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#691046}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cd38a17..568f3984 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icc1a1ace7116865b24c76e3df09834b6c3f33b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691045}
-
Darren Shen authored
This reverts commit a50dfe61. Reason for revert: Possible cause of crbug.com/998385. Original change's description: > Add domain joined check to managed device detection for DoH. > > Some devices may be domain joined but not have any active policies. > We should also disable DoH by default for that scenario. > > Bug: 955454 > Change-Id: I50ad015e9e5d072dddcaa72524e5d39ffb2e005c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773397 > Reviewed-by: Eric Orth <ericorth@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#690809} TBR=ericorth@chromium.org,dalyk@google.com Change-Id: I22da3426da2a759230917f18b3d81d4075ecd9d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772934Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691044}
-
Fergal Daly authored
There were multiple problems: - the tests all passed all the time because displayLocking was disabled, so nothing ever got locked (crbug.com/986574) - the content of the test files was incorrect, they were all executing the same test entry from ref-tests.js (looks like the last patchset overwrote them all, https://chromium-review.googlesource.com/c/chromium/src/+/1680170/35..36 . - the scroller takes several frames to full unlock the correct elements, so this change adds a 1s delay to give it time. - the part.html test is actually failing crbug.com/998356 and so remains disabled for now. BUG=986574 Change-Id: I443ad7a1ce1eb6fd3d8c227e4635ceec0ebcd81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772951Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691043}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f0b17d00b98d..7ffd2346f8fa git log f0b17d00b98d..7ffd2346f8fa --date=short --no-merges --format='%ad %ae %s' 2019-08-27 bryan.bernhart@intel.com Resource Management 5: D3D support for resource allocation. Created with: gclient setdep -r src/third_party/dawn@7ffd2346f8fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I183eddfe2a19bff7521b6088ca3a3b80f0ae48f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691042}
-
Takashi Toyoshima authored
This patch increase the kMaxKeyLength limit, and see how this can improve cache uses by restoring the removed metrics. Bug: 996861 Change-Id: I00be259603b69e5196e7a9729ef1cc509357baeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771367Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691041}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7be971fa3a4e..e36b85f34d27 git log 7be971fa3a4e..e36b85f34d27 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 605f863173b6..cde4dd9601ce (9 commits) Created with: gclient setdep -r src/third_party/skia@e36b85f34d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None Change-Id: I6ef6e90eb22e0ff4918184227c640afcdc8fc355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691040}
-
Yang Guo authored
R=luoe@chromium.org Change-Id: Ib6a5ad8ab65d44e7068645b455b786b948324a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768431 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#691039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b2f2b335b20..b94afc0b88e6 git log 1b2f2b335b20..b94afc0b88e6 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 vapier@chromium.org lint: fix trailing-comma-tuple warnings/errors 2019-08-28 vapier@chromium.org import configparser from six.moves 2019-08-28 zamorzaev@chromium.org cbuildbot: Fix a keyval bug Created with: gclient setdep -r src/third_party/chromite@b94afc0b88e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7413caf928d599b43a0b1f768b189dd87d851bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691038}
-
Christopher Cameron authored
AppShimHost repeatedly queries AppShimHandler::Get to call out of itself. In practice, these always go to the ExtensionAppShimHandler that owns the AppShimHost. Remove these functions from AppShimHandler and put them in the AppShimHost::Client interface. Make the AppShimHost take a Client at creation time (which is safe, now that AppShimHost is owned by ExtensionAppShimHandler). Document that this is the interface between AppShimHost and ExtensionAppShimHandler. Bug: 982024 Change-Id: I954ce6f639596c4c930b701ed9770258852d0e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772667 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#691037}
-
Jan Wilken Dörrie authored
This change adds stubs for integrating the native Password Checkup on Android for the Leak Detection feature. Bug: 986317 Change-Id: Idf57d8a812ee11e6d862dbd68ecb54ea58aff738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773221Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#691036}
-
Jan Wilken Dörrie authored
This change adds logic to record user interactions with the leak detection dialog shown when the user submits a compromised credential. Bug: 986317 Change-Id: I49bc3e9fd5d9d63ed3c00775b0d8d24b52d1acb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768330Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#691035}
-
Abhishek Bhardwaj authored
This change fixes a bug in ScopedWakeLock that didn't actually make the call to acquire a wake lock when constructed. Also adds a test to catch this case. BUG=924762 TEST=Unit tests. Change-Id: Ife26d3b9ae88f399adc21cd8cb62ba628929094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757461 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691034}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 13462f0b. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id36b11ba715266061ab84c9a9e286f077605d6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774116Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691033}
-
Kent Tamura authored
This CL reduces estimated pre-processed size of node.h from 2.89MB to 2.17 MB. Bug: 242216 Change-Id: I28936b13071364293b86b7692efc2bfca202911e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772778 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#691032}
-
Emily Stark authored
This CL adds a histogram for downloads initiated from a page with a Safety Tip. (This is based on the downloads metrics for the EV study from https://chromium-review.googlesource.com/c/chromium/src/+/935369/). It will let us determine whether users are less likely to download files from pages that have Safety Tips. To record this metric, I had to tweak the meaning of VisibleSecurityState::safety_tip_status, such that is set even when the Finch feature is disabled. UI code is now responsible for checking the feature status to decide whether or not to show the UI. This way, the downloads code can record the safety tip status regardless of whether the UI was actually enabled, so that we can compare user behavior with and without the UI. This change also revealed a bug that the safety tip status of the page was being incorrectly reset when a navigation started, even if the navigation didn't commit. I've changed that behavior to reset when a navigation finishes rather than starts, and we now cache the navigation entry ID along with the safety tip status so that we can avoid using the safety tip status if there is a navigation in progress. Bug: 987754 Change-Id: I72fe92c4931897e67d0182953b5dcdd5fdfc3bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773589 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#691031}
-
rbpotter authored
Adding closure compilation for: viewer-zoom-toolbar viewer-pdf-toolbar viewer-toolbar-dropdown Deleting viewer-bookmarks-content, since this appears to be just a wrapper around dom-repeat. Some cleanup/addition of annotations in viewer-bookmark.js Bug: 721073 Change-Id: I88b593c99da3b25deda7e0fe1c6e5d3b3bfa0e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762814 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691030}
-
Eric Willigers authored
We add a flag to allow disabling of waiting for Service Worker to be registered during installation of default installed windows apps. Bug: 905898 Change-Id: I9649515240ca86023b94b135973a476c046ea38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771640 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#691029}
-
Darren Shen authored
TBR=karandeepb@chromium.org Bug: 998369 Change-Id: Ic8136719b0b72533ab1f75ff70c48f420dbea0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772209Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea78a142b81f..8a8dc5068079 Created with: gclient setdep -r src-internal@8a8dc5068079 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8b054f0c7d3177e6cfefab18e4d46b8d87a8049f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691027}
-
Austin Eng authored
https://dawn.googlesource.com/dawn.git/+log/b9b088f57e3d..f0b17d00b98d git log b9b088f57e3d..f0b17d00b98d --date=short --no-merges --format='%ad %ae %s' 2019-08-27 kainino@chromium.org Use TextureFormat::None for RenderBundleEncoder and AttachmentState 2019-08-27 enga@chromium.org Rename SetErrorCallback to SetUncapturedErrorCallback 2019-08-27 enga@chromium.org Rename DeviceErrorCallback to ErrorCallback and add ErrorType arg 2019-08-27 enga@chromium.org Rename ContextLost to DeviceLost 2019-08-27 kainino@chromium.org Remove Texture::createDefaultView Created with: gclient setdep -r src/third_party/dawn@f0b17d00b98d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None TBR=cwallez@chromium.org Change-Id: I415cce5f3e1e5210ed61ff77c69c044bebfd0b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772492 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691026}
-
Keishi Hattori authored
Adds CooperativeScheduling runtime feature flag and makes it available in chrome://flags Bug: 804661 Change-Id: Id0174dc30557822a6d9d34c924e7daa05e3a0523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743231Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#691025}
-
Ian Kilpatrick authored
It is possible for the caching system to believe that atomic-inlines would have been impacted by floats. As a result we threw away a (perfectly good) cached layout result. This ignores line-boxes in this calculation. Change-Id: Icc6dbe948ba88d54b252ceb06b2d50aecc558296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772387 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#691024}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2002bac5500d..1b2f2b335b20 git log 2002bac5500d..1b2f2b335b20 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 vapier@chromium.org lint: fix up consider-merging-isinstance warnings Created with: gclient setdep -r src/third_party/chromite@1b2f2b335b20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibaf41bfb54ccf8731908b9ac4b30601511d35ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691023}
-
Abhishek Bhardwaj authored
This change increments the network wait timeout from 1 minute to 5 minutes. This is done because after manual testing it was found that it could take up to just over a minute for shill to notify Chrome of a network change. 5 minutes is used as the absolute worst case. BUG=924762 TEST=Unit tests. Change-Id: I60a412930f379fd7639d01e9c856c0443e8ef14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757460 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691022}
-
David Bokan authored
Looking at code and the crash stacks, it looks like we're synchronously closing a WebViewImpl while it's handling an input event. This CL adds some debugging to crash earlier so we can get a stack showing where the Close call is coming from. Bug: 992315 Change-Id: I16b17cbbec6dfdafadfc334028a31227ae61ccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769348 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691021}
-
Xianzhu Wang authored
They were to handle cases that layer tree and transform tree had different hierarchy. We can remove them because the cases no longer exist in layer tree mode (for ui compositor only). Bug: 993937 Change-Id: If496b5fc821fb786f281093be8ef2efed86e7bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770510 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691020}
-
Abhishek Bhardwaj authored
This change moves a function that semantically belongs in ResetState. BUG=924762 TEST=Unit tests. Change-Id: I8a8d0c446cda8e8a828857d80031b97e28206fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757459 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691019}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd849a537a4b..7be971fa3a4e git log fd849a537a4b..7be971fa3a4e --date=short --no-merges --format='%ad %ae %s' 2019-08-28 michaelludwig@google.com Fix flutter roll Created with: gclient setdep -r src/third_party/skia@7be971fa3a4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ie547ba81d094effe2fdf505ff64c34c69f97f609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691018}
-
Regan Hsu authored
Test: * Manually test by clicking system tray > bluetooth section > gear which opens bluetooth device page directly. The banner will not be present. * Manually go to settings page and notice banner. Then, navigate into a subpage and notice that the banner is not present. Bug: 997844 Change-Id: Iefe52c0e0111f15adf6c88147a77e4e2210fd0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773204 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#691017}
-