GitLab

This is a repeating callback because it is run by an event handler:
* https://cs.chromium.org/chromium/src/components/mirroring/service/udp_socket_client.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=164

and it is also called repeatedly from a while loop:
* https://cs.chromium.org/chromium/src/media/cast/net/udp_transport_impl.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=208
* https://cs.chromium.org/chromium/src/media/cast/net/udp_transport_impl.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=217

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I265bfe00a5063e85a3461533019bfbc4f598f609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073763
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745421}

Instead of using GetPseudoElement to obtain the ::marker pseudo-element
and then call GetLayoutObject on it, PseudoElementLayoutObject can
directly be used.

This patch should have no effect in practice.

BUG=457718

Change-Id: Iff30a916834b2e57e67be9ce145c2e992b224fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078472Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#745420}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4135db4c51d3..d33ca0263565


Created with:
  gclient setdep -r src-internal@d33ca0263565

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ica58aa1f463155d3d04ef50090f2640162037796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080049Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745419}

It would greatly complicate the callers of StreamThenPromise() to handle
failure, so instead it attempts to return a "dummy" Promise (that will
never resolve) if the call to Then() fails. However, sometimes even a
dummy Promise cannot be created. The two known causes of this are OOM
and worker thread termination. We cannot recover from OOM anyway, so
crashing is fine. However, crashing on worker thread termination is bad.

This change falls back to returning the original promise that was passed
to StreamThenPromise if all else fails. This is potentially an issue if
user JavaScript is able to manipulate that promise, so we only do it if
execution is terminating. If not, we fall back to crashing as before.

This CL is expected to change the stack traces for OOM crashes inside
StreamThenPromise.

BUG=1027304

Change-Id: I815803b23af1457e7a96c6afb554066804c5c54a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955001Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745418}

Put incognito ntp cookie controls logic in a class and replaced
java-side logic with bridge to connect to c++ backend. Same class is
used for incognito for start surface.

Bug: 1040091
Change-Id: I18d679731aabda57c6b3852d4f0e4a68c268bb07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044273
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745417}

Fixed spinner bug caused by removing associated-control attribute.
This change includes also minor fixes to code based on post-review
comments from previous CL.

Bug: 1056525
Change-Id: I7492936329192108870a50c1ed10ae306af659f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078546
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745416}

This patch introduces a test config for the
AutofillAssistantDirectActions approved for the M81 Beta channel. The
corresponding finch config cl is in review and prompted this change.

Bug: b/148647596
Change-Id: Ia85e56c96afaea805c8e65b10a50b1549c93cbaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077740Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745415}

While moving Chrome over to androidx.browser, Strings representing
package names were replaced with Tokens that represent package names
and their signature. Strings have hashCode overridden to provide value
equality whereas Tokens don't, so checking for the existence of an
equivalent Token in a Set of Tokens doesn't work.

This change manually looks through the set of Tokens and calls
Token#matches on each one.

Bug: 1052288
Change-Id: Ia2ad8bf3272853acbd07ae36aad33e9c78fb9e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078548
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745414}

https://webrtc.googlesource.com/src.git/+log/63288e382aeb..e77912ba8c0f

git log 63288e382aeb..e77912ba8c0f --date=short --first-parent --format='%ad %ae %s'
2020-02-28 marinaciocea@webrtc.org Insert frame transformer between Encoded and Packetizer.
2020-02-28 kwiberg@webrtc.org Test copying of variable-sized ArrayView rvalues

Created with:
  gclient setdep -r src/third_party/webrtc@e77912ba8c0f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I0a073c2928926df421e1aa35147c8cd7eb619f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080050Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745413}

incognito.

This CL update the profile passing to TrackerFactory and
DownloadManagerService from IPHBubbleDelegateImpl. Currently, it is
always regular profile, however it is not safe because of possible data
leakage from incognito to regular profile.

Therefore, this CL uses the profile (i.e., regular or off-the-record
profile) belong to active tab in IPHBubbleDelegateImpl,then passes it to
TrackerFactory and DownloadManagerService.

Bug: 1041781

Change-Id: I6b6d18e50f8e59068db4f59ca2bc75e25883d99a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066930
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745412}

TBR=dcheng@chromium.org,huangdarwin@chromium.org

Bug: 1056650
Change-Id: I45ac5d5ac747128f48e6fab502d180479de8822f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080256Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745411}

This reverts commit 9f5f561e.

Reason for revert: reland this patch after fixing of DCHECK failures at crrev.com/c/2061751.

Original change's description:
> Revert "Verify consistency between sync and sign-in account IDs"
> 
> This reverts commit caf8eebf.
> 
> Reason for revert: suspect of running into sync protocol violations and
> the corresponding DCHECK failures.
> 
> This CL reverts a preference being introduced without the corresponding
> cleanup logic; but we intend to reland this patch anyway.
> 
> Original change's description:
> > Verify consistency between sync and sign-in account IDs
> >
> > Local sync metadata belongs to one user account. Due to the distributed
> > nature of the locally persisted sync metadata, the cache GUID is used
> > as "epoch" to detect mismatched in edge cases like the browser crashing
> > during shutdown and before I/O gets flushed.
> >
> > However, prior to this patch, the cache GUID itself has no safety
> > mechanism to detect it maps to the intended account ID. In this patch,
> > a new SyncPref is introduced to achieve that, in away that both prefs
> > (cache GUID and account ID) are stored atomically.
> >
> > Because the pref is newly-introduced, migration logic is introduced to
> > populate it for the first time if initially empty.
> >
> > Change-Id: I2cdd9f997077c4acd16e9283df8c025f51d40546
> > Bug: 1046237,1021527
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023528
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#736848}
> 
> TBR=msarda@chromium.org,treib@chromium.org,mastiz@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1046237, 1021527, 1048771
> Change-Id: Ic9dcaf53780350984c3036f6acdb549f631893f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041669
> Commit-Queue: Rushan Suleymanov <rushans@google.com>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739371}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1046237, 1021527, 1048771
Change-Id: If1a4a8c897d6e8bb1bae3e54b24c549146063f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073757Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#745410}

This callback is run as part of an event handler:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_transport_ipc.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=174

which in turn is called by an IPC handler:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_ipc_dispatcher.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=139

registered in:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_ipc_dispatcher.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=57

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I3ae9158ba5186a5cf686d877845fb3d23090488c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073722
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745409}

As long as the work-around to handle serialization of CoreAudio suspend
and resume tasks is in place (see crbug.com/772884), we will need these
stats. When the issue is resolved by Apple and the work-around can be
removed, we will also remove the stats along with it.

Fixed: 1055397
Change-Id: I867bb80891c462e05a6c8c97834f54612d47ccde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071269Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745408}

This CL has no behavior changes.

Bug: 1052232
Change-Id: I67007e9f988a803277f9299b7c055f55a9344a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079722
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745407}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f13d38f3cd3c..70ba66cdbc23

git log f13d38f3cd3c..70ba66cdbc23 --date=short --first-parent --format='%ad %ae %s'
2020-02-28 johnkslang@users.noreply.github.com Merge pull request #2093 from LilyWangL/vcpkg-instructions

Created with:
  gclient setdep -r src/third_party/glslang/src@70ba66cdbc23

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com
Change-Id: I51bd8afb209ce46a6cb7dab03e7bf16535cf69da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080047Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745406}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I0dac02c433ab9d9e7c0967c98c69a532707ad3d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745405}

This allows it to be shared by Chrome, WebLayer and WebView. For Chrome
this functionality is tested by VariationsHttpHeadersBrowserTest.

To support this a VariationsClient has been added, with an accessor on
BrowserContext, which allows the variations code to tell if the user is
signed in (some of the variations header logic needs to know this).

Bug: 1025612
Change-Id: Ibb5a0dd54e23a3536de4c0fb84624173a6974262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967245
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745404}

TraceAfterDispatch of NodeRareData was  node_lists_ in case it was
empty. This optimization could cause null dereferences when using
the return value of EnsureNodeLists().

Drive-by: MainThreadGCForbiddenScope is no longer needed once Trace
doesn't modify node_lists_ so removing that as well.

Bug: 1055194
Change-Id: I49e2419ac3aff3ff3e13042220a31fade9f4f06a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078433
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745403}

[Sheriff] Mark virtual/controls-refresh/calendar-picker/date-picker-ax.html and virtual/controls-refresh/calendar-picker/date-picker-ax.html as flaky

Bug: 1057036
Change-Id: I3b1d8fd5e361f80a5188da7e8d8eeed7bbfb1a72
Tbr: cmumford@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078821Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#745402}

Added a flag to APIPermissions and a function to ManifestPermissions to
decide if the permissions should trigger full warning on the login screen
of the managed-guest session or not.


Bug: 1015378
Change-Id: I6df56a3a4adbbf1468cbaf36929508bcaa17c464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060948
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745401}

Revert "Fix null check preventing AXObjectCacheImpl from registering as popup document lifecycle observer"

This reverts commit 79d26a28.

Reason for revert: this is breaking the mac builders.
See https://crbug.com/1057044 for details

Original change's description:
> Fix null check preventing AXObjectCacheImpl from registering as popup document lifecycle observer
> 
> Fix the polarity on a couple of null checks that were preventing
> AXObjectCacheImpl from registering as a lifecycle notification observer
> for popup documents.  This failure to register was preventing AX focus
> events from being fired when focus changed inside of a popup.
> 
> The week-picker-ax.html test was passing prematurely because of focus
> events received when opening the popup, without validating that
> additional events were fired when changing focus in the popup.  Update
> that test to confirm that events are also fired for a focus change in
> the popup itself.
> 
> There were a couple of analogous tests (date-picker-ax.html,
> month-picker.html) that were deleted when we purged old date popup tests
> in favor of new tests written for the new popup implementation
> (crrev.com/c/1967608).  I don't see replacements for these in the new
> tests, so this change also restores those tests, updates them for
> the structure of the new form controls, and ensures that they are
> checking that focus events are fired due to changes in the popups and
> not just from events fired when the popups open.
> 
> Bug: 1022920
> Change-Id: Ifbccaff74131031ab60d61a715475eecdca0a7a2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074815
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Dan Clark <daniec@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#745325}

TBR=aboxhall@chromium.org,masonfreed@chromium.org,daniec@microsoft.com

Change-Id: I9a82221dce7efa58a87719cc99827ca5b2cdb8aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022920
Fixed: 1057044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080235Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745400}

https://chromium.googlesource.com/angle/angle.git/+log/a60e49738bf1..8c6e40d2264e

git log a60e49738bf1..8c6e40d2264e --date=short --first-parent --format='%ad %ae %s'
2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 4b34ee3de531..05f5e0b34ac8 (2 commits)

Created with:
  gclient setdep -r src/third_party/angle@8c6e40d2264e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: Ibcd5f95af06848e07a143307576cf4d0061d5eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745399}

TBR=haraken@chromium.org

Change-Id: Iaf663f0ea1fcb4a1c2870846d97fbe9580c5afdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079725Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745398}

When the location of a box is determined, we should update scrollbar
positions by calling SetLocationAndUpdateOverflowControlsIfNeeded()
instead of SetLocation().

Bug: 1056936
Change-Id: I173d825c123981d55acba2575d673eef0d73a27b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079772
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745397}

This is a repeating callback because it is run as part of an event
handler, which can be fired repeatedly:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_transport_ipc.cc?rcl=5703e03dce1a4499c9885d2a42342acfe831c36c&l=118

The event handler is called from an IPC handler:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_ipc_dispatcher.cc?rcl=5703e03dce1a4499c9885d2a42342acfe831c36c&l=82

registered in:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_ipc_dispatcher.cc?rcl=5703e03dce1a4499c9885d2a42342acfe831c36c&l=52

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I7986567aa2191c1566d82b55df7d74a89699786a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073879
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745396}

This CL adds tests to static/dynamic import of non-existing scripts
modules shared workers.

Without 'static import on classic worker' test, all the tests
corresponding to dedicated-worker-import-failure.html have added.
'static import on classic worker' is treated as parse error, and the way
to handle parse error differs from fetching non-existing or invalid
scripts which are tested in this test file.
Therefore, I will add WPTs for parse error in separated files by the
following CLs.

Change-Id: I1f4555f2ea8597f0c0fc197494f0ba5d1510db75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071466
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745395}

https://webrtc.googlesource.com/src.git/+log/b5eeba1bb3d7..63288e382aeb

git log b5eeba1bb3d7..63288e382aeb --date=short --first-parent --format='%ad %ae %s'
2020-02-28 phoglund@webrtc.org Whitespace change to kick bots.
2020-02-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dcd1a26c..45a3ae97 (745220:745356)

Created with:
  gclient setdep -r src/third_party/webrtc@63288e382aeb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Iad1e7b7d5f833869d4a28a46d724c89f934d172f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080045Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745394}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/07e1a0a67aee..f13d38f3cd3c

git log 07e1a0a67aee..f13d38f3cd3c --date=short --first-parent --format='%ad %ae %s'
2020-02-28 johnkslang@users.noreply.github.com Merge pull request #2092 from corporateshark/master

Created with:
  gclient setdep -r src/third_party/glslang/src@f13d38f3cd3c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com
Change-Id: Icdb00cc1e6601f99232cb03ab80754867c9cdea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745393}

marker-path-001-ref.svg:
 The ref did not include the contribution from the viewBox on the
 <marker> in some case. Adjust the markerWidth/Height to make the
 'viewBox' contribution a scale-factor of one. Set 'overflow' to
 'visible' to avoid clipping artifacts.

marker-path-022-ref.svg:
marker-path-023-ref.svg:
 Renders the markers twice - both on the shape itself and as
 "additional" reference markers. Drop the markers from the shape.

Update the expectations for
 wpt/svg/struct/reftests/use-inheritance-001.svg
 wpt/svg/painting/reftests/marker-path-022.svg and
 wpt/svg/painting/reftests/marker-path-023.svg

Bug: 674797, 785246, 1056492
Change-Id: I164fd7a826f8efdb5c5b5cbc486b81906d32a254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077719Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#745392}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dea22b17966e..4135db4c51d3


Created with:
  gclient setdep -r src-internal@4135db4c51d3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ia87780d4b988a2862f47d9c839f3319304992613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080040Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745391}

This should help new folks get started with making changes in the
content settings pages.

Change-Id: I30e695536cd96a64198379c6b4ccbaf8562f2f19

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I30e695536cd96a64198379c6b4ccbaf8562f2f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078577
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745390}

This CL is based on Dave's CL (https://chromium-review.googlesource.com/c/chromium/src/+/2025567).

This CL introduces a PageBroadcast mojom interface.
Freezing is a good example which has to happen on the page/RenderViewHost
granularity rather than LocalMainFrame/Frame. (Freezing mojo CL: https://chromium-review.googlesource.com/c/chromium/src/+/1999899)
This CL will allow us to have page-level mojo messages.

BUG=1046424

Change-Id: If6d660eeacc7dfec4175d2de8be7e887a3519209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043412
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745389}

Remove blink::MultiChannelResampler and replace it with the
blink::MediaMultiChannelResampler.

Bug: 1033408
Change-Id: Ia90022fbf186cf85d1fe5f589819774e63c87746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975713Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com>
Cr-Commit-Position: refs/heads/master@{#745388}

The tests

http/tests/uri/escaped-entity.html
http/tests/uri/utf8-path.html
virtual/text-antialias/international/001.html
http/tests/eventsource/eventsource-bad-mime-type.html

are flakily timing out on Fuchsia. Mark them in TestExpectations.

BUG=1056022

Change-Id: I9991dab28263cf27b48a739454240c41a7e4c17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078378Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745387}

Following the discussion in chromium-mojo and platform-architecture-dev,
we're proposing to add this script to the chromium repository so that
external repositories that still depend on the old mojo types (e.g.
Android's and ChromeOS's libchrome repos) have a simple and maintained
way to downgrade Chromium's .mojom files to the old syntax, while they
can't support the new one.

This CL includes a new mojom_types_downgrader.py script that can be
integrates with those external builds requiring it, plus the necessary
unit tests to guarantee that the downgraded files can still be parsed
correctly by the bindings generator (i.e. mojom_bindings_generator.py).

For extra context, see the relevant discussion in the chromium-mojo ML:
https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/BRK0Xeu7bgQ/z00hkpaGEQAJ

Bug: 1035484
Change-Id: I4c92345e82a188052b06efce9a1bc749d561cca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041759
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#745386}

This file was deprecated by a copy added to //base in
https://chromium-review.googlesource.com/c/chromium/src/+/2071257, and
the internal callers of it have now been ported. I verified that no
commits have been made to the file since the above CL.

Bug: 1031465
Change-Id: Ib14e63a4d4030914227d682141681d6cf838e450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078534
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745385}

https://skia.googlesource.com/skia.git/+log/52037e8ecce6..0a3900fb33dc

git log 52037e8ecce6..0a3900fb33dc --date=short --first-parent --format='%ad %ae %s'
2020-02-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@0a3900fb33dc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I54e18d21ce2091112639876c7918ab5b28fa5112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080037Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745384}

Added size, Capacity, isEmpty, front, back, insert and erase for
NewLinkedHashSet.
NewLinkedHashSet is a new implementation of LinkedHashSet.
LinkedHashSet maintains a linked list
to iterate all entries in the order in which they are inserted.
We replace it with NewLinkedHashSet for the following purposes:
To simplify moving of the backing store.
To implement LinkedHashSet on top of existing WTF primitives.
In NewLinkedHashSet, the linked list is implementing in a vector
(with links begin indices instead of pointers).

Design Doc for NewLinkedHashSet is here:
https://docs.google.com/document/d/1ts2L8XJcGQYlxdVerVBp8_625h6ky7RNGw21AqMJ9Z0/edit?usp=sharing

Change-Id: I327143051ff1f2a1cd36cc9f3ff26923267c5694
Bug-Id: 992506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065815
Commit-Queue: Kei Nakashima <keinakashima@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Auto-Submit: Kei Nakashima <keinakashima@google.com>
Cr-Commit-Position: refs/heads/master@{#745383}

Style attribute changes could affect style matching of other elements
than the one that gets its style attribute modified because of selectors
which have a style attribute selector in the non-right-most compound.
For instance:

  [style] + div

In this case the div will be invalidated by an invalidation set for the
style attribute scheduled in StyleEngine::AttributeChangedForElement().
This method was not invoked for all variants of style attribute
modifications. In particular setting the text for Element.style.

This CL centralizes the invalidation handling to cover all cases.

Bug: 1056151
Change-Id: Iceb70c284e2bb6b209a4243d61f941670eab323e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078532Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745382}