- 14 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b421774ae9c3..72c58a865b57 2021-01-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3549479dc4cc to 5255c465bbba (6 revisions) 2021-01-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 50bcbaad4cbf to 5869a809d551 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I89cdad4aa6ea5cff39990b6bda46e46641d1399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843537}
-
David Roger authored
Strings updated to match the mocks. This CL also adds the Chromium version for the subtitle (which was previously only Chrome branded). Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/47e8c87c841f9b9673f93babdaf98212e6b3056e Subtitle V2: https://storage.cloud.google.com/chromium-translation-screenshots/3a59c757a6c0f10694c64384cef092967697b863 Fixed: 1166621 Change-Id: I009011e045336940c452cd7dd5fd5249fc8705be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627857 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#843536}
-
Anders Hartvoll Ruud authored
We need to propagate container size information down to style resolution of elements that depend on a container queries. The StyleRecalcContext class will (eventually) transport that information. This CL is the first in a chain of CLs which does the necessary refactoring to propagate a StyleRecalcContext all the way from StyleEngine::UpdateStyleAndLayoutTreeForContainer to descendants ElementRuleCollector instances. Longer term I expect StyleRecalcContext to also setup/manage the SelectorFilter (or otherwise merge with that functionality), but this problem is out of scope at the moment. Bug: 1145970 Change-Id: Ia30b796e0e95c83e5f04d971a593644ec18bc8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626433 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843535}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I546ad3eb3c63e14b0e0290f0e1e6151ac5c52565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627998 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#843534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9fba07e606db..069cce000b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: Id59dc86471034b1ca98692fee8bbbd0f5d4a0ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629391Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843533}
-
Sunny Sachanandani authored
This is needed for importing the UV plane of a P010/P016 texture into GL/ANGLE. Bug: 1116101 Change-Id: I32a008ddc0350858372d764de14998c930d48683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626100 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843532}
-
Caroline Rising authored
Add two metrics, one tracking the bookmark bar state the first time a user adds to the reading list because we then open the reading list and another that tracks the bookmark bar state on all additions to the reading list. For the latter, make the ReadLaterButton a ReadingListModelObserver, this will also be needed for future read later work to add a red dot indicator and button highlight. Bug: 1163938 Change-Id: I572ca447707a840f41880a86b1d0779b02eedc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627692 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843531}
-
Jérôme Lebel authored
Removing //ios/chrome/browser/ui/authentication/signin:signin_protected from //ios/chrome/browser/ui/settings/google_services. This dependency is not used anymore. Change-Id: I543b9c129441bfa8b39d3cf16c6fd4aaeab2247e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626389Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843530}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610603782-a901bed343e038af516adf3da71b37fc556670e5.profdata to chrome-linux-master-1610625483-0ee558e7111df5b3a3b368fd27939cbeb6a581b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0ac68b1c49f32fe2c994bbe0107bcca181a88df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843529}
-
Rune Lillesveen authored
Bug: 630597 Change-Id: Ie35038b6e1546f29dc015e3ba2c5bdad73157255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628293Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#843528}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ib7b206bdfc671368999352333a102f7cc471911f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626002 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#843527}
-
Monica Basta authored
Bug: 1063856 Change-Id: Ia491a4cad99a6eb07fd05f600302e25fe018b2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626392 Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843526}
-
Aaron Krajeski authored
The call to DiscardResourceProvider is causing a lot of false negatives. https://uma.googleplex.com/p/chrome/histograms?sid=03450a933557bea663d8de9368d8d279 "Blink.Canvas.IsComposited" is redundant with "IsAccelerated", so I'm just getting rid of it. Bug: 1165879a Change-Id: Ib3d1ce31d5225215155378dfb1eecaa95e4c7b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625289Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#843525}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610603782-06f69987beeafa2099bc1c1b61d54bb2fbf2a8d8.profdata to chrome-win64-master-1610614773-8fa72e139bfbe669301559d8a5dcb0f175d80f50.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I39458479cdae1f980f43707272262aac89c03855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843524}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610603782-b98b7b7ae127903b90c7f2c46875a9e8f16b9cec.profdata to chrome-mac-master-1610625483-a0e2f95e7a919a4bc7e74f0638f605fdfadfc75f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6878fb1b4798c1cb1835e9146b8e3e7f296c36b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843523}
-
Caitlin Fischer authored
Bug: 1126640, 1154531 Change-Id: I132a47d6962bc2479b1096a409b2602e841a6a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626520 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#843522}
-
Antonio Sartori authored
With this CL we store directives names in WebContentSecurityPolicy using the enum network::mojom::CSPDirectiveName instead of using strings. This small changes simplifies the type conversion network::mojom::blink::ContentSecurityPolicy -> WebContentSecurityPolicy -> network::mojom::ContentSecurityPolicy. Bug: 1021462,1149272 Change-Id: I1a28f0be010ff054d3259d733e0fdc2651057d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607888Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#843521}
-
Theresa Sullivan authored
Left-over from bottom toolbar experiments. Change-Id: Ie0f3e8e14b8c937f293aed25697c73a4b6f1b539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628317 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#843520}
-
Karandeep Bhatia authored
Also - Remove support for legacy export.whitelist manifest key. - This also revealed that json_schema_compiler doesn't correctly handle C++ reserved keywords (like export) correctly in the auto-generated code since using them directly causes compilation errors. Fix this. BUG=1113513, 842354 Change-Id: Ib8a4ecc8d398ced6efcfd2ad8f74a364b0a62dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618619 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843519}
-
David Jean authored
Bug: 1131852 Change-Id: I3fce51d376a2925c1fc891bdaaff17b0c3dbf50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627308Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#843518}
-
Alice Wang authored
Bug: None Change-Id: I229c095171cbea3f2f325f93752dee885e4842d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627856 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#843517}
-
Alex Ilin authored
https://crrev.com/c/2615350 introduced a bug when deleting any profile that is not the lst in the list. The profile gets deleted, the list updates in background but the dialog stays open with info about the next profile in the list. The dialog should be explicitly closed from profile_card_menu.js Bug: 1063856 Change-Id: I1688b19300fd7dc89893393bac239ed7163de4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627520 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#843516}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33435f37. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I73cdb88443c5fe4695fbce26dc218a4426e17b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629287Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843515}
-
Laís Minchillo authored
Extend the duration of Android.WebView.AndroidX.ApiCall and WebView.ApiCall. These are core WebView API metrics, to be used both as a measure of success or to guide deprecation of unused methods. Bug: 1160898 Test: N/A Change-Id: I821d65343fbda189ff941df12493e2ae956541ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622372 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843514}
-
Ian Clelland authored
Change-Id: I7df7f963f11495bc28ebdcc739562a190e8fd3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627708 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#843513}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9e71e6a50f6b..81eee879ea6e 2021-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75a9ade2c15c7693e71c946b4deabbd4340c62de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843512}
-
Titouan Rigoudy authored
We were previously recording private network requests similarly for navigations and subresources. This CL merely splits these cases up into two different buckets that are measured independently. Navigation usecounters are slightly incorrect and will need more work to fix than can be achieved by branch point. Subresource usecounters on the other hand should be more accurate and let us evaluate compat risk of a subresource-only launch. Bug: chromium:1124358 Change-Id: I38e8b8d90b58316a400219e762c9d6d1d29451d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627421Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843511}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610571527-a7cc65d6e4dfa3bc4bfeaca916fdc0c69afa5118.profdata to chrome-win32-master-1610603782-7b9d002ed8792e03b1869b7e10210ec4783af8d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icbb2eaf7cae5e9b49b3cecea780d1e7a947ade04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843510}
-
Caroline Rising authored
Bug: 1163938 Change-Id: I383d348d0e08aa42c4aabbfab38c3e8c7ad19331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622274Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#843509}
-
Jan Krcal authored
This CL fixes a bug with the back navigation in profile creation flow that triggers after the user chooses to sign in and then tries to navigate back to the main picker screen. The problem was with pushing LOAD_SIGNIN state on the history stack that was not removed when coming back from that step. This CL thus avoids pushing this state to history by directly triggering the switch in the native UI layout. This CL also fixes an unrelated minor issue that once call site to record page visits got accidentally removed. Bug: 1126913 Change-Id: I871473652cf6f632b5687f6b550f63d94f420766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623944 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#843508}
-
Gyuyoung Kim authored
As the second pre-work to convert the context menu IPC messages, this CL moves Impression struct and ConvertWebImpressionToImpression() method to blink. - Move impression.h/cc to blink/public/common/navigation. - Move impression_conversions.h/cc to blink/renderer/platform. Bug: 1093904 Change-Id: I6d14aa6b028b559f4ecc939c7d2de27ff65b26ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628767Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#843507}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ac263e38879..9fba07e606db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I2f3a5b689b2abb390dd102c3b2a69d1ed50e4392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628463Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843506}
-
Sergey Poromov authored
Until proper DLP reporting is ready we need to log when DLP blocks some user action to provide more transparency for the admins. Bug: 1166600 Change-Id: Iff4ae86bd3c172266723ef7e88290fa1fa47c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628291Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#843505}
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I9489867941a9db12954358d926c2b25f9c8b8617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628928 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#843504}
-
Monica Basta authored
Bug: 1162443 Change-Id: I13c22f9337a2fc8a1c8a7b2e7f61e06f29afeced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624655 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843503}
-
Caitlin Fischer authored
The study has ended, and there are notes in the server-side config and in crbug.com/1111809 that this study is no longer needed. Bug: 1126640, 1111809 Change-Id: I8806a5e6b2807cdd2644fe238a8f0df0597e7701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626512Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843502}
-
Antonio Sartori authored
A LocalFrame's PolicyContainer is the counterpart of the RenderFrameHost's PolicyContainerHost. There are LocalFrames without a corresponding RenderFrameHost, and there are RenderFrameHost (the speculative ones) without a PolicyContainerHost. Previously, in those cases, we were setting a LocalFrame's PolicyContainer to be nullptr. We were trying to handle accesses to a non-defined LocalFrame's PolicyContainer with single nullptr checks. However, a LocalFrame's PolicyContainer is needed every time a LocalFrame needs to handle security policies. It turn out this can happen in a myriad of cases. For example, SVG images included via the img tag (which are rendered using a fake LocalFrame) allow meta tags delivering security policies (although those policies effectively do nothing). Using nullptr checks to handle those cases everywhere is tedious and error prone. With this CL we adopt a similar approach as for the EmptyFrameClients. We always define a PolicyContainer for a LocalFrame, even if it has no RenderFrameHost. In this case, the PolicyContainer is an "empty" client: it is fully functional for Blink's purposes, but it treats all mojo messaging to its (non-existent) Browser counterpart as no-ops. Bug: 1158034,1130587 Change-Id: I18347b9a16c6c7d71931c1f34abda793e66a9324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594768Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#843501}
-
Jan Krcal authored
This CL makes the toolbar bg color in the sign-in flow react to theme changes (so that the button color stays in sync with the toolbar color). It also removes a few obsolete TODOs. Bug: 1126913 Change-Id: Ia01207d4544baed1587e7c1030e9319c553c9be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627160 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843500}
-
Tanmoy Mollik authored
methods OnPrimaryAccount(Set/Cleared) are deprecated. This cl changes components/gcm_driver/* code to use OnPrimaryAccountChanged() instead. This cl also removes OnPrimaryAccountSet method from IdentityManager. Bug: 1158855 Change-Id: I75210065dd113eeb3646c86136236fe2b54afebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611722 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843499}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610571527-cb84a3d10a676e72fe097e5f2fde0ba90e629978.profdata to chrome-win64-master-1610603782-06f69987beeafa2099bc1c1b61d54bb2fbf2a8d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie33f198c66734f2928d25977ae69ff11fb93f630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628658Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843498}
-