- 30 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/016601cc2146..7ae5d7a9b12c git log 016601cc2146..7ae5d7a9b12c --date=short --no-merges --format='%ad %ae %s' 2018-11-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7ae5d7a9b12c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8282b35c12a20c6b1665d55941c1a429c5542088 Reviewed-on: https://chromium-review.googlesource.com/c/1356636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612717}
-
Yi Su authored
TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612716}
-
Vaclav Brozek authored
vabr@ leaves the Chrome team and will only be hobby-contributing in the foreseeable future. Not being able to guarantee staying up to date on the currently owned code, vabr@ is therefore removing himself from all OWNERS files. Notable changes: * Adding dvadym@ to the OWNERS for password manager internals page, because he knows that code thoroughly and plans to enhance it soon. * Adding a reference to components/password_manager/OWNERS to components/test/data/password_manager/OWNERS * Adding cfroussios@ to third_party/libsecret/OWNERS, because of his work on code using this library. R=cfroussios@chromium.org, dvadym@chromium.org, vasilii@chromium.org Bug: 908813 Change-Id: Id45989e6febe523a98f2b97730b82b80c5c29200 Reviewed-on: https://chromium-review.googlesource.com/c/1354009Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612715}
-
Clifford Cheng authored
Fixed all the compile and runtime issues on Windows and enable the test on it. Bug: 898230 Change-Id: I9e92e49583893898603bffa46f6fc6bdc1ef7e20 Reviewed-on: https://chromium-review.googlesource.com/c/1339240Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612714}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ic4740c19ad445bb1974f12876732829b88148a01 Reviewed-on: https://chromium-review.googlesource.com/c/1352782Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612713}
-
John Budorick authored
Bug: 892644 Change-Id: Ib888cb9f6f5db2bea89d3e300d86d0b797f8eacb Reviewed-on: https://chromium-review.googlesource.com/c/1357006Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612712}
-
erikchen authored
The Windows counterpart to WifiServiceMac calls UnIninitialize in the destructor. It appears that the Mac version is failing to call Uninitialize, which may be the source of a large notification-related memory leak. Bug: 904540 Change-Id: I718aa58d69f4f39450bbb78f05375750ce4d6735 Reviewed-on: https://chromium-review.googlesource.com/c/1342088Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612711}
-
Ian Kilpatrick authored
This appears to be a leftover from when we didn't produce fragments for inline children which were containing blocks. There should be no behaviour change. Bug: 636993 Change-Id: Idc78f232390bd58f00517df719b6c2cda6e6830a Reviewed-on: https://chromium-review.googlesource.com/c/1356259Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612710}
-
Robert Sesek authored
This brings EXPECTED_MAC_SI_COUNT back to 0, and reduces the number in Linux by 1. The SI in WelsThreadPool.cpp was removed. Bug: 893594 Change-Id: I6fc03be4b104a5f8afc4c2be1cebce36d322d116 Reviewed-on: https://chromium-review.googlesource.com/c/1356868Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#612709}
-
John Z Wu authored
This was because I was overriding XMLHttpRequest's open and send functions a second time when reinjecting the scripts. The fix is to ensure those functions are only overriden once. Bug: 910284 Change-Id: I1bf203b45865275ec2cbf5e52ab388a5064de16e Reviewed-on: https://chromium-review.googlesource.com/c/1356014Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612708}
-
Robert Liao authored
This seems to work fine on Linux with --gtest_repeat=10. BUG=882338 TBR=shuchen@chromium.org Reenabling a test. Change-Id: I993856797c704a4b438402a97453d4e2b60f72f0 Reviewed-on: https://chromium-review.googlesource.com/c/1356230Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612707}
-
edchin authored
A coordinator's |-stop| should not crash if called multiple times. Bug: 910652 Change-Id: I5a2998726ad3390a8b1c98afbc753f093a4a8986 Reviewed-on: https://chromium-review.googlesource.com/c/1357001 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612706}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2f731d6ce85..7370393b9d26 Created with: gclient setdep -r src-internal@7370393b9d26 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie7fd1cb9adc3d3d7e27a6d740e7e5204ad2661c0 Reviewed-on: https://chromium-review.googlesource.com/c/1356633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612705}
-
Becca Hughes authored
This CL moves any existing uses of content::MediaMetadata to the new media_session::MediaMetadata. BUG=875004 Change-Id: If4b2f889ffb2264daa2bc2f5d9403e9e18586856 Reviewed-on: https://chromium-review.googlesource.com/c/1241572 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612704}
-
Nicolas Pena authored
Before, we'd buffer the firstInput entry only if it happened before onload. This CL forces firstInput to always be buffered. This means EventTiming code is called more in some tests, so the event hardware timestamp is no longer guaranteed to be nonzero, and a couple of xr tests require double RAF to avoid competing with the swap promises from Event Timing. Bug: 841224, 843184 Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8 Reviewed-on: https://chromium-review.googlesource.com/c/1355880Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612703}
-
Clemens Arbesser authored
This relates to http://crrev/c/1340940 , where the class of the bottombar layout was changed in autofill_assistant_sheet.xml, but not in the corresponding cast in BottomBarAnimations.java:setBottomBarHeight(). Bug: 806868 Change-Id: Id2bd5bf41862afe7e8425188a2fc048c478726c8 Reviewed-on: https://chromium-review.googlesource.com/c/1356981Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#612702}
-
Alex Clarke authored
Currently the SequenceManager is being too restrictive for this test, so we relax our check slightly. Bug: 891670 Change-Id: I0cebd070971e0272624b7bd05165ec64404b8f1a Reviewed-on: https://chromium-review.googlesource.com/c/1357080 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#612701}
-
Steven Bennetts authored
This fixes two minor UI issues: 1. Certificate ids were not matched correctly for OpenVPN. 2. ServerCA was not correctly showing 'Do not check' for OpenVPN. Bug: 903531 Change-Id: I31502c7602b44127571f172c0c911434b171ddbb Reviewed-on: https://chromium-review.googlesource.com/c/1355537 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612700}
-
Ryan Daum authored
We no longer want to perform this operation through the WindowManager since that does software color conversion which causes a render pass (leading to issues with inversion while playing video, among other things). Color inversion on cast display devices is now performed through internal hardware-specific methods. Bug: internal b/120272088 Test: manual test on device Change-Id: I60e4b59b8fc90fc2cbfe8f847d0d99fac4606647 Reviewed-on: https://chromium-review.googlesource.com/c/1357013 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#612699}
-
Etienne Pierre-Doray authored
Under this experiment, scheduler workers are only detached if the pool is above its initial capacity (threads that are created to replace blocked threads). 2 options were considered: Option A: Detach only when over initial capacity. Option B: Detach only when over current capacity (includes currently blocked threads in capacity). This might better handle the following case: At any given time, there is at least 1 blocked thread. On top of that, some periodic work uses all worker every 30s or so. The current capacity will encompass for the blocked thread and avoid detaching it periodically. Option A was picked because it is more conservative. Initial capacity is smaller or equal to current capacity, so detaching is closer to current behavior. We want to avoid having too many threads that aren't used. Bug: 847501 Change-Id: I0b116db54095767768b158d92f5f146249720b45 Reviewed-on: https://chromium-review.googlesource.com/c/1348863 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612698}
-
Jonathan Metzman authored
Fix integer overflow in data_size caused by attacker controlled value (win_certificate->dwLength) by using CheckSub from base/numerics. The overflow causes the program to read past the end of win_certificate. The amount read is also attacker controlled and seems essentially unbounded. Change-Id: I006cb4f8ce6c64421ca0bb66df3ce49a72aba839 Bug: 910480, 910522 Reviewed-on: https://chromium-review.googlesource.com/c/1357011Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612697}
-
Georges Khalil authored
This CL adds the serial number to cloud reporting, as a step to transition to using that as the client ID. Bug: 910594 Change-Id: I7b336da99f2f7304b3e03b7a3a25aa07715749d2 Reviewed-on: https://chromium-review.googlesource.com/c/1354342 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#612696}
-
Eric Robinson authored
See also go/chromerulesetservicemerge. This change is the final step in the RulesetService change. Rather than merging the two classes, we've chosen to more appropriately name ContentRulesetService to reflect what it does (RulesetPublisherImpl). In addition, the visibility of that class has been reduced, and it is now only referenced in/visible to the RulesetService class as well as tests. This change reflects splitting up the content of the .cc files, as the splitting of the headers was done in a previous CL. Change-Id: I2937ba2e2838669d3bf6a2f646acfefcd71f5f94 Reviewed-on: https://chromium-review.googlesource.com/c/1354272 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#612695}
-
agrieve authored
Bug: 908997 Change-Id: Iac24d68050cbf7331da37c45a5fe617b94c0d81f Reviewed-on: https://chromium-review.googlesource.com/c/1355908Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612694}
-
Min Chen authored
Bug: 900758 Change-Id: Idb6e22aa144d290f21c5af6139e0d168905e5ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1352526 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612693}
-
Wenzhao Zang authored
Bug: 910409 Change-Id: I7c9a65ccb5e6eb11e2e3f600cef3ba13fe37ee82 Reviewed-on: https://chromium-review.googlesource.com/c/1356240Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612692}
-
Aaron Leventhal authored
Address whitespace-related flakiness by removing whitespace which is irrelevant to what is being tested. TBR=aboxhall@chromium.org Bug: 900532 Change-Id: I0b5a31b4ead65ce9b40658704b5ca8c0ff3f20dd Reviewed-on: https://chromium-review.googlesource.com/c/1356866Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#612691}
-
Xianzhu Wang authored
to increase test coverage. Directories with >= 4 failures are still skipped, and will be updated in later CLs. Change-Id: I02683ee1a33926e312867aa8057215ddc86d9671 Reviewed-on: https://chromium-review.googlesource.com/c/1356125Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612690}
-
Tina Wang authored
Added span tag inside title div to ensure: - the minimum height of title will be 24px, - the theme pills won't shrink size when font size is small Deleted the height and line-height properties in md-title style to: - let the span keep the min height - let the line-height increase automatically when choosing huge font size Bug: 908792 Change-Id: I75f5ab0b39ddc760115b2dfa8ea013adee490e2b Reviewed-on: https://chromium-review.googlesource.com/c/1354356 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#612689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b51eb09fb5bb..317a9ebdb019 git log b51eb09fb5bb..317a9ebdb019 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 tobine@google.com Vulkan: Roll VK deps forward Created with: gclient setdep -r src/third_party/angle@317a9ebdb019 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:845519 TBR=fjhenigman@chromium.org Change-Id: I6c7a2da32e78a857475f89b720cd3d05e04b1b70 Reviewed-on: https://chromium-review.googlesource.com/c/1356632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612688}
-
Hiroshige Hayashizaki authored
This reverts commit 0bdd3c25. Reason for revert: Suspected to cause compile failure on the Google Chrome Linux x64 bot crbug.com/910644 Original change's description: > Roll clang 346388:347933. > > Bug: 904337 > Change-Id: I8fad51cde2b93b83dfa1a14c61a992f659d827be > Reviewed-on: https://chromium-review.googlesource.com/c/1356710 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612660} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: Ia95868dd39daaa60e204a6ec64df6eabfafacb94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904337, 910644 Reviewed-on: https://chromium-review.googlesource.com/c/1357012Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#612687}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/327406e12cba..207cb0177f05 git log 327406e12cba..207cb0177f05 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 treehugger-gerrit@google.com Merge "Only run SIGINT handler once." 2018-11-30 lalitm@google.com trace_processor: add tests for new args table 2018-11-30 lalitm@google.com Merge "trace_processor: refactor to an ever present id approach" Created with: gclient setdep -r src/third_party/perfetto@207cb0177f05 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7109941366ef1f61bfd206410556dd74cd114dca Reviewed-on: https://chromium-review.googlesource.com/c/1356630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612686}
-
Andrey Kosyakov authored
Same as https://chromium-review.googlesource.com/c/chromium/src/+/821410/, but now for the network service. Bug: 898306, 793692, 721408 Change-Id: I96a2a25e66f4ff528d84baf03d600e4f1c89dd30 Reviewed-on: https://chromium-review.googlesource.com/c/1313739Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#612685}
-
Peter Beverloo authored
The spec defines it to be an unsigned long long (uint64_t in Chromium), so let's make sure all the plumbing agrees with that. Change-Id: I9c22d4a197d726c276b3e69818276a4d149c68c8 Reviewed-on: https://chromium-review.googlesource.com/c/1356709Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#612684}
-
Philip Rogers authored
This patch switches web tests to use --enable-blink-features=BlinkGenPropertyTrees instead of --enable-blink-gen-property-trees. This will let us remove the BGPT-specific command line flag in the future. To run web tests (formerly layout tests) with BlinkGenPropertyTrees, use: [run_web_tests] --additional-driver-flag=--enable-blink-features=BlinkGenPropertyTrees Bug: 836884 Change-Id: Ie4fa7d4f8ed8b7c027d6c34308230a4735d77972 Reviewed-on: https://chromium-review.googlesource.com/c/1355610Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612683}
-
Dave Tapuska authored
Apply casts where necessary. These are all safe. BUG=879657 Change-Id: Ia0a79b09796ed065a06e60ef880248cadcef3490 Reviewed-on: https://chromium-review.googlesource.com/c/1355775 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612682}
-
Michael Lippautz authored
Bug: 843903 Change-Id: I24d73949caec0b2ea55cf6cfa058cbf5f7d2826a Reviewed-on: https://chromium-review.googlesource.com/c/1355941Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612681}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bd7b090dcae..f2f731d6ce85 Created with: gclient setdep -r src-internal@f2f731d6ce85 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41e73f5c923c48f0598d80922386a18013ff1491 Reviewed-on: https://chromium-review.googlesource.com/c/1356629Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612680}
-
Nate Chapin authored
Rather than propagating the values set by testRunner.addOriginAccessWhtielistEntry, have the iframe used by the tests call it. Specify which test case to perform by creating the iframe with a different src hash component Bug: 585188 Change-Id: I04c1f647306c3e5675b641b47858aff1d25bfd07 Reviewed-on: https://chromium-review.googlesource.com/c/1354504Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#612679}
-
Thomas Tangl authored
The unified consent feature was not enabled in UnifiedConsentBrowserTest for official tests. This is fixed now. Bug: 910523, 888527 Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda Reviewed-on: https://chromium-review.googlesource.com/c/1356960 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#612678}
-