- 30 Nov, 2017 40 commits
-
-
Luis Hector Chavez authored
In order to reduce the number of base::Bind/base::Callback uses added to the codebase while we are in the process of a migration, we can add a global PRESUBMIT.py hook to nudge people to use the new interfaces. Bug: 714018 Test: git cl try Change-Id: I60741a1532a060fc75f3aeb1533e88abbdf9cfe7 Reviewed-on: https://chromium-review.googlesource.com/794879Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#520611}
-
Mike West authored
Bug: 788936 Change-Id: Icd4e22745561d57c691fd0f0e75bb8c3e4a59303 Reviewed-on: https://chromium-review.googlesource.com/795717 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520610}
-
kapishnikov authored
BUG=706515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4e5a3fb4b42c8367abb0e46d8f5383950442e064 Reviewed-on: https://chromium-review.googlesource.com/801050Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520609}
-
Ivan Sandrk authored
Bug: Change-Id: I2325e83ced67c5388a36d38790ba6e366152bc8f Reviewed-on: https://chromium-review.googlesource.com/793711Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520608}
-
Gauthier Ambard authored
The toolbar's buttons are updated on screen rotation. In particular their alpha value is set to 1 even if the omnibox is focused. It displays the back/forward button as they are hidden during the animation of the omnibox focus. This CL fixes it by not updating the alpha value if the omnibox is focused. Bug: 788816 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I604126cb2f80095f35229c0a3c2ae1a14deb3225 Reviewed-on: https://chromium-review.googlesource.com/796071 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#520607}
-
Gary Kacmarcik authored
This is requires so that the clipboard code can access the Permission methods (since core/ can't reach into modules/). Permission checks will be added in a follow-up cl. Bug: 677564 Change-Id: Ia5dbf39a05ab5acb0b0aa5504bdf8a783751a6fb Reviewed-on: https://chromium-review.googlesource.com/798125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#520606}
-
Nasko Oskov authored
When over the process limit, same-site navigations in new tabs (ctrl+click, middle click, context menu "open in new tab") should try to reuse an existing process suitable for hosting the initial target of the navigation. This CL fixes the current behavior by creating a SiteInstance for the URL the new tab is created with. Bug: 774723 Change-Id: I2e35b7bc1d62826a9a220f2e021c6119d9abcccf Reviewed-on: https://chromium-review.googlesource.com/794952Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
Adds unit tests that simulate tab activity and test the UKMs logged by TabMetricsLogger. Bug: 784639 Change-Id: Id5854b3e2b38b98ecc3d654ac93a24578e26ae3d Reviewed-on: https://chromium-review.googlesource.com/791868 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/e053e0fd169a..646257d65c65 $ git log e053e0fd1..646257d65 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 dsinclair Run clang-tidy google-readability-casting on //third_party/pdfium 2017-11-30 dsinclair Run clang-tidy modernize-use-nullptr on //third_party/pdfium 2017-11-30 jose.dapena GCC build fix: access from global function to private methods in CJS_PublicMethods. 2017-11-30 jose.dapena Add LG Electronics to the AUTHORS 2017-11-30 dsinclair Run clang-tidy modernize-use-bool-literals on //third_party/pdfium 2017-11-30 dsinclair Run clang-tidy modernize-use-auto on //third_party/pdfium 2017-11-30 dsinclair Run clang-tidy modernize-use-equals-{delete,default} on //third_party/pdfium Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id46ddaa6bda8deb93cd88350e2d743c71609cc68 Reviewed-on: https://chromium-review.googlesource.com/801190 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520603}
-
Kevin Bailey authored
Bottom wasn't lined up. Bug: 780835 Change-Id: Id4f7dcc4d590e2f5f3f83457cea2095e7a1011cf Reviewed-on: https://chromium-review.googlesource.com/800791Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#520602}
-
danakj authored
If gpu compositing is disabled globally, or for a single compositor, don't make contexts and don't give them to the ui::Compositor so it knows to generate software resources. R=kylechar@chromium.org Bug: 730660 Change-Id: I192934b798e0ab81b39231066ff80fbc2f3f0774 Reviewed-on: https://chromium-review.googlesource.com/797444Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#520601}
-
kapishnikov authored
[delegate_ totalBytesReceivedPerTask][task] returns a NSNumber that should be converted to integer for proper printing. BUG=706515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57c7ecea727a13ef5a79a205dee1c134dfe93eea Reviewed-on: https://chromium-review.googlesource.com/797952Reviewed-by:
-
Mihai Sardarescu authored
This CL uses the /signin/chrome/sync Gaia endpoint when signing in to Chrome when DICE is enabled. Bug: 789578 Change-Id: Ide40f5b7cc1d3f34f07a482f369d6826c1e2ca29 Reviewed-on: https://chromium-review.googlesource.com/800619 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
kapishnikov authored
It is not entirely correct to use "<" to compare number of failed requests. E.g. it will always fail if the total number of requests is '1'. If the total number of requests is 3 then no failures are tolerated while one should be allowed. BUG=706515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77469141d5b789ca793a1cf8c3a79a9de5206a84 Reviewed-on: https://chromium-review.googlesource.com/800973 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
-
Marc Treib authored
This includes DefaultSearchProviderInstantURL, DefaultSearchProviderInstantURLPostParams, and DefaultSearchProviderSearchTermsReplacementKey. These all haven't had any effect for a while, so let's mark them as such. Bug: 476079 Change-Id: I168dfd781e4a2eaa0e69855e7ba7fc875e5bb83c Reviewed-on: https://chromium-review.googlesource.com/785933Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#520597}
-
Dave Tapuska authored
The fake mouse move event gets fired for mojo input messages and causes the layout test to be flaky. Ensure we have a spacer so that the hover events that the fake mouse move generate are contained in there. BUG=789485 Change-Id: I3a6d659e9f51906536333f78fa32cf40e4ad99c6 Reviewed-on: https://chromium-review.googlesource.com/797850Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#520596}
-
Joe Mason authored
Move the behaviour controlled by ExperimentalSwReporterEngine and ExperimentalSwReporterEngineOnAllArchitectures outside the feature checks so it is always on. The exception is the "tag" parameter which is used in testing so must still be set through a feature until the test scripts are updated. Bug: 786964 Change-Id: I06bd7a599b3ab61121daca939d3df60967b3c0e6 Reviewed-on: https://chromium-review.googlesource.com/779302 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520595}
-
John Abd-El-Malek authored
Add a unit test to ensure that if RESOURCE_TYPE_PREFETCH is specified in content::ResourceRequest, it's translated into the proper net:: flag on URLRequest. The test is for the network service case. The old navigation code path has this covered already in RequestDataResourceDispatcherHostBrowserTest.LinkRelPrefetch. The motivation is to convert a few prefetch browser tests from checking the URLLRequest object (which won't work with network service) to instead look at the ResourceRequest object. Also de-duplicate BuildLoadFlagsForRequest. BUG=776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I29a66944d17a7e99b2bacbcb0766fa1b1174bd57 Reviewed-on: https://chromium-review.googlesource.com/797926Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#520594}
-
Peter Qiu authored
Bug: 789688 Test: manual Change-Id: I5821af5fd79931197dad45b13b365e909c83a0a4 Reviewed-on: https://chromium-review.googlesource.com/798016Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520593}
-
Gheorghe Comanici authored
This CL adds a fallback to display MostVisited URLs when personalized zero-query is enabled with ChromeHomePersonalizedOmniboxSuggestions but the user is not signed-in. TBR=rohitrao for mechanical changes to ios/c/b/a/* Bug: 781994 Change-Id: Id4f46c74115d88003d34df9e6b93190cf4c97368 Reviewed-on: https://chromium-review.googlesource.com/796451 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520592}
-
dpapad authored
This also allows for some simplifications - No longer need to specify --cr-toolbar-field-width. - Removed unnecessary dev-controls div wrapper. Bug: 788981 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9425e3eaecde952dff93a7d1af483abc98518e1 Reviewed-on: https://chromium-review.googlesource.com/797935Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520591}
-
xlai authored
Bug: 787972 Change-Id: Ie0cc0594451cbab0d46320d5997813596c442270 Reviewed-on: https://chromium-review.googlesource.com/788280 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520590}
-
Becca Hughes authored
Add an "autoplay" feature that controls autoplay and delegate activation state through frames. BUG=788390 TBR=skyostil@chromium.org,iclelland@chromium.org Change-Id: I67e40ae00b0ca7acad7bbef4b4cb4525a9e65fb3 Reviewed-on: https://chromium-review.googlesource.com/800851 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#520589}
-
Julian Pastarmov authored
BUG=775960 Change-Id: Ic5ec7c97b18f6d0a5e24a7db6f6b14de43a3adb3 Reviewed-on: https://chromium-review.googlesource.com/799871Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#520588}
-
Miguel Casas authored
This CL adds support for playing back 10 bit VP9 Profile 2 videos using Vaapi (via VaapiVDA and VaapiWrapper). Essentially it adds using VA_RT_FORMAT_YUV420_10BPP and indicating 10b where needed. Vaapi supports VP9.2 10bpc on Kaby Lake processors (e.g. Soraka, Eve). Before that, no changes, VaapiVDA is not used for VP9.2, and we fall back to VpxVideoDecoder as on ToT. Note: the decoding itself happens in 10bits, but blitting still happens onto an 8 bit per channel GpuMemoryBuffer. Further CLs will wire higher bit depth GpuMemoryBuffers. TEST= chrome://gpu; video playback e.g. [1] and verify via chrome://media-internals that GpuVideoDecoder is engaged. Note that the video is played back smoothlier than with VpxVideoDecoder. All this on soraka with a simplechrome. - Also extended video_decode_accelerator_unittest, but has to be landed in separate CLs, see: crrev.com/c/797853 [1] http://crosvideo.appspot.com/?codec=vp9.2&loop=true Bug: 778093 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic9fe15a1a1f4470704228882cccd8a9174edbfd3 Reviewed-on: https://chromium-review.googlesource.com/797443Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#520587}
-
Justin Novosad authored
This is a step towards unifying OffscreenCanvasResourceProvider with CanvasResourceProvider, which will eventually allow low latency canvas rendering to use a single buffered GpuMemoryBuffer BUG=788439, 776801 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie9f04e7920e7d74c229c4d45c34c371ab5d06e36 Reviewed-on: https://chromium-review.googlesource.com/800670 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#520586}
-
Sami Kalliomäki authored
Previously targets like //:foo wouldn't work because an extra slash would be inserted in front of the GradleSubdir. Bug: 620034 Change-Id: I93abfb36ccb683b7c6308a8cbe14e870ea699e00 Reviewed-on: https://chromium-review.googlesource.com/800617Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sami Kalliomäki <sakal@chromium.org> Cr-Commit-Position: refs/heads/master@{#520585}
-
Martin Sramek authored
1. Remove the code of the old ("non-MD") Incognito NTP 2. Remove the qualifier "MD" from variable names (no longer necessary, as the "non-MD" version is removed) 3. Remove the qualifier "MD" from file names (as above; and thus overwrite the previous files). Note: #3 was executed as: > mv md_incognito_tab.css incognito_tab.css > mv md_incognito_tabsjs incognito_tab.js > mv md_incognito_tabshtml incognito_tab.html And then inside md_incognito_tabs.html: > s/md_incognito_tab/incognito_tab/ Although git understood this as delete+rename, the diffs in the code compare the old files with the new ones, so it's not as well visible :( Bug: 693525 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8e4096337dff097aaf400f15b2c2b7b8e1c9c475 Reviewed-on: https://chromium-review.googlesource.com/777319 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:Evan Stade <estade@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520584}
-
Mark Cogan authored
When the BVC is presented, the timing of when the stack view's -viewWillAppear: method call is changed such that it doesn't yet reflect any size changes to the stack view since the last time it ran. (For example, if the device is rotated between seeing the stack view). This means that the card sizes will be computed based on an incorrect size for the stack view. This CL fixes this for non-iPhone X devices by (in MainPresentingVC) calling the new -prepareForDisplayAtSize: TabSwitcher method before -dismissViewController is called, which kicks off the UIKit-managed transition process. -prepareForDisplayAtSize: is a no-op in the iPad TabSwitcher; in the StackViewController it just updates the view bounds to have the passed size if they don't already. This means the right size will be set when -viewWillAppear: is later called. In order for this to work correctly, MainPresentingVC also needs to make sure its child view controllers are properly constrained, so that any size changes to MainPresentingVC's view (which happens in the transition animator) propagate to its child view controller. This CL also includes some assorted cleanup in StackView-related files: - StackViewController's -loadView method is changed to -viewDidLoad. - CardSet's _view ivar is renamed to match the property it backs. - The iOS8 guards around IsPortrait() are removed, since the minimum OS version is now 10.0. Bug: 787832 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1f998f37aa14a1ce12512d912a49b0b274d3043a Reviewed-on: https://chromium-review.googlesource.com/800870 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Sami Kalliomäki authored
Adds supports for methods that have generic types in arguments. Return values with generic types are not supported yet. Bug: webrtc:8557 Change-Id: I1af2b23a0adde561a2ce2cc3906124ec06f6c9d5 Reviewed-on: https://chromium-review.googlesource.com/789941 Commit-Queue: Sami Kalliomäki <sakal@chromium.org> Reviewed-by:
-
Robert Sesek authored
Bug: 598854 Change-Id: Ice5b1a0166c841393966b91b3ff464421aa1b619 Reviewed-on: https://chromium-review.googlesource.com/794351Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520581}
-
Mike Dougherty authored
Failing tests listed in crrev.com/c/778283 were fixed by crrev.com/c/780363 This is a reland of beecf799 Original change's description: > Enable iOS Captive Portal feature by default. > > Bug: 750228 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I0fa138e855d71ac256759d75f3e84d390cd2c896 > Reviewed-on: https://chromium-review.googlesource.com/777468 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517579} Bug: 750228 Change-Id: Idb7aff0f30b9f5cf1f3317355442a34598cc1893 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/798643Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#520580}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/98b56332e9b5..e053e0fd169a $ git log 98b56332e..e053e0fd1 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 npm Reduce memory limit of PDF XFA fuzzers Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I704d2e7797eda77f1a920f0ffacb27fa0a139689 Reviewed-on: https://chromium-review.googlesource.com/800790 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520579}
-
Christopher Grant authored
Text elements can now default to multiline, but can be configured as single-line, to truncate rather than grow the texture vertically. Along the way, remove a field width parameter from the Text constructor. This value needs to match the element size, and should be pulled from element size rather than explicitly set to match. BUG= TBR=vollick@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8a0e48b1efb3b562e9a8f0037e9718020bcfc01b Reviewed-on: https://chromium-review.googlesource.com/796710 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520578}
-
Peter Beverloo authored
It's the responsibility of the NotificationDisplayService to distinguish between multiple profiles, so we're effectively including profile data with notifications twice. Let's remove the less important instance. Bug: 748436 Change-Id: Ie88c91fa115573589e2dafd61f5e028ea27cd03d Reviewed-on: https://chromium-review.googlesource.com/796796 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#520577}
-
Avi Drissman authored
This reverts commit d8d9405e. Reason for revert: Builder: Mac10.9 Tests (dbg) https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 started breaking in TwoClientPasswordsSyncTest.SetPassphraseAndThenSetupSync and this is the only sync change. Sheriff notes say that this was reverted the first time for this exact test breakage. Please DO NOT RELAND until you ensure the test won't fail. Original change's description: > Reland "Migrate away from deprecated RunLoop API" > > In this second attempt, we stick to QuitWhenIdle() for passwords, with > no apparent legit reason. TODO added for further investigation. > > This is a reland of 07edac9e > Original change's description: > > Migrate away from deprecated RunLoop API > > > > Instead, we keep around an instance of base::RunLoop and pass it > > explicitly for Quit(), which makes sure the code quits the intended loop > > and not a nested one. > > > > Bug: 783774 > > Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a > > Reviewed-on: https://chromium-review.googlesource.com/784790 > > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#519664} > > TBR=pavely@chromium.org > > Bug: 783774 > Change-Id: Ia93b738ad34e78289d938809f61e6c6d06c4bc80 > Reviewed-on: https://chromium-review.googlesource.com/793910 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520539} TBR=pavely@chromium.org,mastiz@chromium.org Change-Id: I1f45e1795eaa8d7a8aa22a7af6d87b5cb173ff0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783774 Reviewed-on: https://chromium-review.googlesource.com/801170Reviewed-by:
-
Sammie Quon authored
Originally tries to show bubble when the pref service (user) changes. Added checks in PaletteWelcomeBubble::ShowIfNeeded to check for the two cases where the bubble is not wanted. PaletteTray tries to show the bubble again when the session state changes. Test: ash_unittests PaletteWelcomeBubbleTest.* Bug: 786418, 786590 Change-Id: I0695a83383ce6c9d79f8d8f6dfda2eab0fb37071 Reviewed-on: https://chromium-review.googlesource.com/780841Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#520575}
-
Boris Sazonov authored
Disable SingleProcessMemoryTracingTest.ManyInterleavedDumps on Android+ASAN. TBR=primiano@chromium.org Bug: 788788 Change-Id: Idde4e22139404e59f1acb5df8164ccde1d784821 Reviewed-on: https://chromium-review.googlesource.com/800930Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520574}
-
Gauthier Ambard authored
This CL changes the priority of the constraints in the Clean Toolbar to ensure the width of the toolbar is respected. Bug: 788663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic6e750a4f6227ec3571dd41336c696a14d9b3807 Reviewed-on: https://chromium-review.googlesource.com/800638Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#520573}
-
Gauthier Ambard authored
This CL adds ToolsMenuPresentationProvider to the list of protocol the Toolbar protocol is conforming to. It allows the tools menu to have the correct position of the tools menu button in every case. Bug: 789956 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a19893c12fa3dcfd98ef2d56788d0dd2e4667e7 Reviewed-on: https://chromium-review.googlesource.com/800635 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#520572}
-
