- 21 Jun, 2018 40 commits
-
-
Stephen Martinis authored
Makes the isolated script test wrapper script know that metrics_python_tests is a typ based test suite, so that it passes the proper command line argument to it. Bug: 533481 Change-Id: Ifd45f947409989174e1da046be6a8342931f82eb Reviewed-on: https://chromium-review.googlesource.com/1109400Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#569423}
-
Dominic Mazzoni authored
When a frame is hidden, replace its accessibility tree with just the root, and suppress all accessibility events in that tree while it's hidden. By keeping the root in the tree, this allows us to propagate the change to the browser process and free up resources there too. The goal is that having lots of tabs open shouldn't significantly impact your experience. It may add a slight delay when switching to a tab. Bug: 854411 Change-Id: I78b45e8f5772f0c9745ee59952f27f6ba3557bbc Reviewed-on: https://chromium-review.googlesource.com/1107207 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569422}
-
Hector Carmona authored
Bug: 854560 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I48820701f46e82e27a488f1b2b5a7feaaa20e436 Reviewed-on: https://chromium-review.googlesource.com/1108752Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#569421}
-
Xianzhu Wang authored
Bug: 854848 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id1cf7b09fc32141758792c26f805fb73a1f131cb Reviewed-on: https://chromium-review.googlesource.com/1109500Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569420}
-
Will Harris authored
BUG=767906 Change-Id: I79dfb0509a1acc532a97750b4609e8bd6e3a438e Reviewed-on: https://chromium-review.googlesource.com/1110356 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569419}
-
Xiyuan Xia authored
- Add RunDragLoop and CancelDragLoop to WindowServiceDelegate interface; - WindowServiceDelegateImpl use ash::DragDropController to provide the actual impl; - WindowTree implements PerformDragDrop and CancelDragDrop via the WindowServiceDelegate; Bug: 837716 Test: WindowServiceDelegateImplTest.*Drag*, WindowTreeTest2.*Drag* Change-Id: Id5d609d30dd53171b01bfeec60e4547f7a61b4c3 Reviewed-on: https://chromium-review.googlesource.com/1110669 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569418}
-
Mounir Lamouri authored
Bug: 855051, 853609 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieedad00a60f3a64cf256771dc234953a928b5073 Reviewed-on: https://chromium-review.googlesource.com/1110667Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569417}
-
Michael Spang authored
Chrome OS does not have the VK_KHR_surface or VK_KHR_swapchain extensions. Move them to implementation specific code to allow initialization of vulkan on Chrome OS. Bug: 851997 Test: vulkan ozone_demo on linux x11 Change-Id: I5355a1f7e6d5215b98aba2defc8e4d631f6a964e Reviewed-on: https://chromium-review.googlesource.com/1104860 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#569416}
-
Sean O'Brien authored
To prevent poor quality touches on hana, add a filter for low pressure touches, such as those generated by a pencil. Finger presses are above the chosen threshold and aren't affected. If a contact ever exceeds the presure threshold, all remaining events for that contact are sent. CQ-DEPEND=CL:1093584 BUG=b:69232663 TEST=manual testing on hana with pressure filter enabled Change-Id: Ic2d56eb656e318ee46744ef37f6055d8573a2261 Reviewed-on: https://chromium-review.googlesource.com/1096126Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#569415}
-
Mathieu Perreault authored
For privacy reasons, the native code will have to choose which icon is served within a single source (so the implementer cannot deduct history). The priority order is the local favicon, the server favicon or a letter+circle fallback. This CL implements the first and the last of those, and further CLs will improve the logic. Bug: 853780 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6f56d02f3c953964e4968f191b8fb3177998c962 Reviewed-on: https://chromium-review.googlesource.com/1105508 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569414}
-
Scott Violet authored
Adds registering the ui::mojom::Arc interface. Adds early to AccessibilityController::UpdateVirtualKeyboardFromPref. BUG=837686 TEST=none Change-Id: If417134ed26931a050e9bfdfd4b267d8ee819b9a Reviewed-on: https://chromium-review.googlesource.com/1111012Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569413}
-
Xiaohan Wang authored
This is more consistent with how other capabilities are passed along. Bug: 848532 Test: No new functionality Change-Id: Ib0ec5f979c9d183950fcaa6424729a027c5e5ef5 Reviewed-on: https://chromium-review.googlesource.com/1109739Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569412}
-
Theresa authored
Update fieldtrial testing config for experiment with scroll-to-load disabled. BUG= Change-Id: Ibb8c76592c12addd3c2f807fe9d338665f30e0c0 Reviewed-on: https://chromium-review.googlesource.com/1110850 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569411}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53842b6cbc1f..7a75f465f541 git log 53842b6cbc1f..7a75f465f541 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 simonhatch@chromium.org Revert "Dashboard - Raise error on duplicate histograms in /add_histograms" 2018-06-21 ckitagawa@chromium.org [Build] Filter HealthyDevices by ABI 2018-06-21 simonhatch@chromium.org Dashboard - Properly attach ownership data to alerts. 2018-06-21 benjhayden@chromium.org Add dashboard/dashboard/spa/OWNERS Created with: gclient setdep -r src/third_party/catapult@7a75f465f541 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:853280 TBR=sullivan@chromium.org Change-Id: I15c924f040d46935274f8527d60f55c926f6e850 Reviewed-on: https://chromium-review.googlesource.com/1110301Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569410}
-
Guido Urdaneta authored
These utility sets are very specific to constraints processing, but they have generic-looking names such as DiscreteSet and NumericRangeSet, which might cause issues if actually generic sets with those names want to be added elsewhere. Bug: 731166 Change-Id: I5a5fcec7d1a83417b007621b496b22acba509352 Reviewed-on: https://chromium-review.googlesource.com/1101201 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569409}
-
Jay Civelli authored
This impacted a lot of APIs that now need to be provided with a SharedURLLoaderFactory. Note that in many of these APIs we still need also the net::URLRequestContextGetter as other GAIA requests still use the networ API directly. Once all GAIA code uses the network service, all APIs will be changed to only take the SharedURLLoaderFactory. Many tests that simulate URL responses had to be changed and use a TestURLLoaderFactory. In some instances, we need the TestURLLoaderFactory for the OAuth token but still mock the URLRequests directly for other operations. Also: - split up OAuth2AccessTokenFetcherImplTest.MakeGetAccessTokenBody into smaller tests - exposing ways to simulate URL responses directly in TestURLLoaderFactory as it was required by some tests Bug: 840396 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6d1d1081238aa5e1d8dc5f1469e4c752c93729fc Reviewed-on: https://chromium-review.googlesource.com/1096309 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#569408}
-
Pedro Amaral authored
If the BottomToolbar is destroyed before native is initialized there will be a null pointer exception. This CL adds a null check to prevent this. Bug: 854342 Change-Id: Ic0a82574e87bce7f46b20d3621796fad09c119a5 Reviewed-on: https://chromium-review.googlesource.com/1107053 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#569407}
-
Fady Samuel authored
If a SurfaceLayer is given an invalid SurfaceId then it should not block on that invalid SurfaceId and the specified deadline should play no part in the deadline of the CompositorFrame. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I71c31315ff0dbcd0ab9697e98c5f58aa3691bf67 Reviewed-on: https://chromium-review.googlesource.com/1110028Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Frank Kastenholz authored
Update flags https://chromium-review.googlesource.com/c/1108077 -------------------------------------------------- Fix include guard name https://chromium-review.googlesource.com/c/1106672/ -------------------------------------------------- Add net/third_party/quic/core/quic-debug_info_provider_interface.h Adds this file into the git commit history https://chromium-review.googlesource.com/c/1106672/ -------------------------------------------------- Do not set send alarm if write blocked. Do not set send alarm in the end of quic packet processing if it's write blocked. Protected by FLAGS_quic_reloadable_flag_quic_no_send_alarm_in_process_packet_if_write_blocked. Merge internal change: 200989386 https://chromium-review.googlesource.com/c/1106902/ -------------------------------------------------- Validate largest observed field in ACK frames. In QUIC, validate largest observed in received ack frame by comparing with largest sent packet instead of largest created packet. Protected by FLAGS_quic_reloadable_flag_quic_validate_ack_largest_observed. Merge internal change: 200744974 https://chromium-review.googlesource.com/c/1106899/ -------------------------------------------------- Add two flag protected CHECKs for oob access into sent packet manager's unacked_packets. Protected by FLAGS_quic_reloadable_flag_quic_extra_checks_in_ack_processing. Since bandaid does not have logs or core dumps, CHECK failure is the only way we can think of to get more information(from deathrattle report) to debug b/110029150. Do not intend to verify this flag, we only need to turn it on on bandaid from liveflag. Merge internal change: 200621124 https://chromium-review.googlesource.com/c/1106672/ -------------------------------------------------- Clean up QUIC Frame Generation and Parsing Clean up left-over stuff in the generation and parsing of QUIC Frames - Remove the IETF_TEMP_ frame types that were allocated to the IETF framer for testing purposes, - Remove code that uses/references/expects the IETF_TEMP types - Close connection (and/or do a QUIC_BUG) if we attempt to generate a GO AWAY or STOP WAITING in version 99. These frames are not valid in Version 99 - Close connection (and/or do a QUIC_BUG) if we attempt to generate an APPLICATION_CLOSE, NEW_CONNECTION_ID, MAX_STREAM_ID, STREAM_ID_BLOCKED, PATH_RESPONSE, PATH_CHALLENGE, or STOP_SENDING frame while NOT in version 99. These frames are IETF only. N/A - affected code all protected by the version 99 flag. Merge internal change: 200443164 https://chromium-review.googlesource.com/c/1106669/ -------------------------------------------------- Fix the flaky QuartcConnectionTest.DisconnectClosesRemote 1) We were removing packet writer before the connection was destructed (ownership was probably moved at some point in time). 2) QuartcThreadSafeSession::CloseConnectionSync was not closing a session, which led to the destruction of QuicConnection on the main thread, which led to a race condition. Reinstituted session_ = nullptr and added checks in other delegates. Also added a check in a destructor. 3) Changed "CancelImpl" to "Cancel" in the QuartcAlarm so that the deadline is resetted. Fix ordering of destructors in QuartcSession. Merge internal change: 200439184 https://chromium-review.googlesource.com/c/1106666/ -------------------------------------------------- Add underflow checks in IETF ACK frame processing. Add checks for underflows when stepping through the additional ack blocks for IETF ACK frames N/A Code is executed only if version-99 negotiated, which does not happen. This addresses issues found in Chromium Fuzz Testing - numbers 850476, 850554 Merge internal change: 200395378 https://chromium-review.googlesource.com/c/1106662/ -------------------------------------------------- Increase the default stream/session flow control limits. The default limit of 16KB causes blocking on sender and prevents us from even reaching BWE! This change fixes the delay and dropped frames in Quartc, and should have a significant impact on video quality. Increase the default stream & session flow control limits for quartc quic connection. Merge internal change: 200269081 https://chromium-review.googlesource.com/c/1106661/ -------------------------------------------------- Allow parsing/serializing a CryptoHandshakeMessage in QUIC's TransportParameters The CryptoHandshakeMessage in TransportParameters carries 3 values from QuicConfig: silent close, initial roundtrip time, and connection options. It also contains UAID. This provides support for gQUIC specific parameters in the TLS handshake as a stopgap until they either get added to IETF QUIC or removed from gQUIC. More Transport Parameters in QUIC; proected by --quic_supports_tls_handshake Merge internal change: 200258885 https://chromium-review.googlesource.com/c/1106660/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_no_mspc. Merge internal change: 200126339 https://chromium-review.googlesource.com/c/1106658/ -------------------------------------------------- Set bytes for QUIC connection id to 0. The ICE transport provides unique 5-tuples for each connection, so it's possible to omit the QUIC connection id from packet headers. This should save overhead. n/a (quartc only) Merge internal change: 200118909 https://chromium-review.googlesource.com/c/1106520/ -------------------------------------------------- Remove third_party/quic/http/ as this code is now unused. n/a - unused code Merge internal change: 200099282 https://chromium-review.googlesource.com/c/1106305/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_enable_server_proxy2. Merge internal change: 200091805 https://chromium-review.googlesource.com/c/1106297/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_enable_h2_deframer. Merge internal change: 200089857 https://chromium-review.googlesource.com/c/1106219/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_version_manager_dedupe_transport_versions Merge internal change: 200085914 https://chromium-review.googlesource.com/c/1106004/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_incremental_loss_detection. Merge internal change: 200057466 https://chromium-review.googlesource.com/c/1106002/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_respect_ietf_header. Merge internal change: 200055473 https://chromium-review.googlesource.com/c/1106000/ -------------------------------------------------- Replace flag quic_reloadable_flag_quic_enable_pcc with ..._pcc2 Replace the old pcc enable flag with a new one, so that we can check that the new codes are indeed running in experiment. Changes flag quic_reloadable_flag_quic_enable_pcc to quic_reloadable_flag_quic_enable_pcc2 Merge internal change: 200046441 https://chromium-review.googlesource.com/c/1105999/ -------------------------------------------------- In QUIC, move time wait list manager ProcessPacket from OnUnauthenticatedHeader to OnUnauthenticatedPublicHeader because packet number is not needed for public reset anymore. No function change expected. Not protected. Also remove unused version fields. Merge internal change: 200037571 R=rch@chromium.org Change-Id: I5e76d4b8627c0c2810c7468dad38086f16f82211 https: //chromium-review.googlesource.com/c/1105997/ Reviewed-on: https://chromium-review.googlesource.com/1108373 Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569405}
-
Sarah Hu authored
We should re-position the dialog when tablet mode is changed, and when display metrics is changed. Bug: 841074, 837005 Change-Id: I11299070a947e2fc4f4f494d2bbac4c94c27746e Reviewed-on: https://chromium-review.googlesource.com/1110487Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569404}
-
chrome://flagsDaniele Castagna authored
This patch adds a multi-value entry in about://flags that will help enabling/disabling HW overlay strategies used to promote quads to HW overlays. Bug: 854677 Change-Id: Ibaedb02084a0b6aea490637bd6c4456caa63e29d Reviewed-on: https://chromium-review.googlesource.com/1108520 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569403}
-
Robert Liao authored
MacOS does not handle zero-sized windows well. BUG=854267 Change-Id: I3da67cef7abdc035ca6378d5cb31dc68a097ee67 Reviewed-on: https://chromium-review.googlesource.com/1109200Reviewed-by:
-
Robert Ma authored
All asserts need to be in a step func. Unfortunately this makes the tests more verbose. Found in https://github.com/web-platform-tests/wpt/pull/8748#issuecomment-398954260. Change-Id: Ib15270d6093ea094b0f8c387cc4370f5154cf5dd Reviewed-on: https://chromium-review.googlesource.com/1109689 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#569401}
-
Nico Weber authored
This makes the fyi bots run viz_gtests instead of viz_fyi_gtests which removes a few test binaries, but since those weren't run on any other desktop bot, it probably wasn't intentional that they run on mac anyways. Bug: 843511 Change-Id: Ieb132304f3e6b3869c1c2238ec509ed5a95174ab Reviewed-on: https://chromium-review.googlesource.com/1108360Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569400}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bcd66f54de12..3d8131535e6b git log bcd66f54de12..3d8131535e6b --date=short --no-merges --format='%ad %ae %s' 2018-06-21 tsepez@chromium.org Pass output parameters as pointers in ijs_event_context 2018-06-21 tsepez@chromium.org Remove WideString::c_str() calls where possible. 2018-06-21 tsepez@chromium.org Avoid const-refs to implicitly constructed strings. Created with: gclient setdep -r src/third_party/pdfium@3d8131535e6b The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic8232f5102b620e309927cb2b89866ff19f7251b Reviewed-on: https://chromium-review.googlesource.com/1110457Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569399}
-
David Tseng authored
Test: ChromeVox menus (Search+.) works again. It was breaking the page due to this missing message id. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id2a5539d29d46343472829b5e4b5d8deefe06e94 Reviewed-on: https://chromium-review.googlesource.com/1107165Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569398}
-
Yue Li authored
- Add two more screens for the flow. - Update proto definitions Bug: b/78190629 Test: Manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic9a849e3184ea5b09e0f0f338a018caf2193d829 Reviewed-on: https://chromium-review.googlesource.com/1105469 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Rayan Kanso authored
TBR=jbroman@chromium.org Bug: 817445 Change-Id: I2336b16d2e10a524c176997b75471b8bc8310460 Reviewed-on: https://chromium-review.googlesource.com/1097482 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569396}
-
Ted Choc authored
BUG=854109 Change-Id: Iac8a8b5c947d890a17b187f1cded75332b3dba27 Reviewed-on: https://chromium-review.googlesource.com/1110517Reviewed-by:
-
Theresa authored
BUG=854866 Change-Id: Iff9021221210078e2d013b4c54628b6667323eee Reviewed-on: https://chromium-review.googlesource.com/1110676Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569394}
-
Caleb Rouleau authored
1. Enforce our lack of support for a custom remote-debugging-port by throwing an error if someone uses it. 2. If we can't parse a devtools port from the file, then check to see if Chrome has crashed and use that information to improve the error message. Do this right away instead of waiting 60 seconds. 3. Write tests for these errors! Bug: chromedriver:2474 Change-Id: Ie649f980745e5241ec462e7527a24d58ced9af02 Reviewed-on: https://chromium-review.googlesource.com/1106769 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569393}
-
Luke Sorenson authored
minijail0 security policy was updated to support new features. New components that use these new syscalls must use this new higher env version. Bug: 850956 Change-Id: I53252a4c25bc1b037b89e81960b9a0f164aab351 Reviewed-on: https://chromium-review.googlesource.com/1106007Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#569392}
-
Scott Violet authored
It was passing in the FrameSinkId, when it should have passed in the window id. BUG=837686 TEST=covered by test Change-Id: I2f6920528403452696d358110605aa85519a0b2d Reviewed-on: https://chromium-review.googlesource.com/1110748Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569391}
-
Lu Chen authored
Detail: In order to get finer resolution when recording metrics, the program multiples the area/distance metrics by 100 before sending to UMA, which can cause overflow. Fix: For area metric, the result is limited to 1.0; for distance metric, the result is limited to the maximum expected value (10000) by UMA before sending. Bug: 853435 Change-Id: Ie8d9751c86bd64f38bd79c3e12d502f71a551522 Reviewed-on: https://chromium-review.googlesource.com/1105506 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569390}
-
Tibor Goldschwendt authored
This is a stepping stone to implement a platform-specific scheduler. Bug: 801229 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9da94fc261a0834265e846069a0a6e3c4e51cebf Reviewed-on: https://chromium-review.googlesource.com/1097838Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Malay Keshav authored
This patch replaces the use of cr-link-row polymer element with a simple div element similar to what the touch calibration button is using. The cr-link-row element is meant for non indented DOM sections which the display page is not. The cr-link-row element comes with its own left padding which is not required in an already indented DOM. Bug: 844205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic4ecc5bf7388384cb403fa7783a53a18963305d6 Component: Display settings UI, overscan Reviewed-on: https://chromium-review.googlesource.com/1109205 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569388}
-
Dominik Röttsches authored
Add testing for font service to test methods on FontLoader. FontLoader will be extended to carry additional FontConfig IPC methods for font fallback, querying render style for strike, and performing PPAPI specific font functions. (See "FontService replacing Fonts Sandbox IPC" design doc [1] and issue [2]). Before doing that, let's ensure we have a framework to test these methods. As the font service runs in a child utility process, we need a way to ensure that it is set up for loading the custom FontConfig configuration that we use for consistent font access in testing. To that end, pass a command line feature enabled flag to the child process, and adding while setting up the TestSuite. Test basic matching, test failed matching, and test matching the empty font name. [1] https://docs.google.com/document/d/1dLBekS3RlcQFldeYZlzFGkuLyX53GBr_7Hbf4cUz1OE/ [2] crbug.com/839344 Bug: 849923 Change-Id: Ib3118d4a53b075725cbdc7fa89ba4f2b9eec8d5e Reviewed-on: https://chromium-review.googlesource.com/1091754Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#569387}
-
Mustaq Ahmed authored
The simulated clicks are now executed in the containing frame (vs the container frame). Bug: 805015 Change-Id: I706b73ab4bad3fc3e1784106829df6db5a1eba30 Reviewed-on: https://chromium-review.googlesource.com/1110341Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#569386}
-
W. James MacLean authored
Since page scale factor should never be non-1.f for OOPIFs, and since we're seeing this happen anyways, this CL inserts some diagnostic checks to try and determine where in the page-scale-factor pathways the non-1.f values are originating. Bug: 845097 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1d87e3a618d2fd71aa14cc5149084b08ddb7bf14 Reviewed-on: https://chromium-review.googlesource.com/1110345 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569385}
-
Ahmed Fakhry authored
When Night Light doesn't require software cursor, it should respect other accessibility settings that need the software cursor. BUG=854697 TEST=Expanded test. Change-Id: I6fe29a762265e7319f83af2a1eabe6b608b818c6 Reviewed-on: https://chromium-review.googlesource.com/1109457 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
