- 28 May, 2020 40 commits
-
-
Koji Ishii authored
This patch defers creating |NGFragmentItem| until |NGFragmentItemsBuilder::AddLine|. This patch also removes |NGLogicalLineItem::fragment_item|. It was needed because |NGInlineLayoutAlgorithm| must create |NGFragmentItem|, but with r771489 <crrev.com/c/2212187>, we can create |NGFragmentItem| even after |NGInlineItemResult| was destroyed. This is to reduce memory copy when changing the Vector of |scoped_refptr<NGFragmentItem>| to the Vector of |NGFragmentItem| (WIP <crrev.com/c/2208806>). Bug: 982194 Change-Id: I41a4e4339d09ef5020bc20abcfd3899ca30792e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216133Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772550}
-
Scott Violet authored
The controls shouldn't scroll if a11y is enabled. I plan to merge this to 84, so that I'm forking AccessibilityUtil. The plan it to move AccessibilityUtil to ui so that it can be shared. BUG=1085210 TEST=BrowserControlsTest.testAccessibility Change-Id: Icc04354639d3ae1b4f64773752705b37117e9f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219008 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#772549}
-
zhaoyangli authored
Previously this was only used for iOS 13+ device. This CL changes it for all on device GTests and remove the iOS version check method. This CL only prepares to run these in test runner scripts. Will send follow up CLs on GN configs to make device builders really build and run GTests with xctest. Bug: 1087078, 1001667 Change-Id: I03386ec0caa6f719640cb4d8140cb73ded0ef2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219108 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772548}
-
Nidhi Jaju authored
service worker registration for better estimation of the size of ServiceWorkerRegistrationInfo for an OOM crash investigation. Bug: 848194 Change-Id: I3d5af5405d64ab9629989d6287f474f61ec16436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217668Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#772547}
-
Koji Ishii authored
This patch changes |ComputeAnnotationOverflow| to not to use |fragment_item| to compute the block height of ruby runs. This is needed for crrev.com/c/2216133 to remove |NGLogicalLineItem::fragment_item|. Its replacement should be |inline_item|, but this patch doesn't add it because all ruby runs should have |layout_result| and shouldn't need |inline_item|. Bug: 982194, 1069817 Change-Id: I40a0670121499bd212ca95ba3e2680a9b0f292de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217672Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47bf5f46..97a2e2dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I553631475fcbb840b02f09e9ecabddb6984c4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217858Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772545}
-
Asami Doi authored
This CL adds a feature flag for the offline capability check that checks if a website is installable. Browser tests relating to the check are updated to use parameterized tests depending on the feature flag. Bug: 965802 Change-Id: I3678383d62c3fad084d7c7a804755bc97de9b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203571 Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772544}
-
Takashi Sakamoto authored
Bug: 1087208 Change-Id: Iadf7f79f37f27133c8fa1089a15c173142341500 Tbr: dbertoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217760Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#772543}
-
Stephan Hartmann authored
Constructing base::flat_set of QuotaClientType with parenthesis constructor is ambiguous in GCC. Use brace-initializer to avoid that problem. Bug: 819294 Change-Id: Id33256a25d2af98d7be6ee570e2535a8b7bdf031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217554Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#772542}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I68b71c8bbcdb63a99ae8c2395fc072dc37c284bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219390Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772541}
-
Stimim Chen authored
Add UMA entries to report the validation result of hardware_verifier. BUG=b:147654337 TEST=None Cq-Depend: chromium:2156385, chromium:2193391, chromium:2156386 Change-Id: I32b9402167c91439a93b414986493ee1e13dea2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156329Reviewed-by:
-
Shakti Sahu authored
This is a reland of bee2010f The original CL had DCHECK which got bypassed in some bots. Removing those DCHECK fixes the test. Original change's description: > Reland "Query Tiles : Integration test" > > This is a reland of d95d2248 > > Original change's description: > > Query Tiles : Integration test > > > > This CL adds end-to-end Integration tests for query tiles. The network > > layer is substituted by a embedded test server that serves a fake > > server response. Added omnibox javatests that use this mechanism to > > test the full flow. > > > > Bug: 1083807 > > Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153 > > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: Hesen Zhang <hesen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770512} > > Bug: 1083807 > Change-Id: I7f65bfb79006201bdaa545c0aba8dd7cf2b4a243 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210654 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772139} TBR=dtrainor@chromium.org,xingliu@chromium.org Bug: 1083807 Change-Id: Id25221dccda9d2aba45961859bf39def2d9b3cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218683 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772539}
-
Yuichiro Hanada authored
The extension api test was removed in crrev.com/c/2198861. Bug: 1083803 Change-Id: Ic60ab57af96367bd4579b6f3b5d9dcdfc24686e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217908 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#772538}
-
Takashi Sakamoto authored
The test is failing on Win 7 Tests x64 (1) and Win7 Tests (1). Bug: 1087206 Change-Id: I9afbf027adbdbb53ba91bbf7c56b118a8e5f4855 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217520Reviewed-by:
-
Peter Kotwicz authored
This CL fixes NullPointerException in CustomTabNavigationDelegate#shouldDisableExternalIntentRequestsForUrl() BUG=1075543 Change-Id: Ifc6040880535cd3ba58a9495e1805ba00b07447c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169478 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772536}
-
David Tseng authored
Currently, ChromeVox only allows live regions on focused web content. within a WebView. Specifically, the hosting views::WebView needs to be focused. This change adds support for live regions to the virtual keyboard, which is hosted within an aura::Window. R=jopalmer@chromium.org AX-Relnotes: n/a Change-Id: Icfef3ee2c356ddf4ee59649b8edcde9b390795b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208821 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#772535}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/369a09ac8618..d3a01e5713dc 2020-05-28 bsheedy@chromium.org [Telemetry] LocalFirstBinaryManager improvements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054583 Tbr: rmhasan@google.com Change-Id: I4c0b9b545ae0d4101d05f56e424358bbe85f50df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218658Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772534}
-
Eric Lawrence authored
The origin policy interstitial strings contained minor typos and grammar mistakes. This CL fixes them. Change-Id: I883189b2b32214787e29a13ba3323b15296f0145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213456Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772533}
-
Jiewei Qian authored
This CL extends the expiry time of the following to the end of 2020. - Webapp.InstallResult.System.Apps.* - Webapp.InstallResult.System.Profiles.* - Webapp.InstallResultExtensionDisabledReason.* - Webapp.InstallResultExtensionError - Webapp.InstallDuration.System Fixed: 1084058,1084059 Change-Id: I3aadbb7f9b3dfa6cdb117e04a9817343959935c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208573 Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#772532}
-
Alan Cutter authored
This CL adds a null check for the return value of CreateWebApp(). It's valid for this function to return nullptr in the event of DB corruption so we must check for it. Bug: 1086775 Change-Id: Idd491a136537540f8a65cd466d65772fbdc66300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217990 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#772531}
-
Kazuki Takise authored
HandleBoundsEvents can be called multiple times during a commit process in exo, and we want to save PIP snap fraction once everything gets stable after PIP transition. Note Chrome PIP remembers its position by itself, so it's safe to move the code to exo. BUG=b:156888408 TEST=atest android.server.am.ActivityManagerPinnedStackTests #testEnterPictureInPictureSavePosition Change-Id: I655af04dfc9b4880411b6bb110fbb5781fe28c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215655Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#772530}
-
Brian Sheedy authored
Runs the tests from Intel Dawn Windows builders specifically on Windows 10 1803, as one of them is flakily crashing on 1709, and there's enough 1803 capacity to run all the tests on the specific version. Bug: 1087153, 1087131 Change-Id: I2a3504657def758e282a98d60666b92b7c435bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219040 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772529}
-
David Bertoni authored
flaky on Win10 as well as Win7. Bug: 1083585 Change-Id: I19a98281082642f31e75f8dd07403c385af7eb56 Tbr: danakj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219096Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772528}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aefd51fe93a8..0a40740375ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dbertoni@google.com,tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:834134,chromium:912681 Tbr: dbertoni@google.com,tasak@google.com Change-Id: I356a7e0f9be27da5a8e244943beed8ed0f6b5e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218653Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772527}
-
Joey Scarr authored
This reverts commit ac81b31b. Reason for revert: This change is incomplete; I think I was supposed to update some .pyl files too. Original change's description: > Move linux-blink-cors-rel from fyi to chromium.linux. > > This is to enable the bot to be sheriffed. > > Bug: 1086320 > Change-Id: I0e379f7b168ce3d13874a399d953c251bede8a9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215763 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Joey Scarr <jsca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772501} TBR=agable@chromium.org,toyoshim@chromium.org,estaab@chromium.org,tikuta@chromium.org,jsca@chromium.org Change-Id: I55fed8e6b31ceccc1df40f2b9c0cf1f40285a803 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217518Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#772526}
-
John Smith authored
Bug: 1082918 Change-Id: Ie7c961df60853485fe6eff149ab21bb18920b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213204 Commit-Queue: Joan Barnett <johnsm@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772525}
-
Austin Eng authored
This tests SharedImage interop on Dawn's CQ and CI bots. It prevents changes in Dawn from breaking SharedImages in Chromium. CI bots: Dawn Linux x64 Release (Intel + NVIDIA) Dawn Mac x64 Release (Intel + AMD) Dawn Win10 x64/x86 Release (Intel + NVIDIA) Trybots: linux-dawn-rel mac-dawn-rel win-dawn-rel dawn-try-win10-x86-rel Bug: dawn:396 Change-Id: If3b649208450a60884ae970ae8c5f00761f5d565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219239Reviewed-by:
-
Rachel Carpenter authored
The language that is currently used in loadtimedata has had the region code stripped out. This means that we can't tell the difference between en-GB and en-US, or zh-CN and zh-TW. That means they fall back to english for our app. Using application locale solves this. Bug: b/157427039 Change-Id: Id83d420752aa9da0808652693194ecf6bc9b5702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215158Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772523}
-
Frank Liberato authored
GLImageDXGI should always have a d3d11 texture. This CL sets the texture unconditionally, even if an error occurs. Since error notification is asynchronous, the frame might still be drawn. Bug: 1077645 Change-Id: I72c9aab078fcc8facb72870f5b9be30dc7cfa01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217857Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#772522}
-
Hugo Benichi authored
Now that ArcNetHostImpl overrides chromeos::networkStatehandlerObserver NetworkPropertiesUpdated and fetches shill properties asynchronously, it is not necessary anymore to force NetworkState updates via chromeos::NetworkStateHandler to obtain properties that may be missing like IP configuration data. This patch removes this logic and partially reverts Change-Id I24d26d6492f133e0c38949c8c3b4403687bfac21 and Change-Id I2a39ba9c8d14cf42b6b0dbdd10c885bf5be09cfa. BUG=b:145960788 BUG=b:143258259 TEST=Flashed chrome, tested various connectivity setup with multiple networks, including L2TP connections and Chrome 3p VPN connections. Change-Id: I030a706740986d30830454a3308ea13a05790ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217276 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#772521}
-
David Munro authored
Records the type (e.g. sparse qcow2) of the user's disk. Emitted every time CrostiniRestarter is called, max once per 12 hours, since we care about user counts per histogram bucket, not restarter counts. Some disk types are vulnerable to disk corruption in certain scenarios so this metric tracks our progress in moving people off them and informs the priority of more pushy ways to migrate users. Bug: chromium:1072916 Test: Manual. Launch Crostini a couple times and check for 1x metric. Change-Id: I318449211e37d05bd043c5942c678ad694aa37ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214808 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#772520}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4348097fd4be..22534f2098e7 2020-05-27 michaelludwig@google.com Expose sk_FragCoord for runtime effects 2020-05-27 michaelludwig@google.com Store float value for settings in SkSL v2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Id446cbd631e81a7a54c18425226a6453d17d394c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218900Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590609462-f9ab96859e162a96cc1f1ba3f4ac827a4c53be85.profdata to chrome-win32-master-1590623692-fd13f36c8de9694ea1ca21c5ca06784931c585b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I513ec69ff80053a9fa8d2d067f55200dca3a53c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218660Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590594916-ea624ec669480df16e05aa1202066a2c230a60a5.profdata to chrome-win64-master-1590623692-442abbb1e080c04fab88844b2b8eca58e501203d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If904a3105e47d902c70cbf3c04c76c163a54350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218659Reviewed-by:
-
chrome://flagsTakashi Toyoshima authored
Now that the in-process configuration is not supported on desktops, and default on Android, we do not provide a flag at chrome://flags. The configuration can be modified through the base::Feature to run tests for Android on Linux, but it isn't supported configuration as well. Bug: 1087170 Change-Id: I5b0d41a8dec783524895d57dfee56ab80c24711d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215154 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This method will be exposed as a mojo method as a part of service worker storage migration to the storage service. Mojom doesn't support set so we need to use different container type. Use vector instead of set. Bug: 1055677 Change-Id: Ie16b729d078b549b177d7650b0da988a2cb97cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214875 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#772515}
-
Sreeja Kamishetty authored
!RenderFrameHostImpl::is_active() is used to check if the RenderFrameHost is either in the BackForwardCache or in pending deletion state. For cases when RenderFrameHost IPC handler or navigation related events starts with: if (!is_active()) return; This is problematic because ignoring the IPCs when the page is in the BackForwardCache might break the page. To avoid this, we evict the document from cache along with ignoring such calls to prevent discrepancies between the renderer and browser process once the page is restored from cache. This CL adds IsInactiveAndDisallowReactivation() method which returns true when RFH is either in pending deletion or in BackForwardCache and evicts the document from cache if it is called from BackForwardCache. This is part of effort to remove all |is_active()| occurrences and replace with the most appropriate method so that we don’t break pages and avoid unexpected behavior when a page is in BackForwardCache. For more information on inactive frame and back-forward cache please refer to: https://docs.google.com/document/d/1Q8vbcj0kQRukab_seqTJXVYDgpqLzWMOW_XnM6XitGk/edit?usp=sharing Detailed list of investigations for each is_active usage is presented in this spreadsheet: https://docs.google.com/spreadsheets/d/1TTzZ5r0m7nHBS_TkrEAdcFGs0M2iXO_tS0-lJmbQ3EY/edit?usp=sharing BUG=1073449 Change-Id: I82be7e38b3162e9bcd216c4376cf69b92101826e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183194Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#772514}
-
Ben Pastene authored
This reverts commit 3a8d37c3. Reason for revert: blocking uprevs; crbug.com/1087179 Original change's description: > chromeos: Add only the current SDK version's items to a test's data. > > Instead of adding every version of a given item, this will add only the > current version's. This is a bit tricky since individual versions of an > item are keyed by symlink. And since isolate doesn't follow symlinks, > we have to follow them ourselves. > > Bug: 1027382 > Change-Id: I6b3ea4ec15de3804e99fd6af768daac64f490d5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931155 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771959} TBR=thakis@chromium.org,dpranke@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027382, 1087179 Change-Id: Ie097ba50d36d7eba3865d5cee1775afd5d605354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219315Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#772513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/64cadfcf..47bf5f46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iba86646d79f94ac9acf8a388c379ca3b10d8a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217874Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590609462-0a980a885be44e446b55c280ee660f43e0ab11a0.profdata to chrome-mac-master-1590623692-0f578bc687b2561083fd54c973f9fd861443060a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3872e1740efd3b54198c5730aadb065d95c7b5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218657Reviewed-by:
-
