- 19 Oct, 2020 40 commits
-
-
Peter Wen authored
- CustomViewStyleable - DefaultLocale - DrawAllocation - EllipsizeMaxLines - ExportedContentProvider - ExportedService - HandlerLeak - IconColors - IconLauncherFormat - IconLauncherShape - Instantiatable - InconsistentLayout - InflateParams (Permanently skipped) - InlinedApi (Permanently skipped) - JobSchedulerService Bug: 1116130,1081240 Fixed: 1081240 Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429808 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818559}
-
bttk authored
Bug: 1133482 Change-Id: I30d0131ca1eba153d8f2b1ac725dccf4fe7072d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476625Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#818558}
-
Cattalyya Nuengsigkapian authored
- In non-logged-in screens, update accessibility insets of work area bound in shelf layout manager. - Add a shelf observer to system modal layout manager to update work area when a docked magnifier is enabled and disabled. - Add unit tests for checking that display work area and modal window bounds are updated correctly and consistently when enabling and disabling the docked magnifier. ## Testing - a video showing fixed and make sure that there's no ghost shelf issue https://drive.google.com/drive/folders/1VO032gh3Ha3csIzpyRZzsEI7_7fiAqlG?usp=sharing 1. make sure unmodified code fails a new unit test DockedMagnifierTest.WindowBoundsChangeInNonActiveState before bug fixing. https://screenshot.googleplex.com/S2pzpBHxawVvRr5.png 2. make sure to check update in work area to catch the bug that work area doesn't expand back when disabling a docked magnifier. (CL2465874 that fails manual test should fails unittests) - https://screenshot.googleplex.com/84nhosyUMEFmM5F.png - https://screenshot.googleplex.com/6xpA99WvQPvGt7b.png 3. make sure the modal window bound doesn't overflow. - https://screenshot.googleplex.com/9ExRpjFesGqBuga.png 4. make sure the modal window is centered correctly in the secondary screen. (avoid using inconsistent coordinate system in GetUsableArea). - https://screenshot.googleplex.com/8Hzdy6UfECjE6gU.png Bug: 1057062 Change-Id: Icdb554dbdea21a7191a64bfd31cf519205980fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429743 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818557}
-
Chris Sharp authored
This policy doesn't have to be platform_only=True Bug: 1140118 Change-Id: I5c4f3432137c9e65e3c8173bbb24ce953577f7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485753Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#818556}
-
Alex Turner authored
Whenever an execution context (whether a window or worker) becomes a client of a service worker, the renderer will now inform the respective ServiceWorkerContainerHost of the client's ukm::SourceId once it is execution ready. This id will be passed to SWIdentifiabilityMetrics, a new SWContextCoreObserver. This observer will them emit a UKM event (Worker.ClientConnected) in order to associate the ServiceWorker's ukm::SourceId with the client's. DedicatedWorkers' ukm::SourceIds are not included as they exactly match that of their parent execution context. This association is required both for attributing entropy consumption of workers to sites, but will also help to gain insight into the cross- connectivity between first-party contexts via shared and service workers. Design doc (internal-only): https://docs.google.com/document/d/1mx4-zI53cskB8j75Mis2q3rVrO8uHeJpwGuT8psbURA/edit?usp=sharing Bug: 1085645, 1134193 Change-Id: I7d1728ebe15d162b980dd2e552622e4c4f91edc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321059 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#818555}
-
Dale Curtis authored
The way the kConfigChange state was used is not safe and ultimately useless. It was set atomically on the main thread, but operations on the decoder thread would query multiple times within a single function call and were not expecting kConfigChange. It's ultimately useless since we just end up stopping the decoder thread regardless. Except for cases of destruction or error, it's incorrect to invalidate the WeakPtr posted tasks too. These manage picture buffer allocation and client notifications that should never be dropped. This also applies a temporary fix for a DCHECK() crash and removes some stale debugging code. Bug: 1111273, 1139489 Change-Id: I42a9c76f7ea272c57b8c7aa3e78bd379c3120c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481945 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#818554}
-
harrisonsean authored
This removes the tap animation for safety check rows that are not currently tapable. Bug: 1078782 Change-Id: I5cd6bd50480a613c0de02eb9c06b6631746181bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479525 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#818553}
-
Fredrik Söderqvist authored
No longer flaky. Tbr: schenney@chromium.org Fixed: 1137716, 1138589 Change-Id: Ib8e0cf43abc1ae3df570c70f386f6b6fd3c1cf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484595 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818552}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af704183574c..d40c764ba81e 2020-10-19 nisse@webrtc.org Delete leftover mention of AsyncInvoker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia6c9897b7c2786106f078f993d902b09a345ad6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818551}
-
Ian Struiksma authored
On some test bots, mac dock or external values cause the browser to make minor resizings of the frame. These are extraneous to our tests so we would like to ignore those during tests. This CL provides a test hook by adding test access methods to ChromeAutofillClient to make the autofill popup more resistant to hiding from frame resizes, and then has AutofillUiTest access that hook when running Interactive UI tests. This re-enables autofill interactive tests on mac bots. Bug: 967588 Change-Id: Id9e25988f0cf64f0aa0631a48d48eb982b116c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473802 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#818550}
-
Devlin Cronin authored
Forgot the MAYBE_ prefix in test itself (yay, Mondays!) TBR=jdeblasio@chromium.org NOTRY=True Bug: 1139955 Change-Id: Ic94974f53c57faede67731b41126dd91ec4b2999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485496Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818549}
-
Leonid Baraz authored
Bug: b:169248924 Change-Id: I8ca3f363d7b616d06707b6dd3639ddc29a334351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481004Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818548}
-
Matthew Mourgos authored
This change has the clipboard nudge observe the hotseat state and will animate the bounds of the clipboard nudge so that the nudge is always placed above the hotseat. Also, because the ClipboardNudge uses RootWindows the clipboard_history_controller_ must be reset in before the window_tree_host_manager_ is shutdown. This fixes the original CL which was reverted due to msan issues. Bug: 1137019 Change-Id: Ibbe8f06132f51d569a5ea4993df77ef042eabeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477524 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Carlos IL authored
The histogram logs anytime an app calls WebSettings.setMixedContentMode Bug: 1139424 Change-Id: I88533e1a81bd9228e599201304f89346e5d5a8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482029 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#818546}
-
Ilya Sherman authored
R=gab Bug: none Change-Id: I60b4f00c3ebe5b61c14f25fe4ef4bf38bfed07fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477475Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#818545}
-
Akihiro Ota authored
Bug: N/A Change-Id: Ibc913eaefe212b621b7ffdd83e05bdd75f62920b AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480733Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#818544}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/89042538376b..7156d3e3140b 2020-10-19 dsinclair@chromium.org [wgsl-reader] Add parsing of named structs. 2020-10-19 dsinclair@chromium.org Roll Tint dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I00a603b6f01a65c5bc522d8bec8b0d9c82b718b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485591Reviewed-by:
-
Austin Eng authored
Dawn is not supported on Win7. The tests were inadvertently enabled in https://chromium-review.googlesource.com/c/chromium/src/+/2480584 which changed test set up. Now, the TestGPUServiceHolder is not created at all on unsupported platforms. Use it as a signal to skip the test. Tbr: cwallez@chromium.org Bug: 1139941 Change-Id: I68b4fcf733ca83978b544f7d065866760fc056db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485674Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#818542}
-
Wei Li authored
This CL renames set_callback() member functions in a few classes including Button, Link, Combobox, EditableCombobox, to SetCallback(). This prepares to make callbacks in these classes into properties, so they could be used for builder too. Bug: 938501 Change-Id: I46c3058dc324d2b4235120d493566d7c1fb2c9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476974 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818541}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4277.0-1602498827-benchmark-88.0.4294.0-r1 to 88-4280.20-1603100572-benchmark-88.0.4296.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I67eee7b21d8f9d10b00bbfd458831c297ec7d1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485115Reviewed-by:
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I187c8c14ad14a5f36b939556d41940e0acbd3374 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481349Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818539}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb82eeb03d64..ec6bccd90081 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lanwei@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139314 Tbr: lanwei@google.com Change-Id: Ied676f0cd838ed99c05c082ed8610061364c3c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485613Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818538}
-
David Jacobo authored
This CL gets rid of the unused flag kAppRuntimePerormanceStatistics, this feature has been enabled by default for a while, there is no way to toggle this flag via chrome://flags anymore so it should be safe to remove. Bug: None Test: Build. Change-Id: I79e90d2eb45559e4910b25282819d562ad074cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466867Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#818537}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7bce5fed..375e574d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib21b9b7fabd8a739bdb3484bd302651f7d821ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818536}
-
Sigurdur Asgeirsson authored
R=asvitkine@chromium.org, chromium-metrics-reviews@google.com Bug: 1089602 Change-Id: I76015e47077e8ee14fdd8a915009cf21c10d08b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485294 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#818535}
-
Yue Zhang authored
To build the TabGridDialog show/hide animation, we create an animation card view that looks very similar to a GridTabSwitcher card view. However, when trying to clone the layout of the GridTabSwitcher card view, we missed out the padding setup for the favicon which leads to some visual misbehavior for the animation. This CL fixes this issue by making the padding of the favicon in animation card view same as that of GridTabSwitcher card view (https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java;l=142;drc=6fd9af2e6b5ed2f65a762090823ddf8c09e95ae4;bpv=1;bpt=0) Bug: 1136328 Change-Id: Ibf2ce5d8dbd3bc4dfa9505812b9795dae5fde602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460249 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818534}
-
Elly Fong-Jones authored
This test has is flaky when run on devices that have a real wifi or cellular connection, because in that situation, the call to SimulateNetworkChange() can cause an arbitrary number of real calls to GetCurrentSignalStrengthWithThrottling(). This change de-flakes the test in that situation by: 1) Delaying constructing the HistogramTester, to avoid counting those calls, and 2) Advancing the fake time the test uses at the start of the test, so that the NetworkQualityEstimator under test is never in its timeout period when the test starts This change does not re-enable the test on Android yet, since it seems to be still flaky there for unclear reasons. Bug: 1133439,1130720 Change-Id: I152f43f9c66ccef29060c48201fb7b4e8868fafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476812Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#817719} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485194 Cr-Commit-Position: refs/heads/master@{#818533}
-
Shengfa Lin authored
For some RTL page with 0 document.documentElement.scrollLeft and non 0 document.body.scrollLeft, we should not take the document.body.scrollLeft to calculate DevTools page.capturescreenshot depending on doctype. Instead, we can use window.pageXOffset and pageYOffset that should work with any doctype. Bug: chromedriver:3625 Change-Id: I38a06b854d26d6039c89b74d89509ef39a9bc18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482048Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#818532}
-
Peng Huang authored
Bug: 1135727 Change-Id: I92ec9961066d4d27f12f4a5d9cd92e27d7e00e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485633 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#818531}
-
Xing Liu authored
The top level reading list folder is not editable/movable. The reading list articles is editable since we need to support move and delete for them. Test is adjusted to ensure no overflow menu is shown for the reading list folder. Also this CL is needed for a following CL to adjust positioning logic. Bug: 1139070 Change-Id: Ia09626c4568fe1e90612256da53176a90fc19c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481959 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
Please refer to https://carbon.googleplex.com/cros-ux/pages/screen-capture/motion#647b61a3-343c-448d-8c9b-f289d357c615 for the spec (search for "Screen record countdown"). Not covered in this CL: - stop-recording shelf item animation Bug: 1126669 Change-Id: I747f7df5f51677ef263921f5f00aa56f540b023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463646Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#818529}
-
Dave Tapuska authored
The RenderWidgetFullscreenPepper was removed but the IPC was left around. BUG=1134674 Change-Id: I19a7a16049ac50b852647abb0930b35e07472a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485534Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#818528}
-
Adam Langley authored
Previously only the nonce from the BLE advert was fed into the HKDF to generate the handshake pre-shared key. With this change, the full plaintext of the advert is included. This might be useful if, say, the routing ID or other fields added to the advert in the future, have entropy. Since this is now used in the PSK, the explicit authentication of the EID can be dropped. BUG=1002262 Change-Id: I1bbaa7545de9787ccb8642a5ca1b24db20718d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466675 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#818527}
-
Roberto Moura authored
Bug: 1137983 Change-Id: Id17b3fce32c49dc540bf6699de8dcb19753d93ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475879Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#818526}
-
mark a. foltz authored
When the native Cast MRP was disabled, the FixProviderId() hack was mapping all Chromecast media sources to ProviderId::EXTENSION, which is not expected by RecordPresentationRequestUrlBySink. This patch records the histogram before invoking FixProviderId(). It also restores the unittest for RecordPresentationRequestUrlBySink, which was deleted in http://crrev.com/c/2405519 Bug: 1112866 Change-Id: Iff2ea815c18458d6dcccb00974524c0ad382d461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468788 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#818525}
-
Devlin Cronin authored
Now lint_test_expectations.py is happy. NOTRY=True TBR=lanwei@chromium.org Bug: None Change-Id: I8a943dcabf9cc4b69d940595fad1caa32e3e154d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485437Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ica1f1c09a42b193577bcf1796ea660cf5eeb1c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485171Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#818523}
-
ziyangch authored
Tthe item is removed in eureka-internal/466958 Bug: Internal b/169779668 Test: Locally build. Change-Id: I5e3dfd5f5a4c00cbf0f856d431d22dd4263b9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469141Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#818522}
-
Owen Min authored
Add a new enum field PartialReportType for ChromeDesktopReportRequest and ChromeOsUserReportRequest. It's used to indicate that the report doesn't contain all information but only extension request. It's the same change as cl 337368623. Bug: 1137964 Change-Id: I15a0055437049df073476a9dd89198c503704e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481243Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818521}
-
Christian Biesinger authored
Now that the spec seems to have stabilized, remove .tentative from the testcase names. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: I99f916c87ea51c617e86c079301163ae30327083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485571 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818520}
-
