- 09 Oct, 2019 40 commits
-
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/facebook/fishhook.git/+log/80fe593736ac..66315a9c251e $ git log 80fe59373..66315a9c2 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 swolchok Properly restore protections for iOS 13 2019-08-20 swolchok If hooking in __DATA_CONST, make writable before trying to write Created with: roll-dep src/ios/third_party/fishhook/src Bug: 1012326 Change-Id: I0454bebf46da11c9c52acb24211ed4a847b5e0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848915Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#704390}
-
danakj authored
InitializeLayerTreeView has a weird connection with ScreenInfo which causes us to require it to exist before doing SynchronizeVisualProperties. We're going to pull it apart. Here we pull the input stuff out to get out out of the way. Use the WebMainThreadScheduler from CompositorDependencies instead of going through a nullable RenderThreadImpl pointer in tests. Then make the fake on in unit tests return a task runner for the input handler, which can be the current (main) thread since these tests don't run a compositor thread. Drop all the null checks around the input queue. R=avi@chromium.org Bug: 419087 Change-Id: I117b28eb157ab7b5dc61cef6b80f7f32243404e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850416Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704389}
-
Yuwei Huang authored
This CL allows Android users to silence a notification. Screenshots: https://screenshot.googleplex.com/b0syTP6Yb1q https://screenshot.googleplex.com/GGYARoxf5kq Bug: 1001291 Change-Id: Iaa1776bdd09dd7c4a28ae3743d041f3ec6c1d77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850536Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#704388}
-
Lukasz Anforowicz authored
Since r694827, the request_initiator is set to the website, not to the isolated world's origin (i.e. https://translate.googleapis.com). This means that the request_initiator should be compatible with request_initiator_site_lock and AppCache security checks - there is no longer a need to process Translate requests through a separate URLLoaderFactory (with adjusted request_initiator_site_lock + bypassing AppCache). Bug: 940712 Change-Id: I010cf04eb6df70cb1cd13289661aa0712b9dcffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835021Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704387}
-
George Zhang authored
Previously, there existed no datasouce that would enable the java heap profiler to be called. Thus, to enable that feature, we add a new datasource here and implement the default methods. With this, we can add our heap dump profiler logic to this datasource's start tracing method. Change-Id: I6aa98629f64d876fca3578514a46c4f126868015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838071Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: George Zhang <zhanggeorge@google.com> Cr-Commit-Position: refs/heads/master@{#704386}
-
Sam Fortiner authored
GraphicsLayer's position (which is a CC Layer position query at the implementation level) will no longer be consistently updated in the near future (see https://crbug.com/752756). Removing the call and replacing it with an equivalent is needed to avoid dumping stale information. Even with that change, the layer position being dumped for touch hit rect tests is actually the position relative to the nearest transform node and isn't directly meaningful for these tests. To reduce cognative load we are only dumping size now - primarily to assist with layer identification. Bug: 999336 Change-Id: I5004e67bdbaf2f514cc49d7483b2596c4c0e4e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842712Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704385}
-
khmel@chromium.org authored
This rolls new set of UMA that replaces derpecated PlayStoreShown UMA DD: https://docs.google.com/document/d/1vfJMzoYsXtH-HWYydbb5VJvpT6WeJrfvaO81RHI5v2M/edit BUG=b:142251935 TEST=Locally + unit tests. Change-Id: Ie2ec139b41e702dda604d92324b426782ed494ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845935 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704384}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d5c8d31972d..2fa9d73469ff git log 2d5c8d31972d..2fa9d73469ff --date=short --no-merges --format='%ad %ae %s' 2019-10-09 geofflang@chromium.org Partially Revert "Convert DXT1 RGB data to DXT3 RGBA when uploading to the GPU." Created with: gclient setdep -r src/third_party/angle@2fa9d73469ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ib464ea67da1cb3f4cf0de5fbfac36f90de1976e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704383}
-
Alexander Timin authored
R=clamy@chromium.org,ahemery@chromium.org BUG=1011770 Change-Id: Ic4935b2f74d2fffe9ea6df0db0f796e6d4fe6f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836091 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#704382}
-
Akihiro Ota authored
This change adds logic to ChromeVox to check the login state before populating the tabs menu in the panel; if we are not logged in, then we do not populate the menu. This logic was added due to privacy + security concerns where it was possible to use ChromeVox to access a user's open tabs without being logged in. More details can be found in the associated bug. Bug: 981100 Change-Id: I75afa213e8bf135540af5bbcdb408fcddb526a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832667Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#704381}
-
Manas Verma authored
Adding a check for whether or not the authenticator is bound before attempting to connect to it. Otherwise this may cause crashes if IsUserVerifiable() is called multiple times. Bug: 949269 Change-Id: Ic67218581d8a72b96cbdf1cf24427651d598e13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849128Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#704380}
-
Charlene Yan authored
Bug: 915956 Change-Id: I46d68323a447a972006f165d20d84c73d9ed31e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846097 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#704379}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If831b98d6995b9c7e7fded33c308c4945caa9f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850203Reviewed-by:
-
Eric Roman authored
This is slightly different in that it will also recognize ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN which the previous code did not. Change-Id: I5227f8a3dd42de1b9fab4b77a2db157588a4338e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848397Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704377}
-
Ken Rockot authored
This gets rid of fake implementations of the LevelDBDatabase mojom interface and refactors all dependent tests to use a real in-memory LevelDBDatabaseImpl instead. Local/SessionStorageContextMojo are updated to use a LevelDBDatabaseImpl directly, and other DOM storage classes can by updated similarly in follow-up CLs. This is a step in incrementally deleting the LevelDBDatabase mojom interface and migrating DOM storage implementation to consume a DomStorageDatabase directly. Bug: 1000959 Change-Id: Ieaa8e46a6ebc0f41dc85b3c60423552c88cb0c6a Tbr: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837145 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704376}
-
Matt Menke authored
It was only being set by the AccountAvatarFetcher and the AssistantImageDownloader, and only read by the ExtensionThrottleEntry (which may well not even be on the path for the two classes that set the flag). As such, it's not serving any significant purpose, so can now be removed. Bug: 516495 Change-Id: Ib1b52ab6100a5810836a413e4b05f7a3d06ae7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827489Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#704375}
-
Evan Stade authored
For normal profiles, it isn't sent until browser shutdown, at which point there's no need to check if all user scripts are ready. For OTR profiles, it can be sent when the last incognito window is closed, but |profile_data_| doesn't hold OTR profiles. Bug: 268984 Change-Id: I041fd6242457cf4b94633fe28aacc7c945cfad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833908Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2579de4567d5..7951a0da32d5 git log 2579de4567d5..7951a0da32d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 herb@google.com Introduce SkGlyphPositionRoundingSpec. 2019-10-09 robertphillips@google.com Centralize error checking w/in the GrProgramInfo class 2019-10-09 egdaniel@google.com Add new public api on GrContext for computing image size. 2019-10-09 mtklein@google.com add -f mp4 to skottie_tool 2019-10-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7951a0da32d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I4df876e014a39342732c457ac022bdbbeda58606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850362Reviewed-by:
-
Alex Cooper authored
Since supportsSession is removed from the spec, convert external webxr wpt's that rely on that method to internal tests while that method is deprecated but but still implemented. Update browser tests and sample pages to use the non-deprecated method as well. Bug: 1009052 Change-Id: I30249e38828726b31668b609a491792ef17c22ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850361 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#704372}
-
Rohit Rao authored
The testrunner scripts were using underscores when they should have been using hyphens. BUG=934252 Change-Id: Ie3362193c423a76873328a779f48aaef108c3543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849979Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704371}
-
Nektarios Paisios authored
When information about a table was computed in AXTableInfo, we were not taking account of layout table rows. Also, went through the whole file and ensured that layout tables are always accounted for. Some screen readers, such as on Windows and ChromeVox, treat layout and data tables the same. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1003972 Change-Id: If0bc7241780ccb98fa1649adfe9dd1c3a4b41a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847801 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#704370}
-
Peter Kasting authored
These are just duplicated code at this point. Bug: none Change-Id: If99cae449d438299651d3c81504d7418a170fc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848871 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704369}
-
Lukasz Anforowicz authored
Why it is okay to remove this method ==================================== The ChromeContentBrowserClientExtensionsPart::OverrideNavigationParams method ensured that the referrer used in navigations never points at an extension-specific URL. This method is not needed - even without this method, the referrer is never set to an extension-specific - this is because of the following places in the code (*all* 4 places need to be tweaked to start using extension-specific URL in the newly added browser test): 1. //content: blink::mojom::ReferrerPtr Referrer::SanitizeForRequest: if (!request.SchemeIsHTTPOrHTTPS() || !sanitized_referrer->url.SchemeIsValidForReferrer()) { sanitized_referrer->url = GURL(); return sanitized_referrer; } 2. //third_party/blink: 2a. String KURL::StrippedForUseAsReferrer() if (!ProtocolIsInHTTPFamily()) return String(); 2b. URLSchemesRegistry allowed_in_referrer_schemes({"http", "https"}) 4. //url: GURL GURL::GetAsReferrer() if (!SchemeIsValidForReferrer()) return GURL(); Why new test is desirable ========================= This CL adds a new end-to-end test: ExtensionBrowserTest.NoExtensionsInRefererHeader. This test is desirable, because after tweaking all 4 places above, all other tests continued to pass, except for a ReferrerSanitizerTest.OnlyHTTPFamilyReferrer unit test. Why removing the method is desirable ==================================== If we can remove ContentBrowserClient::OverrideNavigationParams (overrides deal with extensions and NTP), then we may be able to proceed with removal of ContentRendererClient::ShouldFork. Removing the extension-specific part of OverrideNavigationParams helps toward these goals. Bug: 1003957 Change-Id: I31399d62cf86d1caeb935b0218faf18a7f590248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834890Reviewed-by: -
Tsuyoshi Horo authored
Chrome loads unsigned bundled exchanges local files using "files://" origin. So scripts in the file can't read/write the storages of arbitrary origins. There is no larger risk compared to normal HTML local file. So we don't need to show the bad flags prompt. Bug: 995177 Change-Id: I4738c361914cd661fce32066807ba8488a7efbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847601Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#704367}
-
danakj authored
All callers that were getting there through RenderView should instead go through RenderFrame or RenderWidget to get to the methods. R=avi@chromium.org TBR=estade, rdevlin.cronin Bug: 419087 Change-Id: I2b3c2198fcbfea65c7773b1a0ca8e2e15dcfd333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850109Reviewed-by:
-
Sorin Jianu authored
The kernel release might include the '+' character, such as: 4.19.37-5+deb10u2rodete2-amd64 R=ganesh BUG=1012751 Change-Id: If38c3b0358d518456fa5fe0ae133a7c08f0d953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850631Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704365}
-
Christopher Thompson authored
We're updating the certificate for revoked.badssl.com (the previous certificate expired on 2019/09/11) in https://github.com/chromium/badssl.com/pull/410, and we should likewise update the certificate/SPKI in the blocklist. We are also updating the manually added list in CRLSet. Change-Id: I95c50250cc0139cf82dac214c785efa2704ea599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846018Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#704364}
-
Bettina authored
Password protection is expanding to also cover saved passwords so we need metrics to track it. Bug: 1010764 Change-Id: Ib10a62a7bff930152953f93169e5b544e8c9d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847949 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#704363}
-
Anubha Mathur authored
This PR enables navigation to the source of the computed styles using keyboard. 1. Adds a context menu item to navigate to the style in styles pane 2. Adds a context menu item to navigate to the style source in the sources panel Gif: https://imgur.com/a/E2KGmrv Bug: 963183 Change-Id: Iea561af075fcb89b0cd5ebe7a63fb8afbdb2aa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825790Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704362}
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change behavior. It's not encouraged to call Modulator::GetScriptState() outside of Modulator, so this CL removes callsites from the (Service)WorkerModuleTreeClient. Bug: n/a Change-Id: Id15b91e0bbe04cb1dc543e013133549021562231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847600Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#704361}
-
Toby Huang authored
If logged in with a child account, the chrome://extensions page shows developer mode is disabled with an office building icon (used for enterprise users) and the tooltip "This setting is enforced by your administrator." The icon and tooltip should be Unicorn-specific. This CL changes the icon to show the kite icon and tooltip "This setting can't be changed by a child user." Bug: 928543 Change-Id: Ic518d78c1304a957ba0cd007372232cbbb31a15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842494 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704360}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c5de38d..ebc6287a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia8f3cd23ffd91e120b63876497a445d2430e857a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850254Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704359}
-
Chris Blume authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/38c693569427..9d3bf3e96801 $ git log 38c693569..9d3bf3e96 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 efoo Add "# COMPONENT" to libjpeg OWNERS file Created with: roll-dep src/third_party/libjpeg_turbo TBR=efoo@chromium.org Change-Id: I5d951466384680a28346ea922f950690a9089a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846817 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#704358}
-
Adrienne Walker authored
This is just cleanup in preparation for larger data handle changes. There's no need for ShareableFileReference to subclass BlobDataItem::DataHandle as it doesn't implement any of its interfaces. Its goal is to preserve the lifetime of the ScopedFile, and it's clearer to do this by holding onto the ShareableFileReference in BlobDataItem directly. Bug: 1012869 Change-Id: Ieaad64adede4358d734aff8e3cc21bd9038566cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850198 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Adds @provideGoog to compile_preamble.js to tell the compiler that the file provides the goog namespace. Without this, compile_preamble.js is compiled after bindings_lite.js and causes runtime errors when "goog" methods get called by bindings_lite.js. This issue only comes up when compiling with SIMPLE_OPTIMIZATIONS. Compiling with ADVANCED_OPTIMIZATIONS worked correctly. Change-Id: Ia26bdc31e13002c60503813a41ba9613cd764a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847608Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#704356}
-
Gil Dekel authored
In order to decide whether an image will go through hardware decode acceleration, we currently obtain the encoded data, parse it, and extract relevant information to compare it against the supported profiles advertised by the GPU process through GPUInfo. This is unfortunate because getting the encoded data may require a copy if the data is not already contiguous in memory. Not only that, but the copy would need to be done even if the image will ultimately not go through hardware decode acceleration. This CL solves this issue by abstracting and plumbing the necessary information to make the decision up from the DeferredImageDecoder to PaintImage, and then passing it to the ImageDecodeAcceleratorProxy for final decision. Finally, we only make a contiguous copy of the encoded data if hardware accelerated decoding is supported. Bug: 995149, 995887 Change-Id: I99f85e1324126b038a576149b0666245639dc03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778988 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#704355}
-
Lily Chen authored
This is a reland of ffcd2de7 Problem that caused revert fixed by https://crrev.com/c/1849114 TBR=morlovich@chromium.org,mbarbella@chromium.org Original change's description: > Add GetAllCookiesWithAccessSemantics to CookieManager interface > > This CL adds a method, GetAllCookiesWithAccessSemantics, to the mojo > interface CookieManager. This just directly calls > CookieStore::GetAllCookiesWithAccessSemanticsAsync() on the > CookieManager's underlying CookieStore. > > Bug: 978172 > Change-Id: Ic26298caf12d34ffd4de5bcf81058f6984528683 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845803 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703916} Bug: 978172 Change-Id: Id1e92255ad6a15caba08c3e11bd47d27e549a274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850315Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704354}
-
Theresa Wellington authored
BUG=1000662 Change-Id: Ifadcbec9a42cc7055138a6db121622621bd67892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850413 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#704353}
-
Alex Newcomer authored
Send the ShelfAction to Shelf -> ShelfLayoutManager. Then hide the hotseat if an app is launched or swapped to. Bug: 1011901 Change-Id: I32dd58045f75d7cf915ee4523acd21b58a370077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847946 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704352}
-
Avi Drissman authored
The allowing of popups on close was brute-force merged to M78 with no flags. This change doesn't prohibit popups on close (that's still returning in M80), but makes it a feature in about:flags that can be flipped for testing. BUG=1012762 Change-Id: I5b99c162e6fee8eabc37c7887c6bece08b478521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848935 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#704351}
-
