- 10 Sep, 2019 10 commits
-
-
Eric Karl authored
Fixes WebView component build issues. Previous CLs introduced a number of new targets including texture_owner_android and shared_image_video. These were causing build problems due to duplicate file compilation which led to DCHECKs. Moved most of these files into gpu/command_buffer/service:gles2, as they all depended on this target (so no new transitive deps), and it's probably a good place for them for now and simplifies dependency management. Bug: 996285 Change-Id: Ic5a9cced7e67500cfd5fff8809d4ee5e17bbab8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787165Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695006}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/116ffe7e5be4..487f9a17e426 git log 116ffe7e5be4..487f9a17e426 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 mellem@webrtc.org Reland "Refactor SCTP data channels to use DataChannelTransportInterface." Created with: gclient setdep -r src/third_party/webrtc@487f9a17e426 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2122b812358516f3d3717b5f98573db13d0a6d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695005}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92f197b8a4e7..5aec10b3bcd4 Created with: gclient setdep -r src-internal@5aec10b3bcd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2b531d8cd6dbe83e655b0cef4e54ac790be81913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793711Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695004}
-
Gabriel Charette authored
Explicitly (to document for git log purposes), this removes: - base::test::ScopedTaskEnvironment - net::WithScopedTaskEnvironment - net::TestWithScopedTaskEnvironment - content::TestBrowserThreadBundle - web::TestWebThreadBundle Mass migrate stragglers which landed under old names after initial mass migration. TBR=dcheng@chromium.org (to bypass owners for mechanical changes outside //base) Bug: 992483 Change-Id: I16cab3611b7f1a0a869f9f3af22d5b2952f91da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791271 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695003}
-
Khushal authored
R=ericrk@chromium.org Bug: 1001307 Change-Id: If2c7d1bf4d152d0238860ef0daf0b99657afa0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788463 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695002}
-
Xing Liu authored
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1787277 due to flakiness on chromeos builders. This CL tries to reland the browser test that the test seems no longer failed on those trybots. Also can't reproduce the test failure on local machine with linux-chromeos build. TBR=dtrainor@chromium.org Bug: 1001003,963295 Change-Id: Ia1b553aa46f9256b9a94004d2426cf35bc9bf4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793821Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695001}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9c173c8347f8..8cae1e95a23b git log 9c173c8347f8..8cae1e95a23b --date=short --no-merges --format='%ad %ae %s' 2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-09 herb@google.com Cleanup SkPackedGlyphID Created with: gclient setdep -r src/third_party/skia@8cae1e95a23b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I5c49a319735e4bd96d9a1293492713b21995bccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695000}
-
Tsuyoshi Horo authored
Bug: 980828, 1002293 Change-Id: I5df93dfb6375066633c369952f7864889fd99e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775950 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#694999}
-
Zhenyao Mo authored
It only fails on Win/AMD, but we don't have a way to be GPU specific. BUG=1002269 TEST=bot R=kainino@chromium.org TBR=dalecurtis@chromium.org Change-Id: I5db03c1edc848fe465b614f9ff652afda2fc8920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793787 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#694998}
-
John Chen authored
This reverts commit 654f9cbd. Reason for revert: Large number of failures in Android perf tests Original change's description: > [tools/perf] Add stubs for aggregation and uploading methods > > This CL adds two methods to ResultsProcessor: for aggregating traces and > uploading artifacts. They do (almost) nothing so far, because the > corresponding work is done by Telemetry. Implementing full versions of the > methods will allow us to gradually transfer the responsibility for these > tasks from Telemetry to ResultsProcessor without major refactoring. > > Bug: 981349 > Change-Id: I5b2cb3f55dffe5f12e0e8ec0f3aaa1641e009f09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781152 > Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694725} TBR=perezju@chromium.org,khokhlov@google.com Change-Id: Ia4e87e5e23460d0e0b9c02c8b85a09af1e0c15ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981349, 1002272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793927Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694997}
-
- 09 Sep, 2019 30 commits
-
-
Kyle Horimoto authored
This text is shown as a sublabel in the Cellular row of the network selection element when the Cellular SIM card is locked. This UI is shown in OOBE when users select the network to use. Bug: 825762 Change-Id: I3c70cc4f8ae6916aefec1a233c760496ec0c9452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661295 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694996}
-
Maggie Chen authored
It's possible a GPU task is still running when it starts teardown, don't arm the watchdog in this case or a DCHECK will be triggered. During teardown, WillProcessTask should do nothing and DidProcessTask should call InProgress() instead of Disarm() to keep the watchdog armed. Bug:949839 Change-Id: I4fcfbcf71919ced5311d23718d27f29deb6a04b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793359 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#694995}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1d3ff52a37c7..b07dda63ef03 git log 1d3ff52a37c7..b07dda63ef03 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 thestig@chromium.org Remove some checks for CPDF_TextObject::GetFont() return values. 2019-09-09 thestig@chromium.org Tidy bug_1388.in. 2019-09-09 thestig@chromium.org Make a couple small improvements to CPDF_FormField. Created with: gclient setdep -r src/third_party/pdfium@b07dda63ef03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I751bd36313ecd2615ccd330c2988145d0f77836d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694994}
-
rbpotter authored
- Autogenerate Polymer 3 cr-tooltip-icon. This is used by the chrome://extensions page directly (rather than through a pref indicator). - Add to the demo page - Small update to demo page styling so that elements are spaced out a bit. Bug: 965770 Change-Id: Id22953537a3968ce471f1c40221a8ffc68fa9b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787169 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#694993}
-
Chris Lu authored
Separate function name and parameters from the rest of the Message payload. This change encrypts the function name and its parameters in a separate payload from the messageId and replyWithResult values. __gCrWeb.message.routeMessage() is then passed two dictionaries, each containing an encrypted payload and its initialization vector. Both payloads are decrypted and their properties verified in executeMessage_(). This will allow for the function name and parameters to be dropped when forwarding to a child frame, while still providing enough details for the child frame to respond to the native side that it received the message. Bug: 994968 Change-Id: I659d88b8119b2eba2b125d8c30cbea88485c88f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759204Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#694992}
-
Nicholas Hollingum authored
For more information on the crostini force-close UI, see crbug.com/964162. To provide a force-close UI to crostini windows which don't respond. We use a window property, set by the shell surface, and look for that property during crostini window registration. See crrev.com/c/1776140 for the changes that allow us to know when a shell surface is attempting to close. This CL shows how we will wire those up. The actual UI work will be done in a separate CL. Bug: 914322, 964162 Change-Id: Ieafd9bbaf8fe49e3411f4f76dabe52b63d7e784b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775884 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#694991}
-
Kurt Catti-Schmidt authored
There is another variation of crashes that land on AXPlatformNodeBase::UpdateComputedHypertext, however the actual bug is that the state set up prior to that was incorrect. One assumption that we've had throughout development of the exposing hidden nodes is that the web root area is always unignored, so that the root can always be an unignored parent that children can resolve to. With iframes, that is not always the case, so this change forces root web areas to always be unignored. Bug: 996525 Change-Id: I3eaf36e87bed76ce458c4d2d648eaf733bd39ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791800Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694990}
-
Manu Cornet authored
This also checks proper centering on all displays for a small number of apps. Bug: 1000745 Change-Id: I8c127e7bd149a8866ab044a654c705e97d39a6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790269Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#694989}
-
manuk authored
In preparation for launching in M78. This change has no behavior impact, as chrome does not condition any behavior off this feature; weather icons are controlled by the backend and conditioned off a gws_trigger_id. This change explicitly reflects intention. Bug: 856335 Change-Id: Ifd1627ba195bec2e3a8767389cd0527d819486e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782674 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#694988}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca8793223ace..e5641be5fe30 git log ca8793223ace..e5641be5fe30 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e5641be5fe30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I46a130f2b819566f775b0c3f9b2215baf6415848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694987}
-
Hesen Zhang authored
- Cleanup notifications if their icons fail to load. Bug: 963290 Change-Id: I9cfc3b4bf4ebb5526a7986f8dbf8906b2c3c9354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790473Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694986}
-
Andrew Luo authored
Bug: 765833 Change-Id: I91b69339b11225dd52750f6d71aca986f508b472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762704 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#694985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afc6ed3cdbc7..23d211c88c92 git log afc6ed3cdbc7..23d211c88c92 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 nicomazz@google.com Merge "Add stop recording to andriod adb controller" Created with: gclient setdep -r src/third_party/perfetto@23d211c88c92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6b051f41cfbda6b2ae8040220f4a9c0cfe553b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694984}
-
Xianzhu Wang authored
Bug: 994361 Change-Id: Ic354a79dc5f92942475339f6f60609ebfaff7311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791794 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694983}
-
Jinsuk Kim authored
With this CL, gesture navigation sheet can be triggered by both short and long swipe. Short swipe (and holding it for a given time) triggering logic is newly added. This tries to makes the UI more friendly to users. Bug: 937946 Change-Id: Ia0ee3cc968e7cbbb62ef466742ddb7f8bdd799f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792026 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#694982}
-
Eric Seckler authored
This is a reland of e40282f6. Includes a fix to BackgroundTracingActiveScenario, which could end up enabling TraceLog without installing the TraceEventDataSource overrides on Android, see patch set 1 -> 2. This likely caused the crashes observed in crbug.com/997582. Original change's description: > tracing: Enable startup tracing for spawned child processes > > Enables startup tracing for child processes spawned by the browser while > a tracing session is active. > > This allows us to collect early trace events in the period of time > before the child connects to the tracing service. > > Bug: 968424 > Change-Id: I1708cabae77cdd2ab3a33929c28cfab04eb723e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755746 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689599} Bug: 968424 Change-Id: Id69f0821671caf05238896d4a0e1b581b5d5be44 TBR: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782812 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#694981}
-
Hugo Benichi authored
This patch improves net.mojom implementation for active network events by: - Discarding NetworkConfiguration objects corresponding to ARC VPNs as is done for default network events. - Tagging the NetworkConfiguration object that corresponds to the default network. These small improvements will allow to simplify the receiving side inside ARC significantly. BUG=b:138349288 BUG=b:138351476 TEST=Android networking CTS. Flashed eve, connected to various different networks and checked expected mojo properties with $ android-sh -c "dumpsys wifi". Change-Id: Id534a6509de9ef1a9bef4024abe6639b4c8e5c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720118 Auto-Submit: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#694980}
-
Scott Violet authored
Now that we forced ContentViewRenderView this dep is no longer necessary. BUG=none TEST=none Change-Id: I867a1597dc74dc3414c2255e9f63a77854bd4866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793882Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#694979}
-
Matt Mueller authored
Disables the use of system-provided trust roots. Only supported by the "builtin" and "pathbuilder" verifier impls. Change-Id: Iaebcdbb8a5d826963b4deea18b1befeb4f9d5bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790468 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694978}
-
Xinghui Lu authored
A lot of #ifs are introduced in cl:1758740. Rearrange them to make the code cleaner, no functional change. Bug: 995926 Change-Id: I0d60b0a610e9a14a892587c124f9582bd6555299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789996Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694977}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ef368773be1..92f197b8a4e7 Created with: gclient setdep -r src-internal@92f197b8a4e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:977050 Change-Id: I6d756e104d7806f7b4c4f0f37c67cd4826e47023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792798Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694976}
-
Jon Mann authored
Bug: 1001687 Change-Id: I50c527dcce3ffc5b831519c346ff0db30f5495a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790471 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694975}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0e6ded9fcac..116ffe7e5be4 git log a0e6ded9fcac..116ffe7e5be4 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 danilchap@webrtc.org Switch to compiling WebRTC -std=c++14 by default Created with: gclient setdep -r src/third_party/webrtc@116ffe7e5be4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic8fa2bf9280158b167bf825090ecc064b5938cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694974}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ic19035c7dd1bc69cccc1161e2007563051bcda36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793442 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#694973}
-
Robbie McElrath authored
This reverts commit 362070db. Reason for revert: This probably broke monochrome-feedless-builder Original change's description: > Don't include JNI headers in chrome android when they're not used. > > This CL removes dependencies on JNI headers when they're not used and > the Java implementation isn't included. This makes chrome_public_apk > work with crrev.com/c/1743088. > > Bug: 836335 > Change-Id: Iec02f4fec9cf93183949547960e191e675e62ebf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746641 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694921} TBR=changwan@chromium.org,agrieve@chromium.org,rmcelrath@chromium.org Change-Id: I21c2f41e2772f74c1081bf72af96fea9c37d5502 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794022Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#694972}
-
Kenneth Russell authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash ContextLost_WebGLContextLostFromGPUProcessExit ContextLost_WebGLContextLostInHiddenTab These are now running on the full Chromium browser which should have tab control. Bug: 609629 Change-Id: Ia158a3829b5615a8a1f4f0eac1a5903f769294e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788138 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#694971}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ipc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rockot@google.com Bug: 891670 Change-Id: I410de34fd2b80faf6403ee60d3a81e9a0ac40a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787059 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#694970}
-
Dale Curtis authored
As with 69e8f306 and subsequently ad645f7a. It appears that allowing media elements to remain suspended while in the metadata state is not working as expected. This change reverts our play state calculations to requiring the element to reach the future data state to remain suspended. This is okay for preload=metadata suspend and lazy load suspend since we advance to have future data for these modes (in order to not break any pages). This patch also modifies our browser tests to expose the suspend state for the element under test using the window.internals() methods so we can debug this further in case this turns out not to be the right root cause. BUG=986021 TEST=updated tests. R=sandersd Change-Id: Idae559195c238edd3ccf6b2477ae18c3dfbda7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793129 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#694969}
-
Xinghui Lu authored
Replaced it with a local histogram for testing. Bug: 986648 Change-Id: Ie4b3b7971ec63ecbf1e52b4f254bfd9a18538e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790427Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694968}
-
Philip Rogers authored
The interest rect is a window within a scroller which has display items. The typical invalidation mechanisms will handle changes to drawing display items. Hit test display items are a little different because we need to ensure ScrollingCoordinator::UpdateTouchEventTargetRectsIfNeeded is called post-paint to map them into the space of the cc::Layer. The bug was that this mapping update did not occur on interest rect changes. This patch ensures the scrolling coordinator updates anytime display items are painted. Bug: 995715 Change-Id: I1428e956a83c4c07a18e40a8e36559f694eabf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793546Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694967}
-