- 29 May, 2020 40 commits
-
-
Mason Freed authored
Given that the html_background_parser isn't actually threaded, it seems to make more sense to call this "can parse asynchronously". This CL should cause no behavioral changes at all. Bug: 901056 Change-Id: I689ccc3270ecb63781ed0ff92212c21dbb07a569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220628 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#773271}
-
Jeffrey Cohen authored
ComponentCallbacks have been found to be problematic in the past. https://chromium-review.googlesource.com/c/chromium/src/+/1610587 Bug: 1084466 Change-Id: Ia75fec7163bd2e58772c42e50673dddaee48d68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219168Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773270}
-
Xiaohan Wang authored
CdmAdapter uses the CDM origin in crash reporting. Currently the origin comes from the render process during CDM creation. This CL adds a new CdmAuxiliaryHelper::GetCdmOrigin() where the implementation is in the browser process that is more secure. This allows us to remove the |security_origin| from various CreateCdm() calls which will be done in the next CL. Bug: 1065264 Change-Id: I8db09de9586f814c4af0a43e62b0e12eb08e1d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220214 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#773269}
-
Xinghui Lu authored
This CL is for refactor only. There is no functional change. Break RealTimeUrlLookupService into RealTimeUrlLookupServiceBase and RealTimeUrlLookupService, so that the enterprise version won't affect the consumer version. RealTimeUrlLookupServiceBase contains backoff logic and cache logic, because these functionalities will be shared with both enterprise and consumer versions. RealTimeUrlLookupServiceBase has three interfaces to be implemented: CanPerformFullURLLookup CanCheckNonMainframeURL StartLookup Another derived class EnterpriseRealTimeUrlLookupService will be added in a future CL. Bug: 1085261 Change-Id: I9445d3161d44e2402482aac9e9624cf8903d10bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204824 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#773268}
-
Clark DuVall authored
WebLayer requires using the window's Context to access resources and not the Activity, since the Activity belongs to the client and doesn't have WebLayer resources. This also doesn't even need the Activity since the DateTimeChooserAndroid constructor takes a Context. Bug: 1087894 Change-Id: I3b007ee938a67b7819f73cc9e8bc13c2dd2b56fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222622Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773267}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8091017..7693b668 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e205216e56fedeea2dd1a82bc616cad8007ae25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220193Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773266}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie024e1e4ecf60605c935402e6aee9dbc9f1b0a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773265}
-
Thomas Guilbert authored
This reverts commit 5930a9fd. Reason for revert: Likely causing test failures here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28Headless%29 Original change's description: > ozone/wayland: Fix data objects initialization and ownership > > DataDevice-related wrappers initialization and ownership, for both > standard and GTK's primary selection, are quite confusing and spread > over different parts of the backend code. This CL fixes and simplifies > it by: > > - Moving {WaylandData,GtkPrimarySelection}Device ownership to their > respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns > WaylandDataDevice singleton; > > - Fix WaylandClipboard initialization whether the compositor happens to > advertise GtkPrimarySelectionDeviceManager after wl_seat and > wl_data_device_manager; > > - Use dependency injection to provide DataSources with the correct > DataDevice instance at their construction time; > > - Clean up WaylandConnection by getting rid of the multiple (and almost > unused) data device getters from it as well as removing unneeded header > includes. > > Bug: 896640 > Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#773235} TBR=msisov@igalia.com,nickdiego@igalia.com Change-Id: I74b74bd56c2dcb68bb9c28bba66fdc606b946ad9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220194Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773264}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590753475-030a2e24f1ea13d43c4c794e813316525ddd3d28.profdata to chrome-mac-master-1590767663-c9c32cda7f7963eb3f000a0ebfa31cdf13cf0117.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5c4afff5e88d1f3040b413a2ac53f3cb05d13ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222496Reviewed-by:
-
Alexander Cooper authored
The WebXrPermissionsApi shipped with M83, as such, the feature flag can be removed. In order to remove the feature flag, places that rely on it need to be cleaned up. This change modifies the relevant UI code that used this state to determine whether or not to show the AR/VR permission entries. Since the feature is enabled by default, this logic can be removed and/or defaulted to always appearing. Change-Id: I7b6dd98da184811eaf65d94076549a23800eb82e Bug: 1064384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215455Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
adamta authored
Adds a section in the ContentSuggestions collection view which will later be populated by the Discover feed. Bug: 1085419 Change-Id: I36d6c55a4c3041d730d7189cdf2074d6e66ac0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215302 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#773261}
-
Kyle Horimoto authored
This CL adds an implementation for the ancestor page hierarchy in the SearchResult field (previously, this was set to a dummy value). This CL also removes the function which generated dummy values and associated TODOs. Fixed: 1071700 Change-Id: I6e6fa75eda2dec065297502cfa982bbc1d4c5b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220189Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773260}
-
Yao Xiao authored
It's a service that is supposed to (as some functions are incomplete) regularly compute the floc id by sim hashing the navigation history and log it to chrome sync. See floc_id_provider_impl.h for the details. Bug: 1062736 Change-Id: Iba855241e02512e627ab9f060f7c1a33b453c353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189646 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773259}
-
Josh Karlin authored
What: Record the FCP for ad iframes in UMA like we do in UKM already. Why: It's a useful metric for understanding the impact our changes have on ad performance. Bug: 1087602 Change-Id: I00c3b9c39f914127850ed8e7c0df7f4577486735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220610 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Auto-Submit: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773258}
-
Michael Thiessen authored
This code is very old and unused. Tests that need a Render Process Limit look like the just use @CommandLineFlags.Add(ContentSwitches.RENDER_PROCESS_LIMIT + "=1") Change-Id: Ie5841a0e2d1bdc24d0f382b99c1c1e181ddb066c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222525Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1076594 Change-Id: Ia6e093c8888f87f085698eeaf4746ae831578d4c Tbr: arthursonzogni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220874Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#773256}
-
Sergey Ulanov authored
The flakiness was introduced due to a conflict when reverting a change in crrev.com/764623 Bug: 1087687 Change-Id: Id973ae4b1125bd369fe4f0d40b73cd4450cacdab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220817Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773255}
-
Kenneth Russell authored
Regression test being added to WebGL conformance suite in https://github.com/KhronosGroup/WebGL/pull/3087 . Bug: 1085044 Change-Id: I2bf2f58a61e42dc360fe6e9c2fb54a4ec896dc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220812Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773254}
-
Matt Reynolds authored
GamepadDeviceLinux provides a weak pointer factory for use by AbstractHapticGamepad to schedule haptics-related tasks on the polling thread. On Chrome OS, weak pointers from this factory are also used for asynchronous permissions tasks on the DBUS thread. This behavior causes a WeakPtr check failure when a pointer is checked on the DBUS thread after the factory is bound to the polling thread. This CL modifies GamepadDeviceLinux to no longer require a WeakPtr for DBUS tasks. BUG=1020328 Change-Id: Idf71153483ead4740dcbb382f7cc40c3708bb431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217674Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#773253}
-
Jeffrey Cohen authored
The share button was getting stuck in a intermediate step where it was being marked as VISIBLE, but with an alpha of zero and an offset. This makes explicit the assumption that setting the button to visible will find it in its default state. Bug: 1084488 Change-Id: I2ac9797cfdc254c255e31d41bc82a96603bb3f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218707Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773252}
-
Carlos IL authored
The auto-reload logic for error pages is currently also triggering for interstitials. This is causing bugs due to reports triggered in the interstitial constructor, and is also not very effective since causes for interstitials are unlikely to be resolved with reloads. This CL disables auto-reloads for any error page that provides its own HTML (which currently is interstitials and heavy ad blocking pages). Bug: 1085502, 1069112 Change-Id: I474d1797bd4a402cd93516b79a599d57e46c23b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212814 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#773251}
-
Mike Wasserman authored
Check for permission on cross-screen fullscreen requests. Do not prompt users, fall back to the current screen on failure. Plumb the requesting RenderFrameHost into FullscreenController. (needed to make the appropriate origin-specific permission check) Remove the redundant WebContents args; rely on RenderFrameHost. Bug: 1080690 Change-Id: I8ec80e8b1f1f64ad2de1f936f4656d41a6e8e9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203268Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This makes the failure more explicit, and make the expectation aligned in pre-CompositeAfterPaint and CompositeAfterPaint for external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-overflow.html. Previously in CompositeAfterPaint the test triggered a DCHECK that was not obvious of the reason. Bug: 786475 Change-Id: I93c7df7c731b9f87d88d5ad509d2c6a4d4b10755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220159 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#773249}
-
Miguel Casas authored
When there are HDR quads to be presented, BufferQueue calls Reshape() which in turn calls its GLSurfaces' Resize(). This CL extends the implementation of GLSurface, GbmSurfaceless, to catch the ColorSpace and send it to its DrmWindowProxy. Said Proxy then tells DrmThread which sends the ColorSpace to the DrmGpuDisplayManager that tells all its DrmDisplays. If the DrmDisplay supports HDR, configures the linear gamma ramp to reach full scale (full brightness) or just a fraction of it, depending on the ColorSpace. A diagram of the classes and their relationships can be found in https://i.imgur.com/MqW3Gb8.png (https://imgur.com/a/KSxSln7). Bug: 958166 Change-Id: I095ac9804bb6499b03f6b1179635827fcff07d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210637 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#773248}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/828485852b9c..98496cab72c7 2020-05-29 amaiorano@google.com Fix float to int copy in VK backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ia9cedcabff6e0bf994081b369d2be6042622a693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222488Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/acde602c3a4b..25b938b8a38d 2020-05-29 tvanderlippe@chromium.org Typecheck formatter_worker/AcornTokenizer.js with TypeScript 2020-05-29 danakj@chromium.org Remove use of capturePixelsAsyncThen() which will be removed. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1069111,chromium:866140,chromium:952399 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I95cbdb559b802a5c340932ddefbd1fdd61f777ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222493Reviewed-by:
-
Tobias Sargeant authored
This renames url-chunk to gpu-url-chunk so that there aren't two crash keys with the same name set within the same process. Bug: 1084160 Change-Id: Iab27ec7abeecce976f00f3445361abef3bf28416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209055 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#773245}
-
Hui Yingst authored
1. Create a new struct DocumentAttachmentInfo, which contains basic information about a PDF attachment, including the attachment's name, size, creation date and last modified date. 2. Implement a method GetDocumentAttachmentInfoList() in PDFEngine, which returns a list of DocumentAttachmentInfo structure(s) associated with a PDF document. 3. Add 2 unit tests for the new method. To test on PDFs with attachments, this CL uploads a test PDF embedded_attachments.pdf, which contains 3 attachments: 1.txt, attached.pdf and 附錄.txt. These 3 attachments can cover the tests on different file types and names, and tests on attachments with no creation dates or last modified dates. Bug: 177188 Change-Id: If6eaa61f64407af9c848fe2b3b814aa83fc23495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202510Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773244}
-
Josh Simmons authored
This provides the PerformanceHint for the page pattern matching the URL passed to GetHints. Change-Id: Ib780accc64356d414dab01a4736df6d9430d5a83 Bug: 1087123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217114Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#773243}
-
Mohsen Izadi authored
The new Graphics.Smoothness.EventLatency event reports the latency of each pipeline stage with fields for input event type and scroll event input type. A sampling strategy similar to sampling strategy of existing Graphics.Smoothness.Latency event is used. The UKM collection request has been approved here: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 1054019 Change-Id: I2d36ab61210ccf085fe81c8328097e5c84bcd2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175324Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773242}
-
Matt Menke authored
This is used to track areas where we need to fill in empty NetworkIsolationKeys with the correct value. While we certainly should add tests when we do this, keeping Todo()s in tests makes it harder to audit the production code where we need to wire up NIKs. Bug: None Change-Id: I99fcca16a2b2d9a266444512c19bddaba2cc77a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222524 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#773241}
-
Yi Xu authored
Canvas-hit-region related tests doesn't test any any calls to canvas-api directly, the tests suit better in fast/canvas folder. Change-Id: I69be8b2a05c0f1145a738da79c9125dc04a08f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215251Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#773240}
-
Abhishek Kumar authored
VA-API low power encoders are disabled by default in chrome as all platforms does not support LP. H264/AVC Low power encoder is supported on Intel Gen9+ gpu platforms and VP9 LP encoder on Gen11+ platforms[1]. Disable the low power encoder on the Intel Gen 9/9.5 GPU, as it is unstable[2] and is enabled on the Gen10+ platform by default. [1]https://github.com/intel/media-driver#decodingencoding-features [2]https://crbug.com/929849 BUG=b:156874708, chromium:929849 TEST=tast run {DUT_IP} video.EncodeAccel.* on JSL/CML/KBL Change-Id: I747442e9bc314ce1a8b901f3bb6d27da8b75d73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210325Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#773239}
-
Maksim Moskvitin authored
Removed tests covered Directory behavior and blocked removing Directory implementation of Nigori. Bug: 1083924 Change-Id: I96198dc1548879e0e0e1668d3373a1ee4d323af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220049Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#773238}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77a9d35a2289..521a1ec91ba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1066803 Tbr: nsatragno@google.com Change-Id: I4e58d92218ae18e4b9f4dd7bd003c3d5efdc7329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222491Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773237}
-
Jacques Newman authored
Reason for revert: Caused KioskTest.SpokenFeedback to fail intermittently. See: https://bugs.chromium.org/p/chromium/issues/detail?id=1085004 The following CL fixes the flakiness: CL 2219175: Make KioskTest.SpokenFeedback more robust > Original Change Description: > This change allows us to defer sending events to > improve performance during the initial page load. > > EventScheduleMode determines if we schedule events > with a delay or not. > > EventScheduleStatus replaces ack_pending_, and tracks > what state we are in with regard to event scheduling. > > This is based on: > CL 1691523: Large batch accessibility event processing > during page load > > Bug: 976849 > Change-Id: I74cd5f31102199f8c5752e0ef5d0eb623fdbd9d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123310 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#769010} Bug: 976849 Change-Id: I272ac376e70352bf6275ecf884b4f679e86a1576 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219098Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773236}
-
Nick Diego Yamane authored
DataDevice-related wrappers initialization and ownership, for both standard and GTK's primary selection, are quite confusing and spread over different parts of the backend code. This CL fixes and simplifies it by: - Moving {WaylandData,GtkPrimarySelection}Device ownership to their respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns WaylandDataDevice singleton; - Fix WaylandClipboard initialization whether the compositor happens to advertise GtkPrimarySelectionDeviceManager after wl_seat and wl_data_device_manager; - Use dependency injection to provide DataSources with the correct DataDevice instance at their construction time; - Clean up WaylandConnection by getting rid of the multiple (and almost unused) data device getters from it as well as removing unneeded header includes. Bug: 896640 Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320Reviewed-by:Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#773235}
-
Anubha Mathur authored
Original change that introduced change to NetworkRequest object: https://chromium-review.googlesource.com/c/chromium/src/+/2142145 DevTools browser_protocol.pdl is getting updated, but is failing this test, so need to disable test temporarily till it gets checked in: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2220495 Bug: 1066579 Change-Id: Ie2a39211993646f67487de2646f6befd0e8af987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220809Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773234}
-
Jeremy Roman authored
Since the AppBannerManager may miss loading (its usual trigger) if loaded in a portal context, also observe portal activation into a tab and trigger the same logic at that point. Android instrumentation test included. Fixed: 1087163 Change-Id: I9e8a888f6f5ce2d3d13d825f62d64d0d164bfc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219041Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773233}
-
Robert Flack authored
Requesting pushing whether we have a requestAnimationFrame call or animations to the compositor through AnimationHost requires a commit. This leads to a lot of expensive messages even when nothing is changed on the page. Since this is only used for metrics we should find a more efficient way to track these changes. Bug: 1083244 Change-Id: I093d036dafd0abf9e25b7e1592214a4c672866fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216859Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773232}
-
