GitLab

If a FileReader is abort()ed, a task is scheduled to perform the actual
abort operation. Should the containing Document's ActiveDOMObjects be
stopped before that task gets to run, the FileReader would already
advance to a DONE state and be at risk from being GCed before the abort
task gets to run. If so, it would then access a dead object.

The provided test elicits an assert that shows up the problem, but
doesn't trigger the GC and subsequent access of the dead object.

R=kouhei@chromium.org, tzik@chromium.org
BUG=404513

Review URL: https://codereview.chromium.org/478263002

git-svn-id: svn://svn.chromium.org/blink/trunk@180450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rendering gradient consumes considerable amount of time.

BUG=316092

Review URL: https://codereview.chromium.org/440853002

git-svn-id: svn://svn.chromium.org/blink/trunk@180449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch fixes inspector/audits/audits-panel-noimages-functional.html
and inspector/audits/audits-panel-functional.html

BUG=364088, 357079
R=apavlov

Review URL: https://codereview.chromium.org/483683002

git-svn-id: svn://svn.chromium.org/blink/trunk@180448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

guidelines and improved performance in WebViewImpl.cpp a bit.

Review URL: https://codereview.chromium.org/479803002

git-svn-id: svn://svn.chromium.org/blink/trunk@180447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=398840

Review URL: https://codereview.chromium.org/483663002

git-svn-id: svn://svn.chromium.org/blink/trunk@180446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - Removes unnecessary blink:: prefixes.
 - Removes *using namespace* usage.

BUG=

Review URL: https://codereview.chromium.org/468083003

git-svn-id: svn://svn.chromium.org/blink/trunk@180445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

This spec change was made in order to simplify the fix for mis-nested
fullscreen in iframes:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26568 (comments 9-13)

The requestFullscreen() implementation is not in sync with the spec, but
an early return is equivalent until the "run the remaining steps
asynchronously" bit is implemented.

In order to be affected by this change, one would have to request
fullscreen for the same element twice and do something meaningful in the
fullscreenerror event, which is likely rare.

Note that exitFullscreen() already does nothing if the fullscreen
element stack is empty, so there is some symmetry to this.

TEST=LayoutTests/fullscreen/api/element-request-fullscreen-top.html
TEST=LayoutTests/fullscreen/api/element-request-fullscreen-non-top.html

BUG=403741

Review URL: https://codereview.chromium.org/482543002

git-svn-id: svn://svn.chromium.org/blink/trunk@180444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method is always defined, no need for additional checks in inspector tests.

BUG=None

Review URL: https://codereview.chromium.org/486543003

git-svn-id: svn://svn.chromium.org/blink/trunk@180443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The PresentationConsoleMessage management is moved from UISourceCode
into PresentationConsoleMessageHelper.

R=eustas, vsevik

Review URL: https://codereview.chromium.org/472353002

git-svn-id: svn://svn.chromium.org/blink/trunk@180442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WorkerGlobalScopeProxy is dedicated worker specific, while this interface could be reused for
shared/service workers as well.

BUG=404355
R=pfeldman, yurys, sergeyv

Review URL: https://codereview.chromium.org/477313002

git-svn-id: svn://svn.chromium.org/blink/trunk@180441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, XMLHttpRequest accepted |overrideMimeType| regardless
of its state. This is not conformant to the current spec:
http://www.w3.org/TR/XMLHttpRequest2/#the-overridemimetype-method

This CL changes it to throw InvalidStateError when the state
is LOADING or DONE, which aligns to the spec.

BUG=402375

Review URL: https://codereview.chromium.org/478223002

git-svn-id: svn://svn.chromium.org/blink/trunk@180440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's equivalent to webkitCurrentFullScreenElement != null.

BUG=383813

Review URL: https://codereview.chromium.org/476353002

git-svn-id: svn://svn.chromium.org/blink/trunk@180439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are going to switch to tracing backend for the timeline and there won't be TimelineAgent so the tests are changed to use higher level abstractions.

BUG=398785

Review URL: https://codereview.chromium.org/480003002

git-svn-id: svn://svn.chromium.org/blink/trunk@180438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds support for the 'converter' attribute for a group of
semi-custom CSS properties handled by the 'apply_auto' macro. This gets
rid of the redundant 'compute_length=true/false' argument, plus the code
related to that.

It also makes it easier to add other things to the apply_auto-list which
can't be converted with computeLength or a primitive value mapping.

Review URL: https://codereview.chromium.org/454133004

git-svn-id: svn://svn.chromium.org/blink/trunk@180437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=403184

Review URL: https://codereview.chromium.org/486583002

git-svn-id: svn://svn.chromium.org/blink/trunk@180436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://fullscreen.spec.whatwg.org/#model
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26568#c12
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26568#c16

BUG=383813
NOTRY=true

Review URL: https://codereview.chromium.org/477133002

git-svn-id: svn://svn.chromium.org/blink/trunk@180435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unused includes, simplify and clarify a comment, format the
frameBytesAtIndex() code like the rest of the code in this file.

BUG=None

Review URL: https://codereview.chromium.org/485623002

git-svn-id: svn://svn.chromium.org/blink/trunk@180434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This class does more than just manage the fullscreen element stack, and
the shorter name makes the code more readable in many places. In the
renamed Fullscreen class, it also makes it more obvious when the actual
fullscreen element stack is being manipulated.

BUG=383813

Review URL: https://codereview.chromium.org/476763004

git-svn-id: svn://svn.chromium.org/blink/trunk@180433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make XMLHttpRequest return a ReadableStream when the response type is set to
'stream'. This CL also modifies ReadableStream interface and implementation to
make it enable for XMLHttpRequest to use ReadableStream functionalities.

BUG=401396

Review URL: https://codereview.chromium.org/455303002

git-svn-id: svn://svn.chromium.org/blink/trunk@180432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes the acceleratedCompositingForFixedRootBackground setting
and makes the WebSetting setter a no-op. Any code that checked for
this setting is replaced with a check for
preferCompositingToLCDTextEnabled instead.

R=abarth, vollick@chromium.org
BUG=365851

Review URL: https://codereview.chromium.org/479893002

git-svn-id: svn://svn.chromium.org/blink/trunk@180431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402387

Review URL: https://codereview.chromium.org/483603003

git-svn-id: svn://svn.chromium.org/blink/trunk@180430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402536

Review URL: https://codereview.chromium.org/486563002

git-svn-id: svn://svn.chromium.org/blink/trunk@180429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. This stack copying limit is a performance sanity check;
2. ASan/LSan use more space on the stack, and performance is not an issue for LSan/ASan. So, we allow more stack copying to avoid test case failed on these builds.

R=ager@chromium.org, oilpan-reviews@chromium.org
BUG=403273

Review URL: https://codereview.chromium.org/474203002

git-svn-id: svn://svn.chromium.org/blink/trunk@180428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Merge multiple |namespace blink| blocks
- Remove unnecessary blink:: prefix
- Other minor style fixes.

BUG=

Review URL: https://codereview.chromium.org/474183002

git-svn-id: svn://svn.chromium.org/blink/trunk@180427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Another step toward removing the deprecated ServiceWorkerContainer.unregister.
service_worker_unregister_and_register is the biggest consumer of it in our
tests.

Now to unregister, the function first registers at that scope to get a
registration, then calls unregister on it. This only works with registrations
that cleanly install, which is the most common use case.

BUG=404064

Review URL: https://codereview.chromium.org/472293002

git-svn-id: svn://svn.chromium.org/blink/trunk@180426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes |DocumentParser::startParsing()|.
This was only used from XMLDocumentParser, but it was a no-op.
The method initializes |m_state| to |ParsingState|, however the state should
already be in |ParsingState| from c-tor initializer.

BUG=404107

Review URL: https://codereview.chromium.org/471423002

git-svn-id: svn://svn.chromium.org/blink/trunk@180425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Move more code of RenderObject destructors to destroy(). (patchset #1 of https://codereview.chromium.org/459353002/)

Reason for revert:
Caused crashes in ImageQualityController::highQualityRepaintTimerFired().


Original issue's description:
> Oilpan: Move more code of RenderObject destructors to destroy().
> 
> Like [1] and [2]. We should do it in general.
> 
> [1] http://src.chromium.org/viewvc/blink?view=revision&revision=180023
> [2] http://src.chromium.org/viewvc/blink?view=revision&revision=180029
> 
> BUG=398342
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180046

TBR=oilpan-reviews@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398342

Review URL: https://codereview.chromium.org/478923005

git-svn-id: svn://svn.chromium.org/blink/trunk@180424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Given that we clear the m_referencedNodes in AudioContext::uninitialize(),
the m_referencedNodes should be empty in both oilpan builds and non-oilpan builds.

BUG=340522

Review URL: https://codereview.chromium.org/475373002

git-svn-id: svn://svn.chromium.org/blink/trunk@180423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The methods multiply a scale transformation on the current matrix.

The specification:
  http://dev.w3.org/fxtf/geometry/

Intent to Implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM

BUG=388780

Review URL: https://codereview.chromium.org/450533006

git-svn-id: svn://svn.chromium.org/blink/trunk@180421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys

Review URL: https://codereview.chromium.org/470543002

git-svn-id: svn://svn.chromium.org/blink/trunk@180420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This rolls codemirror to 2b30a049fd, which is slightly
later than 4.4.1.

Layout test change: In codemirror version 4.4.1 the viewport update logic has changed and it no longer works if text editor offsetHeight is 0px. So creation of editor instance
for tests now setups default editor height of 100px.

R=apavlov
BUG=404120

Review URL: https://codereview.chromium.org/475393002

git-svn-id: svn://svn.chromium.org/blink/trunk@180419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The methods multiply a translation transformation on the current matrix.

The specification:
  http://dev.w3.org/fxtf/geometry/

Intent to Implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM

BUG=388780

Review URL: https://codereview.chromium.org/446803002

git-svn-id: svn://svn.chromium.org/blink/trunk@180418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ASSERTION FAILED: !extraRowSpanningHeight in WebCore::RenderTableSection::distributeRowSpanHeightToRows

Spanning rows have only percent rows and total percent is less than 100 So only
percent portion of extraRowSpnnaingHeight is consumed in percent spanning rows and
remaining is left to distribute in non-spanning rows. But non-percent rows height
is zero So assertion is failing.

Now, whole extraRowSpanningHeight is distributed to percent spanning rows if non-percent
spanning rows height is zero.

R=jchaffraix@chromium.org
BUG=366579

Review URL: https://codereview.chromium.org/398013005

git-svn-id: svn://svn.chromium.org/blink/trunk@180417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is patch 1 of 4.

TBR=phoglund@chromium.org, jsbell@chromium.org, cmumford@chromium.org
BUG=404303, 404305

Review URL: https://codereview.chromium.org/478863002

git-svn-id: svn://svn.chromium.org/blink/trunk@180416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow Elements who are not styled but have class set to be retrieved using getElementsByClassName.

Matches FF behavior.

https://bugs.webkit.org/show_bug.cgi?id=94718

Review URL: https://codereview.chromium.org/458663003

git-svn-id: svn://svn.chromium.org/blink/trunk@180414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add support to new-line character handling in error and warning console
message texts which are shown in a popover in editor.

BUG=404380
R=vsevik

Review URL: https://codereview.chromium.org/478963002

git-svn-id: svn://svn.chromium.org/blink/trunk@180413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/476083002

git-svn-id: svn://svn.chromium.org/blink/trunk@180412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch adds tooltips with actual pixel values of serifs, representing
CSS breakpoints on CSS ruler.

BUG=391240
R=pfeldman, dgozman

Review URL: https://codereview.chromium.org/478953002

git-svn-id: svn://svn.chromium.org/blink/trunk@180411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no need to repaint fixed position layers that are squashed. Necessarily
they must be squashed onto other fixed position layers, which means they don't
move during scrolling.

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/478823002

git-svn-id: svn://svn.chromium.org/blink/trunk@180410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The event should report DOM.RGBA color instead of string.

R=pfeldman@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/478943002

git-svn-id: svn://svn.chromium.org/blink/trunk@180409 bbb929c8-8fbe-4397-9dbb-9b2b20218538