GitLab

BUG=383999

Review URL: https://codereview.chromium.org/336833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277914 0039d316-1c4b-4281-b951-d872f2087c98

It's duplicative with NodeObserver::OnDestroy.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/341553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277913 0039d316-1c4b-4281-b951-d872f2087c98

r271506 removed has_sse2 from the gcc file, but it remained in the tsan
header.

(I asked in
https://codereview.chromium.org/10948035/diff/17001/base/atomicops_internals_tsan.h#newcode24
for why this struct is in this file at all.)

BUG=348761, 94925

Review URL: https://codereview.chromium.org/345453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277909 0039d316-1c4b-4281-b951-d872f2087c98

This error is shown both in the avatar button, and in the avatar menu. When the 
account for which we're displaying the auth error is clicked in the avatar menu,
we show the Gaia reauth view.

Screenshot: 
https://drive.google.com/file/d/0B1B1Up4p2NRMQW90VmcwcGZQVEU/edit?usp=sharing

I've also fixed a bug where the available text for the account name was 
incorrectly calculated, and eliding overlapped the delete button. Screenshot:
https://drive.google.com/file/d/0B1B1Up4p2NRMaU9DcWdqTVZNMVk/edit?usp=sharing
BUG=311235
TEST= Sign into Chrome with the --new-profile-management flag on. Go to 
accounts.google.com and revoke Chrome's access to that account, from the 
Security tab. Try to bookmark the current page. The avatar button should be
badged like in the attached screenshot.

Review URL: https://codereview.chromium.org/303463010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277908 0039d316-1c4b-4281-b951-d872f2087c98

Remove locks, post tasks, and complexity used to support legacy
rendering path.

BUG=344087

Review URL: https://codereview.chromium.org/331103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/340553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277905 0039d316-1c4b-4281-b951-d872f2087c98

Identify Android vs iOS requests so that server can adjust respond
differently to mobile hits than desktop.

BUG=none

Review URL: https://codereview.chromium.org/337803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277904 0039d316-1c4b-4281-b951-d872f2087c98

r274473 did not remove sanity checks for negative PTS/DTS that occur
prior to any adjustment based on timestampOffset. Current MSE spec does
not call for issuing decode error if PTS or DTS are negative at the top
of the coded frame processing loop. This change removes the sanity
checks that are not spec-compliant.

R=acolwell@chromium.org
BUG=381114
TEST=FrameProcessorTest.AllowNegativeFramePTSAndDTSBeforeOffsetAdjustment

Review URL: https://codereview.chromium.org/334363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277903 0039d316-1c4b-4281-b951-d872f2087c98

Updated ClearFormWithElement() to ignore fields that were not
autofilled.

BUG=379969

Review URL: https://codereview.chromium.org/316853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277902 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277901 0039d316-1c4b-4281-b951-d872f2087c98

Build libstlport with -fno-exceptions
Update arm gcc toolchain 4.8's gdb version to 7.6

BUG=385308

Review URL: https://codereview.chromium.org/339103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277900 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
http://crbug.com/385480

Review URL: https://codereview.chromium.org/331633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277899 0039d316-1c4b-4281-b951-d872f2087c98

It was previously used for per-profile ChromeOS component
installation, and then changed to do cleanup from that
experiment. The files should be cleaned up by now, so remove that code.

Stop registering PNaCl for component updates on ChromeOS
also, since that was just for the cleanup.

Eventually should move to using the default component
installer w/ customization through traits, then we can
get rid of the browser_process field.

BUG=none

Review URL: https://codereview.chromium.org/338403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277896 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176328:176346&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/345443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277895 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/184113005,
system_tray.cc and tray_user_unittest.cc don't need the command line
switch related headers anymore. So we can remove these.

BUG=348133

Review URL: https://codereview.chromium.org/338133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile

Review URL: https://codereview.chromium.org/338323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277893 0039d316-1c4b-4281-b951-d872f2087c98

Chromium linker has been enabled for the full chrome,
and should also be exercised by content / chrome shells.

BUG=382485

Review URL: https://codereview.chromium.org/329223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277892 0039d316-1c4b-4281-b951-d872f2087c98

Bug 338529 has been fixed in Chrome 37, so MediaSource renderer
should work properly now on all platforms.

BUG=321825
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/344483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385677

Review URL: https://codereview.chromium.org/332393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277890 0039d316-1c4b-4281-b951-d872f2087c98

Fix issue where OpenKey() would call Close() and reset the wow64_access to 0 causing subsequent OpenKey() to fail.

BUG=384587
TEST=base_unittests --gtest_filter=RegistryTest.SameWowFlags

Review URL: https://codereview.chromium.org/334973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382630

Review URL: https://codereview.chromium.org/335413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/311183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277887 0039d316-1c4b-4281-b951-d872f2087c98

Instead of creating the exact match in HistoryURLProvider::DoAutocomplete(),
pass it in in the HistoryURLProviderParams struct.

This also uses this match as the "can't find DB, fallback" match in Start(); I
don't see any disadvantage to creating that match on the results of running
fixup, instead of creating a pre-fixup match like before.

This also splits out CanPromoteMatchForInlineAutocomplete() from
PromoteMatchForInlineAutocomplete().  I'll be converting
PromoteMatchForInlineAutocomplete() into a different function in the next part
of this change, and this happens to make the calling convention a little more
sane anyway.

Also removes a few comments from the .cc file that are in the .h file already.

BUG=376199
TEST=none
R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/336173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277886 0039d316-1c4b-4281-b951-d872f2087c98

Previously it would return an array buffer of the JSON.

This corresponds with the recent spec update:
https://dvcs.w3.org/hg/webcrypto-api/rev/f61017a76a5d

BUG=373917, 245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/334333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277884 0039d316-1c4b-4281-b951-d872f2087c98

When the find bar is hidden, there is still an invisible view (its superview)
in its place that was consuming the right-click event.
Fixed this by hiding the find bar superview instead.
Also make sure that the initial state is set to hidden.

TEST=Invoke find bar then close it, right-click where the find bar was, context
menu should appear.

BUG=381207

Review URL: https://codereview.chromium.org/332283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385198

Review URL: https://codereview.chromium.org/337393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277882 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/326043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277881 0039d316-1c4b-4281-b951-d872f2087c98

The progress bar was not being read properly by screen readers for the
Mac (VoiceOver).  This gives the screen reader enough information to
do its job.

BUG=370512

Review URL: https://codereview.chromium.org/333643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277880 0039d316-1c4b-4281-b951-d872f2087c98

This is part 1 of the code to start supporting embedded YT for cast. The main
issue is that YT embedded videos need to be identified via the frame that
contains it. This CL sets the frame URL of each video in the MediaPlayerAndroid
object.

Clank downstream piece to come later. 
Min / Aaron: will send you the doc I have that explains this in more detail.

BUG=358573

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277425

Review URL: https://codereview.chromium.org/302453012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277879 0039d316-1c4b-4281-b951-d872f2087c98

This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases.

This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux.

BUG=155363

Review URL: https://codereview.chromium.org/298813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373344
TEST=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/299663009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277877 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/331853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277876 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Linux sandbox: add sandbox_linux_unittests.isolate (https://codereview.chromium.org/340523006/)

Reason for revert:
Breaking linux_chromium_clang_dbg 

[7609/24970 | 449.637] SOLINK lib/libmojo_launcher.so
FAILED: cd ../../sandbox; python ../tools/isolate_driver.py check --isolated "../out/Debug/sandbox_linux_unittests.isolated" --isolate "linux/sandbox_linux_unittests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=37.0.2056.0" --config-variable "OS=linux" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --ignore_broken_items
Traceback (most recent call last):
  File "../tools/isolate_driver.py", line 279, in <module>
    sys.exit(main())
  File "../tools/isolate_driver.py", line 269, in main
    create_wrapper(args, isolate, isolated)
  File "../tools/isolate_driver.py", line 194, in create_wrapper
    assert os.path.basename(isolate) == isolate, isolate
AssertionError: linux/sandbox_linux_unittests.isolate
ninja: build stopped: subcommand failed.


Original issue's description:
> Linux sandbox: add sandbox_linux_unittests.isolate
> 
> BUG=384514
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277867

TBR=nodir@chromium.org,vadimsh@chromium.org,maruel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384514

Review URL: https://codereview.chromium.org/339183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277875 0039d316-1c4b-4281-b951-d872f2087c98

The file chrome/test/data/extensions/api_test/gcd_private/api/trun is unneeded.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/342493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277872 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of https://codereview.chromium.org/332003002

BUG=144491

Review URL: https://codereview.chromium.org/340543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277871 0039d316-1c4b-4281-b951-d872f2087c98

Fixes regression introduced by r276036 that removed the title from
the notification center on ChromeOS.

BUG=350449

Review URL: https://codereview.chromium.org/335413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385701
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/336423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277869 0039d316-1c4b-4281-b951-d872f2087c98

Check the preferences thaht can be controlled by other users.
Also look for the secondary user banner, and controlled-by
indicators in headings.

BUG=359578
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/322293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384514
NOTRY=true

Review URL: https://codereview.chromium.org/340523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277867 0039d316-1c4b-4281-b951-d872f2087c98