- 13 Oct, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
If the pseudo_id is set, the SelectorChecker::MatchSelector call for each subselector will fail completely because the dynamic_pseudo of the inner result will not match context.pseudo_id. This check does not make sense to perform for nested complex selectors, since pseudo elements are not valid in nested complex selectors. Hence, we can just set the pseudo_id to kPseudoIdNone at the :is/:where boundary. This fixes a bug where selectors such as ":is(.a .b)::before" would never match. This CL also adds a basic test for pseudo classes. (Not related to the fix). Bug: 568705 Change-Id: I119265836ac0f1b77868537c7685690300c265fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466278Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#816500}
-
Mario Sanchez Prada authored
Currently, the code in RFHI::SetEmbeddingToken() (which gets called as the result of a document being loaded in a renderer's RenderFrame for the first time) takes care of locating the correct RenderFrameProxyHost representing the parent frame remotely to send it the embedding token, so that the parent-child relationship can get established. However, there is a race condition for the particular case of inner web contents in that such propagation will only work if SetEmbeddingToken() gets called *after* the inner web contents are attached to the outer one. In that case, since the outer delegater proxy has not been created yet, SetEmbeddingToken() will fail to find the RenderFrameProxyHost and the remote frame representing the parent frame in one renderer will not have its embedding token properly set, breaking things such as the accessibility tree, for instance. To fix that, this CL splits RFHI::SetEmbeddingToken() in two parts: one that actually sets the embedding token and another one that takes care of propagating it to the parent frame. And with that in place, this CL does also make sure that such propagation is requested also after inner web contents get attached, so that the parent-child relationship is always guaranteed to be set. Bug: 1135691, 1094150 Change-Id: Ie3ddd24acb3ad224a08a31c622e319cd69affba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462128 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816499}
-
Joel Hockey authored
It is helpful to use linux-chromeos to see parts of the settings and FilesApp UI which relate to Plugin VM. Change-Id: I4f51642e87d52fd35b125df540173c72d4022ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466545 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816498}
-
Francois Beaufort authored
This CL adds the camera pan tilt zoom permission to devtools browser protocol. Spec: https://github.com/w3c/permissions/pull/204 Bug: 1136778 Change-Id: Ic11990413e2ceeeceb7da5c03930cd4049189b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460898Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Maggie Cai authored
The test fast/events/mouse-cursor-image-set.html is flaky on Mac 10.12 Tests builder. e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/38366. BUG=1137716 TBR=tkent@chromium.org Change-Id: Ib4d284ed30a1e1968ca02fef85ffe2690fd5c478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467577Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816496}
-
Joe DeBlasio authored
Safety Tips have always recorded histogram names based on NoAction, but histograms.xml has had NoActionTaken. That made it look like NoActionTaken just never happened. I now know better. This change lets us see the existing data from the dashboard. :-( The code in question is at: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/reputation/reputation_web_contents_observer.cc;l=69?q=Security.SafetyTips.Interaction&ss=chromium Change-Id: I2cc79ffaf70e962b24f34635e698db3aa145083a Fixed: 1137615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466512 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816495}
-
Marc Treib authored
This allows the corresponding factory to return refptrs instead of raw pointers, and lets remove the explicit Destroy() method. One downside is that now all implementations have to be refcounted, but this only affects some test implementations. One particular test implementation, TestHttpBridge[Factory], was unused and is deleted. Bug: 951350 Change-Id: I8c581136389e2ce470786dffefa3145e88c5d19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466237 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#816494}
-
Victor Hugo Vianna Silva authored
(Most of the changes here are trivial renamings, the interesting parts to review are indicated below.) As explained in the linked bug, there's no need for a distinction between blocking and non-blocking sync data types anymore, so this CL removes instances of non-blocking/non_blocking/nonblocking from methods, class members, local variables, test names and documentation. After this CL only 2 references to this concept remain: non_blocking_sync_common.h, which will possibly be split into other files, and the ModelSafeGroup enum (GROUP_NON_BLOCKING/GROUP_PASSIVE), which will be addressed in crbug.com/1102835. The only interesting changes to review here are: - Documentation of classes, methods and members. - Test names and their comments. - SyncBackendRegistrar: this class still depends on ModelSafeGroup, so its somewhat hard to get rid of the blocking/non-blocking distinction entirely. What we do instead is reference GROUP_[NON_BLOCKING/PASSIVE] directly and add TODOs pointing to crbug.com/1102835. This makes it more likely that these instances get addressed. Bug: 1103583 Change-Id: I66f14afa0a0a96e8541021ba8b4136a3fcca8618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465751 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816493}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9b0de8c80ca..1df9e9aac9d3 2020-10-13 jleconte@google.com Fix pop up statement when triaging with an existing bug. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: nuskos@google.com Change-Id: I182f3b651d9c85d43505f67724b31f4a045218a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816492}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602514791-92b25c346599f1253fe4b5957e8929536703cfb0.profdata to chrome-win32-master-1602536311-b12e3fd5e65df9379666839aba71278f41868f97.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib730131c3214f41774025e0d272fe67bf622b744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467066Reviewed-by:
-
Noel Gordon authored
This reverts commit 6e991fa7 Reason for revert: MSAN error that caused the original revert was fixed on CL:2466572. Original change's description: > Revert "[filesapp] Add missing includes and fail if host crashed" > > This reverts commit 4734ecf2. > > Reason for revert: https://crrev.com/c/2461602 breaks build Linux ChromiumOS MSan Tests in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20900 > Failed test is DevToolsListenerBrowserTest.CanCollectCodeCoverage > > Original change's description: > > [filesapp] Add missing includes and fail if host crashed > > > > Adds #include's that were missing from the initial patch, and FAIL the > > test if the DevToolsAgentHost attached to crashes during the test. > > > > Fix HostString() helper to *actually* take an optional prefix: use C++ > > c++17 {} style initializer. > > > > Test: browser_test --gtest_filter="*DevToolsListener*" > > Bug: 1113941 > > Change-Id: I5901019add9fea92b6e3a8b5b881b8d3d197b6c0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465456 > > Commit-Queue: Ben Reich <benreich@chromium.org> > > Reviewed-by: Noel Gordon <noel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816070} > > TBR=noel@chromium.org,benreich@chromium.org > > Change-Id: I87ec9b3db970807af8fc75ca137fc83397f775bf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113941 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466016 > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816400} TBR=noel@chromium.org,mxcai@chromium.org,benreich@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1113941 Change-Id: I10432537826bc0ecd3938230b8454a9f1dbd8cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465900 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816490}
-
dpapad authored
The previous way of fetching the Closure compiler binary from [1] no longer works (endpoint removed), and using NPM is the suggested alternative. [1] https://dl.google.com/closure-compiler/compiler-latest.zip Bug: 1137293 Change-Id: I6047c760fa97e04b16258beee0dd59c78b231b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465685 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#816489}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602546992-ba4d1f5ead4061da7fd3853f89c3c9703bc786ae.profdata to chrome-linux-master-1602567235-76a4ea133fcdb6cde619178f9199537d86205f8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab4fc8e832116ae0dbd259d88cab186b424f8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467537Reviewed-by:
-
Morten Stenshorne authored
No code changes required. Bug: 294205 Change-Id: I7b69be39368da781a0ac95562ecab34c43fe6e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816487}
-
Rohit Agarwal authored
#testCloseAllIncognitoNotificationIsDisplayed. StatusBarNotification#getTag method can return null if no tag was assigned to a notification. This CL adds the null check here before comparing the tag with the incognito notification tag. Bug: 1134241 Change-Id: I548ec82aebbd15a2e837cf00316d30955d828510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463573Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816486}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6bb6691b933..8900cd2cdaec 2020-10-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-13 alexrudenko@chromium.org Enable TypeScript for LayerDetailsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3c337247cf32b656b7048cf6ab93df8da65c6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464700Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b073999c6f90..aa45aa62c3c6 2020-10-13 orodley@chromium.org [vpython] Update to e5cc6d29d10646efa. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123433 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I302d8b32c79ed3cd5e473bbc7b239eba66730991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464698Reviewed-by:
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I9d36850098c4b08e7cd406a0269e03a04ee05a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463090 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5fa8ec27e929..df42b9a729b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: Ib3c09adec12b6208004683b994079130ccc7d211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816482}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602546992-4541e834d35741f8358d6360b79d19523776e3ad.profdata to chrome-mac-master-1602567235-69e1809554df433714edde9ed60539d7ae5c84b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib32f5dce8d4a14ecb485dfbfb2032ad04e66d713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464699Reviewed-by:
-
Ben Reich authored
This is a reland of c67306a2, which was reverted due to to uninitialized variable MSAN error. That was fixed on CL:2466572; re-landing the original change c67306a2 therefore. . Original change's description: > [filesapp] Add a browser_test for DevToolsListener class > > Test that JS code coverage of a JS IFFE injected in a WebContents gets > collected by DevToolsListener and stored in a ScopedTempDir. > > Test: browser_tests --gtest_filter="*DevToolsListener*" > Bug: 1113941 > Change-Id: I8f04f2e704d677823ffa154272605798b7046f77 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461602 > Commit-Queue: Ben Reich <benreich@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816064} Bug: 1113941 Change-Id: I491101bbe9a8cf050ddfe39842a3f0bd4fb2ec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467165Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c6903a455df..df6b7298bb41 2020-10-13 cclao@google.com Vulkan: Use StoreOp_None_QCOM for read only depth stencil buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Iee16f2105cf3d71b72a8255bb91d5238f26ecd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464695Reviewed-by:
-
Alexander Cooper authored
The Oculus runtime is no longer considered for selecting an appropriate VR Runtime, as our plan is to unify behind OpenXR as the single, supported runtime. This removes the unused Oculus runtime. Fixed: 1121625 Change-Id: I327619423e7a3d6c160a176dffca1354515af4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435722 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816478}
-
Peter Marshall authored
Feature CL: http://crrev.com/c/2443620 Enable CL: http://crrev.com/c/2454085 Bug: 1127827 Change-Id: Ic7ad3ce77c222163794dd3173d046fa3fe6a8a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454721 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816477}
-
Ilya Sherman authored
The top-level histograms.xml file is deprecated. This change * Ensures that `set noparent` applies for all CLs that update histograms. * Cleans up cruft from the //tools/metrics/histograms/OWNERS file. * Leaves cthomp@ as a general metrics reviewer. * Removes all other general metrics reviewers (see below). Note that I have only included cthomp@ as a non-Metrics-team reviewer in this new file. If you were previously listed as a metrics reviewer and wish to continue to be a metrics reviewer, feel free to send a CL re-adding yourself -- typically to one or several relevant subdirectories' OWNERS files, but it's also fine to add yourself as an owner for the entire histograms_xml directory if you prefer. If you were not previously trained as a metrics reviewer but would like to take on stewardship for some metrics reviews, please reach out to the Metrics team. We'll be more than happy to get you onboarded! R=sweilun Fixed: 1133371a Change-Id: I2d3207e74114eead80dc753c5e9f4aa81785ec99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462166 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816476}
-
Fredrik Söderqvist authored
Use StyleDifference::BlendModeChanged() to check for changes. The initial isolation notification will be handled by the AddChild() on the container. Switch the call to IsBlendingAllowed() to a more targeted call (or no call at all). drop that from LayoutSVGModelObject. LayoutObject: :SetStyle() already marks paint properties for updating, so Change-Id: I2d43d6b314509db0881003809375aaf0d8f3a292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463829Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#816475}
-
Peter Marshall authored
Frontend CL: http://crrev.com/c/2456592 Enable CL: http://crrev.com/c/2462084 Bug: 1136848 Change-Id: I8e76d0c7d0708c5467046b6a7c0bae713abf4bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461340Reviewed-by:
-
Joey Arhar authored
This patch rolls libxml from e4fb36841800038c289997432ca547c9bfef9db1 to 0b3c64d9f2f3e9ce1a98d8f19ee7a763c87e27d5 add-missing-ifdef-in-xml-reader.patch was merged upstream. add-fuzz-target.patch was added in order to prevent autoreconf failure on mac. config.h was generated in a different spot than the script looks for on my windows machine, so I changed the path for it. Bug: 934413 Change-Id: I8ddbdd9b36210942730b6b3b78051cff0c17d125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444429 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Exclude chrome/chrome_cleaner/ from the rewrite as it does not ship with the Chrome binary. Bug: 1080832 Change-Id: I0a1975e2e157155d9808bc9e2715e360e2057ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467041Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
There's no need to differentiate between blocking and non-blocking types in the sync codebase anymore (more details in the linked bug), so: - NonBlockingTypeCommitContribution is renamed to CommitContributionImpl - NonBlockingTypeDebugInfoEmitter is merged with its base class Bug: 1103583 Change-Id: I8b97b0117474d92df964ba8b322090155a8743d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466100Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#816471}
-
Yuki Shiino authored
Implements the same features of V8DOMConfiguration as a new class IDLMemberInstaller with refactoring and clean-up. V8DOMConfiguration remains unchanged in order to make the old bindings generator workable as much as possible. IDLMemberInstaller gets rid of old and unnecessary burden, and the APK size will be reduced by 30 KBytes. IDL constants of origin trial features are removed because 1) It's not used in production, it's used only in testing. 2) IDL constants themselves are (a sort of) obsolete. Overall, it's unlikely that we'll need IDL constants of origin trial features. Bug: 839389 Change-Id: I7bd876c779542c4889edbec6d9f6d4150e0bfec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448570 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#816470}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2455947 and crrev.com/c/2463043. The remaining GetAllocatedSize() was still ambiguous, returning two different things only one of which could be considered "allocated size". Furthermore, naming of function params and local variables wasn't always clear. This is an attempt to make the terminology consistent: - requested_size - what the app requested - extras - PA-internal data surrounding the allocated data, like tag/ref-count (for CheckedPtr) or cookies (debug only) - raw_size - requested_size + extras - usable_size (>=requested_size) - in case of over-allocation, this is what's available for the app (no risk of overriding extras, etc.) - utilized_slot_size - contiguous region of the slot that accommodates all of the above (requested allocation, additional usable space and extras); equal to raw_size if it's possible to save it in meta-data (for large allocations only), slot_size otherwise Change-Id: Ia2a771af6d29261b049b0dc98fede6395dc7a35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462909 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Josiah K authored
Plumb through active-descendant focus-following for full-screen magnifier in Chrome OS. Bug: 1131153 Change-Id: I8bc79096768449a231221cd8f354f80c966033a9 AX-Relnotes: Adds Magnifier support for active-descendant focus-following Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440763 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816468}
-
Yuki Shiino authored
Enables the new bindings of IDL callback functions and IDL callback interfaces. No behavioral change, but reduces the APK size by 7 KBytes. Bug: 839389 Change-Id: I8281c922ac310a277954bf35864fc85c7bb9932b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370682 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Updates a few chrome/browser/ui/views/profiles/* classes for compatibility with ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ie11779eebf17c6a8dc93eb5ad88279112faa9836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461315 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816466}
-
rajendrant authored
This is a reland of 0716d3fb The failing test ran fine 100+ times in linux. Could not repro the Mac failures, but I am removing the failing expect check. Original change's description: > LiteVideo: Stop throttling on playback seek events > > This plumbs the playback seek event from renderer to browser and uses it > to stop litevideo throttling. The seek updates to browser are throttled > for performance reasons. > > Subsequent CL will change this to stop throttling only after k seek > events (finchable), and record this in UKM. > > Bug: 1134672 > Change-Id: Idd88819e8ae50ffbc215197a437bf87d6fa9a36a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453801 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815787} TBR=mcrouse@chromium.org,dalecurtis@chromium.org,kinuko@chromium.org Bug: 1134672 Change-Id: Ic75af0f84e35515ae6fde3c2c44b9da782751d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467014Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#816465}
-
Han Leon authored
Ensure PowerMonitorTest:: data members all be accessed only on the UI thread. Bug: 1127374, 1126315 Change-Id: I9c41bb7c4cd451f84732b128f80e14db40d6bcaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465190Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#816464}
-
Colin Blundell authored
WebLayer does not use //components/history and does not want to take a dep on the (large) component, as every dep that WebLayer adds has an impact on WebView. SubresourceFilterContentSettingsManager, however, currently depends on //components/history for its optional observance of the user's deletion of URLs from history. This CL prepares for abstraction of that dependency by having SubresourceFilterContentSettingsManager::OnURLsDeleted() operate on new public APIs of ContentSettingsManager for deleting site metadata. A followup CL will then do the following: - Add the ability for SubresourceFilterProfileContext to store opaque embedder data (via a simple SubresourceFilterProfileContext::EmbedderData interface) - Move the history observance to a new SubresourceFilterHistoryObserver class that is an EmbedderData and takes in a SubresourceFilterContentSettingsManager instance to call into - Have SubresourceFilterProfileContextFactory create SubresourceFilterHistoryObserver to be stored by SubresourceFilterProfileContext instances In this way, WebLayer will be able to use SubresourceFilterProfileContext, AdsInterventionManager, and SubresourceFilterContentSettingsManager without taking on the //components/history dep. Bug: 1116095 Change-Id: Icf20e19722ce4b728645b157d513194cbfefec6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464264Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#816463}
-
Milica Selakovic authored
Autofill assistant is using text selectors that are based on innerText. If translation is presented, it breaks these selectors. So while assistant is running we are disabling translation and enabling it back when assistant finishes run. Bug: 1133783 Change-Id: Ia975a6081625a54183a1bf5ae4b1fcb470b54202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453289Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816462}
-
Kent Tamura authored
This fixes a crash in the following test with LayoutNGTextArea flag: - virtual/layout_ng_block_frag/fast/multicol/textarea-with-placeholder-as-multicol-crash.html This CL has no behavior changes. Regardless of LayoutNGTextArea flag, 'column-count' property doesn't affect <textarea> behavior. Bug: 1040826 Change-Id: Ia66834f8beb8bd0b5df843f5302df2d0ad57d2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467045 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816461}
-
