- 01 Oct, 2020 40 commits
-
-
Melissa Zhang authored
Bug: 1126788 Change-Id: I8c632beddf21fa93740c6a4e76b6d385c940530f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439998Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812510}
-
My Nguyen authored
OOBE is currently using different strings from the normal input method name because it doesn't have the word "keyboard". New naming proposal removes the word "keyboard" and makes the input method name shorter so just use this name directly. Proposal: http://go/cros-input-methods-naming Actual naming: http://go/cros-input-methos Current view: http://screen/4UT5edhYkbXH3yK New view: http://screen/6qGjXzgeMdM42su Bug: 889763 Change-Id: I4a6e54e4f638cf90fccb78b91b30309e855504c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438085Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812509}
-
Omid Tourzan authored
Add SinglePartitionFormat method to cros-disk client. It supposed to remove all existing partition on the disk, create a new one and format it. It tracks pending partitioning disks to prevent auto-mounting when partitioning finished, otherwise there will be conflict between auto-mount (initiated by kernel reread partition table) and format flow. The key to get device path of newly created partition is storage device path that is identical with parent device. Bug: 491043 Change-Id: I026e72dc499a55bb99f2e5f7bf5707f08c4fb393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340347Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812508}
-
Gordon Seto authored
Screenshots: Before: LTE: https://screenshot.googleplex.com/4sww2RRHRW8XxQN.png LTE+: https://screenshot.googleplex.com/8nxVo878HfHDL76.png After: LTE: https://screenshot.googleplex.com/54ow93Nv38bvwVt.png LTE+: https://screenshot.googleplex.com/UTLF9UzawWFjd6m.png Bug: 1099787 Change-Id: I921c7a7a26ee8fb71990f193995898f68e7cd9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441661Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#812507}
-
Yicheng Li authored
The metric is removed in http://crrev/c/2438770. Mark it as obsolete. Bug: b:169082568 Change-Id: I844790fd1139aa101726dfce8e28491fffe140ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438878 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812506}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I72affaa04d0601fcb6e9fea94807e55f29061faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441735Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812505}
-
tby authored
We watch for an app update to the settings SWA that marks it as kReady, and then request the app's icon to use for search results. However when the app is reinstalled, the icon can change but readiness stays at kReady, and so we miss the icon update. This CL adds a check for IconKeyChanged(), and also updates the icon in that case. This CL also disables the provider when the Settings app hasn't been marked as ready, as results won't be very useful before then. Change-Id: I8b5eaa5c5998fd551d3da41f068eb098aac51b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437677Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This change implements automatic reading behavior for the ChromeVox tutorial. This change implements the following: 1. When an interactive lesson is shown, read the lesson title. This is needed because we focus the text content for these lessons. 2. When a non-interactive lesson is shown, read the lesson contents. 3. Refactor requestSpeech() to pass queuemode and properties for more control over speech behavior. 4. Add @suppresss statements to a few functions. This allows us to reference the panel window without triggering closure errors. Automated tests are included confirm bullets 1 and 2. Fixed: 1129194 Change-Id: I2ce38fc0228bce749033f4effac4b79846dd696f AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414776 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812503}
-
Charlie Hu authored
Image policies used to be feature poilcy and the only way to specify feature policy is by specifying 'allow' attribute on iframe. The tests were set up with subframes holding the test content while the main frame specifies the policy. With image policies migrated to document policy which uses HTTP header to specify policy, there is no reason to split the test content to subframe right now. This CL moves test content to main frame for image policy tests. Change-Id: Idf95c84d27fafbdb5fa926fefacfbcf1b913b7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414561 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#812502}
-
Daniel Classon authored
Removes UserActionRecorder as an inherited class of the Per Session tracker in preparation for an update to the UserActionRecorder class. Bug: 1133553 Change-Id: I769e1723a107d4a6a0e32698068fa8a7cc34026f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440307 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812501}
-
Karandeep Bhatia authored
Change it to accept a dictionary instead of individual arguments for better future compatibility. Note that this is a breaking change but we'll reach out to the current users to make sure that they update their extensions. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1131746 No-Presubmit: True Change-Id: Ia9e26e0f0da1694263b27a0d2aeff26562fce228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428300 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812500}
-
Matt Reynolds authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. BUG=1018739 Change-Id: I1adee96b357e554979214b7d16f50576edcb8152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441659Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#812499}
-
Scott Little authored
The IPH will only be shown after the offline indicator finishes showing if the following conditions are met: - There is at least one item that would show up in Download Home, - The IPH has been shown less than twice already in the last year, - The user has not used Download Home in the last 90 days. Bug: 1068700 Change-Id: I2c5018b5d83b60ee2070902d986e9cacfde224f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411667Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#812498}
-
tby authored
This CL replaces the DriveQuickAccessProvider with the new DriveZeroStateProvider, and adds a deprecation todo to the former. If there are any issues with the new provider, this one CL can be reverted to disable the entire feature. Bug: 1034842 Change-Id: I6a82a948aa41301918d8a80368bfb5cda2303a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437996Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#812497}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/09a013c1993f..3c3e8905ad7e $ git log 09a013c19..3c3e8905a --date=short --no-merges --format='%ad %ae %s' 2020-09-30 fayang Deprecate gfe2_reloadable_flag_quic_no_silent_close_for_idle_timeout. 2020-09-29 bnc Add Huffman encoder benchmarks. 2020-09-29 danzh Fix some issues regarding quic TestPacketWriter changing its perspective. 2020-09-29 danzh Move TestPacketWriter from quic_connection_test.cc to quic_test_utils. 2020-09-28 renjietang deprecate gfe2_reloadable_flag_quic_remove_zombie_streams. 2020-09-28 nharper DLOG(INFO) early data reason on server handshake complete 2020-09-28 renjietang deprecate gfe2_reloadable_flag_quic_get_stream_information_from_stream_map. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I9a84ec9c9b9ad5687c3c3adf62a2735320137612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442029 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812496}
-
Maggie Cai authored
This CL removes the pref service from the app service. The clean up code is landed for a few milstones already. BUG=853604 Change-Id: I95659a1abfce2cf80e8a2b2b7b102bbf4c4c0f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438086Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812495}
-
Anna Malova authored
Bug: 1085115 Change-Id: I8846261a0f21ecb48692b70ab778f68996843760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414173Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#812494}
-
David Black authored
Screenshots should only be visible if we have screenshot items. Downloads should only be visible if we have download items. Recent files should only be visible if we screenshots and/or downloads. Bug: 1131253 Change-Id: I1bf70b6312c46cf5f7dbc616c5e33e7af0ad2740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434468 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812493}
-
Daniel Classon authored
Remove the base::Optional from the fn as well as the include statement. Bug: 1133553 Change-Id: Ia1e385de9716b3f54a9df8cb1f36426894303181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441529 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
John Z Wu authored
No clients are calling this method anymore. Change-Id: I02e9c8fc3ae6d5b8a6c2279984a153ed91bca357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442032Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812491}
-
John Z Wu authored
Clients of ios/web_view still go through the old name and expiration fixer flows. Change-Id: I9341d3155ab832f2927ac496964311645272b749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442031Reviewed-by:
-
Noel Gordon authored
PiexLoader has no |this| properties at all: it's a namespace with one API called load() effectively, so no need to instance it with new. Do the simpler thing: make it a namespace [1]. No change in behavior. [1] See CL:2437316 review comments for the namespace discussion. Bug: 1132695 Change-Id: I10319ede41bbaeb0caa0c8bab6ff4b7701ff3081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437319Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#812489}
-
Karandeep Bhatia authored
Change it to accept a dictionary instead of individual arguments for better future compatibility. Note that this is a breaking change but we'll reach out to the current users to make sure that they update their extensions. BUG=1131746 No-Presubmit: True Change-Id: I22c081d5bb0b817922bb9549854031dd0a447968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427866 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38d35cad..c4be5db9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I73754f7a7c278d0a97bf28142a93a405ea904023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812487}
-
Eric Willigers authored
The promise returned by navigator.share() resolves if the share completes successfully, and rejects if the share is cancelled or otherwise unsuccessful. Spec: https://w3c.github.io/web-share/#share-method Builds on https://chromium-review.googlesource.com/c/chromium/src/+/2434078 Bug: 1126788 Change-Id: Ia2ae218bd9b6640bdac21fb84ed12956b17cdb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437552 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812486}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I75277596f245cd3cf19d6309f5d7c6ac6e8210b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812485}
-
Jiewei Qian authored
This reverts commit 7b3ea4c4. Reason for revert: Tests on linux-trusty-rel are failing Get error message: "Unrecognized option: -maxclients" when starting X server. Sample failing job: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/16372 Original change's description: > xvfb.py: explicitly specify -maxclients=512 > > When running ash_unittests on CloudTop instance, many tests would fail > with "Maximum number of clients reached" X11 error. This does not repro > on physical gLinux workstation though. Adding explicitly -maxclients > parameter to make it consistent across platforms. > > Bug: None > Test: Run testing/xvfb.py out/Release/ash_unittests > Change-Id: Iac41378470d87df4b5d8140b3ee03a9a93a8c5ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438577 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812336} TBR=dpranke@google.com,xiaohuic@chromium.org Change-Id: I814c0cec7a6b36eaf498838e5ecb27c3564d8ae6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440720Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812484}
-
Andrew Xu authored
This CL adds rounded corners to the images shown by the multipaste menu. RoundedImageView, instead of layer, is used to achieve it. Because the multipaste menu's ancestors do not cut the children's layers outside of the multipaste menu's container bounds. Meanwhile we have no control on the context menu view hierarchy. This CL does two things: (1) Move rounded_image_view.h and rounded_image_view.cc under ash/public/cpp (2) RoundedImageView replaces ImageView in ClipboardHistoryBitmapItemView Bug: 1133020 Change-Id: Ib56466cfa574410cc83c7f5a125416a27dcabd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436769 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812483}
-
Scott Violet authored
Necessary as behavior landed in 86. BUG=1127518 TEST=test only change TBR=jam@chromium.org Change-Id: Id7706fcd19329e4975a1ef7b358ee9d1aec8cb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441931Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812482}
-
Kartik Hegde authored
To call utility functions more clearly, wrap them in a "util" namespace. TEST=unit_tests --gtest_filter=NetworkDiagnosticsUtilTest* BUG=chromium:956783 Change-Id: I2874dbdbda7fe84c04f7484c876845d75f99f928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438757Reviewed-by:
-
Matthew Mourgos authored
This change adds an announcement which occurs when focusing a shelf item with a notification badge. Also, this change updates the notification badge announcement string for items in the launcher. Bug: 1126492 Change-Id: If4fb6fe203bf3aa5984e9811c407224cf40044e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427021 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
-
mwakizaka authored
Previously adb uses a random port number for forwarding devtools port to Android device. It makes difficult to filter packages based on port number. Now we can specify the port number via chromeOption. Bug: chromedriver:3598 Change-Id: Ib8de0b3abfc7f5c66898739314d552c85852680f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433746Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#812479}
-
Matthew Denton authored
For USER_NOTIF support in the syscall broker, the broker will need to send two fds to the CLONE_FILES process (temporary IPC socket for reply, and the newly opened FD). The current BrokerSimpleMessage only supports sending and receiving a single FD, so this CL adds support for async-signal-safe sending/receiving of multiple FDs. Bug: 1117351 Change-Id: I708f200b047857816a9c2958535a360811e25741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412761Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#812478}
-
Mark Schillaci authored
This CL updates the behavior of ListBox on Android. With this change, the state of a Listbox ("x items") will now be read during swipe navigation when a node is initially selected. For ListBoxItem, the state of the item will read as "in list, item x of y". We append the state of the ListBox or items in the stateDescription element of the node's corresponding AccessibilityNodeInfo object. This CL also updates associated unit test expectations. AX-Relnotes: ListBoxes and ListBoxItems now explicitly announce their count and item index. Bug: 1101656 Change-Id: I41bf46d2f11ea9fb0c744ccd3802855c028ecb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436382 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:Mark Schillaci <mschillaci@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812477}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e92e2156. With Chromium commits locally applied on WPT: 09255d96 "[client-hints] Test client hint availability in service workers" 678dd97f "Revert "[client-hints] Test client hint availability in service workers"" c47ff7fb "[COOP] access reporting: openeeURL, openerURL, otherDocumentURL" af91c973 "Move the default framebuffer scale off of VRDisplayInfo" 432af8c1 "FontAccess: Replace Sticky Activation with Page Visibility check" 2a639e51 "[css-grid] Test for % max-height of image grid items" 98314cbf "[AspectRatio] Fix flex-aspect-ratio-01{3,4} tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id783ecddfdf2cd178773c5eff8995dc49b0edafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440291Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812476}
-
Anastasia Helfinstein authored
This is a pure refactor. AX-Relnotes: n/a. Bug: None. Change-Id: I6fab3b1663a7f4f8e2b2bcfe8d9b373f9c820ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382398Reviewed-by:
-
Xida Chen authored
TBR=qjw@chromium.org NOTRY=true Bug: 1133821 Change-Id: I12e6a29f930b2106aa9306f9f136e3460a975d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442151Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812474}
-
Khushal Sagar authored
This was added as a smoke test while OOPR was still under development. The feature has now been enabled by default and is used by all accelerated rendering tests. So this test is not necessary anymore. R=avi@chromium.org Bug: 757605,1067662 Change-Id: I6d9ab38d7e7291b645dac56b31cba4d79ee31155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441676 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jian Li authored
This reverts commit 4f97ffeb. Reason for revert: suspect of causing a lot of NTP test failures. Please see https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8867 Original change's description: > [ntp][modules] Add info dialog to shopping module > > Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM > > Fixed: 1130862 > Change-Id: Ied56500f9384fc9bedc15eef4cb8ffcde4830b5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437473 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812227} TBR=mahmadi@chromium.org,tiborg@chromium.org Change-Id: I95a99407b60c89e7640a0e58055f05299c582c0c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442170Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812472}
-
Jimmy Gong authored
PhoneStatusProcessor is responsible for converting incoming proto messages to PhoneHub objects and have clients be notified of the incoming changes. Bug: 1106937 Test: unittest Change-Id: Ib22c626ccd7c571692ae8c687935243a948c0581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427107 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
