- 10 Jul, 2019 14 commits
-
-
Jack Steinberg authored
alongside test scaffolding for future action testing. BUG=972945 Change-Id: I852f3aa0603e87e8cb6c66e47837512b88ec0193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682474 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#675883}
-
Sky Malice authored
Bug: 977713 Change-Id: I7735da146baf9661bc3a750109bd489d4856945e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693553Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#675882}
-
Giovanni Ortuño Urquidi authored
Before we only had tests for the old names. Bug: 968369 Change-Id: Id6296bc490c9eb87c1ae5446817d1408274dc52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692184Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#675881}
-
Jun Cai authored
This CL fixes invalid use of std::move() in network_hints_message_filter.cc by replacing it with std::unique_ptr::reset(). Bug: 981366 Change-Id: Ib5168dbe68d9e74417e0fb27474ec891605e5357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693947Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#675880}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/13c48a77..ffcc6abe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I583c08c3f33ba13985f469062c5c78ddf34317d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692157Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675879}
-
Chris Blume authored
This CL adds a Vulkan GPU Pixel Test configuration to the Pixel 2 bot. Bug: 969864 Change-Id: I07a62d343b486a6e93a38f8b208883a85db0e615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668467Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#675878}
-
Kristi Park authored
Use var for dark mode dialog background color and drop shadow. Change-Id: I31a4821966456d13b1d433b5999d182e1781922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692331 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675877}
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId - hidden upon visibility change introduced by aria-hidden and visibility:hidden, accompanied by associated browser dump tests. - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification Bug: 928949 Change-Id: I7808ba8fe352d515a054027217afc34892b38732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659970 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#675876}
-
Geoff Lang authored
Some of the expectations were not covering ANGLE/passthrough command decoder on Android. Broaden the flaky exepctations to cover all Android. TBR=kbr@chromium.org BUG=981579 BUG=834933 Change-Id: I859f2caace96cc7868c403a145165ede603f9619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692765Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#675875}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/123c46068daa..5cc5f6ebf601 git log 123c46068daa..5cc5f6ebf601 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 ntfschr@chromium.org Devil: support Q in SetWebViewFallbackLogic 2019-07-09 yrizk@chromium.org increase timeout for Oobe.isEnrollmentSuccessfullForTest Created with: gclient setdep -r src/third_party/catapult@5cc5f6ebf601 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948905,chromium:969629 TBR=sadrul@google.com Change-Id: If1bbfc9d8f55b8bb32d6d3f4d89cc31b3f063e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692336Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675874}
-
Liquan(Max) Gu authored
According to the spec (https://w3c.github.io/user-timing/#measure-method), UserTimingL3 API has the second argument being: optional (DOMString or PerformanceMeasureOptions) startOrMeasureOptions This indicates that the arg cannot distinguish between: 1. null 2. {} 3. undefined 4. { invalidDictProperty } According to the spec: 3.1.3 measure() method... 3. Compute start time as follows.. 4. Otherwise, let start time be 0. When these indistinguishable values are passed, they should be interpreted as start time being 0. Bug: 953840 Change-Id: I052a7823d9ae8b27056f53f04a26fcc93421db75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691862 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675873}
-
Daniel Murphy authored
This clarrifies the purpose of this layer, as previously it was easy to confuse it with the wrapped library, leveldb. Bug: 862456 Change-Id: I7589688d3c49c9725f05bb461fa823abf0961ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691244Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#675872}
-
Robbie McElrath authored
I can't reproduce flakes locally, so I'm going to re-enable them and see if we've fixed them in the last couple months. I also added additional assertions to the test so we'll get more information about why they fail if they do. Bug: 964338 Change-Id: I4a864101de6cfb1b434c3b2157d2323d8e6e522a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693704Reviewed-by:
-
Dominik Laskowski authored
The controller interface is a remnant from Mus. Bug: 929449 Test: Build Change-Id: Ia1cafc13fb404e7f80e31eafa9257acd7b8913d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686039 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#675870}
-
- 09 Jul, 2019 26 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b249c5420944..4876cb21c82f git log b249c5420944..4876cb21c82f --date=short --no-merges --format='%ad %ae %s' 2019-07-09 mbonadei@webrtc.org Revert "Fix collection of audio metrics from PC test framework for audio test" 2019-07-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2bc3837c..58be81bf (675350:675720) 2019-07-09 henrika@webrtc.org Enables usage of ChannelMixer in WebRTC's output mixer. Created with: gclient setdep -r src/third_party/webrtc@4876cb21c82f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I389fb715293b699002cb9572f5a11f98ba961bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692335Reviewed-by:
-
Kristyn Hamasaki authored
Control + R now allows for toggle of the debug rectangles in UI Devtools. Bug: 978100 Change-Id: I29f7c4d79b514de88a7594a48fc3cca6526f5346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673861Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#675868}
-
Caleb Rouleau authored
This should be committed after https://chromium-review.googlesource.com/c/catapult/+/1688194 is committed and rolls into Chromium and before committing https://chromium-review.googlesource.com/c/chromium/src/+/1687783 . This contains three changes: Shard map generation code is augmented to add 'abridged' option into every shard map. Eventually some benchmarks on some platforms will be reconfigured to not add that argument. run_performance_tests.py is taught to translate 'abridged': False into --run-full-story-set for the benchmark run. Since shard map generation would shuffle the benchmarks around, I wrote custom code to modify the shard maps myself as a one-time thing. Here is the code that I used to augment the shard_maps as a one-time thing: import collections import json import os def _DumpJson(data, output_path): with open(output_path, 'w') as output_file: json.dump(data, output_file, indent=4, separators=(',', ': ')) def main(): files = os.listdir('.') shard_map_files = [f for f in files if f.endswith('map.json')] for shard_map_file in shard_map_files: with open(shard_map_file, 'r') as fh: shard_map = json.load(fh, object_pairs_hook=collections.OrderedDict) for key in shard_map: if key != u'extra_infos': benchmarks = shard_map[key][u'benchmarks'] for b in benchmarks: benchmarks[b]['abridged'] = False _DumpJson(shard_map, shard_map_file) if __name__ == '__main__': main() Bug: 965158 Change-Id: Ia954394ecce5a512c88b62fe3534363dae179d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688532 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#675867}
-
Yue Li authored
The home button style used to depend on the Assistant user consent status, but that is no longer relevant to opt-out mode Assistant. Bug: None Test: No functional change Change-Id: I2af8bd8d7c64261ff1787e08bf114e39f8d6c76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693561 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#675866}
-
Mustaq Ahmed authored
With User Activation v2 (shipped in M72), multiple triggering in a event sequence is unnecessary: the activation state is not stack-scoped so triggering only on the first event in the sequence (mouseup here) still allows calling activation-gated-APIs on any follow-up event. Bug: 959850 Change-Id: I2eb61a853dd6d4f3f1247cb080ba3d85d50f1765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689825 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#675865}
-
Raymes Khoury authored
Recent MojoChannel changes may have fixed the flakiness. Bug: 980072, 913181 Change-Id: Icd92cf9094d5ffe7a6f1f2e5debf19ca0332a8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690053 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#675864}
-
Yuly Novikov authored
TBR=kbr Bug: 976471 Change-Id: I89a5376a8f362836f1049fe8fe07e264f7c5d350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692332Reviewed-by:
-
Ahmed Fakhry authored
This allows us prevent updating the visibility of the mirrored backdrop in the desk preview view based on changes in the source backdrop's layer visibility. BUG=978917 Change-Id: I98c80a7c697f61fff37a06aab377f157099ded17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693186Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#675862}
-
Kristi Park authored
Changes include: - Tile selection color darkened for Backgrounds and Color submenus. - Dark mode support added to submenu sidebar. - Dark mode support added to local background and default background tiles in Backgrounds submenu. Screenshots: http://screen/hE6jRaeXxhz.png http://screen/daVG9S8r7b1.png http://screen/a7FH96kYYnF.png http://screen/5ytaAPDr3KT.png Bug: 937570, 960982 Change-Id: I0f397be59363b378f262a6b79416765db7b0992f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691553 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert the implementation in the browser process (AuthenticatorImpl) as well as the client in the renderer process (CredentialManagerProxy), as well as the definition of the GetAuthenticator() in the interface blink.mojom.DocumentInterfaceBroker. Bug: 955171, 978694 Change-Id: I9aacbf7aad26a5d9538aa9b2a5fb40317cb75450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687536 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#675860}
-
Sinan Sahin authored
Bug: 971502 Change-Id: Iafb37d949abc1afca650e0bc28829ed953c8a7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691250 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#675859}
-
Abhishek Bhardwaj authored
This change refreshes policies when the update check timer expires. It adds this logic to the UpdateChecker class and refresh policies only after an update check is done. BUG=924762 TEST=Unit tests. Change-Id: I5a6b336761cbfba2d544e25a59505b8fb3edeade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661180 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#675858}
-
Axel Antoine authored
The PredictorFactory contains all the predictors names and types constants. The factory proposes two static methods: 1. A method to get a PredictorType when passing a predictor name 2. A method to get a unique instance of a predictor when passing a PredictorType Each predictor now returns the constant stored in the factory when calling GetName() Bug: 981147 Change-Id: Ib1069b069d8eb4fb45313aa4b9fbddd49f8bf84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688283Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Axel Antoine <axantoine@google.com> Cr-Commit-Position: refs/heads/master@{#675857}
-
Finnur Thorarinsson authored
Bug: 895776, 656015 Change-Id: Idbf6b76b8488824c6171d8d0e0b7ea971acb3919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692177Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#675856}
-
Steven Bennetts authored
networkState.connectionState is now an enum not a string, so !connectionState is no longer a valid test. Bug: 980659 Change-Id: I9ff24a063fc3bb847b995e48c374786f9b16e567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692495 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#675855}
-
Kyle Horimoto authored
Change-Id: Ic89d5de0cde54748da47d173389c561ee2d501bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693030 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#675854}
-
May Lippert authored
BUG=none Change-Id: Ia6ab9dc95b14d0e7d57a1091a481e568497b070d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693034 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#675853}
-
Brian Sheedy authored
Enables the Skia Gold version of the GPU pixel tests on all remaining bots that are running the non-Gold version. Specifically, enables it on Linux Debug (NVIDIA) Mac Release (Intel) Mac Debug (Intel) Android Release (Nexus 5X) Win10 Debug (NVIDIA) Linux Release Code Coverage (NVIDIA) Mac Retina Release (AMD) Linux Release (NVIDIA) Mac Retina Debug (AMD) Win10 Release (NVIDIA) Bug: 850107 Change-Id: I536574c11c3bc6ed32b65737d287864055b0e595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691304Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#675852}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/00142ad6d990..179cd3396152 git log 00142ad6d990..179cd3396152 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 andrewoverton@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@179cd3396152 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: Iff10326e43b0ca75efad1cc1af1fff8d78e87442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692732Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f697fe3b7dd2..27e67b5f9719 git log f697fe3b7dd2..27e67b5f9719 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 rharrison@chromium.org Rolling 4 dependencies 2019-07-09 cwallez@chromium.org Implement WebGPU formats on D3D12 2019-07-09 jiawei.shao@intel.com Metal: Move all the computation in buffer-texture copies to one function Created with: gclient setdep -r src/third_party/dawn@27e67b5f9719 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I5edc08ec22c29528600635c43e341db279d0c174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692333Reviewed-by:
-
Liquan(Max) Gu authored
LargestImagePaint handles both normal layout images and background images. Currently these two kinds of images are handled by two different functions. It poses a challenge for maintenance, as we need double effort in making change the handling logic. This CL combines the two. The main difference for the two kinds of images in LCP is that background image uses (node_id, cached_image) as the key for storage, whereas the normal image uses only node_id. It's based on the fact that we can use (node_id, cached_image) to identify normal image as well as background image. As a side effect, this change automatically solves crbug.com/965653, where the original version didn't handle the case where a layout image changed its src. A follow-up patch will correct the variable names. Bug: 965653, 972146 Change-Id: I33a7961c663b7a24b4116e23c4a2f1052c864ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692494Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#675849}
-
Oliver Hunt authored
Adding ambient-executable feature flag to component sandboxes as a preflight for restricting the use of replace_as_executable with an invalid handle. Bug: SEC-354 Change-Id: If23482218720e8024f054a7dafc3f4366d1db7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687945 Commit-Queue: Oliver Hunt <ojh@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#675848}
-
Jordy Greenblatt authored
http://crbug.com/982375: The callback onCloseMenu_() is only defined in the language page JavaScript file in CrOS and Windows however it is bound as a callback in the HTML file regardless of the OS, causing console warnings [1]. http://crbug.com/982390: Also, the private functions section of the language_page's JS [1] is complicated unnecessarily by OS specific blocks for the same conditions that are separated for no logical reason. The first patchset in this CL consolidates the OS specific blocks of complete private methods (i.e. fixes http://crbug.com/982390). The second patch set prevents the onCloseMenu_() callback from being bound unless the OS is CrOS or window (i.e. fixes http://crbug.com/982375). [1] https://imgur.com/a/O5IFCE4 Bug: 982375, 982390 Change-Id: Ic72e7f0e8e1d1680907b4ab8aa99b45f221e4575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693385Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#675847}
-
Robert Ogden authored
Bug: 977603 Change-Id: I659c9c6096c00ecdc73994860e30d51606447a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692497Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#675846}
-
Kehuang Li authored
This is the receiver side of Cast audio capture service that will observing platform audio input hoocked in assistant service. More info can be found in the design go/comms-virtual-mic. tests on desktop. Bug: internal: 133880006 Merge-With: eureka-internal/274195 Test: Make OTT call on Home after patching all CLs. Run and pass unit Change-Id: I662c77f4fae819ced791861ca5b762cdf08e8f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655085 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#675845}
-
Maksym Onufriienko authored
If tests run is interrupted(e.g. lost connection to testservice, test was stuck and no output for 3 mins and was killed then), xcodebuild_runner needs to parse test_output, collect passed tests and re-run test_bundle by filtering already passed tests (e.g. https://chromium-swarm.appspot.com/task?id=45c892feae862110). Removed _make_cmd_list_for_failed_tests because now tests will filter by passed tests for both cases when tests were interrupted and not. At the end of run also add a check whether all tests from test-bundle were executed and if not add 'not executed tests' record. Created the radar 'After primaryInstrumentsServerWithError xcodebuild did not finish its execution' https://feedbackassistant.apple.com/feedback/6476415 Bug: 979267 Change-Id: I596945e10bd8382c41487633456a3c80a3569419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680973Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#675844}
-
