GitLab

File name the same as in chrome/common/cloud_print/ failed some VS builds.

NOTRY=true

Review URL: https://codereview.chromium.org/55143012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/53313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232935 0039d316-1c4b-4281-b951-d872f2087c98

gesture.config_is_truthworthy is a temporary pref used to do a one-time
wipe of gesture prefs. Now, in order to remove it, we first need to
clear it from users' Preferences file. Next step would be to remove it
completely from code.

BUG=269292

Review URL: https://codereview.chromium.org/52363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232934 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12322: (dschuff) Build binutils with toolchain_build.py infrastructure
r12323: (stichnot) Add a --retries=<N> flag, for flaky test environments.
r12324: (dschuff) Add gyp_nacl.py to make gyp_nacl importable on python 2.6
r12325: (bradnelson) Incorporate gcc version string into toolchain_build platform string.
r12326: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS for SJLJ EH change
r12327: (dschuff) Revert "Build binutils with toolchain_build.py infrastructure"
r12328: (mseaborn) PNaCl: Update GCC revision in pnacl/DEPS for SJLJ EH change
r12329: (bsy) hook up pwrite/pread syscalls.  untrusted pwrite/pread test.
r12330: (sehr) Remove combreloc from configuration, to avoid an assertion failure in the dynamic loader
r12331: (jfb) Allow SPEC2k to be run unsandboxed with LLVM.
r12332: (stichnot) Update llvm_test_suite DEPS to get improved testsuite.
r12333: (sehr) Change build to use new binutils
r12334: (dschuff) Port PNaCl x86 main waterfall buildbots to buildbot_lib
r12335: (dschuff) Fix bot breakage in r12334 and remove obsolete PNaCl bots from buildbot_selector.py
r12336: (dschuff) Build binutils with toolchain_build.py infrastructure
r12337: (dschuff) Set some default configuration values in buildbot_lib's Context ctor
r12338: (dschuff) Use new format for PNaCl component revisions.
r12339: (dschuff) PNaCl FYI bot script: explicitly setup newlib nacl headers
r12340: (dschuff) Update TOOL_REVISIONS for PNaCl 12274->12331
r12341: (stichnot) Remove two ARM known failures.
r12342: (mark) Run strip via xcrun.
r12343: (mseaborn) pnacl-translate: Remove "-shared" and "-static" options
r12344: (dschuff) Remove obsolete bots from buildbot_selector.py
r12345: (dschuff) Fix buildbot_selector.py's disabling of gyp builds on some bots
r12346: (mseaborn) PNaCl: Add script for updating the Git revisions in pnacl/COMPONENT_REVISIONS
r12347: (dschuff) Fix pnacl COMPONENT_REVISIONS to match what was in DEPS in r12337
r12348: (mseaborn) PNaCl: Remove some tests' uses of "-nostdlib" in TRANSLATEFLAGS
r12349: (mcgrathr) Update binutils revision in tools/REVISIONS
r12350: (mseaborn) pnacl-ld: Remove "-shared" option and make "-rpath-link" a no-op
r12351: (mseaborn) PNaCl: Remove unused file, pnacl/scripts/libgcc-glibc.mvars
r12352: (mseaborn) pnacl-clang: Remove "-shared" and "-dynamic" options

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/45763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232933 0039d316-1c4b-4281-b951-d872f2087c98

This improves decode performance of VP9 input encoded with tiling enabled.  Each 
tile must be at least 256 pixels wide. The number of tile columns are log2. So encoded
files can have 1, 2, 4, 8, 16 tile columns. E.g. 1920x1080 files can have up to 4
encoded tile columns. Tile rows do not matter for decode performance.

Specifically, any system with multiple cores and/or hyper threading will
benefit from this change.

On desktop 1080p decode speed is roughly 1.5-2x with this change. For example, 
on the low end of the results from the test set used to produce these numbers 
an average increase is from 82 frames/second to 163 frames/second.

This holds on Android devices as well, with the same clip on a Nexus 7 going
from 14 frames/second to 25. Chrome OS shows similar gains. This puts some 1080p 
in the playable range and gives 720p more clearance.

Review URL: https://codereview.chromium.org/55213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232932 0039d316-1c4b-4281-b951-d872f2087c98

Some context: Chrome OS Guest mode is incognito mode and user extensions are
disabled but we have couple component extensions that work in Guest mode.
QuickOffice is one of them. It uses incognito split mode and runs in incognito
profile. CanCrossIncognito returns false if extension runs in not split mode.
Therefore include_incognito is false. But in general there is no problem
if chrome.windows.create return incognito window if extension itself already
works in incognito mode.

BUG=313789
TEST=manual

Review URL: https://codereview.chromium.org/49463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232931 0039d316-1c4b-4281-b951-d872f2087c98

Avoiding the DRM prefix such that it isn't confused with Digital Rights
Management.

BUG=

Review URL: https://codereview.chromium.org/49303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232930 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative fix for the crash:
https://crash-old.corp.google.com/reportdetail?reportid=4897b184b09b23c8#crashing_thread

My hypothesis is that the request is released while there is a pending call to DidWriteBuffer().
The request was maybe released because
- the fetch was stopped or cancelled
- or ReleaseRequest() was called in OnReadCompleted


BUG=308626, 314241

Review URL: https://codereview.chromium.org/46573008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232929 0039d316-1c4b-4281-b951-d872f2087c98

If a username field is prefilled, make sure to check all possible usernames
to see if we can fill instead of only filling with the preferred username if
it matches.

BUG=309817
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/56653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232928 0039d316-1c4b-4281-b951-d872f2087c98

Causing 30-50% rate failure in slave* trybots.  I'm sorry Julien. :-\

> Linux: add a Credentials class to handle Linux capabilities.
> 
> (This is a re-land of https://chromiumcodereview.appspot.com/51113009/)
> 
> BUG=312380
> TBR=jorgelo@chromium.org
> 
> Review URL: https://codereview.chromium.org/58693002

TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/59073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=312841
TEST=None
R=avi@chromium.org, bbudge@chromium.org, joi@chromium.org, wjia@chromium.org

Review URL: https://codereview.chromium.org/48743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232926 0039d316-1c4b-4281-b951-d872f2087c98

This is a test for the Blink change:
https://codereview.chromium.org/54373013/

BUG=264959

Review URL: https://codereview.chromium.org/55763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232923 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up fix for https://codereview.chromium.org/46583005/
(Send Allow{Database,FileSystem,IndexedDB} sync IPCs
directly from worker threads)

I needed to default behavior to allow storage access when NULL proxy
is returned to make content_shell work, and therefore needed not to
return NULL when origin.isUnique()==true case.

BUG=none
R=jam,michaeln
TBR=jam

Review URL: https://codereview.chromium.org/55433006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232922 0039d316-1c4b-4281-b951-d872f2087c98

In order to set |wasClean| property of CloseEvent and show the failure message
correctly, The blink-side WebSocket need to know whether the connection
is dropped because of a server request.

Blink side change is: https://codereview.chromium.org/36033003/
BUG=310405

Review URL: https://codereview.chromium.org/34753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232921 0039d316-1c4b-4281-b951-d872f2087c98

When completing prefetch for multiple streams, if more than one stream has
|kConfigChanged| next, then the calls to DecodeMoreAudio() and
DecodeMoreVideo() need to allow possibility that
|CONFIG_CHANGE_EVENT_PENDING| is already set by the other stream.
Also includes a new unit test for this scenario.

R=qinmin@chromium.org,acolwell@chromium.org,xhwang@chromium.org
BUG=314170
TEST=All media_unittests pass on Android with MediaCodecBridge available.

Review URL: https://codereview.chromium.org/50433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232920 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025

Review URL: https://codereview.chromium.org/53533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232917 0039d316-1c4b-4281-b951-d872f2087c98

DevToolsManagerTest was forcing a process swap using
ShouldSwapProcessesForNavigation, but this was unnecessary since the
navigation was cross-site anyway.  Removing the extra code so that it doesn't
force an unnecessary swap on the first navigation.

BUG=123007
TEST=DevToolsManagerTest.ReattachOnCancelPendingNavigation

Review URL: https://codereview.chromium.org/53293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=301920
TBR=mattm@chromium.org

Review URL: https://codereview.chromium.org/58953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232914 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232912 0039d316-1c4b-4281-b951-d872f2087c98

The blink_perf.web_animations benchmark was disabled in
https://codereview.chromium.org/48793006.
These Web Animation perf tests no longer crash and can be re-enabled to
be run by the perf bots.

NOTRY=TRUE
BUG=309981

Review URL: https://codereview.chromium.org/55363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232910 0039d316-1c4b-4281-b951-d872f2087c98

When throttling, either when paused or when in background, only throttle
fallback tick. There are apps relying on the fact that invalidates are
not throttled when paused. When in background, framework should take
care of not calling back with draw for invalidates.

Internal bug b/11230312

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/58483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232909 0039d316-1c4b-4281-b951-d872f2087c98

Get statistics on how often OnCloseWebContentsDeleter would have showed a
dialog, presumably for onbeforeunload, just to see how often this actually
occurs.

BUG=304932

Review URL: https://codereview.chromium.org/58053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232908 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/57933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232907 0039d316-1c4b-4281-b951-d872f2087c98

EnableZygote exposes an implementation detail. The utility process
already has a DisableSandbox method, and a SetExposedDir method
that we can use to disable the zygote.

BUG=None
TEST=browser_tests, launch Chrome and install an extension.

Review URL: https://codereview.chromium.org/55133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232906 0039d316-1c4b-4281-b951-d872f2087c98

Currently the RulesRegistry may be marked as ready on a different thread
than the owner thread which can be racy and fails an assert in debug
builds.

BUG=312461
TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/57933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232905 0039d316-1c4b-4281-b951-d872f2087c98

Reland of https://codereview.chromium.org/52983004/ which failed due to
timeouts on Windows XP.

Part of moving ExtensionProcessManager to src/extensions.
* Introduce more test coverage
* Convert most usage of Profile to BrowserContext
* Separate out "master" vs. incognito profiles/contexts
* Move switches into extensions/common/switches.h

BUG=313481
TEST=unit_tests ExtensionProcessManager* and browser_tests ExtensionProcessManager*
TBR=miket@chromium.org

Review URL: https://codereview.chromium.org/57813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232904 0039d316-1c4b-4281-b951-d872f2087c98

r232635 landed the histograms, but forgot to populate the data
submitted from GetLastChangeCount().

BUG=240396
NOTRY=True

Review URL: https://codereview.chromium.org/57463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/57463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232902 0039d316-1c4b-4281-b951-d872f2087c98

This will be necessary for an upcoming change to make the infobar update the
ShortcutsBackend when the user clicks the link.

BUG=151044
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/58553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232901 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up CL of r185433, which mistook |message| for |wparam|.
With this CL, base::PowerMonitor and base::PowerObserver become
functional again on Windows.

BUG=314477, 149059
TEST=manually done with a debugger (by disconnecting the power supply cable)

Review URL: https://codereview.chromium.org/57383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232900 0039d316-1c4b-4281-b951-d872f2087c98

This hasn't been touched in substantive ways since it was added 3.5 years ago
(https://codereview.chromium.org/1515006/) and appears to be unused.

(I'm removing some infra bits that look related in
https://codereview.chromium.org/49503007/)

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/57373008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232899 0039d316-1c4b-4281-b951-d872f2087c98

ChromeOS windows are transparent by default. This allows the window header to be transparent when there is only one window on screen. This CL fixes a case where we were clobbering the window's default opacity.

BUG=312441
TEST=See bug

Review URL: https://codereview.chromium.org/56623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232898 0039d316-1c4b-4281-b951-d872f2087c98

Ensures that any valid invocation of ConfigureVideoDecoderJob with a
pending surface change event causes the job to be reset and the
surface change event cleared immediately, or after a possible browser seek.
Also changes call from ConfigureVideoDecoderJob() to |manager_|->OnMediaMetaDataChanged() to only occur if new job was created.

BUG=313470
R=xhwang@chromium.org,qinmin@chromium.org,acolwell@chromium.org
TEST=all media_unittests pass on Android with MediaCodecBridge available and the new test fails prior to patching MSP

Review URL: https://codereview.chromium.org/53413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308664

Review URL: https://codereview.chromium.org/56383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305643
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/56123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314745

Review URL: https://codereview.chromium.org/55223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232894 0039d316-1c4b-4281-b951-d872f2087c98

This is step 1 of 4 in deleting FrameLoader::m_suppressOpenerInNewFrame, which
shouldn't need to be a class variable.

BUG=314177

Review URL: https://codereview.chromium.org/54983012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232893 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an unittest framework for JavaScript components. In addition, this also adds an unit test of NavigationListModel using the framework.

BUG=309946
TEST=browser_test passes
R=hashimoto@chromium.org, mtomasz@chromium.org

Review URL: https://codereview.chromium.org/48623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232892 0039d316-1c4b-4281-b951-d872f2087c98

Views currently only supports point-based event targeting,
meaning that the center point is the only location used
when determining the target of a touch region. This can
lead to a poor experience for touchscreen users because
a touch can overlap many more possible targets than a
mouse cursor and it is difficult to ensure that the center
of the touch region is over the intended target (especially
if that target is small, such as the tab close button).

The goal of this patch is to add support for rect-based
event targeting ("touch fuzzing") by using a heuristic
to determine the most probable target of a rectangular
region.

This heuristic is implemented in
View::GetEventHandlerForRect() by recursively looking for
targets among the descendants of |this| which the
touch region overlaps by at least 60% (and then returning
the one that is closest to the location of the touch). If
no such targets exist, instead return the target that would
have been returned if point-based event targeting were
used with the center point of the touch. The idea behind
this approach is that small targets are more difficult to
touch reliably than large targets, so small targets
should get priority when determining the most probable
target of a touch.

In this patch, all of the overrides of
View::GetEventHandlerForRect() (formerly
View::GetEventHandlerForPoint()) simply call
View::GetEventHandlerForPoint() directly if rect-based
event targeting is to be used. The two exceptions are
NotificationView and AutofillDialogViews::SectionContainer,
for which I have preserved the existing point-based
behavior for the time being (and have added TODOs to
implement rect-based targeting in a follow up patch).

BUG=129794,131208
TEST=ViewTest.GetEventHandlerForRect
R=sky@chromium.org

Review URL: https://codereview.chromium.org/22891016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232891 0039d316-1c4b-4281-b951-d872f2087c98