GitLab

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=mek@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: Ie172f571ab430c800b6476186e82917743f46afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895638
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711776}

- Set/reset focus while opening/closing the popup dialog.
- Use cr-dialog instead of popup-overlay to trap the focus.
- Adjust the popup dialog with according to the oobe dialog.

Bug: b/142957550, 962415
Test: Manual Test
Change-Id: I96fcc1bb713c4fb1c40bf3622dffaa5131fc45ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893825Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711775}

According to go/unicros-extensions-dd, we need to keep track of which
extensions have received parental approval. This dictionary will map
extension ids to the approved version. These extensions are safe for
child users to install and enable. Deprecate global preference
profile.managed.approved_extensions for legacy supervised users as
well.

Bug: 1014700
Change-Id: Ida8fdde0f264d42e5b101a0b3057c9866fd78d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864516Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711774}

IWYU. This fixes the libstdc++ build after commit 135dadb4 ("Encapsulate
addrinfo in RAII type"):

In file included from ../../net/dns/address_info.cc:5:
../../net/dns/address_info.h:56:12: error: no template named 'unique_ptr' in namespace 'std'
      std::unique_ptr<AddrInfoGetter> getter = nullptr);
      ~~~~~^
../../net/dns/address_info.h:73:34: error: no template named 'unique_ptr' in namespace 'std'
  AddressInfo(addrinfo* ai, std::unique_ptr<AddrInfoGetter> getter);
                            ~~~~~^
../../net/dns/address_info.h:77:8: error: no template named 'unique_ptr' in namespace 'std'
  std::unique_ptr<AddrInfoGetter> getter_;
  ~~~~~^

Bug: 957519
Change-Id: I81f3403ad4b0aee6dc815241b41814d528b867ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894000
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711773}

This was left over from r702570. I'll probably add it back next week
when reenabling this (hopefully for the last time), but best to clean it
up just in case.

Change-Id: Ic2b0b447ed6b88eade3585fe91076965e72e373f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895382
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711772}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/98f3379d14d4..e3c523e49ef5

git log 98f3379d14d4..e3c523e49ef5 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 seanabraham@chromium.org chromeos_config: restore chell and glados to being critical

Created with:
  gclient setdep -r src/third_party/chromite@e3c523e49ef5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I77c9b1fbaba7db83886ed3afbc5d423ebdda5f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894923Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711771}

This removes the 8 histograms
Cookie.{Age,AllAges}For{Secure,NonSecure}{SameSite,CrossSite}Request
and also the histogram Cookie.NetworkSecurity.

Fixed: 953145, 1000084, 918394, 982138

Bug: 993120, 953145, 1000084, 918394, 982138
Change-Id: I8aeff796bb7119caa99d62c5d277a635f9f33e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893958Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711770}

This CL temporarily disables a network search test. This test will
be rebaselined and re-enabled after
lands


https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592
Bug: 963183
Change-Id: I31be37367f553660e350516c6ddd588f9a3ea131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895737Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#711769}

Change-Id: Ifb157a184ba20ac9435659d91d11523503daa87e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893995
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711768}

This reverts commit ccf4d9f8.

Reason for revert: Relanding this on trunk

Original change's description:
> Disable renderer CIG temporarily.
> 
> This is to allow time for third party vendors who currently inject
> into Chrome renderer processes to update their software.
> 
> This will be re-enabled in a future release of Chrome.
> 
> BUG=750886
> 
> Change-Id: I081a44a39ff499b86d02a637cb56ce4b6ff2c17d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885226
> Reviewed-by: James Forshaw <forshaw@chromium.org>
> Commit-Queue: Will Harris <wfh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710148}

TBR=forshaw@chromium.org,wfh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 750886
Change-Id: Ic93018f5d02048c962f43bfa7c30825f03b9e705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895384Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711767}

This change modifies base::FilePath::StringType to be std::wstring on
Windows and updates affected code.

Bug: 911896
Change-Id: I243053a4e2117e3b4c5987a944aa8ea052c0d15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891192Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711766}

Various security checks on Web Authentication calls are performed both
in the renderer process immediately after the API call, and again in the
browser process.

Browser process checks are more resilient, so this CL starts the process
of removing the renderer process checks (initially on desktop only) and
plumbing back error codes to display useful developer console messages.

Bug: 827542
Change-Id: I848825acb5798950d55cd358fa773bcf50474fe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869074
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#711765}

This CL adds a few metrics for the general well-functioning of the
MultipartUploadRequest as it launches.

Bug: 1017334
Change-Id: Id80391de814cc19a752a1c3a655507cd639c882e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894183
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711764}

Splitview is not enabled when chromevox is, so the drag indicators
are not created.

Test: added tests
Bug: 1020440
Change-Id: I26f9c6e058784e13dd62da4a087682e2b86fbfd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894301
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711763}

Bug: 1019532
Change-Id: I9f1f9e23f27fd7771a03c10ca2deb733184b3a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894534Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711762}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=sky@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: Ie715f5d61b1b0233b4e26cdb5603225ea169659a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894887
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711761}

Crash is gone. Only the AudioClock CHECK seems to have been hit, but
that disappeared after M62 when we stopped shipping x86 on mac.

BUG=674856

Change-Id: I446f05ae659f0fa6622b5662f9f8e7ccd206c23f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894244
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711760}

Startup.FirstWebContents.NonEmptyPaint2 is a better indicator of startup
time as perceived by users.

Also, remove the suffix on Startup.FirstWebContents.FinishReason.
Since Startup.FirstWebContents.MainFrameLoad2 is no longer tracked, the
non-suffixed FinishReason is always for
Startup.FirstWebContents.NonEmptyPaint2 and the suffix does not provide
additional information.

Bug: 975113
Change-Id: I2ae72627e809d61e939ecb63f8a7a190ee72ffa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872316Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711759}

Bug: 1005931
Change-Id: Ie56ba62a695b9895fdd5b67ef9547aa8c59bc1fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893507
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711758}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9e349b7d76cd..ee0968eaa398

git log 9e349b7d76cd..ee0968eaa398 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 9856269+sarahM0@users.noreply.github.com Add spvcir unit test - OpCapability (#857)

Created with:
  gclient setdep -r src/third_party/shaderc/src@ee0968eaa398

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I115ab53fd230faaffd1bee0bb58ae5487bd9ccd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894925Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711757}

Bug: 1017800
Change-Id: Ie14cdc47e3cb0382ab59d31e085c8a0000be3d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894330
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711756}

https://skia.googlesource.com/skia.git/+log/2540704a38af..23e856f36982

git log 2540704a38af..23e856f36982 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 mtklein@google.com add GM for exercising interesting paths in SkVMBlitter
2019-11-01 mtklein@google.com try hashing shaders via their program
2019-11-01 brianosman@google.com Add BT2020 (non-constant-luminance) YUV color space
2019-11-01 brianosman@google.com Remove SK_LEGACY_YUV_MATRICES
2019-11-01 robertphillips@google.com Update GrTextureOp to use index buffer offsets for draws

Created with:
  gclient setdep -r src/third_party/skia@23e856f36982

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:960620
Change-Id: Icad24ee024f4e52ac01c8ca8215599c9a17a2d47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894922Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711755}

CastRender is the implementation of MojoRenderer for chromecast.
It needs to be informed with the video geometry information from
the display compositor. VideoGeometrySetter provides the IPC between
the CastRenderer and the display compositor so the video geometry
information can reach CastRenderer.

Bug:925450
Test: 1. Build with chromium/1749480, cast a youtube page. Use log to see
the IPC works. 2. Also cast a youtube page without said CL. 3. Internal CQ.

Change-Id: I4b13699cfc8c641611ca49471f3f7f44eb3a24b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799692Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711754}

This fixes a crash when building with _LIBCPP_DEBUG=0. The comparison
should also check pair_1.first.y() > pair_2.first.y() before moving on
to the x-coordinates.

gfx::Point already defines a comparision function which matches the one
here (compare y first, then x), so just use that.

Bug: 923166
Change-Id: Ie3eb7d76d4e6f0a1cbc56140059f260ce6313365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894101
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711753}

With this, the test coverage of the class on Gerrit will be
100% except for 1) statvfs call, 2) DLC code path which is
not fully functional yet, and 3) functions that will be
removed once we switch to virtio-fs.

BUG=b:136128691
TEST=try

Change-Id: I6e3fe68e587c3c7603f70a21b24fe9f5353a6e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893589
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711752}

Update WebRTCInternals::OnAddStandardStats(),
WebRTCInternals::OnAddLegacyStats(), their callers, and some related
code to new base::Value APIs. Fix nits and lint errors along the way.

Bug: 646113
Change-Id: Ib7fff9a87dbcb9203c182269ff739b1d70270640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894111Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711751}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=bbudge@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I92b2e2f80b080fa169592eb46db994b577463934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895637
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711750}

This is needed for it to replace ChromePreferenceManager.

Bug: 1017800
Change-Id: I45154b8bdfdfc0cb4816739270a42c303016d5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894184Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711749}

Bug: 1017800
Change-Id: I284d71f177da8b1e4d1b35ba4ee569221397d0e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894320
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711748}

Using wpt-import in Chromium 1a9e06fc.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
9be931cb "[WPT/common/security-features] Refactor navigable tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: If764d527707930ccdb9b2abb064ab1608aaa6ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895392Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711747}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: Ibe6c8f69d48fd1a22126b85f81332184f58255f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895639
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711746}

- chrome://snippets-internals is updated to let testers easily override
the feed host.
- If the server sends a Bless nonce, display it in snippets-internals so it
can be used by the tester.
- If the host is overridden, enable sending credentials in the request. This
is necessary for authenticating with some test servers.
- I tested that this workflow works, but it currently requires the
 --ignore-urlfetcher-cert-requests command-line switch.

Change-Id: If8fb1a0484dfbf992f84bed93eeef548b5e8f860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888387Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711745}

Bug: 1014959
Change-Id: I6f1dc977117532529cdb236abff09f16e0222390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890978
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711744}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ab12219ba56a..eecfdbf1701d

$ git log ab12219ba..eecfdbf17 --date=short --no-merges --format='%ad %ae %s'
2019-10-29 junyer Tweak some printed debugging for style.
2019-10-29 junyer Address the MSVC warnings that crept in recently.
2019-10-29 junyer Simplify parse_double_float() in util/pcre.cc.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Change-Id: I8df22f5d69eacf5a4dc665f79b7197935fe90572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894068Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711743}

When you long press an overview item in clamshell mode with only one
virtual desk, you shall be gracefully prevented from dragging it,
instead of getting a DCHECK failure.

Test: ash_unittests DesksTest.LongPressOverviewItemInClamshellModeWithOnlyOneVirtualDesk
Bug: 1020339
Change-Id: I9fc2a6f587fea8487f11819645e68dcb8bfa5cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894531
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711742}

This reverts commit 184873e8.

Reason for revert: This is causing compile failures on linux-chromeos-google-rel.

Original change's description:
> Clean up old uses of AssistantAudioDecoderFactory
> 
> This CL replaces the last use of old Mojo type of
> AssistantAudioDecoderFactory interface with
> mojo::Remote.
> 
> Bug: 955171
> Change-Id: I16778198e4dc1b7a7693dbbc0f7b85ae4a3d6bbc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890454
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#711712}

TBR=rockot@google.com,wutao@chromium.org,gyuyoung@igalia.com

Change-Id: Ibc3450e2774d5d71df873358b393f6a400ea7a3d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 955171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895735Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711741}

https://android.googlesource.com/platform/external/perfetto.git/+log/a7669da7bf27..5e1ef7e22ff0

git log a7669da7bf27..5e1ef7e22ff0 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 eseckler@google.com Merge "processor: Support disabling json importer separately from export_json"

Created with:
  gclient setdep -r src/third_party/perfetto@5e1ef7e22ff0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: If7d2768917dbb20e58c371d9e89531133ec5b322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894625Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711740}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I196bc206e14e1a316abd892eef6518753109864f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894920Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711739}

This reland adds two extra sanity checks for when
sending WTF::String over mojo, in case they were generated
from std::string instances with String::FromUTF8().

Null WTF::String passed over mojo from renderer to
browser can cause mojo validation errors as seen on
[1] and [2]. This is bug [3]

[1] https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280
[2] https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/53971
[3] https://crbug.com/635987

BUG=1020525, 787254

Original change's description:
> Fix about:webrtc-internals "Stats Tables"
>
> This is a fixup CL of [1] spotted and report by hbos@chromium.org
> on [2].
>
> [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences)
> [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1
>
> Basically the original CL was supposed to replace the code
> that used to bound PeerConnectionTracker to its associated
> mojom::Receiver instance in [3] by the corresponding code in
> Blink.
> However, the replacement code got accidentally missing while rebasing
> the CL over and over.
>
> [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777
>
> This CL amends the original CL with the proper code in
> blink/renderer/modules/modules_initializer.cc@RegisterInterfaces().
>
> TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \
> --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001
>
> Manual test= Open Chromium load about:webrtc-internals and [4].
> It is expected that WebRTC statistics appear.
>
> [4] https://codepen.io/anon/pen/JQLEqR?editors=1010
>
> R=haraken@chromium.org
> TBR=guidou@chromium.org, hbos@chromium.org
>
> BUG=787254
>
> Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711647}

R=armax@chromium.org, haraken@chromium.org

Bug: 787254
Change-Id: Ie8936038788c9bc05610fcf3684375712bedae2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895393Reviewed-by: Armando Miraglia <armax@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711738}

In https://crrev.com/710460 I deprecated the use of
base::ProtectedMemory in download_status_updater_linux.cc but forgot to
apply NO_SANITIZE("cfi-icall") to one function, introducing a crash on
download for Ubuntu clients. Fix that crash by marking
EnsureLibUnityLoaded with the same attribute.

Bug: 1020468, 1018834
Change-Id: I904372a3df7828787adfdd9041fa739e89ddc787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895373
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711737}