GitLab

Change-Id: I956ea3523eb42b6d7f0cf851a126c6a11578912e
Reviewed-on: https://chromium-review.googlesource.com/1121378
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572253}

Makes several changes to VR tests related to the VR controller:

1. Switches VrShellWebInputEditingTest to use the Chrome-side controller
   input mocking rather than VrCore controller emulation since the
   latter was slightly flaky.
2. Adds a null check to VrShellWebInputEditingTest to prevent a rare
   flake.
3. Remove @Manual from all VrShellDialogTest cases. These are mainly
   intended for screen diff tests, but do have some value as functional
   tests.
4. Fix hitting a DCHECK when using Chrome-side input mocking that was
   caused by some recent controller changes.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic3ccda408f7f531e1b8a78a46bae55858f46dc82
Reviewed-on: https://chromium-review.googlesource.com/1123400Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572252}

https://chromium.googlesource.com/catapult.git/+log/c61a0380486a..9f46241c6c03


git log c61a0380486a..9f46241c6c03 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 nednguyen@google.com Add documentation_link diagnostic


Created with:
  gclient setdep -r src/third_party/catapult@9f46241c6c03

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:859524
TBR=sullivan@chromium.org

Change-Id: I9f01f6305f67c46c9bb9723ef4b43eb1cd30a67b
Reviewed-on: https://chromium-review.googlesource.com/1124644Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572251}

Bug: 859685
Change-Id: Ibba0f9e17d04e6385b995ed28bf0536507d209e3
Reviewed-on: https://chromium-review.googlesource.com/1124676Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572250}

Bug: 843161
Change-Id: I705cf2ee2665ebd8245ccafb5e157d2039cf86f5
Reviewed-on: https://chromium-review.googlesource.com/1122410Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572249}

R=tandrii@chromium.org

No-Try: true
No-Tree-Checks: true
Bug: 836232
Change-Id: I9fc2feb8dc92d76411126449615578605419c248
Reviewed-on: https://chromium-review.googlesource.com/1124468Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572248}

https://chromium.googlesource.com/angle/angle.git/+log/92da844eb754..2b06054dd41f


git log 92da844eb754..2b06054dd41f --date=short --no-merges --format='%ad %ae %s'
2018-07-03 jie.a.chen@intel.com Vulkan: Insert a barrier after buffer copy


Created with:
  gclient setdep -r src/third_party/angle@2b06054dd41f

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I6eec1539882837dc7e761518f6108f74506b7303
Reviewed-on: https://chromium-review.googlesource.com/1124642Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572247}

PasswordManager::OnPasswordFormSubmittedNoChecks

The OnSameDocumentNavigation forwards to OnPasswordFormSubmittedNoChecks
and because the former is the only caller of the latter
remove OnSameDocumentNavigation and replace it with
OnPasswordFormSubmittedNoChecks.

R=jdoerrie@chromium.org

Bug: 795462
Change-Id: I2097b748c630559d5922288e2d0832c8b819de83
Reviewed-on: https://chromium-review.googlesource.com/1124472
Commit-Queue: Narcis Gemene <gemene@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572246}

These are not supposed to be widely used per the style guide, and aren't
necessary where we're using them. Also const&& makes no sense.

Bug: none
Test: compile
Change-Id: Id16a193d6dfbeee109a1bd6ade61800afbe07574
Reviewed-on: https://chromium-review.googlesource.com/1118976
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572245}

This CL makes 'signal' member in LockOption non nullable
to be spec conformant. [1]
It also drops a test that is inconsistent with this change.

[1] https://inexorabletash.github.io/web-locks/#idl-index


Bug: 855968
Change-Id: I4faf6582451347a05eeca34f02e25a43217d86cd
Reviewed-on: https://chromium-review.googlesource.com/1121953
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572244}

The histograms are being recorded in code that isn't used when the
network service is enabled. It was decided that these histograms see
little enough use that it was better to remove them, rather than make
them work with the network service.

In particular, the histograms are:
Net.Prefetch.TimeSpentPrefetchingFromCache
Net.Prefetch.TimeSpentPrefetchingFromNetwork
Net.Prefetch.TimeBeforeCancel
Net.LoadPrefetch.Pattern
Net.Prefetch.Pattern
Net.Prefetch.TimeSpentOnPrefetchHit

Bug: 859535
Change-Id: Idc85a43ce4a7b2c959c419401c422d17b07e35d3
Reviewed-on: https://chromium-review.googlesource.com/1122703
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572243}

DocumentState is now created in content and passed all the way down to
FrameLoader::CommitNavigation to be put directly into the DocumentLoader.
In DidCreateDocumentLoader we now only create the DocumentState for
cases where the content layer was never yet aware, such as
DocumentLoader from a frame init and Renderer initiated navigations.

A future patch is on its way to remove PendingNavigationParams and build
DocumentState directly from parameters.

Bug: 789577
Change-Id: Iffe7804784b13afc7f9d708828039d723b36ebbf
Reviewed-on: https://chromium-review.googlesource.com/1105985Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572242}

Bug: 850128
Change-Id: Ifc009ffebaddac9037b7e72175ba571f980ff83a
Reviewed-on: https://chromium-review.googlesource.com/1124759
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572241}

The IPH_BottomToolbarTip feature was added in crrev.com/c/1076131 but
the UMA tracking for this feature wasn't added. This CL adds the right
constants.

Bug: 830635
Change-Id: I4d1b94cdcd1b1b851996fa66ae1bb712e157e4fc
Reviewed-on: https://chromium-review.googlesource.com/1122225Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572240}

This CL adds a histogram to record EQT on renderer processes that do not
host main frames:
RendererScheduler.ExpectedTaskQueueingDurationWithoutMainFrame

While at it, fix a typo introduced in 5ec20588 in histograms.xml.

Bug: 829796
Change-Id: I05b3ce7a7cd3eb5432ce4f54eb54bf7100816b97
Reviewed-on: https://chromium-review.googlesource.com/1120778Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572239}

This is a preparation CL to move AutofillDownloadManager from URLFetcher
to SimpleURLLoader et al. Specifically, it moves some autofill tests away
from using base::Clock, for testing whether a autofill query request is
properly cached/fetched. Still, both CACHE_HIT and CACHE_MISS functionalities
are exercised.

Basically, instead of setting the base::Clock instance with manually configured
valid and expired dates, the following was changed:

- the original test (AutofillQueryTest.CacheableResponse) was spun off into
another test: AutofillQueryTest.ExpiredCacheInResponse.

- The former sets a Cache-Control max-age value to some time in the future
(100 seconds), so that its cached content is valid/reached.

- The later sets a Cache-Control max-age value to 0, and delay execution in
a few milliseconds to ensure the cache content is already expired, and never
hit.

BUG=837830,844929

Change-Id: Ib82ca230fb0169b9e6847d90019574eb571e4c97
Reviewed-on: https://chromium-review.googlesource.com/1122456Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572238}

Change-Id: I7bb88a19e280140a2a8126f1199aa4321fdf56ef
Reviewed-on: https://chromium-review.googlesource.com/1102425
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572237}

Tab Page

In MacViews mode, the 'Always Show Bookmarks' menu item is always checked
regardless of whether the bookmark bar is detached or attached. In Cocoa
mode, this was not an issue because the visibility state is determined by the
bookmark preference value for 'kShowBookmarkBar', which stores whether the
'Always Show Bookmarks' option is checked. In MacViews mode, the visibility
state always returns 'true' because it calls IsBookmarkBarVisible() instead,
which is 'true' if the bookmark bar is in a detached state (on New Tab Page).

Add contact info to AUTHORS


Update 'Always Show Bookmarks' checkmark visibility when toggled on New Tab Page

R=bsep@chromium.org, sky@chromium.org

Bug: 854962
Change-Id: I19f3741cd720474642d0661192f92f4517da075c
Reviewed-on: https://chromium-review.googlesource.com/1123890
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572236}

- Changes the disclore headerFooter subtitle label CompressionResistancePriority to prevent it
being compressed when refreshing the Cell.
- Deletes some un-needed constraints that weren't playing nicely with the TableView dynamic sizing,
causing broken constraints.

Bug: 851929
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifd641c1d7c227592d4767d9af1874dfcb3e556ca
Reviewed-on: https://chromium-review.googlesource.com/1123335Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572235}

There is only one implementation so there doesn't need to be a virtual
base class. Also remove some unused functions.

Bug: 832243
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I581d47639448efa4a0812f604808a03587269320
Reviewed-on: https://chromium-review.googlesource.com/1119122
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572234}

Bug: 843161
Change-Id: Ibaa9c303a72f20af52290471b88a7da071e231e3
Reviewed-on: https://chromium-review.googlesource.com/1120528Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572233}

The test assumed no cache named 'foo' existed, but another test
cache-keys-attributes-for-service-worker creates a cache by that name,
so the test would flakily fail in some runs depending on the ordering
of the tests.

Make the test defensive by deleting such a cache before proceeding.

Bug: 840850
Change-Id: Ia349706c9a32af309cfadf9a63ba5cffea11998d
Reviewed-on: https://chromium-review.googlesource.com/1119104
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572232}

https://pdfium.googlesource.com/pdfium.git/+log/65f38c8fae09..1448cc11b9be


git log 65f38c8fae09..1448cc11b9be --date=short --no-merges --format='%ad %ae %s'
2018-07-03 vmiklos@collabora.co.uk Add FPDFText_GetTextRenderMode() API
2018-07-03 thestig@chromium.org Use GetPos() and SetPos() in CPDF_SyntaxParser::ReadStream().
2018-07-03 thestig@chromium.org Fix indentation in CPDF_SyntaxParser.


Created with:
  gclient setdep -r src/third_party/pdfium@1448cc11b9be

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I287c8ce2b525224970aabd16fdf36a8204b39ede
Reviewed-on: https://chromium-review.googlesource.com/1124640Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572231}

This CL process local updates in the bookmarks model and updates the
tracker accordingly.

Bug: 516866
Change-Id: Idfa2f2e7822029fb71030e3decbc6d8091856737
Reviewed-on: https://chromium-review.googlesource.com/1124164
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572230}

This CL introduces MovableString to hold javascript string
resources. This class may move its data, although this CL only
introduces the simulation of it in order to gather data about such an
approach.

This CL is essentially a port of
https://codereview.chromium.org/1583263002 from hajimehoshi@. It has
been updated to the new conventions and coding style, but is otherwise
equivalent, with changes to histogram collection and triggering.

Bug: 837659,574317
Change-Id: I9028fd941f3d235761f10a2147ab21e31edac6d6
Reviewed-on: https://chromium-review.googlesource.com/1082445
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572229}

https://webrtc.googlesource.com/src.git/+log/46f858a626d5..3bc977a42022


git log 46f858a626d5..3bc977a42022 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 mbonadei@webrtc.org Revert "Add sprang@ as owner of simulcast.cc/h"
2018-07-03 danilchap@webrtc.org Discard frame self-dependency when parsing genric frame descriptor
2018-07-03 buildbot@webrtc.org Roll chromium_revision f6935ecd..ce19c6d8 (572058:572160)


Created with:
  gclient setdep -r src/third_party/webrtc@3bc977a42022

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:859281,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iafdb693db9daef07e8dac90bdc685e15e154e8df
Reviewed-on: https://chromium-review.googlesource.com/1124641Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572228}

BUG=859563

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibc3cefb18aa81a7a9c1a1a2bf25e6c533b527389
Reviewed-on: https://chromium-review.googlesource.com/1123057Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572227}

Locked fullscreen mode wasn't working for devices that were in tablet mode.

Needed to put SetLockedFullscreenState below window()->Show() as that one
was resetting the locked-fullscreen mode.

Bug: chromium:857125
Change-Id: Ic36e2dc0f4f76e05bf713b1f2dcc384d1ead308e
Reviewed-on: https://chromium-review.googlesource.com/1120526
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572226}

The workaround was added due to a bug in Chrome versions before M46,
where we didn't persist the permission value in prefs (crbug.com/533086
and crbug.com/619759). By now, all users should long have updated prefs,
so time to get rid of the workaround.

Bug: none
Change-Id: I3c2581b96ece5b2a64db14f8d8df7ff93ff5cfc2
Reviewed-on: https://chromium-review.googlesource.com/1124688Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572225}

Bug: 859611
Change-Id: I0298db9bbf4aed6bd40600aef2e1c5794e8cd058
Reviewed-on: https://chromium-review.googlesource.com/1123056Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572224}

This CL contains a few changes related to app bundle generation.
part of a simplification of the following large CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1071657

More specifically:

- bundletool.py: Enable the python script to be imported. This
  will happen in a future CL that will add new Python build
  scripts to generate app bundles and apk sets.

- Compile resources to protobuf-based format using the new
  aapt2 binary added recently to third_party/android_build_tools/.

- Add an entry in an APK's .build_config file indicating the location
  of its final dex files, to help the bundle-generating targets
  use them later.

BUG=820459
R=agrieve@chromium.org, benmason@chromium.org, yfriedman@chromium.org

Change-Id: Ifd66f11bafe804625efba3051ecf5f7c40fcf740
Reviewed-on: https://chromium-review.googlesource.com/1120530Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572223}

https://skia.googlesource.com/skia.git/+log/d7425b58df89..94d57c477fe1


git log d7425b58df89..94d57c477fe1 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 ruiqimao@google.com updated SkCanvas documentation for animation overloads of drawVertices


Created with:
  gclient setdep -r src/third_party/skia@94d57c477fe1

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: Ie8cf1cad2e287f4807d7bcae4b6ebf61dfba5fe7
Reviewed-on: https://chromium-review.googlesource.com/1124619Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572222}

Try to avoid a crash in a situation we've seen where a lab
system has a policy file referencing an owner but the user
list in the Local State file is empty.

Bug: 850139
Change-Id: I4fad13685d8a8975e6b8f1e41a65bf37cdfcd89d
Reviewed-on: https://chromium-review.googlesource.com/1121377Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572221}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I592701124bb563e5d0a39e71d6b2efa328ec3c03
Reviewed-on: https://chromium-review.googlesource.com/1124672Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572220}

These benchmarks will be used to train the new production android orderfile.

Bug: 843561
Change-Id: Iea097d784773c98ec3076f297aac16558c2a8104
Reviewed-on: https://chromium-review.googlesource.com/1124561Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572219}

This way there's a consistent measurement point, irrespecive the
setting of how TabLoadTracker assesses the loaded state.

Bug: 755840
Change-Id: I42790bff863e1787db2ac804eecd117b185b5afb
Reviewed-on: https://chromium-review.googlesource.com/1119062Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572218}

This is a reland of ec3716fd

Original change's description:
> Changing AudioService experiment field trial to test service launch on startup
>
> [1] introduced AudioServiceLaunchOnStartup feature which we want to roll out
> with a new experiment group. Updating field trial to run the config on bots
> first.
>
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1104681
>
> Bug: 851611,853781
> Change-Id: I3796a8ac205a6d37706a86e8647c933ee510f41a
> Reviewed-on: https://chromium-review.googlesource.com/1105957
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568485}

Bug: 851611, 853781
Change-Id: Ief31b6eee175e36735946ae835175ec7c0f36d24
Reviewed-on: https://chromium-review.googlesource.com/1118985
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572217}

LayerTreeHostImpl::OnMemoryPressure has only worked for low-end devices.
But it would be good if it works for all devices.

Bug: 839687
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9f670ab08587ad4c5f626eb74fe5d7c9db256150
Reviewed-on: https://chromium-review.googlesource.com/1107025
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572216}

NOTIFICATION_CONTAINER is a container MenuItemView which is added and
removed to an app context menu as notifications for the app come and go.

The container is added to the tree of MenuItemViews by adding it to
the menu's SimpleMenuModel.

The bug is that the container MenuItemView for NOTIFICATION_CONTAINER
is not enabled when added. The root cause is that when the
NOTIFICATION_CONTAINER is added, it is not addd to |menu_items_|(same
name for both classes modified).

I originally tried to ensure that items added to the SimpleMenuModel
were also added to |menu_items_|, but when adding an item to
|menu_items_| in ash/public/cpp/menu_utils.h, we check
|delegate_|->IsCommandIdEnabled(), which requires that the item is in
|menu_items_|. This means that new items are disabled. This is because
|menu_items_| was designed to be built once, and not modified.

This fix works because we don't need to check
|menu_items_| anyways because NOTIFICATION_CONTAINER is always enabled.

Fixing |menu_items_| so that it holds all items that SimpleMenuModel
holds would be ideal, but its current behavior is only a problem in
the NOTIFICATION_CONTAINER edge case.

Bug: 857565
Change-Id: I1ec1d6db20b1ba45d0a772eb2ec7ab3ec0498c06
Reviewed-on: https://chromium-review.googlesource.com/1119057
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572215}

Add study to test new NTP features on ToT. Disable these features for
old tests.

Bug: None
Change-Id: Ie706c56263f232fc1f0dd4e7c9ae03909b77a935
Reviewed-on: https://chromium-review.googlesource.com/1111009Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572214}