- 15 Oct, 2019 40 commits
-
-
Maksim Sisov authored
These tests have been stable and run for quite a long time. So, it's safe to remove the experiment now. Bug: 700309 Change-Id: Ic9138013913dfd841cbb9ffa23fc27d3e790bf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862462Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#706130}
-
Maks Orlovich authored
The cookies used in the test don't explicitly specify SameSite attribute, so eventually they'll be interpreted as 1st-party only. Adjust the code in tests that queries them to delcare itself as 1st party so it can actually see them. Bug: 1006816 Change-Id: Ied26333b46fa76142580fbb0dabdcb0df25a08e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856887Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#706129}
-
Chris Dalton authored
Change-Id: Ib6a0f9829dfe781c9d66c9d62fb950f92b9a1c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860497Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Chris Dalton <csmartdalton@chromium.org> Cr-Commit-Position: refs/heads/master@{#706128}
-
Daniel Hosseinian authored
Bug: 989978 Change-Id: I8b943250012cdc6e1a253905aa5dc8e65690ece6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856920Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#706127}
-
Drew Davenport authored
Only one ScopedFeatureList::InitXXX function should be called on a particular ScopedFeatureList instance. If any Init functions are called more than once, it will hit DCHECK(!init_called_) in ScopedFeatureList::InitWithFeaturesImpl. Refactor feature enabling so that the desired features are sent as a vector of features in one call to ScopedFeatureList::InitWithFeatures TEST=video_encode_accelerator_unittest does not hit DCHECK BUG=none Change-Id: I445ea51740b93361c771450e47cd31300ae13c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862257Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#706126}
-
Morten Stenshorne authored
It may be the wrong year to do this, but fixing 22 tests with such a tiny effort still seems worth it. :) Bug: 829028 Change-Id: I5e34fc18edcb063d125933aac9174ff08a5acc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860421 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706125}
-
Alex Keng authored
This change updates the position of the slider ticks to be below the slider (overlapping the thumb by 1 pixel) and shortens the ticks by 2 pixels (from 6 to 4) Bug: 1014373 Change-Id: I498e8f76259f677378f6ec5af4780e74653c8a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860513 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#706124}
-
Daniel Rubery authored
This CL adds four new danger types to correspond to new UX for the result of download deep scanning. BLOCKED_TOO_LARGE will be generated for downloads that are supposed to be scanned (per the policy), but is not due to the file size. SENSITIVE_CONTENT_WARNING is generated for downloads that contain sensitive content violations, and the recommended behavior is warnings. SENSITIVE_CONTENT_BLOCK is generated when the recommended behavior is blocking. DEEP_SCANNED_SAFE is generated when the scan completed successfully, and no danger was identified. Bug: 980777 Change-Id: I2cce35c256b1095172fcc23bab946503d77a1536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845675Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706123}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/12dc10e0278c..3dbb965bdf76 git log 12dc10e0278c..3dbb965bdf76 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 oysteine@google.com Merge "Moved the StackProfileTracker to the ProtoIncrementalState" 2019-10-15 fmayer@google.com Merge "Set incremental_state_cleared on first packet." Created with: gclient setdep -r src/third_party/perfetto@3dbb965bdf76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie53a1de9585c0ce3497c47a756430b9addaa0677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706122}
-
Victor Vasiliev authored
Also re-enable QUIC end-to-end test since a fix for it has landed. R=rch@chromium.org Bug: 1010206 Change-Id: I76fb982e82fd9b5b4d1ed6f2f72aea14e12d6272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860595Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706121}
-
Mandy Chen authored
Disabled due to failure on win10, but test passes now on win10. Bug: 1009016 Change-Id: I9c530d8fe33e0f06bf2a810fa6958545e195487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863569Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706120}
-
Maksim Moskvitin authored
We used to check that bridge fails on receiving NigoriSpecifics with default passphrase type. It's wrong, because default passphrase type is IMPLICIT_PASSPHRASE, which should be supported. The purpose of this test is to check that bridge fails on receiving specifics with some new passphrase type, which is not supported on current client. With NigoriSpecifics::passphrase_type being converted to int, it means value out of PassphraseType enum. Bug: 922900 Change-Id: Ia5bbb39afb17c0a31ba7847d9a1e233cdee4c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862674 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706119}
-
Nasko Oskov authored
This test was disabled a while ago for issues with site isolation. At this time the test passes 100 iterations locally, so I'll enable it for now and hopefully the underlying flakiness is fixed. Bug: 648406 Change-Id: I32ccea18e684a112753e90ea63c1daa80b8a2be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863591Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#706118}
-
Dave Tapuska authored
As outlined in design sketches https://docs.google.com/document/d/1ChpbGA1M6aYxH9wqQYXQcvXZiVikeLI3JJP-fkezKP8/edit and https://docs.google.com/document/d/1QO99UstlPTY8eK4Lnc9qcNq3wQYTBDBsRZu6nGC4XG4/edit introduce a FrameHost interface in blink so that blink can talk directly to the RenderFrameHostImpl and not go through a public blink API. ie. the API becomes a mojo interface. BUG=1008432 Change-Id: I98ef40c08b93f4a1fbc2e3ecad92a88bbbdcfc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826988Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#706117}
-
Darwin Huang authored
sqlite 3.30.1 update changes: https://www.sqlite.org/releaselog/3_30_1.html Bug: 1013400 Change-Id: Ifad0ab8d46541d2ef8119d9b8065173ec94cdfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860937Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706116}
-
Roman Sorokin authored
Looks like it was switched to use installationSettingsDialog in oobe_eula.html Bug: none Change-Id: I409ed0b6c468af51ada1902e9fc8266519b737e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862461Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706115}
-
Morten Stenshorne authored
Collapse block margins between sibling spanners and add inline margins, including auto margins. We now position spanners correctly. Bug: 829028 Change-Id: I07b5c1af92852d385cf558db6c20de61e88d87d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860419 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Manu Cornet authored
* Rename the "NotifyXYZ" methods into "OnXYZ" which is more idiomatic for callbacks, and makes things more consistent across the app list classes (instead of having both, depending on the class). * Change the notion of "target visibility changed" to "visibility will change". * Remove "AppList" from within the method names when "AppList" is already part of the class name (i.e. except for observers outside of app_list). This is purely a name change and has no user-visible effects. Change-Id: I37dfe742d50e516bd70d78b037b867486230a8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861018Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706113}
-
Hector Carmona authored
Bug: 876601 Change-Id: I49c8f9730adf76a6612cb108785145465c3b640f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861112 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706112}
-
Robert Liao authored
There was only one caller in system_fonts_win.cc and it is better served with a direct call to SystemParametersInfo. BUG= Change-Id: Icd3f4e6e27d50d8569e602cb0eeace2c6dd530a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861109 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Because kEvaluateScriptMovedBetweenElementDocuments UMA has been 0 for a week on canary, it seems also safe to stop executing such scripts. We still keep the use counter to confirm that such cases are really rare on stable channel. Bug: 721914 Change-Id: I2b4963321f6e81284b9baac22ee5d5f9e3df7484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854643Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706110}
-
Daniel McArdle authored
Now we only use valid UTF8 strings. Also, the session_id string must begin with "{", end with "}", and be nonempty, according to DCHECKs in MakeProtocolRequest. Bug: 1014625 Change-Id: If30c9b21f63c7cab7a01f456ec0593971ef1bc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863669Reviewed-by:Sorin Jianu <sorin@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#706109}
-
Maks Orlovich authored
They will need to be marked explicitly and secure, so adjust some tests to be over SSL and mark those cookies appropriately Bug: 1006816 Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389Reviewed-by:
-
Sergey Poromov authored
SCHEMA_ALLOW_INVALID strategy is used only for ManagedBookmarks policy and is considered for deprecation. Adding UMA metrics to check how ofter this strategy is useful in reality Bug: 969706 Change-Id: I0dee14588d48ce30e83cbd14cacc0375e3fa1a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841031Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706107}
-
Clark DuVall authored
Due to some recent changes in how the fragment works, the browser tests were crashing on Android. Change-Id: I5302c63f1f02eccdac3d5e95fe711a9d24048cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863592Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706106}
-
John Lee authored
- Mostly only tests CSS properties that have an impact on visibility, such as opacity, width, and display, or can be tested using CSS vars - Fixes an attribute that should have been private Bug: 989131 Change-Id: Icdf6e830d5a95cf8feeca63cd0b755ecc1ad64d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857023 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706105}
-
Elly Fong-Jones authored
This change removes overrides from: * DesktopMediaPickerDialogView, which used static strings * DownloadDangerPromptViews, which used static strings conditional on a constructor parameter * HungRendererDialogView, which computes its strings but never updates them after creation * PermissionsBubbleDialogDelegateView, which used static strings conditional on GetDialogButtons(), which itself returned a constant * PasswordReuseModalWarningDialog, which used strings computed from a member that never changes after construction * TabModalConfirmDialogViews, which gets its strings from a delegate but never updates them * UninstallView, which used static strings This change also removes a couple of redundant overrides of GetDialogButtons that replicated the default, and const-ifies a couple of members where the const-ness helps reason about code correctness. Bug: 1011446 Change-Id: I6f89e975895c16a492cc0becad98f43a4f96e6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862119 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706104}
-
Martin Kreichgauer authored
When enrolling a fingerprint template on a security key through the settings UI, the device will generally choose some default value for template's human-readable name label. This change adds an extra step to let the user optionally modify the label after enrolling the template completed. Bug: 974046 Change-Id: If85f3db63cbb9c10b7870fcd75fb79db6b6127b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848477Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
-
Collin Baker authored
This is the first C++-side browser test for the thumbstrip. Bug: 997887 Change-Id: Ic155adc5c2d519cc383438326c7ffb6fe21caf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861110 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706102}
-
Hesen Zhang authored
- Create client side code. - Add client type. Bug: 1013685 Change-Id: Ie915b1e697b3a7e40a42079a629301918dfd5966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856884Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Tommy Li authored
This CL is a cleanup to pave the way for more work to polish the on-focus suggestions UI. Bug: 1013287, 996516, 963173 Change-Id: Iec5b40451b00baf440e61a7881c8168a29eedde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862715 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706100}
-
Wenbin Zhang authored
All builds on android-nexus5x-perf are generating "infra failure" due to the fact that six devices are missing from Swarming. We're reducing the expected shard size for this specific builder in this case, as discussed in: https://bugs.chromium.org/p/chromium/issues/detail?id=1014120#c17 Bug: chromium:1014120 Change-Id: I87bf6d66523d0299d39a9d38de69209a2c82cf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862995 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706099}
-
Manu Cornet authored
(Weidong left the team a while ago.) Change-Id: Ifc9f1532f188d832e77b0b81a0292c2b435d3691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859912Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706098}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/b8d86733e9d9..412547ad4b75 $ git log b8d86733e..412547ad4 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 angiebird Refactor calc_frame_boost() 2019-10-09 angiebird Add first_pass_info in TWO_PASS 2019-10-09 angiebird Refactor get_prediction_decay_rate() 2019-10-09 angiebird Replace cpi by frame_info in get_sr_decay_rate() 2019-10-09 angiebird Change the interface of calc_frame_boost 2019-10-09 angiebird Use frame_info in calculate_active_area 2019-10-09 angiebird Add FRAME_INFO into VP9_COMP 2019-10-08 angiebird Add detect_flash_from_frame_stats() 2019-10-04 jianj vp9: fix non bitexact when reuse_inter_pred is 0. 2019-10-03 hienho vp9/common/vp9_reconinter: fix int sanitizer warnings 2019-10-01 hienho vpx_dsp/quantize: fix int sanitizer warnings 2019-10-01 hienho vp9/decoder/vp9_detokenize: fix int sanitizer warnings 2019-09-28 jzern namespace ARCH_* defines 2019-09-27 jianj Fix python3 format issue 2019-09-20 marpan vp9-rtc: Fix to speed 4 for real-time mode 2019-09-19 angiebird Remove USE_PQSORT and CHANGE_MV_SEARCH_ORDER Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Idb64446d8484a2ebacc8a295b1cb3d91219a5bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857584Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#706097}
-
Dave Tapuska authored
If a Webview app delays setting the allowUniversalAccessFromFileURLs it is possible that further accesses will fail because they are different agent clusters. Grant corss agent cluster access. BUG=1006684 Change-Id: Ic19b5ae26ffc03747f5d352f824a00e2deda776a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857301Reviewed-by:
-
Krishna Govind authored
This reverts commit 7294a953. Reason for revert: crashes bug 1013972 Original change's description: > Rolling R8 1.6.28 -> 1.7.11 > > Change-Id: I4a431f966ab297e7c81b7abe8e29ed302b984586 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849181 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705353} TBR=agrieve@chromium.org,smaier@chromium.org Binary-Size: revert R8 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9a0cc7ad69dec3a20308b208aa7ec36e6e6927dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860126 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#706095}
-
Koji Ishii authored
This patch fixes hit-testing image list markers. The previous fix for hit-testing list markers (r682470 crrev.com/c/1726571) didn't cover image list markers, and unfortunately the test did not cover the case. Bug: 1002417 Change-Id: Ieefcfa91240570a3d59265cf7e75c802396da6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862873Reviewed-by:
-
dalyk authored
This change will allow URLRequests to bypass DoH during hostname resolution. Change-Id: Ic5a5346d57bf8fc639a82ff8b284f4e11893745d Bug: 1012268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842562 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#706093}
-
Tommy Li authored
The API currently has an unused pointer argument that's used as a bool. It just makes for a confusing read, and I'm trying to build on top of it to fix some polish issues for on-focus suggestions (ZeroSuggest). This CL turns that pointer-as-boolean argument into an explicit bool argument that's properly labeled. No behavior changes. Bug: 996516, 963173 Change-Id: I02767d26849dae035feeb54173ebee2fbc66ea03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862256 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706092}
-
Fredrik Söderquist authored
The font code (FontMetrics::AscentDescentWithHacks specifically) will (may) mangle (round) the ascent and descent, meaning that for small font-sizes all precision is lost. Using our (potentially) "rescaled" Font for computing the baseline for text gives us a chance to recover some of the precision lost in the rounding process. Bug: 1013859 Change-Id: Ieaadaf558315b8a082331ac76deeb52bcf3b11c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859961Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706091}
-
