GitLab

Change-Id: I6178d17add00beb32ac7067638c8119cb4ed236f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773216
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691105}

- Include fcm_token and encryption_info in all non-Ack SharingMessage,
  so we can send Ack without looking up sync preference. This allow Ack
  to be sent reliably and own't be affected by delay for above data
  propagating through sync
- Store encryption_info in local preference, so we can embed it in
  SharingMessage without looking up GcmEncryptionProvider
- Add method to fast lookup Device from SharingSyncPreference
- Removed logic in SharingFCMSender that clean up GONE device, because
  this will race with device trying to registering at the same time, and
  results in device not in sync preference after registration. As we're
  migrating to DeviceInfo we won't be able to clean up other devices in
  the future as well.

Bug: 988975
Change-Id: I2d0f7051fe1a31aa7a2db9e3494584b475aa7052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768702
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691104}

https://chromium.googlesource.com/angle/angle.git/+log/886698bc3fdd..6f24d8a79388

git log 886698bc3fdd..6f24d8a79388 --date=short --no-merges --format='%ad %ae %s'
2019-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src a3bc04b278ed..f27bd2aa2e3f (4 commits)

Created with:
  gclient setdep -r src/third_party/angle@6f24d8a79388

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: chromium:None
Change-Id: I43f8f0a02ca610885cc827e2826c6827c9231e72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691103}

The test relies on closing a notification to be faster than SW ->
document communication, which until recently was true, but is not a
guaranteed contract.

Bug: 997824
Change-Id: I32141ed13acd85b7e74e9f14c5493b156c69870f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768341Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691102}

Bug: 998359
Change-Id: Id9c7290487bd8ae001c28a02a7a629c3727a30d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772210Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691101}

This reverts commit 887f778e.

Reason for revert: Breaks MSan tests

Original change's description:
> Roll src/third_party/swiftshader a9da772f0587..04e148570dbb (8 commits)
> 
> https://swiftshader.googlesource.com/SwiftShader.git/+log/a9da772f0587..04e148570dbb
> 
> git log a9da772f0587..04e148570dbb --date=short --no-merges --format='%ad %ae %s'
> 2019-08-28 capn@google.com Make round-robin task enqueue index thread safe
> 2019-08-27 bclayton@google.com Device: Migrate Renderer to Yarn
> 2019-08-27 bclayton@google.com Device: Don't use a global for the cluster count.
> 2019-08-27 bclayton@google.com Some minor code tidying.
> 2019-08-27 bclayton@google.com Pipeline: Use Yarn to make compute multi-threaded.
> 2019-08-27 bclayton@google.com Vulkan: Build a yarn::Scheduler and pass it down to the vk::Queue.
> 2019-08-27 bclayton@google.com vk::Queue: Lazily construct Renderers
> 2019-08-27 bclayton@google.com Yarn: Don't zero-initialize data in Pool<T>::Item::construct()
> 
> Created with:
>   gclient setdep -r src/third_party/swiftshader@04e148570dbb
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/swiftshader-chromium-autoroll
> Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=swiftshader-team+autoroll@google.com
> 
> Bug: chromium:b/139010488,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139010488,chromium:b/139142453
> Change-Id: Iceb60a95f44801f390732a1506641ace01c4e131
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774264
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#691066}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com

Change-Id: I58b3d9d5fb39b0db4e2fedac3a29ca1f1e5a3998
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:b/139010488, chromium:b/139142453, 998457
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773142Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691100}

This patch markes following CSS properties layout dependent:
 - margin-block-start, margin-block-end
 - margin-inline-start, margin-inline-end
 - padding-block-start, padding-block-end
 - padding-inline-start, padding-inline-end
for improving browser interoperatiblity.

This patch is follow up of the CL[1] to fix following tests:
 - css/css-logical/parsing/margin-block-inline-computed.html
 - css/css-logical/parsing/padding-block-inline-computed.html

[1] http://crrev.com/c/1760419 Import WPT tests

Bug: 995612
Change-Id: If754cdcb7085ffa10cf965301f46f7aace33032d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774421Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691099}

No behavioral change.

Change-Id: I054cd7f3743d0021f52241f2839297c0ae97bcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768340
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691098}

This fixes a bug where the client would not correctly end a PR action for some invalid protos. Note: this is likely *not* b/140008909, but I can't yet confirm.

This also fixes a bug where the client should fail the PR if a login choice was requested but no options are available (e.g., for websites which do not offer guest checkout). In practice, this is unlikely to happen, but the case should be handled regardless.

Bug: 806868
Change-Id: I68174fa84e72fbfe209272cc62d6461970762fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771604
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691097}

https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/ecb3c4f4ce2c..681ca92480ec

$ git log ecb3c4f4c..681ca9248 --date=short --no-merges --format='%ad %ae %s'
2019-08-23 msmiljanic.gm Replace plain text Serbian dictionary with rule based dictionary.

Created with:
  roll-dep src/third_party/hunspell_dictionaries
R=gujen@chromium.org

Bug: 997228
Change-Id: I2737accf1293ebcfa7b4903ce92ba5755835be60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769176
Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691096}

This reverts commit d0788ba8.

Reason for revert: Breaking the build (crbug.com/998383)

Bug: 998383

Original change's description:
> Don't compile DownloadService in Android.
> 
> Bug: 996380
> Change-Id: I57e49cad315fb038ef4b9dfb71293f49f64c749f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769728
> Commit-Queue: Bettina Dea <bdea@chromium.org>
> Reviewed-by: Daniel Rubery <drubery@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690903}

TBR=bdea@chromium.org,drubery@chromium.org

Change-Id: I441fa51291798df8d4243f197ecad0090c43638f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774279Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691095}

With 32 bits build gone, iOS can use the posix implementation of
TimeExploded, which is faster.

Bug: 985061
Change-Id: Ic1d42ebddfa2d0bb0d37bb7b2086683914aa87a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763679
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691094}

URLs like `https://whatever.com:0/` have an opaque origin, as they're
rejected in the SchemeHostPort constructor (see [1] and [2]). This
means that they fail the `IsOriginSecure()` check, and crash the
renderer, which is a bit unfortunate, as they're going to fail to load
regardless.

This patch excludes URLs with opaque origins from the referrer check in
order to avoid that crash.

[1]: https://cs.chromium.org/chromium/src/url/scheme_host_port.h?rcl=90e84c7240870d52c224cb8c07b52545a2ef7cef&l=83
[2]: https://cs.chromium.org/chromium/src/url/scheme_host_port.cc?rcl=90e84c7240870d52c224cb8c07b52545a2ef7cef&l=85

Bug: 960312
Change-Id: I39a41e3148554fda36e52d1f0c9934f52a2b8dff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771906
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691093}

The promise resolution was already wrapped in calling it inside the
right execution context, but the reject was not. Add the correct
execution context and schedule rejecting the promise if font loading for
a local() font fails when it is triggered by an implicit UA-triggered
load.

Spec reference:
https://drafts.csswg.org/css-font-loading/#font-face-load
in particular the last normative paragraph: "User agents can initiate
font loads on their own, whenever they determine that a given font face
is necessary to render something on the page. When this happens, they
must act as if they had called the corresponding FontFace’s load()
method described here."

Thanks to Roel Nieskens (pixelambacht@) for the helpful bug report and
reproduction test case.

Bug: 996687
Change-Id: Icb5d75675b8a2e0b3f100808645a1e2e550cfcd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771607
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691092}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7096a4a9fc5b..0f0281d3e2a8


Created with:
  gclient setdep -r src-internal@0f0281d3e2a8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Iba6155c369448cc52caf79f5fde91da4010e5971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772455Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691091}

This patch adds logging for the dropped invalidations in Sync browser
tests. This will help investigate some flaky tests.

Invalidation are dropped if they are received before an
FCMNetworkHandler is actually assigned and listening for FCM messages.


Change-Id: I10409bfdda7b0616da6e45a6ecd5f00b3cd5bef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771904
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691090}

A crash can sometimes happen when there the base and extent are
equal and there are no valid nodes going rightward. This fixes it
so in this situation it should have the selection on the same
leftward node.

Bug: 989162
Bug: 987702
Change-Id: I10a05125367f561ed5b4ba2b3d533907caf8b7ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760303Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Jessica Tallon <jtallon@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691089}

ScheduledAction::Execute is only ever called by DOMTimer::Fired which is called as a task. So the stack is simple and we should be able to add AllowedStackScope and allow cooperative scheduling.

Bug: 804661
Change-Id: Ida6d3605810469d0e95b6e72ded3f1aed05ad341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743236
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691088}

Move the logic of calculating delay for the next background
sync event to the chrome layer. This CL moves the logic to
apply cross-registration limits for the same origin to
BackgroundSyncController in the chrome layer.

It also moves a unit test to this layer, and adds additional
unit tests to BackgroundSyncController.

Bug: 949499
Change-Id: I26bdd63d376c5b0821d62ccb7293833fbadaa444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751250
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691087}

Intended to enable landing of
https://webrtc-review.googlesource.com/c/src/+/53861

Bug: webrtc:8733
Change-Id: Ia0b946c51215fc7ce6f7f27541d1e788cda1a843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768587Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691086}

Using wpt-import in Chromium 23bae0af.
With Chromium commits locally applied on WPT:
1194775a "Add ability to block same-origin access via document-access feature policy"
5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport."
d3b97055 "Update simulateUserActivation to match webxr-test-api spec"
2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest"
90789f54 "Implement fallback to element anchor"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I8ef90c4180acc76fd2c8149a493c85682ab13985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774379Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691085}

Update callsites.

Change-Id: I2ebaf88c479c0a8c20953f77fae00cdb77835fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769212
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691084}

This CL adds test cases for a conversion from Dmabuf frame to Dmabuf frame. The
test cases are currently for ImageProcessor using VA-API, which will be
introduced in crrev.com/c/1367389. The ImageProcessor only supports a conversion
between Dmabuf frames.

Bug: 898423, 917951
Test: image_processor_tests on atlas
Change-Id: I69460be06c7c5a5cd5827b09f4a62d67e9148a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772926
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691083}

There are still some parts of the code that are un-tested, particularly concerning additional actions and T&C links.

Bug: b/140018932
Change-Id: Iea4a4f92dbb6f118c01e1fab1839721ebac76082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769447
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691082}

It used to use runtimeStatsMetric but this seems broken, so move to
runtimeStatsTotalMetric instead.

Perf Sheriffs: This is expected to change all the metrics on
v8.runtime_stats.top_25 due to the change in measurements.

BUG=chromium:688342

Change-Id: I3e185fa9086e69151f4c5fa2db5fbf3d326d93fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771611Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691081}

This patch changes |LayoutText::SetTextWithOffset()| to reduce text shaping by
reusing |ShapeResult| of before and after replaced range for improving
performance, 10% to 15% faster but 3 times slower than legacy layout.
(Profile data: http://bit.ly/33B9rfg)

From this patch, |SetTextWithOffset()| does:
 1. Get offset mapping to map DOM offsets to text content offsets for replaced
  range.
 2. Collect inlines into |text_content| and |NGInlineItem| to get newly inserted
  text.
 3. Copy before and after |ShapeResult| from current data to |NGInlineItem| list
  in step 2.
 4. Call |NGInlineNode::ShapeText()| with |NGInlineItem| list to reuse
  |ShapeResult|.

This patch gets rid of NGInlineNodeTest.InvalidateSetTextWithOffset because
new test case replaces this test and this test call |SetTextWithOffset()| with
wrong parameter. It shoulbe |SetTextWithOffset("baftere", 1, 4)| as result of
|"before".replaceData(1, 4, "after")|.

Bug: 707656
Change-Id: I078b19615d6f7e31362c1e6398aac88fb17b29c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729330
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691080}

The macro EXPECT_EQ_UNIQUE_ID() has been defined in a way that expects
variables with exact names `expected' and `actual' defined in a dynamic
scope, i.e. in the scope of C++ code that actually uses either
EXPECT_EQ_UNIQUE_ID() or EXPECT_FORM_FIELD_DATA_EQUALS() macros.

It seems the original intent was to use argument expressions passed to
EXPECT_FORM_FIELD_DATA_EQUALS(), not necessarily bound to exact names.

BUG=896689

Change-Id: I4f782afc1c8ab7c55b77ee111dcbbe64002a4d6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757823
Auto-Submit: Andrei Polushin <anpol@yandex-team.ru>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691079}

Fix the code in results_processor that detects whether output options
should be processed or not.

Add a test in scripts_smoke_test to make sure the "run_benchmark list"
command is kept working.

And add more tests on the current behaviour for output option
processing. These would have avoided crbug.com/997284.

Bug: 996493
Change-Id: I1476a32eb3b48b7c1ebbaae60b47dba9b17ca23c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771603
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691078}

Not taking the new woff2 support right now, since Chromium already has
woff2 support (which already depends on brotli) and Chromium needs to
roll FreeType past this commit while evaluating what to do.

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9adc3b35f1a6..cbee985a2bc1

git log 9adc3b35f1a6..cbee985a2bc1 --date=short --no-merges --format='%ad %ae %s'
2019-08-27 drott@chromium.org [woff2] Don't use `FT_UInt64' (#56815).
2019-08-27 wl@gnu.org [truetype] Prevent crash in `TT_Set_Named_Instance' (#56813).
2019-08-27 wl@gnu.org CHANGES: Updated.
2019-08-27 wl@gnu.org [woff2] Fix compiler warnings.
2019-08-27 wl@gnu.org [woff2] Formatting; some comments.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Check whether known tag is in array bounds.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] More formatting and documentation.
2019-08-27 ramakrishnan.nikhil@gmail.com * src/sfnt/sfwoff2.c: Improve trace comments.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Formatting.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Support `hmtx' reconstruction when `glyf' is untransformed.
2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Support `face->num_faces' for WOFF2 fonts.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Improve memory and error handling.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Avoid too many calls to `FT_REALLOC'.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Reconstruct `loca', `hmtx', and swap out stream.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Reconstruct transformed `glyf' table.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Copy un-transformed tables to sfnt stream.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Create stream for uncompressed buffer.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Handle TTCs and start reconstructing font.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Get known tags from function.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Minor.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Uncompress Brotli streams and `face_index' support.
2019-08-27 ramakrishnan.nikhil@gmail.com * builds/unix/configure.raw: Change argument name to `brotli'.
2019-08-27 ramakrishnan.nikhil@gmail.com Add Brotli dependency and required checks.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Write SFNT Offset table.
2019-08-27 ramakrishnan.nikhil@gmail.com * src/sfnt/sfwoff2.c: #undef macros.
2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Read table and collection directory.
2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Include `woff2tags.c' for building.
2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Add WOFF2 constants.
2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Read WOFF 2 header.
2019-08-27 ramakrishnan.nikhil@gmail.com Add structures for WOFF2.

Created with:
  gclient setdep -r src/third_party/freetype/src@cbee985a2bc1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Bug: 998083
TBR=bungeman@google.com,drott@google.com,thestig@google.com

Change-Id: Ia8406de15aeb9b5593c9e1f8ae579fe2baf8bf9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773439
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691077}

Bug: 978136
Change-Id: Id7026f3132f38398f1a0e9fc8cf2413a30095979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771402Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Jessica Tallon <jtallon@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691076}

Because of the typo, not only the test name is wrong but also it actually tests
conversion from memory based frame to dmabuf based one. This CL fixes the typo
and begins to test a conversion from dmabuf based frame to memory based frame.
This also renames ImageProcessorSimpleParamTest to ImageProcessorParamTest as
the "Simple" is unnecessary.

Bug: 917951
Test: image_processor_test on atlas
Change-Id: I1ec4f1d8cac776292aef4f8e07b7d7999a81fba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773076
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691075}

Fixes flakiness in unit testing due to DWriteFontLookupTableBuilder
spuriously trying to index fonts when it should not.

In order to test DWriteFontLookupTableBuilder a cache directory is
configured for persisting the built table. The same happens when a full
browser runs with a profile - in which case a subdirectory of the
USER_DATA directory is used. Do not scan fonts if a directory is not
configured.

This situation happens in unit tests in tests other than the
DWriteFontLookupTableBuilder unit tests, as ContentClient and
BrowserClient do not return a path for GetFontLookupTableCacheDir() in
testing. It is sufficient to test DWriteFontLookupTableBuilder in its
own unittests. If local unique font matching on Windows 7 is required in
a unit test, a cache directory can be configured using
DWriteFontLookupTableBuilder::GetInstance()->
    SetCacheDirectoryForTesting(...)

Thanks to etienneb@ for spotting this problem and initial fix proposals.

Bug: 996167
Change-Id: Iccac27225d7be7fc464a645e7e7689eba3680efa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769437Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691074}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d2e5f8ebe67..7096a4a9fc5b


Created with:
  gclient setdep -r src-internal@7096a4a9fc5b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I3e3e747de03376b52c34c7c3900cc848ee005b29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774266Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691073}

Because we're using mojo data pipe, which has own quota control,
to transfer received data, we don't have manual one, or
mojom::WebSocket.AddReceiveFlowControlQuota().
This CL does a sort of work removing the function.

mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks:
browser side(mainly on WebSocketChannel)
 1. Trigger the first ReadFrame if renderer gets not throttled.
For #1, this patch moves the trigger to mojo WebSocket.StartReceiving.

 2. Trigger next ReadFrame if there is enough quota.
 3. Send pending dataframes based on added quota.
This patch moves task #2 and #3 to websocket.cc and datapipe itself.

 4. Dropchannel if all pending frames are received by renderer when closed.
Because we can care #4 w/o renderer ping back, this patch move
RespondToClosingHandshake()to WebSocketChannel::ReadFrames().

renderer side(mainly on WebSocketChannelImpl)
 5. Ping browser that backpressure is turned off.
For task #5, this patch changes not to call the mojo but throttle
datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames().

receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build:
ToT:            144 MB/s (stdev: 4.56 MB/s)
Patch:          208 MB/s (stdev: 6.15 MB/s)
  (+44% to ToT, +41% to ReadOnlyBuffer)
ReadOnlyBuffer: 147 MB/s

Change-Id: I61feab06f0e3719520e6a47eea61e0322e4da01f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763507
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691072}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/568f3984..d190ff4e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iad61500b224ac717136bb30467e3f54bd2159a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772211Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691071}

The chip view needs to react to certain state changes with changed text
colors. Since the secondary label is added lazily, it needs to check for
these states explicitly.

Once views that are part of the hierarchy they will receive most of the
state changes (e.g. a setSelected on ChipView will apply to both
TextViews).
For some reason, setEnabled wasn't applied to children by default but it
is strictly necessary in order to automatically select the correct text
appearance.

Additional fix: ensure there is an appropriate disabled state color.
Screenshots are in the linked bug.

Bug: 989960
Change-Id: Ic63d09f22c22af485d060d03d6ba6c20ef233bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771613
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691070}

Bug: 244755
Change-Id: Ib1ecb888e82d99393cd15d867cae7c0f0d7ca9a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769446Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691069}

TBR=meacer@chromium.org

Change-Id: Ifd4d32cefcc3e3c98720d20a3227a1d42af403b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774262
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691068}

We now first strip the path data and then check if it's an
empty string. This allows white space at the end of the
string. This follows the spec.
https://www.w3.org/TR/SVG11/animate.html#ValuesAttribute

Bug: 429301
Change-Id: Ie77731cb0ec17b489b439953e73230650a16bcd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768771Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#691067}

https://swiftshader.googlesource.com/SwiftShader.git/+log/a9da772f0587..04e148570dbb

git log a9da772f0587..04e148570dbb --date=short --no-merges --format='%ad %ae %s'
2019-08-28 capn@google.com Make round-robin task enqueue index thread safe
2019-08-27 bclayton@google.com Device: Migrate Renderer to Yarn
2019-08-27 bclayton@google.com Device: Don't use a global for the cluster count.
2019-08-27 bclayton@google.com Some minor code tidying.
2019-08-27 bclayton@google.com Pipeline: Use Yarn to make compute multi-threaded.
2019-08-27 bclayton@google.com Vulkan: Build a yarn::Scheduler and pass it down to the vk::Queue.
2019-08-27 bclayton@google.com vk::Queue: Lazily construct Renderers
2019-08-27 bclayton@google.com Yarn: Don't zero-initialize data in Pool<T>::Item::construct()

Created with:
  gclient setdep -r src/third_party/swiftshader@04e148570dbb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/139010488,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139010488,chromium:b/139142453
Change-Id: Iceb60a95f44801f390732a1506641ace01c4e131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774264Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691066}