- 06 Nov, 2018 40 commits
-
-
Emircan Uysaler authored
Bug: 326740 Change-Id: Iea381d99984249796fb0e11279174a553ea9ce8a Reviewed-on: https://chromium-review.googlesource.com/c/1313328Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605602}
-
Scott Graham authored
Initializing a struct member with the value of an enum would previously fail to compile; implement this. This is slightly awkward because the front end does not scope the enum value to the enum like the C++ (and JS) bindings but rather only to the library. So the compiler needs to know the type to which it's being assigned and use that to determine how the enum's value is intended to be qualified. Bug: 883496 Change-Id: Id8a9f75d07bb0acb11963ecbd37d4915b36c28e0 Reviewed-on: https://chromium-review.googlesource.com/c/1313286 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605601}
-
Yuta Kitamura authored
This CL simplifies lengthy function calls via Platform::Current() that obtain the current thread and the main thread by using Thread::Current() and Thread::MainThread(). Also now-redundant null checks for those functions are removed. Bug: 826203 Change-Id: Iedfd7f09b5334dc84fa921cdca84ca39ad9b3af9 Reviewed-on: https://chromium-review.googlesource.com/c/1318773Reviewed-by:
-
Eric Foo authored
Change-Id: I759a8630ea1ae636bfc3954006a2fa5fd6b5299d Reviewed-on: https://chromium-review.googlesource.com/c/1318732 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#605599}
-
Hirokazu Honda authored
This adds video frame flags, --frame_validator=, check : compares md5 values computed from video frame with the expected md5 values. Test fails if there is an unexpected video frame. dump : outputs video frames to files BUG=chromium:856562 TEST=VDA unittest with --test_import TEST=VDA unittest with --test_import --frame_validator=check TEST=VDA unittest with --frame_validator=check TEST=VDA unittest with --frame_validator=check,dump TEST=VDA unittest with --frame_validator=dump TEST=VDA unittest with --gtest_filter=VideoDecodeAcceleratorTest.DISABLED_GenMD5 --gtest_also_run_disabled_tests Change-Id: I1511ef07a2bd01231e9daf1038776324c22e3da5 Reviewed-on: https://chromium-review.googlesource.com/c/1309390Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605598}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: Id3b9912d9b06e0baae9e98e4e51d9da53ec64e6b Reviewed-on: https://chromium-review.googlesource.com/c/1319331Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#605597}
-
Eric Foo authored
Change-Id: I80a812501aeb3c4d894d687326dac3777b2f54c5 Reviewed-on: https://chromium-review.googlesource.com/c/1318587Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605596}
-
Yuta Kitamura authored
This CL simplifies lengthy function calls via Platform::Current() that obtain the current thread and the main thread by using Thread::Current() and Thread::MainThread(). Bug: 826203 Change-Id: I18a106751518e361aecfb6e82152359c1b00f3d1 Reviewed-on: https://chromium-review.googlesource.com/c/1319129Reviewed-by:
-
https://crbug.com/889567Makoto Shimazu authored
Bug: 889567 Change-Id: I790222c0e74692214bc10daff7a6aa00478a4b88 Reviewed-on: https://chromium-review.googlesource.com/c/1319109 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605594}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3d2886849216..c238958c1ca3 git log 3d2886849216..c238958c1ca3 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c238958c1ca3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I07cd28e68dc926a69573e8627859e0e287e92467 Reviewed-on: https://chromium-review.googlesource.com/c/1318164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605593}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::AssociateItemsWithInlines()| to associate |NGInlineItem| to |LayoutText| correctly by skipping |NGInlineItem| without layout object. Before this patch, |LayoutText| is assocaited |NGIninlineItem| objects after the |NGIninlineItem.layout_object == nullptr|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1309562 Make Element#innterText to utilize NGInlineItem instead of NGPaintFragment Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I41f16ea13ca1e0641cb2a42331d64fa2cd6387ac Reviewed-on: https://chromium-review.googlesource.com/c/1317217 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605592}
-
Wenzhao Zang authored
This reverts commit 2bdc43ad. Reason for revert: crbug.com/900373 Original change's description: > viz: Turn off or crop primary plane when possible > > For many fullscreen cases, the rest of the renderpass quads are solid > black quads. In that case, we can turn off the primary plane, and not > having to scan out an full screen of black pixels saves a good deal of > power. In other cases, we can crop down the primary plane down to the > content rectangle (youtube channel logo, for example) and save power. > > Averaging battery draw measurement over about a minute of play back > for a fullscreen youtube video, power savings for soraka is around > 500mW (6.5W to 6.0W) and 300mW for kevin (4.4W to 4.1W), when we > turn off the primary plane. > > Change-Id: I7946d7acab334bffdf2bb49a1d9c424cf46fc610 > Reviewed-on: https://chromium-review.googlesource.com/c/1045256 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600415} TBR=dongseong.hwang@intel.com,dcastagna@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 900373 Change-Id: I37857bca0cda656c2e2a83dc04312b9c599976e7 Reviewed-on: https://chromium-review.googlesource.com/c/1318547 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605591}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I06691e83b83420cc54891b0ad95c123470fca502 Reviewed-on: https://chromium-review.googlesource.com/c/1319172Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605590}
-
Timothy Loh authored
This CL makes a few improvements in searching for the Crostini Terminal: - Allow partial matches (bug 840699). Instead of requiring the entire word 'terminal', allowa match from just 'ter' (but still require a few characters to avoid over-triggering). - Add additional keywords 'linux', 'crostini' (bug 858822). - Add unlocalized (English) keywords. Users may still search for these as localizations of Linux/Crostini tend to be tranliterations. Bug: 840699, 858822 Change-Id: Iabff74d9d8a61c2c2abcc50f9683b381c5dce126 Reviewed-on: https://chromium-review.googlesource.com/c/1280092 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605589}
-
Heng-Ruey Hsu authored
API doesn't ask user to call SetPhotoOptions before TakePhoto. Therefore TakePhoto should enable blob streams as well if SetPhotoOptions is not called. BUG=b:114676133, chromium:900900 TEST=./capture_unittest --gtest_filter="*VideoCaptureDeviceTests/*" and take photo in CCA Change-Id: I72d4f1394fe95aaca768cb366a341796f55fe336 Reviewed-on: https://chromium-review.googlesource.com/c/1314074Reviewed-by:Miguel Casas <mcasas@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605588}
-
David Bokan authored
When an Element is made the global rootScroller, it can hide the URL bar like Document scrolling does normally. However, the Element's LayoutBox, like the LayoutView, is not resized in this case. This means there's a newly exposed region at the bottom of the screen that's visible beyond the Element's overflow rect. LayoutView already has an exception in the PaintLayerClipper for this case. This CL extends the exception to the root scroller. This fixes hit testing that descends into child PaintLayers of the root scroller's layer. In addition, it also caches an "IsGlobalRootScroller" bit in LayoutObject for performance, just like the effective bit added in https://crrev.com/2685a6b3e82be7711c6d3b02f225b1b90bb9bf46 Also added tests to ensure this works in an iframe. Bug: 798719 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaf87db5569ebbe1aa82f20d3cf19868a12ed9539 Reviewed-on: https://chromium-review.googlesource.com/c/1287176 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605587}
-
John Budorick authored
This reverts commit ba0225d1. Reason for revert: breaks internal compilation; see e.g. http://shortn/_9928H1Hk0R Original change's description: > Reland "Android: turning on bytecode checker" > > This is a reland of 0301a791 > > I don't think this would have caused a runtime chromeos error, since it's > a build time android change. If it pops up again that I broke the test, > I will investigate further. > > TBR=retry > > Original change's description: > > Android: turning on bytecode checker > > > > This arg was defaulting to false when it should have defaulted to true. > > > > TBR=turning off bytecode checks for certain dirs > > > > Bug: 874854 > > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605068} > > Bug: 874854 > Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968 > Reviewed-on: https://chromium-review.googlesource.com/c/1318071 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605347} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I4bb41ab999431fd2df511838d10db598cd5c0a87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874854 Reviewed-on: https://chromium-review.googlesource.com/c/1319333Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605586}
-
Nektarios Paisios authored
This patch also fixes the bug whereby Jaws wasn't announcing the visited state on a link. We need to update the accessibility tree if there are any changes to the way a layout object is painted. To be safe, we update the whole subtree. The update needs to happen after the style change, not before, so as to catch any changes to the visited link state, color and font. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I03f512a95f8101c603a712fb3d62e7b31a59da5e Bug: 898706 Reviewed-on: https://chromium-review.googlesource.com/c/1298173 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#605585}
-
sangwoo.ko authored
Stop notifying events via old api and replace old API with new API. This CL is a refactor and has no intended behavior change. Bug: 842194 Change-Id: I5e11e7323940acbbdc31bd73d599480c7312e8b9 Reviewed-on: https://chromium-review.googlesource.com/c/1314508 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605584}
-
siyua authored
The previous title has translation issue. Bug: 897998 Change-Id: I59471c13de7c099bd8b7755d09c67d83e517f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/1316835Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#605583}
-
rajendrant authored
The fields ps, sid in chrome-proxy header are deprecated. So removing them. https://g3doc.corp.google.com/wireless/speed/flywheel/g3doc/protocol/syntax_proxy.md#requests Bug: 893728 Change-Id: I752938b6defd6e55405bd40151341ab50486c014 Reviewed-on: https://chromium-review.googlesource.com/c/1316677 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#605582}
-
Fan Yang authored
With this change, client initiated stream ID is 0, 2, 4..., and server initiated stream ID is 1, 3, 5... If client starts with v99, and server does not support v99, the version negotiation is not supported. Merge internal change: 218572979 R=rch@chromium.org Change-Id: I922820118ce229e1ae188a3c2d1a16cf3b34c2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1318355 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#605581}
-
Dmitry Gozman authored
- Merge TargetRegistry into DevToolsSession. - Allow flatten children on any targets. Bug: 775132 Change-Id: Idaafb019f9881a937f3e4b2d1abab7a3e89af06e Reviewed-on: https://chromium-review.googlesource.com/c/1316748 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605580}
-
Dmitry Titov authored
This reverts commit dc7a451a. Reason for revert: Broke tests on Mac (at least): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16499 Broken test output: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930653299367123984/+/steps/network_service_browser_tests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Upload_AddStrikeIfSaveFails/0 Original change's description: > Add StrikeDatabase browsertests > > The tests in this CL have been landed and reverted a couple of times; > they work, but end up being a little flaky on Win7. We've had a hard > time getting a reproducible setup, and the Chrome testing team have > verified our feature works as intended, so for the time being we're > marking the tests as flaky on Windows and will follow up. > > (Sheriffs: If somehow the landing of this CL causes additional > flakes, feel free to revert. Flake analysis hasn't shown anything > outside of Win7.) > > Bug: 884817 > Change-Id: Iec545cb861bfc1aa3d50746c3a413257c9a9ec82 > Reviewed-on: https://chromium-review.googlesource.com/c/1316666 > Commit-Queue: Jared Saul <jsaul@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605507} TBR=estade@chromium.org,jsaul@google.com Change-Id: I1e408b6395c80c425d982544bfdd88e01231db7b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884817 Reviewed-on: https://chromium-review.googlesource.com/c/1319190Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605579}
-
Mitsuru Oshima authored
Bug: 901402 Test: manual. The window title fades in after overview animation ends (in clamshell, tablet, from home launcher). and hides immediately when exiting. Change-Id: I06b25ebea428439ec6e7ab2751db74409971855f Reviewed-on: https://chromium-review.googlesource.com/c/1316363 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605578}
-
siyua authored
Make a new CL since the master branch has changed much. The unresolved comments in the previous CL are addressed here. 1) Add vector icon for https://icons.googleplex.com/#icon=ic_lightbulb_outline&search=light%20bulb 2) Add components factory for finished and action required views. 3) Update the text string in action-required dialog. 4) Move image, title and LocalCardMigrationOfferView to LocalCardMigrationDialogView. 5) Update MigratableCardView to add different content depending on the card migration status. Have uploaded implementation screenshots in the bug below (comment#8). Bug: 897998 Change-Id: I34d6f112a872944ab3ba1cb96f3aaa1665e4173d Reviewed-on: https://chromium-review.googlesource.com/c/1300473 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#605577}
-
Ken Rockot authored
This is a reland of 14c0b604 Original change's description: > [mojo] Add IPC support to core shared library > > Updates the mojo_core shared library so that it is actually suitable > for production IPC use. Namely: > > - MojoInitialize now spins up a background thread for I/O and gives > it to the core impl. > - A flag is added to Initialize(), allowing shared library consumers > to initialize themselves as a broker process. > - The thunks helper correctly loads the mojo_core library with > RTLD_DEEPBIND set, avoiding heap crossover within the core impl > due to e.g. malloc and free lazy-binding to different heaps > - Fixes the thunks header to compile as C once again, as it was > missing some struct keywords. > - Adds MojoShutdown to the core ABI as a necessary call for shared > library consumers who want clean shutdown. > > This also adds a new multiprocess test consuming the shared library > to tie together and validate all of the above changes. > > Bug: 809320 > Change-Id: Ic1c56d99c86fd4a2dc7f812ee152994ced35ece6 > Reviewed-on: https://chromium-review.googlesource.com/c/1306347 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605109} TBR=reillyg@chromium.org Bug: 809320 Change-Id: I8a8b2c1acfb16bf42823f266dffbae8e897075f3 Reviewed-on: https://chromium-review.googlesource.com/c/1318061Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#605576}
-
Shinya Kawanaka authored
Due to disk shortage, `all` cannot be built for Mac Goma Canary (clobber). Let's build chrome instead. The disk of "Chromium Mac Goma GCE Staging" is also getting short, so I changed this builder, too. Bug: 899425 Change-Id: I58a960ad8455c78bc7ae871298edf78aed650f7b Reviewed-on: https://chromium-review.googlesource.com/c/1316952 Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605575}
-
Xiaocheng Hu authored
This patch converts the layout test with W3C testharness to reduce usage of deprecated js-test.js. This patch is also a preparation for using Element.innerText for text dump. As the layout tests adds float style to all <span>, without this patch, innerText dump can be confusing. Bug: 887148 Change-Id: Ia8cafbc996fe1f4ae66350b565b7611bb7ec35e5 Reviewed-on: https://chromium-review.googlesource.com/c/1318357 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605574}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I9af8ed01ad2fae3e51e99a5a484e874c31ae8938 Reviewed-on: https://chromium-review.googlesource.com/c/1318162Reviewed-by:
-
Eliot Courtney authored
This clips the requested screen capture area to the desktop window for ArcScreenCaptureSession. AuraDesktopCapturer already does this. Bug: b/118675936 Test: cts passes Change-Id: I3795d21bf34f05e7f71e46f3fcc8ff2e50cec506 Reviewed-on: https://chromium-review.googlesource.com/c/1316985Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#605572}
-
Andreas Butler authored
Removing flag and adding method to virtual/stable/ expected.txt files for shipping IDBFactory.databases() (IndexedDB database info enumeration function). Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xSf7B0aVxnI/0E05ZEB6DAAJ Change-Id: Idb3253ed11368f3cc0353756409a0f49c9e61426 Reviewed-on: https://chromium-review.googlesource.com/c/1318536Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Theresa authored
The regular card layout and alternate are now quite similar. Remove the alternate. BUG=899409 Change-Id: Ic8def75cdcac631579306418c4cf410070aaeeed Reviewed-on: https://chromium-review.googlesource.com/c/1313741Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605570}
-
Kevin Strohbehn authored
Bug: 891442 Change-Id: Ib173d99becdfc8924ddf382aeb0687c2bde1a145 Reviewed-on: https://chromium-review.googlesource.com/c/1317899 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605569}
-
Quan Nguyen authored
The system salt is no longer needed for authentication. Also remove unused PendingDoAuthenticateUser declaration. Bug: 902161 Change-Id: I7920f2975cf4b547149caa2d0c7056085d6dab2a Reviewed-on: https://chromium-review.googlesource.com/c/1318632 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#605568}
-
Martin Kreichgauer authored
This adds a FidoDiscoveryBase class to instantiate the Windows authenticator. Instantiatiation of the new Discovery at request time is conditioned on a newly added feature flag and availability of the Windows WebAuthn API (which acts as our proxy signal for whether USB devices are blocked). For requests where the discovery is enabled, the existing FidoHidDiscovery is disabled. Bug: 898718 Change-Id: I2048e179bd3987ed3703b3818870253fe2a50e2c Reviewed-on: https://chromium-review.googlesource.com/c/1313733 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#605567}
-
Jun Cai authored
This CL migrates NetworkMetricsProvider from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. The "Initial upload" patch of this CL is the same as: https://chromium-review.googlesource.com/c/chromium/src/+/1222918 Bug: 883121 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Change-Id: Ic6879e48b9515d2281dc9da7c9437bad4c044a99 Reviewed-on: https://chromium-review.googlesource.com/c/1274585Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605566}
-
Giovanni Ortuño Urquidi authored
Rather than manually iterating over the vector and removing elements, use the base::EraseIf() helper function. Bug: 882346 Change-Id: If7c608239ae5081b6e4750dc5a4c33439a18b0a6 Reviewed-on: https://chromium-review.googlesource.com/c/1316978Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605565}
-
Min Chen authored
Bug: None Change-Id: I97e0cccfc77d51bbf738bfab307b8b98d34040be Reviewed-on: https://chromium-review.googlesource.com/c/1318797Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b1f256782eb..9a5dbc6f4454 git log 6b1f256782eb..9a5dbc6f4454 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 benjhayden@chromium.org Remove new_points from docs/pages-and-endpoints.md 2018-11-05 benjhayden@chromium.org Fix logUrls type-check in add_histograms_queue. Created with: gclient setdep -r src/third_party/catapult@9a5dbc6f4454 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I40476cb28f0644000bd799a93acffd80fa6d5e37 Reviewed-on: https://chromium-review.googlesource.com/c/1318798Reviewed-by:
-
